tasks/service/history/queues/convert_test.go at release/v1.30.x

mirror of https://github.com/hanzoai/tasks.git synced 2026-11-02 12:22:18 +00:00

Files

T

Roey BermanandGitHub 243effc6e1 Forbid the use of pborman/uuid and remove uses (#8541 )

## What

Used the `depguard` linter to prevent importing the package and modified
all uses of it.

Also fixed a bug in the membership code where we were not updating the
next page token:

https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350


## Why?

From the package README in GitHub:

> This package now leverages the github.com/google/uuid package (which
is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the
codebase.

## Test

Added the invalid import and confirmed it works:

```
../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

```

2025-11-26 01:33:02 +00:00

239 lines

6.4 KiB

Go

Raw Permalink Blame History

 package queues
 import (
 	"math/rand"
 	"testing"
 	"time"
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 	"go.temporal.io/api/temporalproto"
 	enumsspb "go.temporal.io/server/api/enums/v1"
 	"go.temporal.io/server/common/predicates"
 	"go.temporal.io/server/service/history/tasks"
 )
 type (
 	convertSuite struct {
 		suite.Suite
 		*require.Assertions
 	}
 )
 func TestConvertSuite(t *testing.T) {
 	s := new(convertSuite)
 	suite.Run(t, s)
 }
 func (s *convertSuite) SetupTest() {
 	s.Assertions = require.New(s.T())
 }
 func (s *convertSuite) TestConvertPredicate_All() {
 	predicate := predicates.Universal[tasks.Task]()
 	s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 }
 func (s *convertSuite) TestConvertPredicate_Empty() {
 	predicate := predicates.Empty[tasks.Task]()
 	s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 }
 func (s *convertSuite) TestConvertPredicate_And() {
 	testCases := []tasks.Predicate{
 		predicates.And(
 			predicates.Universal[tasks.Task](),
 			predicates.Empty[tasks.Task](),
 		),
 		predicates.And(
 			predicates.Or[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			),
 			predicates.Or[tasks.Task](
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_ACTIVITY_RETRY_TIMER,
 				}),
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT,
 				}),
 			),
 		),
 		predicates.And(
 			predicates.Not(predicates.Empty[tasks.Task]()),
 			predicates.And[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			),
 		),
 		predicates.And(
 			predicates.Not(predicates.Empty[tasks.Task]()),
 			predicates.And[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT,
 				}),
 			),
 		),
 	}
 	for _, predicate := range testCases {
 		s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 	}
 }
 func (s *convertSuite) TestConvertPredicate_Or() {
 	testCases := []tasks.Predicate{
 		predicates.Or(
 			predicates.Universal[tasks.Task](),
 			predicates.Empty[tasks.Task](),
 		),
 		predicates.Or(
 			predicates.And[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			),
 			predicates.And[tasks.Task](
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_ACTIVITY_RETRY_TIMER,
 				}),
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT,
 				}),
 			),
 		),
 		predicates.Or(
 			predicates.Not(predicates.Empty[tasks.Task]()),
 			predicates.And[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			),
 		),
 		predicates.Or(
 			predicates.Not(predicates.Empty[tasks.Task]()),
 			predicates.And[tasks.Task](
 				tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT,
 				}),
 			),
 		),
 	}
 	for _, predicate := range testCases {
 		s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 	}
 }
 func (s *convertSuite) TestConvertPredicate_Not() {
 	testCases := []tasks.Predicate{
 		predicates.Not(predicates.Universal[tasks.Task]()),
 		predicates.Not(predicates.Empty[tasks.Task]()),
 		predicates.Not(predicates.And[tasks.Task](
 			tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			tasks.NewTypePredicate([]enumsspb.TaskType{}),
 		)),
 		predicates.Not(predicates.Or[tasks.Task](
 			tasks.NewNamespacePredicate([]string{uuid.NewString()}),
 			tasks.NewTypePredicate([]enumsspb.TaskType{}),
 		)),
 		predicates.Not(predicates.Not(predicates.Empty[tasks.Task]())),
 		predicates.Not[tasks.Task](tasks.NewNamespacePredicate([]string{uuid.NewString()})),
 		predicates.Not[tasks.Task](tasks.NewTypePredicate([]enumsspb.TaskType{
 			enumsspb.TASK_TYPE_ACTIVITY_RETRY_TIMER,
 		})),
 	}
 	for _, predicate := range testCases {
 		s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 	}
 }
 func (s *convertSuite) TestConvertPredicate_NamespaceID() {
 	testCases := []tasks.Predicate{
 		tasks.NewNamespacePredicate(nil),
 		tasks.NewNamespacePredicate([]string{}),
 		tasks.NewNamespacePredicate([]string{uuid.NewString(), uuid.NewString(), uuid.NewString()}),
 	}
 	for _, predicate := range testCases {
 		s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 	}
 }
 func (s *convertSuite) TestConvertPredicate_TaskType() {
 	testCases := []tasks.Predicate{
 		tasks.NewTypePredicate(nil),
 		tasks.NewTypePredicate([]enumsspb.TaskType{}),
 		tasks.NewTypePredicate([]enumsspb.TaskType{
 			enumsspb.TASK_TYPE_ACTIVITY_RETRY_TIMER,
 			enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT,
 			enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT,
 		}),
 	}
 	for _, predicate := range testCases {
 		s.Equal(predicate, FromPersistencePredicate(ToPersistencePredicate(predicate)))
 	}
 }
 func (s *convertSuite) TestConvertTaskKey() {
 	key := NewRandomKey()
 	s.Equal(key, FromPersistenceTaskKey(
 		ToPersistenceTaskKey(key),
 	))
 }
 func (s *convertSuite) TestConvertTaskRange() {
 	r := NewRandomRange()
 	s.Equal(r, FromPersistenceRange(
 		ToPersistenceRange(r),
 	))
 }
 func (s *convertSuite) TestConvertScope() {
 	scope := NewScope(
 		NewRandomRange(),
 		tasks.NewNamespacePredicate([]string{uuid.NewString(), uuid.NewString()}),
 	)
 	s.True(temporalproto.DeepEqual(scope, FromPersistenceScope(
 		ToPersistenceScope(scope),
 	)))
 }
 func (s *convertSuite) TestConvertQueueState() {
 	readerScopes := map[int64][]Scope{
 : {},
 : {
 			NewScope(
 				NewRandomRange(),
 				tasks.NewNamespacePredicate([]string{uuid.NewString(), uuid.NewString()}),
 			),
 		},
 : {
 			NewScope(
 				NewRandomRange(),
 				tasks.NewNamespacePredicate([]string{uuid.NewString(), uuid.NewString()}),
 			),
 			NewScope(
 				NewRandomRange(),
 				tasks.NewTypePredicate([]enumsspb.TaskType{
 					enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT,
 					enumsspb.TASK_TYPE_ACTIVITY_RETRY_TIMER,
 				}),
 			),
 		},
 	}
 	queueState := &queueState{
 		readerScopes:                 readerScopes,
 		exclusiveReaderHighWatermark: tasks.NewKey(time.Unix(0, rand.Int63()).UTC(), 0),
 	}
 	s.True(temporalproto.DeepEqual(queueState, FromPersistenceQueueState(
 		ToPersistenceQueueState(queueState),
 	)))
 }

239 lines 6.4 KiB Go Raw Permalink Blame History

239 lines

6.4 KiB

Go

Raw Permalink Blame History