mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Prathyush PVandGitHub
7c701ff791
## What changed? A pointer to testQueueOptions is used in the test suite. This allows tests to directly modify options; later these modified options will be used by other tests, causing them to fail. Changing testQueueOptions to a struct so that each test can get a copy of it. ## Why? To fix flakiness when multiple tests are run. ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
88 lines
2.2 KiB
Go
88 lines
2.2 KiB
Go
package queues
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/cluster"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/service/history/shard"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
"go.temporal.io/server/service/history/tests"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
type (
|
|
immediateQueueSuite struct {
|
|
suite.Suite
|
|
*require.Assertions
|
|
|
|
controller *gomock.Controller
|
|
mockShard *shard.ContextTest
|
|
mockExecutionManager *persistence.MockExecutionManager
|
|
|
|
immediateQueue *immediateQueue
|
|
}
|
|
)
|
|
|
|
func TestImmediateQueueSuite(t *testing.T) {
|
|
s := new(immediateQueueSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *immediateQueueSuite) SetupTest() {
|
|
s.Assertions = require.New(s.T())
|
|
|
|
s.controller = gomock.NewController(s.T())
|
|
s.mockShard = shard.NewTestContext(
|
|
s.controller,
|
|
&persistencespb.ShardInfo{
|
|
ShardId: 0,
|
|
RangeId: 1,
|
|
Owner: "test-shard-owner",
|
|
},
|
|
tests.NewDynamicConfig(),
|
|
)
|
|
s.mockExecutionManager = s.mockShard.Resource.ExecutionMgr
|
|
s.mockShard.Resource.ClusterMetadata.EXPECT().GetCurrentClusterName().Return(cluster.TestCurrentClusterName).AnyTimes()
|
|
|
|
s.immediateQueue = NewImmediateQueue(
|
|
s.mockShard,
|
|
tasks.CategoryTransfer,
|
|
nil, // scheduler
|
|
nil, // rescheduler
|
|
&testQueueOptions,
|
|
NewReaderPriorityRateLimiter(
|
|
func() float64 { return 10 },
|
|
1,
|
|
),
|
|
GrouperNamespaceID{},
|
|
log.NewTestLogger(),
|
|
metrics.NoopMetricsHandler,
|
|
nil, // execuable factory
|
|
)
|
|
}
|
|
|
|
func (s *immediateQueueSuite) TearDownTest() {
|
|
s.controller.Finish()
|
|
}
|
|
|
|
func (s *immediateQueueSuite) TestPaginationFnProvider_ShardOwnershipLost() {
|
|
paginationFnProvider := s.immediateQueue.paginationFnProvider
|
|
|
|
s.mockExecutionManager.EXPECT().GetHistoryTasks(gomock.Any(), gomock.Any()).Return(nil, &persistence.ShardOwnershipLostError{
|
|
ShardID: s.mockShard.GetShardID(),
|
|
}).Times(1)
|
|
|
|
paginationFn := paginationFnProvider(NewRandomRange())
|
|
_, _, err := paginationFn(nil)
|
|
s.True(shard.IsShardOwnershipLostError(err))
|
|
|
|
// make sure shard is also marked as invalid
|
|
s.False(s.mockShard.IsValid())
|
|
}
|