Files
Roey BermanandGitHub 243effc6e1 Forbid the use of pborman/uuid and remove uses (#8541)
## What

Used the `depguard` linter to prevent importing the package and modified
all uses of it.

Also fixed a bug in the membership code where we were not updating the
next page token:

https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350


## Why?

From the package README in GitHub:

> This package now leverages the github.com/google/uuid package (which
is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the
codebase.

## Test

Added the invalid import and confirmed it works:

```
../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

```
2025-11-26 01:33:02 +00:00

230 lines
7.1 KiB
Go

package parentclosepolicy
import (
"context"
"time"
"github.com/google/uuid"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
taskqueuepb "go.temporal.io/api/taskqueue/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/sdk/activity"
"go.temporal.io/sdk/converter"
"go.temporal.io/sdk/temporal"
"go.temporal.io/sdk/workflow"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/client"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/primitives"
"google.golang.org/protobuf/types/known/durationpb"
)
const (
// processorTaskQueueName is the taskqueue name
processorTaskQueueName = "temporal-sys-processor-parent-close-policy"
// processorWFTypeName is the workflow type
processorWFTypeName = "temporal-sys-parent-close-policy-workflow"
processorActivityName = "temporal-sys-parent-close-policy-activity"
processorChannelName = "ParentClosePolicyProcessorChannelName"
)
type (
// RequestDetail defines detail of each workflow to process
RequestDetail struct {
Namespace string
NamespaceID string
WorkflowID string
RunID string
Policy enumspb.ParentClosePolicy
}
// Request defines the request for parent close policy
Request struct {
ParentExecution *commonpb.WorkflowExecution
Executions []RequestDetail
}
processorContextKeyType struct{}
)
var (
processorContextKey = processorContextKeyType{}
retryPolicy = temporal.RetryPolicy{
InitialInterval: 10 * time.Second,
BackoffCoefficient: 1.7,
MaximumInterval: 5 * time.Minute,
}
activityOptions = workflow.ActivityOptions{
ScheduleToStartTimeout: time.Minute,
StartToCloseTimeout: 5 * time.Minute,
RetryPolicy: &retryPolicy,
}
)
// ProcessorWorkflow is the workflow that performs actions for ParentClosePolicy
func ProcessorWorkflow(ctx workflow.Context) error {
requestCh := workflow.GetSignalChannel(ctx, processorChannelName)
for {
var request Request
if !requestCh.ReceiveAsync(&request) {
// no more request
break
}
opt := workflow.WithActivityOptions(ctx, activityOptions)
_ = workflow.ExecuteActivity(opt, processorActivityName, request).Get(ctx, nil)
}
return nil
}
// ProcessorActivity is activity for processing batch operation
func ProcessorActivity(ctx context.Context, request Request) error {
processor := ctx.Value(processorContextKey).(*Processor)
client := processor.clientBean.GetHistoryClient()
// this is for backward compatibility
// ideally we should always have childWorkflowOnly = true
// however if ParentExecution is not specified, setting it to false
// will cause terminate or cancel request to return mismatch error
childWorkflowOnly := request.ParentExecution.GetWorkflowId() != "" &&
request.ParentExecution.GetRunId() != ""
remoteExecutions := make(map[string][]RequestDetail)
for _, execution := range request.Executions {
requestCtx := headers.SetCallerName(ctx, execution.Namespace)
var err error
switch execution.Policy {
case enumspb.PARENT_CLOSE_POLICY_ABANDON:
// no-op
continue
case enumspb.PARENT_CLOSE_POLICY_TERMINATE:
_, err = client.TerminateWorkflowExecution(requestCtx, &historyservice.TerminateWorkflowExecutionRequest{
NamespaceId: execution.NamespaceID,
TerminateRequest: &workflowservice.TerminateWorkflowExecutionRequest{
Namespace: execution.Namespace,
WorkflowExecution: &commonpb.WorkflowExecution{
WorkflowId: execution.WorkflowID,
},
Reason: "by parent close policy",
Identity: processorWFTypeName,
FirstExecutionRunId: execution.RunID,
},
ExternalWorkflowExecution: request.ParentExecution,
ChildWorkflowOnly: childWorkflowOnly,
})
case enumspb.PARENT_CLOSE_POLICY_REQUEST_CANCEL:
_, err = client.RequestCancelWorkflowExecution(requestCtx, &historyservice.RequestCancelWorkflowExecutionRequest{
NamespaceId: execution.NamespaceID,
CancelRequest: &workflowservice.RequestCancelWorkflowExecutionRequest{
Namespace: execution.Namespace,
WorkflowExecution: &commonpb.WorkflowExecution{
WorkflowId: execution.WorkflowID,
},
Identity: processorWFTypeName,
FirstExecutionRunId: execution.RunID,
},
ExternalWorkflowExecution: request.ParentExecution,
ChildWorkflowOnly: childWorkflowOnly,
})
}
switch typedErr := err.(type) {
case nil:
metrics.ParentClosePolicyProcessorSuccess.With(processor.metricsHandler).Record(1)
case *serviceerror.NotFound, *serviceerror.NamespaceNotFound:
// no-op
case *serviceerror.NamespaceNotActive:
remoteExecutions[typedErr.ActiveCluster] = append(remoteExecutions[typedErr.ActiveCluster], execution)
default:
metrics.ParentClosePolicyProcessorFailures.With(processor.metricsHandler).Record(1)
getActivityLogger(ctx).Error("failed to process parent close policy", tag.Error(err))
return err
}
}
if err := signalRemoteCluster(
ctx,
processor.currentCluster,
processor.clientBean,
request.ParentExecution,
remoteExecutions,
processor.cfg.NumParentClosePolicySystemWorkflows(),
); err != nil {
getActivityLogger(ctx).Error("Failed to signal remote parent close policy workflow", tag.Error(err))
return err
}
return nil
}
func signalRemoteCluster(
ctx context.Context,
currentCluster string,
clientBean client.Bean,
parentExecution *commonpb.WorkflowExecution,
remoteExecutions map[string][]RequestDetail,
numWorkflows int,
) error {
for cluster, executions := range remoteExecutions {
_, remoteClient, err := clientBean.GetRemoteFrontendClient(cluster)
if err != nil {
return err
}
signalValue := Request{
ParentExecution: parentExecution,
Executions: executions,
}
signalInput, err := converter.GetDefaultDataConverter().ToPayloads(signalValue)
if err != nil {
return err
}
signalCtx, cancel := context.WithTimeout(ctx, signalTimeout)
_, err = remoteClient.SignalWithStartWorkflowExecution(
signalCtx,
&workflowservice.SignalWithStartWorkflowExecutionRequest{
Namespace: primitives.SystemLocalNamespace,
RequestId: uuid.NewString(),
WorkflowId: getWorkflowID(numWorkflows),
WorkflowType: &commonpb.WorkflowType{
Name: processorWFTypeName,
},
TaskQueue: &taskqueuepb.TaskQueue{
Name: processorTaskQueueName,
},
Input: nil,
WorkflowTaskTimeout: durationpb.New(workflowTaskTimeout),
Identity: currentCluster + "-" + string(primitives.WorkerService) + "-service",
WorkflowIdReusePolicy: workflowIDReusePolicy,
SignalName: processorChannelName,
SignalInput: signalInput,
},
)
cancel()
if err != nil {
return err
}
}
return nil
}
func getActivityLogger(ctx context.Context) log.Logger {
processor := ctx.Value(processorContextKey).(*Processor)
wfInfo := activity.GetInfo(ctx)
return log.With(
processor.logger,
tag.WorkflowID(wfInfo.WorkflowExecution.ID),
tag.WorkflowRunID(wfInfo.WorkflowExecution.RunID),
tag.WorkflowNamespace(wfInfo.WorkflowNamespace),
)
}