mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Break out of the loop, when iteration through mutable states fails ## Why? Previously, we continued to iterate, leading to the panic: https://github.com/temporalio/temporal/issues/8037 ## How did you test it? - [X] run locally and tested manually - [X] added new unit test(s)
276 lines
11 KiB
Go
276 lines
11 KiB
Go
package scanner
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"time"
|
|
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/sdk/activity"
|
|
sdkclient "go.temporal.io/sdk/client"
|
|
"go.temporal.io/sdk/worker"
|
|
"go.temporal.io/sdk/workflow"
|
|
"go.temporal.io/server/api/adminservice/v1"
|
|
"go.temporal.io/server/api/historyservice/v1"
|
|
"go.temporal.io/server/api/matchingservice/v1"
|
|
"go.temporal.io/server/common"
|
|
"go.temporal.io/server/common/backoff"
|
|
"go.temporal.io/server/common/config"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/headers"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/common/membership"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/common/persistence/visibility/manager"
|
|
"go.temporal.io/server/common/sdk"
|
|
"go.temporal.io/server/service/worker/scanner/build_ids"
|
|
)
|
|
|
|
type (
|
|
// Config defines the configuration for scanner
|
|
Config struct {
|
|
MaxConcurrentActivityExecutionSize dynamicconfig.IntPropertyFn
|
|
MaxConcurrentWorkflowTaskExecutionSize dynamicconfig.IntPropertyFn
|
|
MaxConcurrentActivityTaskPollers dynamicconfig.IntPropertyFn
|
|
MaxConcurrentWorkflowTaskPollers dynamicconfig.IntPropertyFn
|
|
|
|
// PersistenceMaxQPS the max rate of calls to persistence
|
|
PersistenceMaxQPS dynamicconfig.IntPropertyFn
|
|
// Persistence contains the persistence configuration
|
|
Persistence *config.Persistence
|
|
// TaskQueueScannerEnabled indicates if taskQueue scanner should be started as part of scanner
|
|
TaskQueueScannerEnabled dynamicconfig.BoolPropertyFn
|
|
// BuildIdScavengerEnabled indicates if the build ID scavenger should be started as part of scanner
|
|
BuildIdScavengerEnabled dynamicconfig.BoolPropertyFn
|
|
// HistoryScannerEnabled indicates if history scanner should be started as part of scanner
|
|
HistoryScannerEnabled dynamicconfig.BoolPropertyFn
|
|
// ExecutionsScannerEnabled indicates if executions scanner should be started as part of scanner
|
|
ExecutionsScannerEnabled dynamicconfig.BoolPropertyFn
|
|
// HistoryScannerDataMinAge indicates the cleanup threshold of history branch data
|
|
// Only clean up history branches that older than this threshold
|
|
HistoryScannerDataMinAge dynamicconfig.DurationPropertyFn
|
|
// HistoryScannerVerifyRetention indicates if the history scavenger to do retention verification
|
|
HistoryScannerVerifyRetention dynamicconfig.BoolPropertyFn
|
|
// ExecutionScannerPerHostQPS the max rate of calls to scan execution data per host
|
|
ExecutionScannerPerHostQPS dynamicconfig.IntPropertyFn
|
|
// ExecutionScannerPerShardQPS the max rate of calls to scan execution data per shard
|
|
ExecutionScannerPerShardQPS dynamicconfig.IntPropertyFn
|
|
// ExecutionDataDurationBuffer is the data TTL duration buffer of execution data
|
|
ExecutionDataDurationBuffer dynamicconfig.DurationPropertyFn
|
|
// ExecutionScannerWorkerCount is the execution scavenger task worker number
|
|
ExecutionScannerWorkerCount dynamicconfig.IntPropertyFn
|
|
// ExecutionScannerHistoryEventIdValidator indicates if the execution scavenger to validate history event id.
|
|
ExecutionScannerHistoryEventIdValidator dynamicconfig.BoolPropertyFn
|
|
|
|
// RemovableBuildIdDurationSinceDefault is the minimum duration since a build ID was last default in its
|
|
// containing set for it to be considered for removal.
|
|
RemovableBuildIdDurationSinceDefault dynamicconfig.DurationPropertyFn
|
|
// BuildIdScavengerVisibilityRPS is the rate limit for visibility calls from the build ID scavenger
|
|
BuildIdScavengerVisibilityRPS dynamicconfig.FloatPropertyFn
|
|
}
|
|
|
|
// scannerContext is the context object that gets
|
|
// passed around within the scanner workflows / activities
|
|
scannerContext struct {
|
|
cfg *Config
|
|
logger log.Logger
|
|
sdkClientFactory sdk.ClientFactory
|
|
metricsHandler metrics.Handler
|
|
executionManager persistence.ExecutionManager
|
|
taskManager persistence.TaskManager
|
|
visibilityManager manager.VisibilityManager
|
|
metadataManager persistence.MetadataManager
|
|
historyClient historyservice.HistoryServiceClient
|
|
matchingClient matchingservice.MatchingServiceClient
|
|
adminClient adminservice.AdminServiceClient
|
|
namespaceRegistry namespace.Registry
|
|
currentClusterName string
|
|
hostInfo membership.HostInfo
|
|
}
|
|
|
|
// Scanner is the background sub-system that does full scans
|
|
// of database tables to cleanup resources, monitor anamolies
|
|
// and emit stats for analytics
|
|
Scanner struct {
|
|
context scannerContext
|
|
wg sync.WaitGroup
|
|
lifecycleCancel context.CancelFunc
|
|
}
|
|
)
|
|
|
|
// New returns a new instance of scanner daemon
|
|
// Scanner is the background sub-system that does full
|
|
// scans of database tables in an attempt to cleanup
|
|
// resources, monitor system anamolies and emit stats
|
|
// for analysis and alerting
|
|
func New(
|
|
logger log.Logger,
|
|
cfg *Config,
|
|
sdkClientFactory sdk.ClientFactory,
|
|
metricsHandler metrics.Handler,
|
|
executionManager persistence.ExecutionManager,
|
|
metadataManager persistence.MetadataManager,
|
|
visibilityManager manager.VisibilityManager,
|
|
taskManager persistence.TaskManager,
|
|
historyClient historyservice.HistoryServiceClient,
|
|
adminClient adminservice.AdminServiceClient,
|
|
matchingClient matchingservice.MatchingServiceClient,
|
|
registry namespace.Registry,
|
|
currentClusterName string,
|
|
hostInfo membership.HostInfo,
|
|
) *Scanner {
|
|
return &Scanner{
|
|
context: scannerContext{
|
|
cfg: cfg,
|
|
sdkClientFactory: sdkClientFactory,
|
|
logger: logger,
|
|
metricsHandler: metricsHandler,
|
|
executionManager: executionManager,
|
|
taskManager: taskManager,
|
|
visibilityManager: visibilityManager,
|
|
metadataManager: metadataManager,
|
|
historyClient: historyClient,
|
|
matchingClient: matchingClient,
|
|
adminClient: adminClient,
|
|
namespaceRegistry: registry,
|
|
currentClusterName: currentClusterName,
|
|
hostInfo: hostInfo,
|
|
},
|
|
}
|
|
}
|
|
|
|
// Start starts the scanner
|
|
func (s *Scanner) Start() error {
|
|
ctx := context.WithValue(context.Background(), scannerContextKey, s.context)
|
|
ctx = headers.SetCallerInfo(ctx, headers.SystemBackgroundHighCallerInfo)
|
|
ctx, s.lifecycleCancel = context.WithCancel(ctx)
|
|
|
|
workerOpts := worker.Options{
|
|
Identity: "temporal-system@" + s.context.hostInfo.Identity(),
|
|
MaxConcurrentActivityExecutionSize: s.context.cfg.MaxConcurrentActivityExecutionSize(),
|
|
MaxConcurrentWorkflowTaskExecutionSize: s.context.cfg.MaxConcurrentWorkflowTaskExecutionSize(),
|
|
MaxConcurrentActivityTaskPollers: s.context.cfg.MaxConcurrentActivityTaskPollers(),
|
|
MaxConcurrentWorkflowTaskPollers: s.context.cfg.MaxConcurrentWorkflowTaskPollers(),
|
|
|
|
BackgroundActivityContext: ctx,
|
|
}
|
|
|
|
var workerTaskQueueNames []string
|
|
if s.context.cfg.Persistence.DefaultStoreType() != config.StoreTypeSQL && s.context.cfg.ExecutionsScannerEnabled() {
|
|
s.wg.Add(1)
|
|
go s.startWorkflowWithRetry(ctx, executionsScannerWFStartOptions, executionsScannerWFTypeName)
|
|
workerTaskQueueNames = append(workerTaskQueueNames, executionsScannerTaskQueueName)
|
|
} else if s.context.cfg.ExecutionsScannerEnabled() {
|
|
s.context.logger.Info("ExecutionsScanner is not supported for SQL store")
|
|
}
|
|
|
|
if s.context.cfg.Persistence.DefaultStoreType() == config.StoreTypeSQL && s.context.cfg.TaskQueueScannerEnabled() {
|
|
s.wg.Add(1)
|
|
go s.startWorkflowWithRetry(ctx, tlScannerWFStartOptions, tqScannerWFTypeName)
|
|
workerTaskQueueNames = append(workerTaskQueueNames, tqScannerTaskQueueName)
|
|
}
|
|
|
|
if s.context.cfg.HistoryScannerEnabled() {
|
|
s.wg.Add(1)
|
|
go s.startWorkflowWithRetry(ctx, historyScannerWFStartOptions, historyScannerWFTypeName)
|
|
workerTaskQueueNames = append(workerTaskQueueNames, historyScannerTaskQueueName)
|
|
}
|
|
|
|
if s.context.cfg.BuildIdScavengerEnabled() {
|
|
s.wg.Add(1)
|
|
go s.startWorkflowWithRetry(ctx, build_ids.BuildIdScavengerWFStartOptions, build_ids.BuildIdScavangerWorkflowName)
|
|
|
|
buildIdsActivities := build_ids.NewActivities(
|
|
s.context.logger,
|
|
s.context.taskManager,
|
|
s.context.metadataManager,
|
|
s.context.visibilityManager,
|
|
s.context.namespaceRegistry,
|
|
s.context.matchingClient,
|
|
s.context.currentClusterName,
|
|
s.context.cfg.RemovableBuildIdDurationSinceDefault,
|
|
s.context.cfg.BuildIdScavengerVisibilityRPS,
|
|
)
|
|
|
|
work := s.context.sdkClientFactory.NewWorker(s.context.sdkClientFactory.GetSystemClient(), build_ids.BuildIdScavengerTaskQueueName, workerOpts)
|
|
work.RegisterWorkflowWithOptions(build_ids.BuildIdScavangerWorkflow, workflow.RegisterOptions{Name: build_ids.BuildIdScavangerWorkflowName})
|
|
work.RegisterActivityWithOptions(buildIdsActivities.ScavengeBuildIds, activity.RegisterOptions{Name: build_ids.BuildIdScavangerActivityName})
|
|
|
|
// TODO: Nothing is gracefully stopping these workers or listening for fatal errors.
|
|
if err := work.Start(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// TODO: There's no reason to register all activities and workflows on every task queue.
|
|
for _, tl := range workerTaskQueueNames {
|
|
work := s.context.sdkClientFactory.NewWorker(s.context.sdkClientFactory.GetSystemClient(), tl, workerOpts)
|
|
|
|
work.RegisterWorkflowWithOptions(TaskQueueScannerWorkflow, workflow.RegisterOptions{Name: tqScannerWFTypeName})
|
|
work.RegisterWorkflowWithOptions(HistoryScannerWorkflow, workflow.RegisterOptions{Name: historyScannerWFTypeName})
|
|
work.RegisterWorkflowWithOptions(ExecutionsScannerWorkflow, workflow.RegisterOptions{Name: executionsScannerWFTypeName})
|
|
work.RegisterActivityWithOptions(TaskQueueScavengerActivity, activity.RegisterOptions{Name: taskQueueScavengerActivityName})
|
|
work.RegisterActivityWithOptions(HistoryScavengerActivity, activity.RegisterOptions{Name: historyScavengerActivityName})
|
|
work.RegisterActivityWithOptions(ExecutionsScavengerActivity, activity.RegisterOptions{Name: executionsScavengerActivityName})
|
|
|
|
// TODO: Nothing is gracefully stopping these workers or listening for fatal errors.
|
|
if err := work.Start(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *Scanner) Stop() {
|
|
s.lifecycleCancel()
|
|
s.wg.Wait()
|
|
}
|
|
|
|
func (s *Scanner) startWorkflowWithRetry(ctx context.Context, options sdkclient.StartWorkflowOptions, workflowType string, workflowArgs ...interface{}) {
|
|
defer s.wg.Done()
|
|
|
|
policy := backoff.NewExponentialRetryPolicy(time.Second).
|
|
WithMaximumInterval(time.Minute).
|
|
WithExpirationInterval(backoff.NoInterval)
|
|
err := backoff.ThrottleRetryContext(ctx, func(ctx context.Context) error {
|
|
return s.startWorkflow(
|
|
ctx,
|
|
s.context.sdkClientFactory.GetSystemClient(),
|
|
options,
|
|
workflowType,
|
|
workflowArgs...,
|
|
)
|
|
}, policy, func(err error) bool {
|
|
return true
|
|
})
|
|
// if the scanner shuts down before the workflow is started, then the error will be context canceled
|
|
if err != nil && !common.IsContextCanceledErr(err) {
|
|
s.context.logger.Fatal("unable to start scanner", tag.WorkflowType(workflowType), tag.Error(err))
|
|
}
|
|
}
|
|
|
|
func (s *Scanner) startWorkflow(
|
|
ctx context.Context,
|
|
client sdkclient.Client,
|
|
options sdkclient.StartWorkflowOptions,
|
|
workflowType string,
|
|
workflowArgs ...interface{},
|
|
) error {
|
|
ctx, cancel := context.WithTimeout(ctx, 5*time.Minute)
|
|
_, err := client.ExecuteWorkflow(ctx, options, workflowType, workflowArgs...)
|
|
cancel()
|
|
if err != nil {
|
|
if _, ok := err.(*serviceerror.WorkflowExecutionAlreadyStarted); ok {
|
|
return nil
|
|
}
|
|
s.context.logger.Error("error starting workflow", tag.WorkflowType(workflowType), tag.Error(err))
|
|
return err
|
|
}
|
|
s.context.logger.Info("workflow successfully started", tag.WorkflowType(workflowType))
|
|
return nil
|
|
}
|