Files
tasks/tests/workflow_visibility_test.go
Roey BermanandGitHub 243effc6e1 Forbid the use of pborman/uuid and remove uses (#8541)
## What

Used the `depguard` linter to prevent importing the package and modified
all uses of it.

Also fixed a bug in the membership code where we were not updating the
next page token:

https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350


## Why?

From the package README in GitHub:

> This package now leverages the github.com/google/uuid package (which
is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the
codebase.

## Test

Added the invalid import and confirmed it works:

```
../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

```
2025-11-26 01:33:02 +00:00

178 lines
5.6 KiB
Go

package tests
import (
"testing"
"time"
"github.com/google/uuid"
"github.com/stretchr/testify/suite"
commandpb "go.temporal.io/api/command/v1"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
filterpb "go.temporal.io/api/filter/v1"
taskqueuepb "go.temporal.io/api/taskqueue/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/server/common/payloads"
"go.temporal.io/server/tests/testcore"
"google.golang.org/protobuf/types/known/durationpb"
"google.golang.org/protobuf/types/known/timestamppb"
)
type WorkflowVisibilityTestSuite struct {
testcore.FunctionalTestBase
}
func TestWorkflowVisibilityTestSuite(t *testing.T) {
t.Parallel()
suite.Run(t, new(WorkflowVisibilityTestSuite))
}
func (s *WorkflowVisibilityTestSuite) TestVisibility() {
startTime := time.Now().UTC()
// Start 2 workflow executions
id1 := "functional-visibility-test1"
id2 := "functional-visibility-test2"
wt := "functional-visibility-test-type"
tl := "functional-visibility-test-taskqueue"
identity := "worker1"
startRequest := &workflowservice.StartWorkflowExecutionRequest{
RequestId: uuid.NewString(),
Namespace: s.Namespace().String(),
WorkflowId: id1,
WorkflowType: &commonpb.WorkflowType{Name: wt},
TaskQueue: &taskqueuepb.TaskQueue{Name: tl, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
Input: nil,
WorkflowRunTimeout: durationpb.New(100 * time.Second),
WorkflowTaskTimeout: durationpb.New(10 * time.Second),
Identity: identity,
}
startResponse, err0 := s.FrontendClient().StartWorkflowExecution(testcore.NewContext(), startRequest)
s.NoError(err0)
// Now complete one of the executions
wtHandler := func(task *workflowservice.PollWorkflowTaskQueueResponse) ([]*commandpb.Command, error) {
return []*commandpb.Command{{
CommandType: enumspb.COMMAND_TYPE_COMPLETE_WORKFLOW_EXECUTION,
Attributes: &commandpb.Command_CompleteWorkflowExecutionCommandAttributes{CompleteWorkflowExecutionCommandAttributes: &commandpb.CompleteWorkflowExecutionCommandAttributes{
Result: payloads.EncodeString("Done"),
}},
}}, nil
}
poller := &testcore.TaskPoller{
Client: s.FrontendClient(),
Namespace: s.Namespace().String(),
TaskQueue: &taskqueuepb.TaskQueue{Name: tl, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
Identity: identity,
WorkflowTaskHandler: wtHandler,
ActivityTaskHandler: nil,
Logger: s.Logger,
T: s.T(),
}
_, err1 := poller.PollAndProcessWorkflowTask()
s.NoError(err1)
// wait until the start workflow is done
var nextToken []byte
historyEventFilterType := enumspb.HISTORY_EVENT_FILTER_TYPE_CLOSE_EVENT
for {
historyResponse, historyErr := s.FrontendClient().GetWorkflowExecutionHistory(testcore.NewContext(), &workflowservice.GetWorkflowExecutionHistoryRequest{
Namespace: startRequest.Namespace,
Execution: &commonpb.WorkflowExecution{
WorkflowId: startRequest.WorkflowId,
RunId: startResponse.RunId,
},
WaitNewEvent: true,
HistoryEventFilterType: historyEventFilterType,
NextPageToken: nextToken,
})
s.Nil(historyErr)
if len(historyResponse.NextPageToken) == 0 {
break
}
nextToken = historyResponse.NextPageToken
}
startRequest = &workflowservice.StartWorkflowExecutionRequest{
RequestId: uuid.NewString(),
Namespace: s.Namespace().String(),
WorkflowId: id2,
WorkflowType: &commonpb.WorkflowType{Name: wt},
TaskQueue: &taskqueuepb.TaskQueue{Name: tl, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
Input: nil,
WorkflowRunTimeout: durationpb.New(100 * time.Second),
WorkflowTaskTimeout: durationpb.New(10 * time.Second),
Identity: identity,
}
_, err2 := s.FrontendClient().StartWorkflowExecution(testcore.NewContext(), startRequest)
s.NoError(err2)
startFilter := &filterpb.StartTimeFilter{}
startFilter.EarliestTime = timestamppb.New(startTime)
startFilter.LatestTime = timestamppb.New(time.Now().UTC())
closedCount := 0
openCount := 0
var historyLength int64
s.Eventually(
func() bool {
resp, err3 := s.FrontendClient().ListClosedWorkflowExecutions(testcore.NewContext(), &workflowservice.ListClosedWorkflowExecutionsRequest{
Namespace: s.Namespace().String(),
MaximumPageSize: 100,
StartTimeFilter: startFilter,
Filters: &workflowservice.ListClosedWorkflowExecutionsRequest_TypeFilter{
TypeFilter: &filterpb.WorkflowTypeFilter{
Name: wt,
},
},
})
s.NoError(err3)
closedCount = len(resp.Executions)
if closedCount == 1 {
historyLength = resp.Executions[0].HistoryLength
s.Nil(resp.NextPageToken)
return true
}
s.Logger.Info("Closed WorkflowExecution is not yet visible")
return false
},
testcore.WaitForESToSettle,
100*time.Millisecond,
)
s.Equal(1, closedCount)
s.Equal(int64(5), historyLength)
s.Eventually(
func() bool {
resp, err4 := s.FrontendClient().ListOpenWorkflowExecutions(testcore.NewContext(), &workflowservice.ListOpenWorkflowExecutionsRequest{
Namespace: s.Namespace().String(),
MaximumPageSize: 100,
StartTimeFilter: startFilter,
Filters: &workflowservice.ListOpenWorkflowExecutionsRequest_TypeFilter{
TypeFilter: &filterpb.WorkflowTypeFilter{
Name: wt,
},
},
})
s.NoError(err4)
openCount = len(resp.Executions)
if openCount == 1 {
s.Nil(resp.NextPageToken)
return true
}
s.Logger.Info("Open WorkflowExecution is not yet visible")
return false
},
testcore.WaitForESToSettle,
100*time.Millisecond,
)
s.Equal(1, openCount)
}