mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Removes the full test failure from the `Details` portion of a `junit.Result` which was breaking XML formatting. ## Why? Breaks our flaky test analysis ## How did you test it? - [ ] built - [X] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Flaky tests reporting could be breaking again.
255 lines
6.3 KiB
Go
255 lines
6.3 KiB
Go
package testrunner
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"errors"
|
|
"fmt"
|
|
"iter"
|
|
"log"
|
|
"os"
|
|
"slices"
|
|
"strings"
|
|
|
|
"github.com/jstemmer/go-junit-report/v2/junit"
|
|
)
|
|
|
|
type junitReport struct {
|
|
junit.Testsuites
|
|
path string
|
|
reportingErrs []error
|
|
}
|
|
|
|
func (j *junitReport) read() error {
|
|
f, err := os.Open(j.path)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to open junit report file: %w", err)
|
|
}
|
|
defer f.Close()
|
|
|
|
decoder := xml.NewDecoder(f)
|
|
if err = decoder.Decode(&j.Testsuites); err != nil {
|
|
return fmt.Errorf("failed to read junit report file: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func generateStatic(names []string, suffix string, message string) *junitReport {
|
|
var testcases []junit.Testcase
|
|
for _, name := range names {
|
|
testcases = append(testcases, junit.Testcase{
|
|
Name: fmt.Sprintf("%s (%s)", name, suffix),
|
|
Failure: &junit.Result{Message: message},
|
|
})
|
|
}
|
|
return &junitReport{
|
|
Testsuites: junit.Testsuites{
|
|
Suites: []junit.Testsuite{
|
|
{
|
|
Name: "suite",
|
|
Testcases: testcases,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func (j *junitReport) write() error {
|
|
f, err := os.Create(j.path)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to open junit report file: %w", err)
|
|
}
|
|
defer f.Close()
|
|
|
|
encoder := xml.NewEncoder(f)
|
|
encoder.Indent("", " ")
|
|
if err = encoder.Encode(j.Testsuites); err != nil {
|
|
return fmt.Errorf("failed to write junit report file: %w", err)
|
|
}
|
|
log.Printf("wrote junit report to %s", j.path)
|
|
return nil
|
|
}
|
|
|
|
// appendAlertsSuite adds a synthetic JUnit suite summarizing high-priority alerts
|
|
// (data races, panics, fatals) so that CI surfaces them prominently.
|
|
func (j *junitReport) appendAlertsSuite(alerts []alert) {
|
|
// Deduplicate by kind+details to avoid noisy repeats across retries.
|
|
alerts = dedupeAlerts(alerts)
|
|
if len(alerts) == 0 {
|
|
return
|
|
}
|
|
var cases []junit.Testcase
|
|
for _, a := range alerts {
|
|
name := fmt.Sprintf("%s: %s", a.Kind, a.Summary)
|
|
if p := primaryTestName(a.Tests); p != "" {
|
|
name = fmt.Sprintf("%s — in %s", name, p)
|
|
}
|
|
// Include only test names for context, not the full log details to avoid XML malformation
|
|
var details string
|
|
if len(a.Tests) > 0 {
|
|
details = fmt.Sprintf("Detected in tests:\n\t%s", strings.Join(a.Tests, "\n\t"))
|
|
}
|
|
r := &junit.Result{Message: string(a.Kind), Data: details}
|
|
cases = append(cases, junit.Testcase{
|
|
Name: name,
|
|
Failure: r,
|
|
})
|
|
}
|
|
suite := junit.Testsuite{
|
|
Name: "ALERTS",
|
|
Failures: len(cases),
|
|
Tests: len(cases),
|
|
Testcases: cases,
|
|
}
|
|
j.Suites = append(j.Suites, suite)
|
|
j.Failures += suite.Failures
|
|
j.Tests += suite.Tests
|
|
}
|
|
|
|
// dedupeAlerts removes duplicate alerts (e.g., repeated across retries) based
|
|
// on kind and details while preserving the first-seen order.
|
|
func dedupeAlerts(alerts []alert) []alert {
|
|
seen := make(map[string]struct{}, len(alerts))
|
|
var out []alert
|
|
for _, a := range alerts {
|
|
key := string(a.Kind) + "\n" + a.Details
|
|
if _, ok := seen[key]; ok {
|
|
continue
|
|
}
|
|
seen[key] = struct{}{}
|
|
out = append(out, a)
|
|
}
|
|
return out
|
|
}
|
|
|
|
func (j *junitReport) collectTestCases() map[string]struct{} {
|
|
cases := make(map[string]struct{})
|
|
for _, suite := range j.Suites {
|
|
for _, tc := range suite.Testcases {
|
|
cases[tc.Name] = struct{}{}
|
|
}
|
|
}
|
|
return cases
|
|
}
|
|
|
|
func (j *junitReport) collectTestCaseFailures() []string {
|
|
var failures []string
|
|
for _, suite := range j.Suites {
|
|
if suite.Failures == 0 {
|
|
continue
|
|
}
|
|
for _, tc := range suite.Testcases {
|
|
if tc.Failure != nil {
|
|
failures = append(failures, tc.Name)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Sort lexicographically
|
|
slices.Sort(failures)
|
|
|
|
// Find leaf failures using the simplified algorithm
|
|
var leafFailures []string
|
|
for i := 0; i < len(failures)-1; i++ {
|
|
if !strings.HasPrefix(failures[i+1], failures[i]+"/") {
|
|
leafFailures = append(leafFailures, failures[i])
|
|
}
|
|
}
|
|
if len(failures) > 0 {
|
|
leafFailures = append(leafFailures, failures[len(failures)-1])
|
|
}
|
|
|
|
return leafFailures
|
|
}
|
|
|
|
func mergeReports(reports []*junitReport) (*junitReport, error) {
|
|
if len(reports) == 0 {
|
|
return nil, errors.New("no reports to merge")
|
|
}
|
|
|
|
var reportingErrs []error
|
|
var combined junit.Testsuites
|
|
combined.XMLName = reports[0].Testsuites.XMLName
|
|
combined.Name = reports[0].Testsuites.Name
|
|
|
|
for i, report := range reports {
|
|
combined.Tests += report.Testsuites.Tests
|
|
combined.Errors += report.Testsuites.Errors
|
|
combined.Failures += report.Testsuites.Failures
|
|
combined.Skipped += report.Testsuites.Skipped
|
|
combined.Disabled += report.Testsuites.Disabled
|
|
combined.Time += report.Testsuites.Time
|
|
|
|
// If the report is for a retry ...
|
|
var suffix string
|
|
if i > 0 {
|
|
suffix = fmt.Sprintf(" (retry %d)", i)
|
|
prevFailures := reports[i-1].collectTestCaseFailures()
|
|
currCases := report.collectTestCases()
|
|
|
|
var missing []string
|
|
for _, f := range prevFailures {
|
|
if _, ok := currCases[f]; !ok {
|
|
missing = append(missing, f)
|
|
}
|
|
}
|
|
if len(missing) > 0 {
|
|
reportingErrs = append(reportingErrs, fmt.Errorf(
|
|
"expected rerun of all failures from previous attempt, missing: %v", missing))
|
|
}
|
|
}
|
|
|
|
for _, suite := range report.Testsuites.Suites {
|
|
if len(suite.Testcases) == 0 {
|
|
continue
|
|
}
|
|
|
|
newSuite := suite // shallow copy
|
|
newSuite.Name += suffix
|
|
newSuite.Testcases = make([]junit.Testcase, 0, len(suite.Testcases))
|
|
|
|
// Sort test cases by name.
|
|
slices.SortFunc(suite.Testcases, func(a, b junit.Testcase) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
|
|
// Collect test cases.
|
|
for j := range len(suite.Testcases) {
|
|
testCase := suite.Testcases[j]
|
|
// Check if this is a parent test case (ie prefix of next test).
|
|
if j != len(suite.Testcases)-1 && strings.HasPrefix(suite.Testcases[j+1].Name, testCase.Name) {
|
|
// Discard test case parents since they provide no value.
|
|
continue
|
|
}
|
|
testCase.Name += suffix
|
|
newSuite.Testcases = append(newSuite.Testcases, testCase)
|
|
}
|
|
combined.Suites = append(combined.Suites, newSuite)
|
|
}
|
|
}
|
|
|
|
return &junitReport{
|
|
Testsuites: combined,
|
|
reportingErrs: reportingErrs,
|
|
}, nil
|
|
}
|
|
|
|
type node struct {
|
|
children map[string]node
|
|
}
|
|
|
|
func (n node) visitor(path ...string) func(yield func(string, node) bool) {
|
|
return func(yield func(string, node) bool) {
|
|
for name, child := range n.children {
|
|
path := append(path, name)
|
|
if !yield(strings.Join(path, "/"), child) {
|
|
return
|
|
}
|
|
child.visitor(path...)(yield)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (n node) walk() iter.Seq2[string, node] {
|
|
return n.visitor()
|
|
}
|