mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Expanding `testrunner` tool to add alerts for panics and data races. Sample table with an injected data race (and real panic): <table><tr><th><th>Tests</th><th>Passed ✅</th><th>Skipped ⏭️</th><th>Failed ❌</th></tr><tr><td>JUnit Test Report</td><td>721 ran</td><td>340 passed</td><td>370 skipped</td><td>11 failed</td></tr></table> <table><tr><th>Test</th><th>Result</th></tr><tr><td colspan="2"><strong>JUnit Test Report</strong></td></tr><tr><td>functional-test (crash)</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestActivityApiBatchResetClientTestSuite/TestActivityBatchReset_DataRace</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestTaskQueueStats_Pri_Suite/TestNoTasks_ValidateStats</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestVersioning3FunctionalSuite/TestUnpinnedQuery_NoSticky/ForceTaskForwardForcePollForwardForceAsync</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestVersioningFunctionalSuite/TestDispatchQueryOld/ForceTaskForwardForcePollForwardForceAsync</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestActivityApiBatchResetClientTestSuite/TestActivityBatchReset_DataRace (retry 1)</td><td>❌ failure</td></tr><tr><td>io/server/tests.TestActivityApiBatchResetClientTestSuite/TestActivityBatchReset_DataRace (retry 2)</td><td>❌ failure</td></tr><tr><td>func1.DATA RACE: Data race detected — in go.temporal.io/server/tests.(*ActivityApiBatchResetClientTestSuite).TestActivityBatchReset_DataRace.func1</td><td>❌ failure</td></tr><tr><td>PANIC: runtime error: invalid memory address or nil pointer dereference — in TestTaskQueueStats_Pri_Suite/TestAddMultipleTasks_MultiplePartitions_ValidateStats_Cached</td><td>❌ failure</td></tr><tr><td>func1.DATA RACE: Data race detected — in go.temporal.io/server/tests.(*ActivityApiBatchResetClientTestSuite).TestActivityBatchReset_DataRace.func1</td><td>❌ failure</td></tr><tr><td>func1.DATA RACE: Data race detected — in go.temporal.io/server/tests.(*ActivityApiBatchResetClientTestSuite).TestActivityBatchReset_DataRace.func1</td><td>❌ failure</td></tr></table> Source: https://github.com/temporalio/temporal/actions/runs/17870152469?pr=8351 ## Why? This change will help the temporal team find bugs sooner. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s) ## Potential risks NA
322 lines
8.4 KiB
Go
322 lines
8.4 KiB
Go
package testrunner
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"log"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
"slices"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/google/uuid"
|
|
)
|
|
|
|
const (
|
|
codeCoverageExtension = ".cover.out"
|
|
maxAttemptsFlag = "--max-attempts="
|
|
coverProfileFlag = "-coverprofile="
|
|
junitReportFlag = "--junitfile="
|
|
crashReportNameFlag = "--crashreportname="
|
|
gotestsumPathFlag = "--gotestsum-path="
|
|
)
|
|
|
|
const (
|
|
testCommand = "test"
|
|
crashReportCommand = "report-crash"
|
|
)
|
|
|
|
type attempt struct {
|
|
runner *runner
|
|
number int
|
|
exitErr *exec.ExitError
|
|
junitReport *junitReport
|
|
coverProfilePath string
|
|
}
|
|
|
|
func (a *attempt) run(ctx context.Context, args []string) (string, error) {
|
|
for i, arg := range args {
|
|
if strings.HasPrefix(arg, coverProfileFlag) {
|
|
args[i] = coverProfileFlag + a.coverProfilePath
|
|
} else if strings.HasPrefix(arg, junitReportFlag) {
|
|
args[i] = junitReportFlag + a.junitReport.path
|
|
}
|
|
}
|
|
log.Printf("starting test attempt #%d: %v %v",
|
|
a.number, a.runner.gotestsumPath, strings.Join(args, " "))
|
|
cmd := exec.CommandContext(ctx, a.runner.gotestsumPath, args...)
|
|
var output strings.Builder
|
|
cmd.Stdout = io.MultiWriter(os.Stdout, &output)
|
|
cmd.Stderr = os.Stderr
|
|
cmd.Stdin = os.Stdin
|
|
err := cmd.Run()
|
|
return output.String(), err
|
|
}
|
|
|
|
type runner struct {
|
|
gotestsumPath string
|
|
junitOutputPath string
|
|
coverProfilePath string
|
|
attempts []*attempt
|
|
maxAttempts int
|
|
crashName string
|
|
alerts []alert
|
|
}
|
|
|
|
func newRunner() *runner {
|
|
return &runner{
|
|
attempts: make([]*attempt, 0),
|
|
maxAttempts: 1,
|
|
}
|
|
}
|
|
|
|
// nolint:revive,cognitive-complexity
|
|
func (r *runner) sanitizeAndParseArgs(command string, args []string) ([]string, error) {
|
|
var sanitizedArgs []string
|
|
for _, arg := range args {
|
|
if strings.HasPrefix(arg, maxAttemptsFlag) {
|
|
var err error
|
|
r.maxAttempts, err = strconv.Atoi(strings.Split(arg, "=")[1])
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid argument %q: %w", maxAttemptsFlag, err)
|
|
}
|
|
if r.maxAttempts == 0 {
|
|
return nil, fmt.Errorf("invalid argument %q: must be greater than zero", maxAttemptsFlag)
|
|
}
|
|
continue // this is a `testrunner` only arg and not passed through
|
|
}
|
|
|
|
if strings.HasPrefix(arg, gotestsumPathFlag) {
|
|
r.gotestsumPath = strings.Split(arg, "=")[1]
|
|
continue
|
|
}
|
|
|
|
if strings.HasPrefix(arg, crashReportNameFlag) {
|
|
r.crashName = strings.Split(arg, "=")[1]
|
|
if r.crashName == "" {
|
|
return nil, fmt.Errorf("invalid argument %q: must not be empty", crashReportNameFlag)
|
|
}
|
|
if command != crashReportCommand {
|
|
return nil, fmt.Errorf("argument %q is only valid for command %q", crashReportNameFlag, crashReportCommand)
|
|
}
|
|
continue // this is a `testrunner` only arg and not passed through
|
|
}
|
|
|
|
if strings.HasPrefix(arg, coverProfileFlag) {
|
|
r.coverProfilePath = strings.Split(arg, "=")[1]
|
|
} else if strings.HasPrefix(arg, junitReportFlag) {
|
|
// --junitfile is used by gotestsum
|
|
r.junitOutputPath = strings.Split(arg, "=")[1]
|
|
}
|
|
|
|
sanitizedArgs = append(sanitizedArgs, arg)
|
|
}
|
|
|
|
if r.junitOutputPath == "" {
|
|
return nil, fmt.Errorf("missing required argument %q", junitReportFlag)
|
|
}
|
|
|
|
switch command {
|
|
case testCommand:
|
|
if r.coverProfilePath == "" {
|
|
return nil, fmt.Errorf("missing required argument %q", coverProfileFlag)
|
|
}
|
|
if r.junitOutputPath == "" {
|
|
return nil, fmt.Errorf("missing required argument %q", junitReportFlag)
|
|
}
|
|
if r.gotestsumPath == "" {
|
|
return nil, fmt.Errorf("missing required argument %q", gotestsumPathFlag)
|
|
}
|
|
case crashReportCommand:
|
|
if r.crashName == "" {
|
|
return nil, fmt.Errorf("missing required argument %q", crashReportNameFlag)
|
|
}
|
|
default:
|
|
return nil, fmt.Errorf("unknown command %q", command)
|
|
}
|
|
|
|
return sanitizedArgs, nil
|
|
}
|
|
|
|
func (r *runner) newAttempt() *attempt {
|
|
a := &attempt{
|
|
runner: r,
|
|
number: len(r.attempts) + 1,
|
|
coverProfilePath: fmt.Sprintf(
|
|
"%v_%v%v",
|
|
strings.TrimSuffix(r.coverProfilePath, codeCoverageExtension),
|
|
len(r.attempts),
|
|
codeCoverageExtension),
|
|
junitReport: &junitReport{
|
|
path: filepath.Join(os.TempDir(), fmt.Sprintf("temporalio-temporal-%s-junit.xml", uuid.NewString())),
|
|
},
|
|
}
|
|
r.attempts = append(r.attempts, a)
|
|
return a
|
|
}
|
|
|
|
func (r *runner) allReports() []*junitReport {
|
|
var reports []*junitReport
|
|
for _, a := range r.attempts {
|
|
reports = append(reports, a.junitReport)
|
|
}
|
|
return reports
|
|
}
|
|
|
|
// Main is the entry point for the testrunner tool.
|
|
// nolint:revive,deep-exit
|
|
func Main() {
|
|
log.SetPrefix("[testrunner] ")
|
|
ctx := context.Background()
|
|
|
|
if len(os.Args) < 2 {
|
|
log.Fatalf("expected at least 2 arguments")
|
|
}
|
|
r := newRunner()
|
|
|
|
command := os.Args[1]
|
|
args, err := r.sanitizeAndParseArgs(command, os.Args[2:])
|
|
if err != nil {
|
|
log.Fatalf("failed to parse command line options: %v", err)
|
|
}
|
|
|
|
switch command {
|
|
case testCommand:
|
|
r.runTests(ctx, args)
|
|
case crashReportCommand:
|
|
r.reportCrash()
|
|
default:
|
|
log.Fatalf("unknown command %q", command)
|
|
}
|
|
}
|
|
|
|
// nolint:revive,deep-exit
|
|
func (r *runner) reportCrash() {
|
|
jr := generateStatic([]string{r.crashName}, "crash", "Crash")
|
|
jr.path = r.junitOutputPath
|
|
if err := jr.write(); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func (r *runner) runTests(ctx context.Context, args []string) {
|
|
var currentAttempt *attempt
|
|
for a := 1; a <= r.maxAttempts; a++ {
|
|
currentAttempt = r.newAttempt()
|
|
|
|
// Run tests.
|
|
stdout, err := currentAttempt.run(ctx, args)
|
|
// Extract prominent alerts from this attempt's output.
|
|
r.alerts = append(r.alerts, parseAlerts(stdout)...)
|
|
if err != nil && !errors.As(err, ¤tAttempt.exitErr) {
|
|
log.Fatalf("test run failed with an unexpected error: %v", err)
|
|
}
|
|
|
|
stacktrace, timedoutTests := parseTestTimeouts(stdout)
|
|
if len(timedoutTests) > 0 {
|
|
// Run timed out and was aborted.
|
|
// Update JUnit XML output for timed out tests since none will have been generated.
|
|
currentAttempt.junitReport = generateStatic(timedoutTests, "timed out", "Timeout")
|
|
log.Print(stacktrace)
|
|
|
|
// Don't retry.
|
|
break
|
|
}
|
|
|
|
// All tests were run, parse JUnit XML output.
|
|
if err = currentAttempt.junitReport.read(); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
|
|
// If the run completely successfull, no need to retry.
|
|
if currentAttempt.exitErr == nil {
|
|
break
|
|
}
|
|
|
|
// Sanity check: make sure failures are reported when the run failed.
|
|
failures := currentAttempt.junitReport.collectTestCaseFailures()
|
|
if len(failures) == 0 {
|
|
log.Fatalf("tests failed but no failures have been detected, not rerunning tests")
|
|
}
|
|
|
|
// Rerun all tests from previous attempt if there's more than 10 failures in a single suite.
|
|
if len(failures) > 10 && a < r.maxAttempts {
|
|
log.Printf(
|
|
"number of failures exceeds configured threshold (%d/%d) for narrowing down tests to retry, retrying with previous attempt's args",
|
|
len(failures), 10)
|
|
continue
|
|
}
|
|
args = stripRunFromArgs(args)
|
|
for i, failure := range failures {
|
|
failures[i] = goTestNameToRunFlagRegexp(failure)
|
|
}
|
|
failureArg := strings.Join(failures, "|")
|
|
// -args has special semantics in Go.
|
|
argsIdx := slices.Index(args, "-args")
|
|
if argsIdx == -1 {
|
|
args = append(args, "-run", failureArg)
|
|
} else {
|
|
args = slices.Insert(args, argsIdx, "-run", failureArg)
|
|
}
|
|
}
|
|
|
|
// Merge reports from all attempts and write the final JUnit report.
|
|
mergedReport, err := mergeReports(r.allReports())
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
// Append ALERTS suite to the merged JUnit if any were found.
|
|
if len(r.alerts) > 0 {
|
|
mergedReport.appendAlertsSuite(r.alerts)
|
|
}
|
|
mergedReport.path = r.junitOutputPath
|
|
if err = mergedReport.write(); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
if len(mergedReport.reportingErrs) > 0 {
|
|
log.Fatal(mergedReport.reportingErrs)
|
|
}
|
|
|
|
// Exit with the exit code of the last attempt.
|
|
if currentAttempt.exitErr != nil {
|
|
log.Printf("exiting with failure after running %d attempt(s)", len(r.attempts))
|
|
os.Exit(currentAttempt.exitErr.ExitCode())
|
|
}
|
|
}
|
|
|
|
func stripRunFromArgs(args []string) (argsNoRun []string) {
|
|
var skipNext bool
|
|
for _, arg := range args {
|
|
if skipNext {
|
|
skipNext = false
|
|
continue
|
|
} else if arg == "-run" {
|
|
skipNext = true
|
|
continue
|
|
} else if strings.HasPrefix(arg, "-run=") {
|
|
continue
|
|
}
|
|
argsNoRun = append(argsNoRun, arg)
|
|
}
|
|
return
|
|
}
|
|
|
|
func goTestNameToRunFlagRegexp(test string) string {
|
|
parts := strings.Split(test, "/")
|
|
var sb strings.Builder
|
|
for i, p := range parts {
|
|
if i > 0 {
|
|
sb.WriteByte('/')
|
|
}
|
|
sb.WriteByte('^')
|
|
sb.WriteString(regexp.QuoteMeta(p))
|
|
sb.WriteByte('$')
|
|
}
|
|
return sb.String()
|
|
}
|