mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Stephan BehnkeandGitHub
6827aad2cc
## What changed? Added a CI step that writes a crash JUnit XML file if the testrunner doesn't complete. ## Why? (1) Make the "Summary" helpful again by quickly seeing what went wrong. (2) Make CodeCov show these crashes. (3) Make our internal test report show these crashes. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) Example run: https://github.com/temporalio/temporal/actions/runs/17107215158?pr=8221 <img width="1184" height="1167" alt="image" src="https://github.com/user-attachments/assets/a1c5445e-4359-450d-83ec-8b7a169c47cd" />
142 lines
3.4 KiB
Go
142 lines
3.4 KiB
Go
package testrunner
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRunnerSanitizeAndParseArgs(t *testing.T) {
|
|
t.Run("Passthrough", func(t *testing.T) {
|
|
r := newRunner()
|
|
args, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
"--gotestsum-path=/bin/gotestsum",
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
"--max-attempts=3",
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, []string{
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
// max-attempts has been stripped
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
}, args)
|
|
require.Equal(t, "test.xml", r.junitOutputPath)
|
|
require.Equal(t, 3, r.maxAttempts)
|
|
require.Equal(t, "test.cover.out", r.coverProfilePath)
|
|
})
|
|
|
|
t.Run("GoTestSumPathMissing", func(t *testing.T) {
|
|
r := newRunner()
|
|
_, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
// missing:
|
|
// "--max-attempts=0",
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.ErrorContains(t, err, `missing required argument "--gotestsum-path="`)
|
|
})
|
|
|
|
t.Run("AttemptsInvalid1", func(t *testing.T) {
|
|
r := newRunner()
|
|
_, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
"--gotestsum-path=/bin/gotestsum",
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
"--max-attempts=0", // invalid!
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.ErrorContains(t, err, `invalid argument "--max-attempts=": must be greater than zero`)
|
|
})
|
|
|
|
t.Run("AttemptsInvalid2", func(t *testing.T) {
|
|
r := newRunner()
|
|
_, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
"--gotestsum-path=/bin/gotestsum",
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
"--max-attempts=invalid", // invalid!
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.ErrorContains(t, err, `invalid argument "--max-attempts=": strconv.Atoi: parsing "invalid"`)
|
|
})
|
|
|
|
t.Run("JunitfileMissing", func(t *testing.T) {
|
|
r := newRunner()
|
|
_, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
// missing:
|
|
// "--junitfile=test.xml"
|
|
"-foo",
|
|
"bar",
|
|
"--max-attempts=3",
|
|
"--",
|
|
"-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.ErrorContains(t, err, `missing required argument "--junitfile="`)
|
|
})
|
|
|
|
t.Run("CoverprofileMissing", func(t *testing.T) {
|
|
r := newRunner()
|
|
_, err := r.sanitizeAndParseArgs(testCommand, []string{
|
|
"--gotestsum-path=/bin/gotestsum",
|
|
"--junitfile=test.xml",
|
|
"-foo",
|
|
"bar",
|
|
"--max-attempts=3",
|
|
"--",
|
|
// missing:
|
|
// "-coverprofile=test.cover.out",
|
|
"baz",
|
|
})
|
|
require.ErrorContains(t, err, `missing required argument "-coverprofile="`)
|
|
})
|
|
}
|
|
|
|
func TestStripRunFromArgs(t *testing.T) {
|
|
t.Run("OneArg", func(t *testing.T) {
|
|
args := stripRunFromArgs([]string{"-foo", "bar", "-run=A"})
|
|
require.Equal(t, []string{"-foo", "bar"}, args)
|
|
})
|
|
|
|
t.Run("TwoArgs", func(t *testing.T) {
|
|
args := stripRunFromArgs([]string{"-foo", "bar", "-run", "A"})
|
|
require.Equal(t, []string{"-foo", "bar"}, args)
|
|
})
|
|
}
|
|
|
|
func TestRunnerReportCrash(t *testing.T) {
|
|
out, err := os.CreateTemp("", "junit-report-*.xml")
|
|
require.NoError(t, err)
|
|
defer func() { _ = os.Remove(out.Name()) }()
|
|
|
|
r := newRunner()
|
|
_, err = r.sanitizeAndParseArgs(crashReportCommand, []string{
|
|
"--junitfile=" + out.Name(),
|
|
"--crashreportname=my-test",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
r.reportCrash()
|
|
requireReportEquals(t, "testdata/junit-crash-output.xml", out.Name())
|
|
}
|