Files
tasks/client/matching/metric_client.go
Yichao YangandGitHub 198f4d9c5f Add per namespace rate limiter for matching service (#10069)
## What changed?
- Add per namespace rate limiter for matching service
- Same as https://github.com/temporalio/temporal/pull/9884 but for
matching.

## Why?
- Noisy neighbor protection. Provide knob for preventing one namespace
from consuming all available matching host rps.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
2026-05-15 14:21:42 -07:00

256 lines
7.3 KiB
Go

package matching
import (
"context"
"errors"
"time"
"go.temporal.io/api/serviceerror"
taskqueuepb "go.temporal.io/api/taskqueue/v1"
"go.temporal.io/server/api/matchingservice/v1"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
serviceerrors "go.temporal.io/server/common/serviceerror"
"go.temporal.io/server/common/tqid"
"google.golang.org/grpc"
)
var _ matchingservice.MatchingServiceClient = (*metricClient)(nil)
type metricClient struct {
client matchingservice.MatchingServiceClient
metricsHandler metrics.Handler
logger log.Logger
throttledLogger log.Logger
}
// NewMetricClient creates a new instance of matchingservice.MatchingServiceClient that emits metrics
func NewMetricClient(
client matchingservice.MatchingServiceClient,
metricsHandler metrics.Handler,
logger log.Logger,
throttledLogger log.Logger,
) matchingservice.MatchingServiceClient {
return &metricClient{
client: client,
metricsHandler: metricsHandler,
logger: logger,
throttledLogger: throttledLogger,
}
}
func (c *metricClient) AddActivityTask(
ctx context.Context,
request *matchingservice.AddActivityTaskRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.AddActivityTaskResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientAddActivityTaskScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
c.emitForwardedSourceStats(
scope,
request.GetForwardInfo().GetSourcePartition(),
request.TaskQueue,
)
return c.client.AddActivityTask(ctx, request, opts...)
}
func (c *metricClient) AddWorkflowTask(
ctx context.Context,
request *matchingservice.AddWorkflowTaskRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.AddWorkflowTaskResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientAddWorkflowTaskScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
c.emitForwardedSourceStats(
scope,
request.GetForwardInfo().GetSourcePartition(),
request.TaskQueue,
)
return c.client.AddWorkflowTask(ctx, request, opts...)
}
func (c *metricClient) PollActivityTaskQueue(
ctx context.Context,
request *matchingservice.PollActivityTaskQueueRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.PollActivityTaskQueueResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientPollActivityTaskQueueScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
if request.PollRequest != nil {
c.emitForwardedSourceStats(
scope,
request.GetForwardedSource(),
request.PollRequest.TaskQueue,
)
}
return c.client.PollActivityTaskQueue(ctx, request, opts...)
}
func (c *metricClient) PollWorkflowTaskQueue(
ctx context.Context,
request *matchingservice.PollWorkflowTaskQueueRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.PollWorkflowTaskQueueResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientPollWorkflowTaskQueueScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
if request.PollRequest != nil {
c.emitForwardedSourceStats(
scope,
request.GetForwardedSource(),
request.PollRequest.TaskQueue,
)
}
return c.client.PollWorkflowTaskQueue(ctx, request, opts...)
}
func (c *metricClient) QueryWorkflow(
ctx context.Context,
request *matchingservice.QueryWorkflowRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.QueryWorkflowResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientQueryWorkflowScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
c.emitForwardedSourceStats(
scope,
request.GetForwardInfo().GetSourcePartition(),
request.TaskQueue,
)
return c.client.QueryWorkflow(ctx, request, opts...)
}
func (c *metricClient) DispatchNexusTask(
ctx context.Context,
request *matchingservice.DispatchNexusTaskRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.DispatchNexusTaskResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientDispatchNexusTaskScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
c.emitForwardedSourceStats(
scope,
request.GetForwardInfo().GetSourcePartition(),
request.TaskQueue,
)
return c.client.DispatchNexusTask(ctx, request, opts...)
}
func (c *metricClient) PollNexusTaskQueue(
ctx context.Context,
request *matchingservice.PollNexusTaskQueueRequest,
opts ...grpc.CallOption,
) (_ *matchingservice.PollNexusTaskQueueResponse, retError error) {
scope, stopwatch := c.startMetricsRecording(ctx, metrics.MatchingClientPollNexusTaskQueueScope)
defer func() {
c.finishMetricsRecording(scope, stopwatch, retError)
}()
if request.Request != nil {
c.emitForwardedSourceStats(
scope,
request.GetForwardedSource(),
request.Request.TaskQueue,
)
}
return c.client.PollNexusTaskQueue(ctx, request, opts...)
}
func (c *metricClient) emitForwardedSourceStats(
metricsHandler metrics.Handler,
forwardedFrom string,
taskQueue *taskqueuepb.TaskQueue,
) {
if taskQueue == nil {
return
}
switch {
case forwardedFrom != "":
metrics.MatchingClientForwardedCounter.With(metricsHandler).Record(1)
default:
// TODO: confirmed from metrics, it seems this error does happen at the moment...
// it means some mangled name come here; need to check why
_, err := tqid.NewTaskQueueFamily("", taskQueue.GetName())
if err != nil {
c.logger.Info("invalid tq name", tag.Error(err), tag.String("proto", taskQueue.GetName()))
metrics.MatchingClientInvalidTaskQueueName.With(metricsHandler).Record(1)
}
}
}
func (c *metricClient) startMetricsRecording(
ctx context.Context,
operation string,
) (metrics.Handler, time.Time) {
caller := headers.GetCallerInfo(ctx).CallerName
handler := c.metricsHandler.WithTags(metrics.OperationTag(operation), metrics.NamespaceTag(caller), metrics.ServiceRoleTag(metrics.MatchingRoleTagValue))
metrics.ClientRequests.With(handler).Record(1)
return handler, time.Now().UTC()
}
func (c *metricClient) finishMetricsRecording(
metricsHandler metrics.Handler,
startTime time.Time,
err error,
) {
if err != nil {
switch err.(type) {
case *serviceerrors.StickyWorkerUnavailable,
*serviceerror.Canceled,
*serviceerror.DeadlineExceeded,
*serviceerror.NotFound,
*serviceerror.QueryFailed,
*serviceerror.NamespaceNotFound,
*serviceerror.NewerBuildExists,
*serviceerror.WorkflowExecutionAlreadyStarted,
*serviceerror.ResourceExhausted:
// noop - not interest and too many logs
default:
c.throttledLogger.Info("matching client encountered error", tag.Error(err), tag.ServiceErrorType(err))
}
metrics.ClientFailures.With(metricsHandler).Record(1, metrics.ServiceErrorTypeTag(err))
}
metrics.ClientLatency.With(metricsHandler).Record(time.Since(startTime))
}
func (c *metricClient) Route(p tqid.Partition) (string, error) {
// Ideally we wouldn't do a type-check here and require c.client to have
// Route, but it would require changing too many types all over the place.
// This isn't called in a hot path.
rc, ok := c.client.(RoutingClient)
if !ok {
return "", errors.New("not routing client")
}
return rc.Route(p)
}