Files
tasks/cmd/tools/getproto/main.go
7fec4a9a3f Implement SignalWithStart as a system nexus endpoint (#9833)
## What changed?
This PR adds `SignalWithStartWorkflowExecution` as a synchronous Nexus
operation exposed via `__temporal_system endpoint`, allowing workflows
to signal-with-start other workflows through the CHASM Nexus operation
framework.

Key changes:
- `chasm/lib/workflow/nexus_service.go`: `workflowServiceNexusHandler`
implements the `SignalWithStartWorkflowExecution` Nexus sync operation
by resolving the namespace and delegating to the History service. A
`SignalWithStartOperationProcessor` handles input enrichment (namespace,
request ID, links) and routing via CHASM's
`NexusOperationProcessorResult`.
- `chasm/lib/workflow/library.go` — library now holds the
`workflowServiceNexusHandler`, the workflow `Config`, the SA mapper
provider, and the SA validator. `newLibrary` (used by fx) takes those
dependencies, while the public `NewLibrary` keeps its old signature for
external callers. Adds `NexusServices()` so the library registers its
Nexus service via CHASM.
- `chasm/lib/workflow/validator.go`: `RequestValidator` consolidates the
`SignalWithStartWorkflowExecution` validation logic (previously inlined
in `WorkflowHandler`) into a reusable, injectable struct. This same
validator is used by both the frontend handler and the new CHASM
processor.
- common/dynamicconfig/constants.go — adds
`EnableSignalWithStartFromWorkflow` (namespace-scoped, default false).
- `service/frontend/workflow_handler.go`: Removed the `SignalWithStart`
validation block
- `service/history/fx.go`: Provides a `HistoryServiceServerProvider` so
the CHASM workflow library can call the history handler directly.
- `temporal/fx.go`: Removes the now-redundant `ChasmLibraryOptions`
grouping; each service module registers its own CHASM libraries.
- `components/nexusoperations/workflow/commands.go`: `NotFound` and
`InvalidArgument` errors during Nexus command handling are now surfaced
as workflow task failures instead of being treated as transient handler
errors.
- `common/payloads`: Adds `EncodeSingle`, `MustEncodeSingle`, and
`MustEncode` helpers used in tests.
- `cmd/tools/getproto`: Adds support for nexus-proto-annotations proto
imports.
- `tests/signal_with_start_from_workflow_test.go`: Functional test suite
covering the happy path, duplicate detection, conflict policies, and
validation rejection for the new Nexus operation.


## Why?
This functionality is one of our most requested GitHub issues.

## How did you test it?
- [X] built
- [X] run locally and tested manually
- [ ] covered by existing tests
- [X] added new unit test(s)
- [X] added new functional test(s)

## Potential risks
The history service now directly exposes a `HistoryServiceServer`
interface via `fx` for injection into the CHASM workflow library. This
tight coupling between the CHASM workflow library and the history
handler could complicate future layering — callers outside the history
service should not adopt this pattern. The feature is gated by
`history.enableSignalWithStartFromWorkflow` for rollout.

---------

Co-authored-by: Roey Berman <[email protected]>
2026-05-20 21:49:35 +00:00

196 lines
4.8 KiB
Go

package main
import (
"flag"
"fmt"
"io/fs"
"log"
"os"
"path/filepath"
"regexp"
"sort"
"strings"
expmaps "golang.org/x/exp/maps"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/reflect/protodesc"
"google.golang.org/protobuf/reflect/protoreflect"
"google.golang.org/protobuf/types/descriptorpb"
)
var (
matchImport = regexp.MustCompile(`^\s*import\s+"([^"]+\.proto)"\s*;\s*$`)
versionSuffix = regexp.MustCompile(`^(.*)/v\d+$`)
// set by files.go if present
importMap map[string]protoreflect.FileDescriptor
)
func fatalIfErr(err error) {
if err != nil {
log.Fatal(err)
}
}
func findProtoImports() []string {
importMap := make(map[string]struct{})
fatalIfErr(filepath.WalkDir("proto/internal", func(path string, d fs.DirEntry, err error) error {
if err != nil {
return err
}
if d.Type().IsRegular() && strings.HasSuffix(path, ".proto") {
protoFile, err := os.ReadFile(path)
fatalIfErr(err)
for line := range strings.SplitSeq(string(protoFile), "\n") {
if match := matchImport.FindStringSubmatch(line); len(match) > 0 {
i := match[1]
if strings.HasPrefix(i, "temporal/api/") ||
strings.HasPrefix(i, "google/") ||
strings.HasPrefix(i, "nexus/") {
importMap[i] = struct{}{}
}
}
}
}
return nil
}))
return expmaps.Keys(importMap)
}
func getImportName(i string) string {
withoutV := i
if match := versionSuffix.FindStringSubmatch(i); match != nil {
withoutV = match[1]
}
return filepath.Base(withoutV)
}
func mangle(p string) string {
mangled := strings.ReplaceAll(p, "/", "_")
return "File_" + strings.ReplaceAll(mangled, ".", "_")
}
func genFileList(protoImports []string) {
sort.Strings(protoImports)
goImportsMap := make(map[string]string)
protoToPackage := make(map[string]string)
for _, i := range protoImports {
if strings.HasPrefix(i, "temporal/api/") {
goImport := filepath.Dir(strings.Replace(i, "temporal/api/", "go.temporal.io/api/", 1))
importName := getImportName(goImport)
goImportsMap[goImport] = importName
protoToPackage[i] = importName
} else if strings.HasPrefix(i, "google/") {
base := strings.TrimSuffix(filepath.Base(i), ".proto") + "pb"
base = strings.ReplaceAll(base, "field_mask", "fieldmask")
var goImport string
if base == "descriptorpb" {
goImport = "google.golang.org/protobuf/types/descriptorpb"
} else {
goImport = "google.golang.org/protobuf/types/known/" + base
}
goImportsMap[goImport] = base
protoToPackage[i] = base
} else if strings.HasPrefix(i, "nexusannotations/") {
goImport := filepath.Dir(strings.Replace(i, "nexusannotations/", "github.com/nexus-rpc/nexus-proto-annotations/go/nexusannotations/", 1))
importName := "nexusannotations"
goImportsMap[goImport] = importName
protoToPackage[i] = importName
}
}
goImports := expmaps.Keys(goImportsMap)
sort.Strings(goImports)
out, err := os.Create("cmd/tools/getproto/files.go")
fatalIfErr(err)
defer out.Close()
fmt.Fprintf(out, `
// Code generated by getproto. DO NOT EDIT.
// If you get build errors in this file, just delete it. It will be regenerated.
package main
import (
"google.golang.org/protobuf/reflect/protoreflect"
`)
for _, i := range goImports {
fmt.Fprintf(out, "\t%s %q\n", goImportsMap[i], i)
}
fmt.Fprintf(out, `)
func init() {
importMap = make(map[string]protoreflect.FileDescriptor)
`)
for _, i := range protoImports {
fmt.Fprintf(out, "\timportMap[%q] = %s.%s\n", i, protoToPackage[i], mangle(i))
}
out.WriteString("}\n")
}
func addImports(missing []string) {
newImportMap := make(map[string]struct{})
for i, _ := range importMap {
newImportMap[i] = struct{}{}
}
for _, i := range missing {
newImportMap[i] = struct{}{}
}
genFileList(expmaps.Keys(newImportMap))
fmt.Println("<rerun>")
os.Exit(0)
}
func initSeeds() {
genFileList(findProtoImports())
fmt.Println("<rerun>")
os.Exit(0)
}
func checkImports(files map[string]protoreflect.FileDescriptor) {
missing := make(map[string]struct{})
for _, fd := range files {
imports := fd.Imports()
num := imports.Len()
for i := range num {
imp := imports.Get(i).Path()
if strings.HasPrefix(imp, "temporal/api/") || strings.HasPrefix(imp, "google/") || strings.HasPrefix(imp, "nexus/") {
if _, ok := files[imp]; !ok {
missing[imp] = struct{}{}
}
}
}
}
if len(missing) > 0 {
addImports(expmaps.Keys(missing)) // doesn't return
}
}
func main() {
out := flag.String("out", "", "where to put the serialized FileDescriptorSet")
flag.Parse()
if *out == "" {
flag.Usage()
os.Exit(1)
}
if len(importMap) == 0 {
initSeeds() // doesn't return
}
checkImports(importMap) // doesn't return if any errors
set := &descriptorpb.FileDescriptorSet{}
for _, fd := range importMap {
set.File = append(set.File, protodesc.ToFileDescriptorProto(fd))
}
b, err := proto.Marshal(set)
fatalIfErr(err)
fatalIfErr(os.WriteFile(*out, b, 0644))
}