Files
tasks/common/persistence/visibility/visiblity_manager_metrics.go
zeekay 40351cce6f rip: delete temporal fork — native ZAP-only tasksd
Goes from 135 MB binary with 1153 files importing go.temporal.io and 224
importing google.golang.org/grpc to a 10 MB native binary with ZERO of
either.

Deleted:
- tasks/, tasktests/, service/, chasm/, client/, api/, proto/, tools/
- cmd/tools/, components/, docker/
- schema/{cassandra,elasticsearch,mysql,postgresql,sqlite}/
- 40 tainted common/ subdirs + 7 top-level common files
- tests/testutils (no longer referenced after surviving deps drop common)

New cmd/tasksd (~100 lines) boots tasks.Embed (zap.Node) + http.Server.
New pkg/tasks/embed.go registers ZAP handlers for the SDK opcode surface
(0x0060-0x00A5). Workflow handlers return a 501 "not yet implemented"
envelope; native engine lands behind this contract.

Build:  go build ./cmd/tasksd → 10 MB
Vet:    go vet ./... → clean
Boot:   tasksd --zap-port 9999 --http :7243
Probes: /healthz, /v1/tasks/health → 200
UI:     /_/tasks/, / → 200 (embedded Vite bundle)
ZAP:    _tasks._tcp on :9999 (mDNS disabled; direct connect)

go.mod: tidy. No go.temporal.io. No google.golang.org/grpc.
2026-04-26 14:06:21 -07:00

238 lines
9.2 KiB
Go

package visibility
import (
"context"
"time"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/api/visibilityservice/v1"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility/manager"
)
var _ manager.VisibilityManager = (*visibilityManagerMetrics)(nil)
type visibilityManagerMetrics struct {
metricHandler metrics.Handler
logger log.Logger
delegate manager.VisibilityManager
slowQueryThreshold dynamicconfig.DurationPropertyFn
visibilityPluginNameMetricsTag metrics.Tag
visibilityIndexNameMetricsTag metrics.Tag
}
func NewVisibilityManagerMetrics(
delegate manager.VisibilityManager,
metricHandler metrics.Handler,
logger log.Logger,
slowQueryThreshold dynamicconfig.DurationPropertyFn,
visibilityPluginNameMetricsTag metrics.Tag,
visibilityIndexNameMetricsTag metrics.Tag,
) *visibilityManagerMetrics {
return &visibilityManagerMetrics{
metricHandler: metricHandler,
logger: logger,
delegate: delegate,
slowQueryThreshold: slowQueryThreshold,
visibilityPluginNameMetricsTag: visibilityPluginNameMetricsTag,
visibilityIndexNameMetricsTag: visibilityIndexNameMetricsTag,
}
}
func (m *visibilityManagerMetrics) Close() {
m.delegate.Close()
}
func (m *visibilityManagerMetrics) GetReadStoreName(nsName namespace.Name) string {
return m.delegate.GetReadStoreName(nsName)
}
func (m *visibilityManagerMetrics) GetStoreNames() []string {
return m.delegate.GetStoreNames()
}
func (m *visibilityManagerMetrics) HasStoreName(stName string) bool {
return m.delegate.HasStoreName(stName)
}
func (m *visibilityManagerMetrics) GetIndexName() string {
return m.delegate.GetIndexName()
}
func (m *visibilityManagerMetrics) ValidateCustomSearchAttributes(
searchAttributes map[string]any,
) (map[string]any, error) {
return m.delegate.ValidateCustomSearchAttributes(searchAttributes)
}
func (m *visibilityManagerMetrics) RecordWorkflowExecutionStarted(
ctx context.Context,
request *manager.RecordWorkflowExecutionStartedRequest,
) error {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceRecordWorkflowExecutionStartedScope)
err := m.delegate.RecordWorkflowExecutionStarted(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) RecordWorkflowExecutionClosed(
ctx context.Context,
request *manager.RecordWorkflowExecutionClosedRequest,
) error {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceRecordWorkflowExecutionClosedScope)
err := m.delegate.RecordWorkflowExecutionClosed(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) UpsertWorkflowExecution(
ctx context.Context,
request *manager.UpsertWorkflowExecutionRequest,
) error {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceUpsertWorkflowExecutionScope)
err := m.delegate.UpsertWorkflowExecution(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) DeleteWorkflowExecution(
ctx context.Context,
request *manager.VisibilityDeleteWorkflowExecutionRequest,
) error {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceDeleteWorkflowExecutionScope)
err := m.delegate.DeleteWorkflowExecution(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) ListWorkflowExecutions(
ctx context.Context,
request *manager.ListWorkflowExecutionsRequestV2,
) (*manager.ListWorkflowExecutionsResponse, error) {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceListWorkflowExecutionsScope)
response, err := m.delegate.ListWorkflowExecutions(ctx, request)
elapsed := time.Since(startTime)
if elapsed > m.slowQueryThreshold() {
m.logger.Warn("List query exceeded threshold",
tag.Duration("duration", elapsed),
tag.String("visibility-query", request.Query),
tag.Stringer("namespace", request.Namespace),
)
}
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return response, m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) ListChasmExecutions(
ctx context.Context,
request *visibilityservice.ListChasmExecutionsRequest,
) (*visibilityservice.ListChasmExecutionsResponse, error) {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceListChasmExecutionsScope)
response, err := m.delegate.ListChasmExecutions(ctx, request)
elapsed := time.Since(startTime)
if elapsed > m.slowQueryThreshold() {
m.logger.Warn("List query exceeded threshold",
tag.Duration("duration", elapsed),
tag.String("visibility-query", request.Query),
tag.String("namespace", request.Namespace),
)
}
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return response, m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) CountWorkflowExecutions(
ctx context.Context,
request *manager.CountWorkflowExecutionsRequest,
) (*manager.CountWorkflowExecutionsResponse, error) {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceCountWorkflowExecutionsScope)
response, err := m.delegate.CountWorkflowExecutions(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return response, m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) CountChasmExecutions(
ctx context.Context,
request *visibilityservice.CountChasmExecutionsRequest,
) (*visibilityservice.CountChasmExecutionsResponse, error) {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceCountChasmExecutionsScope)
response, err := m.delegate.CountChasmExecutions(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return response, m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) GetWorkflowExecution(
ctx context.Context,
request *manager.GetWorkflowExecutionRequest,
) (*manager.GetWorkflowExecutionResponse, error) {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceGetWorkflowExecutionScope)
response, err := m.delegate.GetWorkflowExecution(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return response, m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) AddSearchAttributes(
ctx context.Context,
request *manager.AddSearchAttributesRequest,
) error {
handler, startTime := m.tagScope(metrics.VisibilityPersistenceAddSearchAttributesScope)
err := m.delegate.AddSearchAttributes(ctx, request)
elapsed := time.Since(startTime)
metrics.VisibilityPersistenceLatency.With(handler).Record(elapsed)
metrics.ContextCounterAdd(ctx, metrics.TaskPersistenceLatency.Name(), elapsed.Nanoseconds())
return m.updateErrorMetric(handler, err)
}
func (m *visibilityManagerMetrics) tagScope(operation string) (metrics.Handler, time.Time) {
taggedHandler := m.metricHandler.WithTags(metrics.OperationTag(operation), m.visibilityPluginNameMetricsTag, m.visibilityIndexNameMetricsTag)
metrics.VisibilityPersistenceRequests.With(taggedHandler).Record(1)
return taggedHandler, time.Now().UTC()
}
func (m *visibilityManagerMetrics) updateErrorMetric(handler metrics.Handler, err error) error {
if err == nil {
return nil
}
metrics.VisibilityPersistenceErrorWithType.With(handler).Record(1, metrics.ServiceErrorTypeTag(err))
switch err := err.(type) {
case *serviceerror.InvalidArgument,
*persistence.TimeoutError,
*persistence.ConditionFailedError,
*serviceerror.NotFound:
// no-op
case *serviceerror.ResourceExhausted:
metrics.VisibilityPersistenceResourceExhausted.With(handler).Record(
1, metrics.ResourceExhaustedCauseTag(err.Cause), metrics.ResourceExhaustedScopeTag(err.Scope))
default:
m.logger.Error("Operation failed with an error.", tag.Error(err))
metrics.VisibilityPersistenceFailures.With(handler).Record(1)
}
return err
}