mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
stuart-wellsandGitHub
28fb98c825
## What changed? Adds JWT to server-to-server connections. Frontend already had support for reading auth so this focuses on getting a token and injecting it. ## Why? s2s is currently a gap in the auth abilities. This provides more flexibility for users based on their auth requirements. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) ## Potential risks Need to get auth right. Main risk is a user believing they are secure when they are not.
126 lines
3.5 KiB
Go
126 lines
3.5 KiB
Go
package rpc
|
|
|
|
import (
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strconv"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.temporal.io/server/common/membership"
|
|
"go.temporal.io/server/common/primitives"
|
|
"go.temporal.io/server/common/rpc"
|
|
"go.uber.org/mock/gomock"
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
func TestCreateLocalFrontendHTTPClient_UsingMembership(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
monitor := membership.NewMockMonitor(ctrl)
|
|
resolver := membership.NewMockServiceResolver(ctrl)
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Write([]byte("ok"))
|
|
}))
|
|
defer srv.Close()
|
|
addr := srv.Listener.Addr()
|
|
_, portStr, err := net.SplitHostPort(addr.String())
|
|
require.NoError(t, err)
|
|
port, err := strconv.ParseInt(portStr, 10, 64)
|
|
require.NoError(t, err)
|
|
monitor.EXPECT().GetResolver(primitives.FrontendService).Return(resolver, nil)
|
|
resolver.EXPECT().AvailableMembers().Return([]membership.HostInfo{membership.NewHostInfoFromAddress(addr.String())})
|
|
|
|
fact := rpc.NewFactory(
|
|
nil,
|
|
primitives.HistoryService,
|
|
nil, // No logger
|
|
nil, // No metrics handler
|
|
nil,
|
|
membership.GRPCResolverURLForTesting(monitor, primitives.FrontendService),
|
|
membership.GRPCResolverURLForTesting(monitor, primitives.FrontendService),
|
|
int(port),
|
|
nil, // No TLS
|
|
nil,
|
|
map[primitives.ServiceName][]grpc.DialOption{},
|
|
monitor,
|
|
nil,
|
|
)
|
|
|
|
client, err := fact.CreateLocalFrontendHTTPClient()
|
|
require.NoError(t, err)
|
|
require.Equal(t, "internal", client.Address)
|
|
require.Equal(t, "http", client.Scheme)
|
|
res, err := client.Get(srv.URL)
|
|
require.NoError(t, err)
|
|
defer res.Body.Close()
|
|
require.Equal(t, http.StatusOK, res.StatusCode)
|
|
}
|
|
|
|
func TestCreateLocalFrontendHTTPClient_UsingFixedHostPort(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Write([]byte("ok"))
|
|
}))
|
|
defer srv.Close()
|
|
addr := srv.Listener.Addr()
|
|
|
|
fact := rpc.NewFactory(
|
|
nil, // unused
|
|
primitives.HistoryService,
|
|
nil, // No logger
|
|
nil, // No metrics handler
|
|
nil,
|
|
membership.GRPCResolverURLForTesting(nil, primitives.FrontendService),
|
|
addr.String(),
|
|
0, // Port is unused
|
|
nil, // No TLS
|
|
nil,
|
|
map[primitives.ServiceName][]grpc.DialOption{},
|
|
nil, // monitor should not be used
|
|
nil,
|
|
)
|
|
|
|
client, err := fact.CreateLocalFrontendHTTPClient()
|
|
require.NoError(t, err)
|
|
require.Equal(t, addr.String(), client.Address)
|
|
require.Equal(t, "http", client.Scheme)
|
|
res, err := client.Get(srv.URL)
|
|
require.NoError(t, err)
|
|
defer res.Body.Close()
|
|
require.Equal(t, http.StatusOK, res.StatusCode)
|
|
}
|
|
|
|
func TestCreateLocalFrontendHTTPClient_UsingFixedHostPort_AndTLS(t *testing.T) {
|
|
srv := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Write([]byte("ok"))
|
|
}))
|
|
defer srv.Close()
|
|
addr := srv.Listener.Addr()
|
|
tlsConfig := srv.Client().Transport.(*http.Transport).TLSClientConfig
|
|
|
|
fact := rpc.NewFactory(
|
|
nil, // unused
|
|
primitives.HistoryService,
|
|
nil, // No logger
|
|
nil, // No metrics handler
|
|
nil,
|
|
membership.GRPCResolverURLForTesting(nil, primitives.FrontendService),
|
|
addr.String(),
|
|
0, // Port is unused
|
|
tlsConfig,
|
|
nil,
|
|
map[primitives.ServiceName][]grpc.DialOption{},
|
|
nil, // monitor should not be used
|
|
nil,
|
|
)
|
|
|
|
client, err := fact.CreateLocalFrontendHTTPClient()
|
|
require.NoError(t, err)
|
|
require.Equal(t, addr.String(), client.Address)
|
|
require.Equal(t, "https", client.Scheme)
|
|
res, err := client.Get(srv.URL)
|
|
require.NoError(t, err)
|
|
defer res.Body.Close()
|
|
require.Equal(t, http.StatusOK, res.StatusCode)
|
|
}
|