Files
Alan WuandGitHub 3589b4e1e3 Fix activity start-to-close metric timestamps (#9586)
## What changed?
wrap timestamp calls with `timestamp.TimeValue` to avoid incorrectly set
Epoch Timestamps.

## Why?
AsTime() converts timestamp to Unix time, and if that value is nil, that
defaults to the Epoch timestamp. If the Epoch Timestamp is used, (non
Zero value), [metrics are
recorded](https://github.com/temporalio/temporal/blob/activity-start-to-close-fix/service/history/workflow/metrics.go#L161).


https://github.com/temporalio/temporal/blob/activity-start-to-close-fix/common/primitives/timestamp/time.go#L13
provides helper functions to correctly format nil Time values,
converting to a 0 value correctly.

## How did you test it?
- [X] built
- [X] run locally and tested manually
- [X] covered by existing tests
- [X] added new unit test(s)
- [ ] added new functional test(s)
2026-03-20 13:05:14 -04:00

149 lines
5.3 KiB
Go

package respondactivitytaskfailed
import (
"context"
"time"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/primitives/timestamp"
"go.temporal.io/server/common/tasktoken"
"go.temporal.io/server/service/history/api"
"go.temporal.io/server/service/history/consts"
historyi "go.temporal.io/server/service/history/interfaces"
"go.temporal.io/server/service/history/workflow"
)
func Invoke(
ctx context.Context,
req *historyservice.RespondActivityTaskFailedRequest,
shard historyi.ShardContext,
workflowConsistencyChecker api.WorkflowConsistencyChecker,
) (resp *historyservice.RespondActivityTaskFailedResponse, retError error) {
request := req.FailedRequest
tokenSerializer := tasktoken.NewSerializer()
token, err0 := tokenSerializer.Deserialize(request.TaskToken)
if err0 != nil {
return nil, consts.ErrDeserializingToken
}
namespaceEntry, err := api.GetActiveNamespace(shard, namespace.ID(req.GetNamespaceId()), token.WorkflowId)
if err != nil {
return nil, err
}
namespaceName := namespaceEntry.Name()
if err := api.SetActivityTaskRunID(ctx, token, workflowConsistencyChecker); err != nil {
return nil, err
}
var attemptStartedTime time.Time
var firstScheduledTime time.Time
var taskQueue string
var workflowTypeName string
var closed bool
var versioningBehavior enumspb.VersioningBehavior
err = api.GetAndUpdateWorkflowWithNew(
ctx,
token.Clock,
definition.NewWorkflowKey(
token.NamespaceId,
token.WorkflowId,
token.RunId,
),
func(workflowLease api.WorkflowLease) (*api.UpdateWorkflowAction, error) {
mutableState := workflowLease.GetMutableState()
workflowTypeName = mutableState.GetWorkflowType().GetName()
if !mutableState.IsWorkflowExecutionRunning() {
return nil, consts.ErrWorkflowCompleted
}
scheduledEventID := token.GetScheduledEventId()
if scheduledEventID == common.EmptyEventID { // client call CompleteActivityById, so get scheduledEventID by activityID
scheduledEventID, err0 = api.GetActivityScheduledEventID(token.GetActivityId(), mutableState)
if err0 != nil {
return nil, err0
}
}
ai, activityRunning := mutableState.GetActivityInfo(scheduledEventID)
// First check to see if cache needs to be refreshed as we could potentially have stale workflow execution in
// some extreme cassandra failure cases.
if !activityRunning && scheduledEventID >= mutableState.GetNextEventID() {
metrics.StaleMutableStateCounter.With(shard.GetMetricsHandler()).Record(
1,
metrics.OperationTag(metrics.HistoryRespondActivityTaskFailedScope))
return nil, consts.ErrStaleState
}
if !activityRunning || api.IsActivityTaskNotFoundForToken(token, ai, nil) {
return nil, consts.ErrActivityTaskNotFound
}
if request.GetLastHeartbeatDetails() != nil {
// Save heartbeat details as progress
mutableState.UpdateActivityProgress(ai, &workflowservice.RecordActivityTaskHeartbeatRequest{
TaskToken: request.GetTaskToken(),
Details: request.GetLastHeartbeatDetails(),
Identity: request.GetIdentity(),
Namespace: request.GetNamespace(),
})
}
postActions := &api.UpdateWorkflowAction{}
failure := request.GetFailure()
// RetryActivity mutates ai in place and clears per-attempt timing fields when it resets the activity for retry.
// Capture the metric inputs before that mutation so we record the attempt that just finished.
attemptStartedTime = timestamp.TimeValue(ai.GetStartedTime())
firstScheduledTime = timestamp.TimeValue(ai.FirstScheduledTime)
taskQueue = ai.TaskQueue
mutableState.RecordLastActivityCompleteTime(ai)
retryState, err := mutableState.RetryActivity(ai, failure)
if err != nil {
return nil, err
}
// TODO uncomment once RETRY_STATE_PAUSED is supported
// if retryState != enumspb.RETRY_STATE_IN_PROGRESS && retryState != enumspb.RETRY_STATE_PAUSED {
if retryState != enumspb.RETRY_STATE_IN_PROGRESS {
// no more retry, and we want to record the failure event
if _, err := mutableState.AddActivityTaskFailedEvent(scheduledEventID, ai.StartedEventId, failure, retryState, request.GetIdentity(), request.GetWorkerVersion()); err != nil {
// Unable to add ActivityTaskFailed event to history
return nil, err
}
postActions.CreateWorkflowTask = true
closed = true
} else {
closed = false
}
versioningBehavior = mutableState.GetEffectiveVersioningBehavior()
return postActions, nil
},
nil,
shard,
workflowConsistencyChecker,
)
if err == nil {
completionMetrics := workflow.ActivityCompletionMetrics{
AttemptStartedTime: attemptStartedTime,
FirstScheduledTime: firstScheduledTime,
Status: workflow.ActivityStatusFailed,
Closed: closed,
}
workflow.RecordActivityCompletionMetrics(shard,
namespaceName,
taskQueue,
completionMetrics,
metrics.OperationTag(metrics.HistoryRespondActivityTaskFailedScope),
metrics.WorkflowTypeTag(workflowTypeName),
metrics.ActivityTypeTag(token.ActivityType),
metrics.VersioningBehaviorTag(versioningBehavior))
}
return &historyservice.RespondActivityTaskFailedResponse{}, err
}