Files
Stephan BehnkeandGitHub c4b9e0ae33 Remove WithFxOptionsForService from xdc/history_replication_signals_and_updates_test.go (#10322)
## What changed

Migrated `tests/xdc/history_replication_signals_and_updates_test.go` to
stop relying on `WithFxOptionsForService` to replace fx modules and
instead use test hooks.

## Why

We want to eliminate `WithFxOptionsForService` as it is blocking us from
migrating away from the `onebox.go` approach (which duplicates the fx
setup) since we don't want to expose an equivalent method in
`temporal/fx.go`.
2026-05-26 09:17:27 -07:00

426 lines
13 KiB
Go

package replication
import (
"context"
"strconv"
"github.com/dgryski/go-farm"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/client"
"go.temporal.io/server/common/clock"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/namespace/nsreplication"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/serialization"
"go.temporal.io/server/common/quotas"
ctasks "go.temporal.io/server/common/tasks"
"go.temporal.io/server/common/testing/testhooks"
"go.temporal.io/server/service/history/configs"
historyi "go.temporal.io/server/service/history/interfaces"
"go.temporal.io/server/service/history/queues"
"go.temporal.io/server/service/history/replication/eventhandler"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/tasks"
"go.uber.org/fx"
)
type (
ClusterChannelKey struct {
ClusterName string
}
TaskSerializer interface {
SerializeReplicationTask(task tasks.Task) (*persistencespb.ReplicationTaskInfo, error)
DeserializeReplicationTask(replicationTask *persistencespb.ReplicationTaskInfo) (tasks.Task, error)
}
)
var Module = fx.Provide(
NewTaskFetcherFactory,
func(m persistence.ExecutionManager) ExecutionManager {
return m
},
nsreplication.NewNoopDataMerger,
nsreplication.NewDefaultAdmitter,
NewExecutionManagerDLQWriter,
ClientSchedulerRateLimiterProvider,
ServerSchedulerRateLimiterProvider,
PersistenceRateLimiterProvider,
func(serializer serialization.Serializer) TaskSerializer {
return serializer
},
replicationTaskConverterFactoryProvider,
replicationTaskExecutorProvider,
fx.Annotated{
Name: "HighPriorityTaskScheduler",
Target: replicationStreamHighPrioritySchedulerProvider,
},
fx.Annotated{
Name: "LowPriorityTaskScheduler",
Target: replicationStreamLowPrioritySchedulerProvider,
},
executableTaskConverterProvider,
streamReceiverMonitorProvider,
eagerNamespaceRefresherProvider,
sequentialTaskQueueFactoryProvider,
dlqWriterAdapterProvider,
newDLQWriterToggle,
historyPaginatedFetcherProvider,
resendHandlerProvider,
eventImporterProvider,
historyEventsHandlerProvider,
)
func eagerNamespaceRefresherProvider(
metadataManager persistence.MetadataManager,
namespaceRegistry namespace.Registry,
logger log.Logger,
clientBean client.Bean,
clusterMetadata cluster.Metadata,
dataMerger nsreplication.NamespaceDataMerger,
admitter nsreplication.NamespaceReplicationAdmitter,
metricsHandler metrics.Handler,
testHooks testhooks.TestHooks,
) EagerNamespaceRefresher {
return NewEagerNamespaceRefresher(
metadataManager,
namespaceRegistry,
logger,
clientBean,
nsreplication.NewTaskExecutor(
clusterMetadata.GetCurrentClusterName(),
metadataManager,
dataMerger,
admitter,
logger,
testHooks,
),
clusterMetadata.GetCurrentClusterName(),
metricsHandler,
)
}
func replicationTaskConverterFactoryProvider(
config *configs.Config,
replicationTaskSerializer TaskSerializer,
) SourceTaskConverterProvider {
return func(
historyEngine historyi.Engine,
shardContext historyi.ShardContext,
clientClusterName string,
serializer serialization.Serializer,
) SourceTaskConverter {
return NewSourceTaskConverter(
historyEngine,
shardContext.GetNamespaceRegistry(),
serializer,
replicationTaskSerializer,
config)
}
}
func replicationTaskExecutorProvider() TaskExecutorProvider {
return func(params TaskExecutorParams) TaskExecutor {
return NewTaskExecutor(
params.RemoteCluster,
params.Shard,
params.RemoteHistoryFetcher,
params.DeleteManager,
params.WorkflowCache,
)
}
}
func replicationStreamHighPrioritySchedulerProvider(
config *configs.Config,
logger log.Logger,
queueFactory ctasks.SequentialTaskQueueFactory[TrackableExecutableTask],
lc fx.Lifecycle,
) ctasks.Scheduler[TrackableExecutableTask] {
// SequentialScheduler has panic wrapper when executing task,
// if changing the executor, please make sure other executor has panic wrapper
scheduler := ctasks.NewSequentialScheduler[TrackableExecutableTask](
&ctasks.SequentialSchedulerOptions{
QueueSize: config.ReplicationProcessorSchedulerQueueSize(),
WorkerCount: config.ReplicationProcessorSchedulerWorkerCount,
},
WorkflowKeyHashFn,
queueFactory,
logger,
)
taskChannelKeyFn := func(e TrackableExecutableTask) ClusterChannelKey {
return ClusterChannelKey{
ClusterName: e.SourceClusterName(),
}
}
channelWeightFn := func(key ClusterChannelKey) int {
return 1
}
// This creates a per cluster channel.
// They share the same weight so it just does a round-robin on all clusters' tasks.
rrScheduler := ctasks.NewInterleavedWeightedRoundRobinScheduler(
ctasks.InterleavedWeightedRoundRobinSchedulerOptions[TrackableExecutableTask, ClusterChannelKey]{
TaskChannelKeyFn: taskChannelKeyFn,
ChannelWeightFn: channelWeightFn,
},
scheduler,
logger,
)
lc.Append(fx.StartStopHook(rrScheduler.Start, rrScheduler.Stop))
return rrScheduler
}
func replicationStreamLowPrioritySchedulerProvider(
rateLimiter ClientSchedulerRateLimiter,
timeSource clock.TimeSource,
config *configs.Config,
nsRegistry namespace.Registry,
logger log.Logger,
metricsHandler metrics.Handler,
lc fx.Lifecycle,
) ctasks.Scheduler[TrackableExecutableTask] {
// P-way parallelism for executions of the same workflow (per ReplicationLowPriorityTaskParallelism)
// is modeled as P distinct per-namespace-workflow queue IDs. We bucket by execution (RunID) so all
// low-priority tasks for one execution share a queue; the third field stores the slot index, not
// the run UUID.
queueFactory := func(task TrackableExecutableTask) ctasks.SequentialTaskQueue[TrackableExecutableTask] {
item := task.QueueID()
workflowKey, ok := item.(definition.WorkflowKey)
if !ok {
return NewSequentialTaskQueueWithID(item)
}
parallelism := config.ReplicationLowPriorityTaskParallelism()
if parallelism < 1 {
parallelism = 1
}
// 0..parallelism-1, stable for a given RunID. Different runs of the same workflow can share
// a slot, so up to P sequential queues (and workers) can progress them concurrently.
slot := int(farm.Fingerprint32([]byte(workflowKey.RunID)) % uint32(parallelism))
return NewSequentialTaskQueueWithID(
definition.NewWorkflowKey(workflowKey.NamespaceID, workflowKey.WorkflowID, strconv.Itoa(slot)),
)
}
// SequentialScheduler has panic wrapper when executing task,
// if changing the executor, please make sure other executor has panic wrapper
scheduler := ctasks.NewSequentialScheduler[TrackableExecutableTask](
&ctasks.SequentialSchedulerOptions{
QueueSize: config.ReplicationProcessorSchedulerQueueSize(),
WorkerCount: config.ReplicationLowPriorityProcessorSchedulerWorkerCount,
},
WorkflowKeyHashFn,
queueFactory,
logger,
)
taskChannelKeyFn := func(e TrackableExecutableTask) ClusterChannelKey {
return ClusterChannelKey{
ClusterName: e.SourceClusterName(),
}
}
channelWeightFn := func(key ClusterChannelKey) int {
return 1
}
taskQuotaRequestFn := func(t TrackableExecutableTask) quotas.Request {
var taskType string
var nsName namespace.Name
replicationTask := t.ReplicationTask()
if replicationTask != nil {
taskType = replicationTask.TaskType.String()
rawTaskInfo := replicationTask.GetRawTaskInfo()
if rawTaskInfo != nil {
var err error
nsName, err = nsRegistry.GetNamespaceName(namespace.ID(replicationTask.GetRawTaskInfo().NamespaceId))
if err != nil {
nsName = namespace.EmptyName
}
}
}
return quotas.NewRequest(
taskType,
taskSchedulerToken,
nsName.String(),
headers.CallerTypePreemptable,
0,
"")
}
taskMetricsTagsFn := func(t TrackableExecutableTask) []metrics.Tag {
replicationTask := t.ReplicationTask()
var taskType string
namespaceTag := metrics.NamespaceUnknownTag()
if replicationTask != nil {
taskType = replicationTask.TaskType.String()
rawTaskInfo := replicationTask.GetRawTaskInfo()
if rawTaskInfo != nil {
nsName, err := nsRegistry.GetNamespaceName(namespace.ID(replicationTask.GetRawTaskInfo().NamespaceId))
if err != nil {
namespaceTag = metrics.NamespaceTag(nsName.String())
}
}
}
return []metrics.Tag{
namespaceTag,
metrics.TaskTypeTag(taskType),
metrics.OperationTag(taskType), // for backward compatibility
metrics.TaskPriorityTag(ctasks.PriorityPreemptable.String()),
}
}
// This creates a per cluster channel.
// They share the same weight so it just does a round-robin on all clusters' tasks.
rrScheduler := ctasks.NewInterleavedWeightedRoundRobinScheduler(
ctasks.InterleavedWeightedRoundRobinSchedulerOptions[TrackableExecutableTask, ClusterChannelKey]{
TaskChannelKeyFn: taskChannelKeyFn,
ChannelWeightFn: channelWeightFn,
},
scheduler,
logger,
)
ts := ctasks.NewRateLimitedScheduler[TrackableExecutableTask](
rrScheduler,
rateLimiter,
timeSource,
taskQuotaRequestFn,
taskMetricsTagsFn,
ctasks.RateLimitedSchedulerOptions{
Enabled: config.ReplicationEnableRateLimit,
EnableShadowMode: config.ReplicationEnableRateLimitShadowMode,
},
logger,
metricsHandler,
)
lc.Append(fx.StartStopHook(ts.Start, ts.Stop))
return ts
}
func sequentialTaskQueueFactoryProvider(
logger log.Logger,
metricsHandler metrics.Handler,
config *configs.Config,
) ctasks.SequentialTaskQueueFactory[TrackableExecutableTask] {
return func(task TrackableExecutableTask) ctasks.SequentialTaskQueue[TrackableExecutableTask] {
if config.EnableReplicationTaskBatching() {
return NewSequentialBatchableTaskQueue(task, nil, logger, metricsHandler)
}
item := task.QueueID()
workflowKey, ok := item.(definition.WorkflowKey)
if !ok {
return NewSequentialTaskQueueWithID(item)
}
return NewSequentialTaskQueueWithID(
definition.NewWorkflowKey(workflowKey.NamespaceID, workflowKey.WorkflowID, ""),
)
}
}
func executableTaskConverterProvider(
processToolBox ProcessToolBox,
) ExecutableTaskConverter {
return NewExecutableTaskConverter(processToolBox)
}
func streamReceiverMonitorProvider(
processToolBox ProcessToolBox,
taskConverter ExecutableTaskConverter,
) StreamReceiverMonitor {
return NewStreamReceiverMonitor(
processToolBox,
taskConverter,
processToolBox.Config.EnableReplicationStream(),
)
}
func resendHandlerProvider(
namespaceRegistry namespace.Registry,
clientBean client.Bean,
serializer serialization.Serializer,
clusterMetadata cluster.Metadata,
shardController shard.Controller,
config *configs.Config,
remoteHistoryFetcher eventhandler.HistoryPaginatedFetcher,
logger log.Logger,
importer eventhandler.EventImporter,
) eventhandler.ResendHandler {
return eventhandler.NewResendHandler(
namespaceRegistry,
clientBean,
serializer,
clusterMetadata,
func(ctx context.Context, namespaceId namespace.ID, workflowId string) (historyi.Engine, error) {
shardContext, err := shardController.GetShardByNamespaceWorkflow(
namespaceId,
workflowId,
)
if err != nil {
return nil, err
}
return shardContext.GetEngine(ctx)
},
remoteHistoryFetcher,
importer,
logger,
config,
)
}
func eventImporterProvider(
historyFetcher eventhandler.HistoryPaginatedFetcher,
shardController shard.Controller,
serializer serialization.Serializer,
logger log.Logger,
) eventhandler.EventImporter {
return eventhandler.NewEventImporter(
historyFetcher,
func(ctx context.Context, namespaceId namespace.ID, workflowId string) (historyi.Engine, error) {
shardContext, err := shardController.GetShardByNamespaceWorkflow(
namespaceId,
workflowId,
)
if err != nil {
return nil, err
}
return shardContext.GetEngine(ctx)
},
serializer,
logger,
)
}
func dlqWriterAdapterProvider(
dlqWriter *queues.DLQWriter,
replicationTaskSerializer TaskSerializer,
clusterMetadata cluster.Metadata,
) *DLQWriterAdapter {
return NewDLQWriterAdapter(dlqWriter, replicationTaskSerializer, clusterMetadata.GetCurrentClusterName())
}
func historyEventsHandlerProvider(
clusterMetadata cluster.Metadata,
importer eventhandler.EventImporter,
shardController shard.Controller,
logger log.Logger,
) eventhandler.HistoryEventsHandler {
return eventhandler.NewHistoryEventsHandler(
clusterMetadata,
importer,
shardController,
logger,
)
}
func historyPaginatedFetcherProvider(
namespaceRegistry namespace.Registry,
clientBean client.Bean,
serializer serialization.Serializer,
logger log.Logger,
) eventhandler.HistoryPaginatedFetcher {
return eventhandler.NewHistoryPaginatedFetcher(
namespaceRegistry,
clientBean,
serializer,
logger,
)
}