mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Goes from 135 MB binary with 1153 files importing go.temporal.io and 224
importing google.golang.org/grpc to a 10 MB native binary with ZERO of
either.
Deleted:
- tasks/, tasktests/, service/, chasm/, client/, api/, proto/, tools/
- cmd/tools/, components/, docker/
- schema/{cassandra,elasticsearch,mysql,postgresql,sqlite}/
- 40 tainted common/ subdirs + 7 top-level common files
- tests/testutils (no longer referenced after surviving deps drop common)
New cmd/tasksd (~100 lines) boots tasks.Embed (zap.Node) + http.Server.
New pkg/tasks/embed.go registers ZAP handlers for the SDK opcode surface
(0x0060-0x00A5). Workflow handlers return a 501 "not yet implemented"
envelope; native engine lands behind this contract.
Build: go build ./cmd/tasksd → 10 MB
Vet: go vet ./... → clean
Boot: tasksd --zap-port 9999 --http :7243
Probes: /healthz, /v1/tasks/health → 200
UI: /_/tasks/, / → 200 (embedded Vite bundle)
ZAP: _tasks._tcp on :9999 (mDNS disabled; direct connect)
go.mod: tidy. No go.temporal.io. No google.golang.org/grpc.
666 lines
22 KiB
Go
666 lines
22 KiB
Go
package batcher
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"slices"
|
|
"testing"
|
|
"time"
|
|
"unicode"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
batchpb "go.temporal.io/api/batch/v1"
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
historypb "go.temporal.io/api/history/v1"
|
|
workflowpb "go.temporal.io/api/workflow/v1"
|
|
"go.temporal.io/api/workflowservice/v1"
|
|
"go.temporal.io/sdk/temporal"
|
|
"go.temporal.io/sdk/testsuite"
|
|
"go.temporal.io/server/api/adminservice/v1"
|
|
batchspb "go.temporal.io/server/api/batch/v1"
|
|
"go.temporal.io/server/api/historyservice/v1"
|
|
"go.temporal.io/server/api/historyservicemock/v1"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/primitives/timestamp"
|
|
"go.temporal.io/server/common/testing/mockapi/workflowservicemock/v1"
|
|
"go.uber.org/mock/gomock"
|
|
"golang.org/x/time/rate"
|
|
)
|
|
|
|
type activitiesSuite struct {
|
|
suite.Suite
|
|
testsuite.WorkflowTestSuite
|
|
|
|
controller *gomock.Controller
|
|
|
|
mockFrontendClient *workflowservicemock.MockWorkflowServiceClient
|
|
}
|
|
|
|
func (s *activitiesSuite) SetupTest() {
|
|
s.controller = gomock.NewController(s.T())
|
|
|
|
s.mockFrontendClient = workflowservicemock.NewMockWorkflowServiceClient(s.controller)
|
|
}
|
|
|
|
func TestActivitiesSuite(t *testing.T) {
|
|
suite.Run(t, new(activitiesSuite))
|
|
}
|
|
|
|
const NumTotalEvents = 10
|
|
|
|
// Pattern contains either c or f representing completed or failed task.
|
|
// Schedule events for each task has id of NumTotalEvents*i + 1 where i is the index of the character
|
|
// EventId for each task has id of NumTotalEvents*i+NumTotalEvents where i is the index of the character
|
|
func generateEventHistory(pattern string) *historypb.History {
|
|
events := make([]*historypb.HistoryEvent, 0)
|
|
for i, char := range pattern {
|
|
// add a Schedule event independent of type of event
|
|
scheduledEventId := int64(NumTotalEvents*i + 1)
|
|
scheduledEvent := historypb.HistoryEvent{EventId: scheduledEventId, EventType: enumspb.EVENT_TYPE_WORKFLOW_TASK_SCHEDULED}
|
|
events = append(events, &scheduledEvent)
|
|
|
|
event := historypb.HistoryEvent{EventId: int64(NumTotalEvents*i + NumTotalEvents)}
|
|
switch unicode.ToLower(char) {
|
|
case 'c':
|
|
event.EventType = enumspb.EVENT_TYPE_WORKFLOW_TASK_COMPLETED
|
|
event.Attributes = &historypb.HistoryEvent_WorkflowTaskCompletedEventAttributes{
|
|
WorkflowTaskCompletedEventAttributes: &historypb.WorkflowTaskCompletedEventAttributes{ScheduledEventId: scheduledEventId},
|
|
}
|
|
case 'f':
|
|
event.EventType = enumspb.EVENT_TYPE_WORKFLOW_TASK_FAILED
|
|
}
|
|
events = append(events, &event)
|
|
}
|
|
|
|
return &historypb.History{Events: events}
|
|
}
|
|
|
|
func (s *activitiesSuite) TestGetLastWorkflowTaskEventID() {
|
|
namespaceStr := "test-namespace"
|
|
tests := []struct {
|
|
name string
|
|
history *historypb.History
|
|
wantWorkflowTaskEventID int64
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "Test history with all completed task event history",
|
|
history: generateEventHistory("ccccc"),
|
|
wantWorkflowTaskEventID: NumTotalEvents*4 + NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with last task failing",
|
|
history: generateEventHistory("ccccf"),
|
|
wantWorkflowTaskEventID: NumTotalEvents*3 + NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with all tasks failing",
|
|
history: generateEventHistory("fffff"),
|
|
wantWorkflowTaskEventID: 2,
|
|
},
|
|
{
|
|
name: "Test history with some tasks failing in the middle",
|
|
history: generateEventHistory("cfffc"),
|
|
wantWorkflowTaskEventID: NumTotalEvents*4 + NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with empty history should error",
|
|
history: generateEventHistory(""),
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
s.Run(tt.name, func() {
|
|
ctx := context.Background()
|
|
slices.Reverse(tt.history.Events)
|
|
workflowExecution := &commonpb.WorkflowExecution{}
|
|
s.mockFrontendClient.EXPECT().GetWorkflowExecutionHistoryReverse(ctx, gomock.Any()).Return(
|
|
&workflowservice.GetWorkflowExecutionHistoryReverseResponse{History: tt.history, NextPageToken: nil}, nil)
|
|
gotWorkflowTaskEventID, err := getLastWorkflowTaskEventID(ctx, namespaceStr, workflowExecution, s.mockFrontendClient, log.NewTestLogger())
|
|
s.Equal(tt.wantErr, err != nil)
|
|
s.Equal(tt.wantWorkflowTaskEventID, gotWorkflowTaskEventID)
|
|
if tt.wantErr {
|
|
var appErr *temporal.ApplicationError
|
|
s.Require().ErrorAs(err, &appErr, "error should be an ApplicationError")
|
|
s.True(appErr.NonRetryable(), "error should be non-retryable")
|
|
s.Equal("NoWorkflowTaskFound", appErr.Type(), "error type should be NoWorkflowTaskFound")
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *activitiesSuite) TestGetFirstWorkflowTaskEventID() {
|
|
namespaceStr := "test-namespace"
|
|
workflowExecution := commonpb.WorkflowExecution{}
|
|
tests := []struct {
|
|
name string
|
|
history *historypb.History
|
|
wantWorkflowTaskEventID int64
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "Test history with all completed task event history",
|
|
history: generateEventHistory("ccccc"),
|
|
wantWorkflowTaskEventID: NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with last task failing",
|
|
history: generateEventHistory("ccccf"),
|
|
wantWorkflowTaskEventID: NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with first task failing",
|
|
history: generateEventHistory("fcccc"),
|
|
wantWorkflowTaskEventID: NumTotalEvents*1 + NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with all tasks failing",
|
|
history: generateEventHistory("fffff"),
|
|
wantWorkflowTaskEventID: 2,
|
|
},
|
|
{
|
|
name: "Test history with some tasks failing in the middle",
|
|
history: generateEventHistory("cfffc"),
|
|
wantWorkflowTaskEventID: NumTotalEvents,
|
|
},
|
|
{
|
|
name: "Test history with empty history should error",
|
|
history: generateEventHistory(""),
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
s.Run(tt.name, func() {
|
|
ctx := context.Background()
|
|
s.mockFrontendClient.EXPECT().GetWorkflowExecutionHistory(ctx, gomock.Any()).Return(
|
|
&workflowservice.GetWorkflowExecutionHistoryResponse{History: tt.history, NextPageToken: nil}, nil)
|
|
gotWorkflowTaskEventID, err := getFirstWorkflowTaskEventID(ctx, namespaceStr, &workflowExecution, s.mockFrontendClient, log.NewTestLogger())
|
|
s.Equal(tt.wantErr, err != nil)
|
|
s.Equal(tt.wantWorkflowTaskEventID, gotWorkflowTaskEventID)
|
|
if tt.wantErr {
|
|
var appErr *temporal.ApplicationError
|
|
s.Require().ErrorAs(err, &appErr, "error should be an ApplicationError")
|
|
s.True(appErr.NonRetryable(), "error should be non-retryable")
|
|
s.Equal("NoWorkflowTaskFound", appErr.Type(), "error type should be NoWorkflowTaskFound")
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *activitiesSuite) TestGetResetPoint() {
|
|
ctx := context.Background()
|
|
ns := "namespacename"
|
|
tests := []struct {
|
|
name string
|
|
points []*workflowpb.ResetPointInfo
|
|
buildId string
|
|
currentRunOnly bool
|
|
wantWorkflowTaskEventID int64
|
|
wantErr bool
|
|
wantSetRunId string
|
|
}{
|
|
{
|
|
name: "not found",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run1",
|
|
FirstWorkflowTaskCompletedId: 123,
|
|
Resettable: true,
|
|
},
|
|
},
|
|
buildId: "otherbuild",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "found",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run1",
|
|
FirstWorkflowTaskCompletedId: 123,
|
|
Resettable: true,
|
|
},
|
|
},
|
|
buildId: "build1",
|
|
wantWorkflowTaskEventID: 123,
|
|
},
|
|
{
|
|
name: "not resettable",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run1",
|
|
FirstWorkflowTaskCompletedId: 123,
|
|
Resettable: false,
|
|
},
|
|
},
|
|
buildId: "build1",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "from another run",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run0",
|
|
FirstWorkflowTaskCompletedId: 34,
|
|
Resettable: true,
|
|
},
|
|
},
|
|
buildId: "build1",
|
|
wantWorkflowTaskEventID: 34,
|
|
wantSetRunId: "run0",
|
|
},
|
|
{
|
|
name: "from another run but not allowed",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run0",
|
|
FirstWorkflowTaskCompletedId: 34,
|
|
Resettable: true,
|
|
},
|
|
},
|
|
buildId: "build1",
|
|
currentRunOnly: true,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "expired",
|
|
points: []*workflowpb.ResetPointInfo{
|
|
{
|
|
BuildId: "build1",
|
|
RunId: "run1",
|
|
FirstWorkflowTaskCompletedId: 123,
|
|
Resettable: true,
|
|
ExpireTime: timestamp.TimePtr(time.Now().Add(-1 * time.Hour)),
|
|
},
|
|
},
|
|
buildId: "build1",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
s.Run(tt.name, func() {
|
|
s.mockFrontendClient.EXPECT().DescribeWorkflowExecution(gomock.Any(), gomock.Any()).Return(
|
|
&workflowservice.DescribeWorkflowExecutionResponse{
|
|
WorkflowExecutionInfo: &workflowpb.WorkflowExecutionInfo{
|
|
AutoResetPoints: &workflowpb.ResetPoints{
|
|
Points: tt.points,
|
|
},
|
|
},
|
|
},
|
|
nil,
|
|
)
|
|
execution := &commonpb.WorkflowExecution{
|
|
WorkflowId: "wfid",
|
|
RunId: "run1",
|
|
}
|
|
id, err := getResetPoint(ctx, ns, execution, s.mockFrontendClient, tt.buildId, tt.currentRunOnly)
|
|
s.Equal(tt.wantErr, err != nil)
|
|
s.Equal(tt.wantWorkflowTaskEventID, id)
|
|
if tt.wantSetRunId != "" {
|
|
s.Equal(tt.wantSetRunId, execution.RunId)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *activitiesSuite) TestAdjustQueryBatchTypeEnum() {
|
|
tests := []struct {
|
|
name string
|
|
query string
|
|
expectedResult string
|
|
batchType enumspb.BatchOperationType
|
|
}{
|
|
{
|
|
name: "Empty query",
|
|
query: "",
|
|
expectedResult: "",
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Acceptance",
|
|
query: "A=B",
|
|
expectedResult: fmt.Sprintf("(A=B) AND (%s)", statusRunningQueryFilter),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Acceptance with parenthesis",
|
|
query: "(A=B)",
|
|
expectedResult: fmt.Sprintf("((A=B)) AND (%s)", statusRunningQueryFilter),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Acceptance with multiple conditions",
|
|
query: "(A=B) OR C=D",
|
|
expectedResult: fmt.Sprintf("((A=B) OR C=D) AND (%s)", statusRunningQueryFilter),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Contains status - 1",
|
|
query: "ExecutionStatus=Completed",
|
|
expectedResult: fmt.Sprintf("(ExecutionStatus=Completed) AND (%s)", statusRunningQueryFilter),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Contains status - 2",
|
|
query: "A=B OR ExecutionStatus='Completed'",
|
|
expectedResult: fmt.Sprintf("(A=B OR ExecutionStatus='Completed') AND (%s)", statusRunningQueryFilter),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
},
|
|
{
|
|
name: "Not supported batch type",
|
|
query: "A=B",
|
|
expectedResult: "A=B",
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UNSPECIFIED,
|
|
},
|
|
}
|
|
for _, testRun := range tests {
|
|
s.Run(testRun.name, func() {
|
|
a := activities{}
|
|
adjustedQuery := a.adjustQueryBatchTypeEnum(testRun.query, testRun.batchType)
|
|
s.Equal(testRun.expectedResult, adjustedQuery)
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *activitiesSuite) TestAdjustQueryAdminBatchType() {
|
|
a := activities{}
|
|
|
|
s.Run("Empty query", func() {
|
|
adminReq := &adminservice.StartAdminBatchOperationRequest{
|
|
VisibilityQuery: "",
|
|
Operation: &adminservice.StartAdminBatchOperationRequest_RefreshTasksOperation{
|
|
RefreshTasksOperation: &adminservice.BatchOperationRefreshTasks{},
|
|
},
|
|
}
|
|
adjustedQuery := a.adjustQueryAdminBatchType(adminReq)
|
|
s.Empty(adjustedQuery)
|
|
})
|
|
|
|
s.Run("RefreshWorkflowTasks returns query unchanged", func() {
|
|
adminReq := &adminservice.StartAdminBatchOperationRequest{
|
|
VisibilityQuery: "WorkflowType='MyWorkflow'",
|
|
Identity: "test",
|
|
Operation: &adminservice.StartAdminBatchOperationRequest_RefreshTasksOperation{
|
|
RefreshTasksOperation: &adminservice.BatchOperationRefreshTasks{},
|
|
},
|
|
}
|
|
adjustedQuery := a.adjustQueryAdminBatchType(adminReq)
|
|
// RefreshWorkflowTasks applies to both open and closed workflows, no filter added
|
|
s.Equal("WorkflowType='MyWorkflow'", adjustedQuery)
|
|
})
|
|
|
|
s.Run("RefreshWorkflowTasks with complex query unchanged", func() {
|
|
adminReq := &adminservice.StartAdminBatchOperationRequest{
|
|
VisibilityQuery: "(WorkflowType='MyWorkflow') OR (WorkflowType='OtherWorkflow')",
|
|
Operation: &adminservice.StartAdminBatchOperationRequest_RefreshTasksOperation{
|
|
RefreshTasksOperation: &adminservice.BatchOperationRefreshTasks{},
|
|
},
|
|
}
|
|
adjustedQuery := a.adjustQueryAdminBatchType(adminReq)
|
|
// RefreshWorkflowTasks applies to both open and closed workflows, no filter added
|
|
s.Equal("(WorkflowType='MyWorkflow') OR (WorkflowType='OtherWorkflow')", adjustedQuery)
|
|
})
|
|
|
|
s.Run("Nil operation returns query unchanged", func() {
|
|
adminReq := &adminservice.StartAdminBatchOperationRequest{
|
|
VisibilityQuery: "WorkflowType='MyWorkflow'",
|
|
}
|
|
adjustedQuery := a.adjustQueryAdminBatchType(adminReq)
|
|
s.Equal("WorkflowType='MyWorkflow'", adjustedQuery)
|
|
})
|
|
}
|
|
|
|
func (s *activitiesSuite) TestProcessAdminTask_RefreshWorkflowTasks() {
|
|
ctx := context.Background()
|
|
mockHistoryClient := historyservicemock.NewMockHistoryServiceClient(s.controller)
|
|
|
|
a := &activities{
|
|
activityDeps: activityDeps{
|
|
HistoryClient: mockHistoryClient,
|
|
},
|
|
}
|
|
|
|
namespaceID := "test-namespace-id"
|
|
workflowID := "test-workflow-id"
|
|
runID := "test-run-id"
|
|
|
|
batchOperation := &batchspb.BatchOperationInput{
|
|
NamespaceId: namespaceID,
|
|
AdminRequest: &adminservice.StartAdminBatchOperationRequest{
|
|
Namespace: "test-namespace",
|
|
Identity: "test-identity",
|
|
Operation: &adminservice.StartAdminBatchOperationRequest_RefreshTasksOperation{
|
|
RefreshTasksOperation: &adminservice.BatchOperationRefreshTasks{},
|
|
},
|
|
},
|
|
}
|
|
|
|
testTask := task{
|
|
executionInfo: &workflowpb.WorkflowExecutionInfo{
|
|
Execution: &commonpb.WorkflowExecution{
|
|
WorkflowId: workflowID,
|
|
RunId: runID,
|
|
},
|
|
},
|
|
}
|
|
|
|
limiter := rate.NewLimiter(rate.Limit(100), 1)
|
|
|
|
// Expect RefreshWorkflowTasks to be called with correct parameters
|
|
mockHistoryClient.EXPECT().RefreshWorkflowTasks(gomock.Any(), gomock.Any()).DoAndReturn(
|
|
func(_ context.Context, req *historyservice.RefreshWorkflowTasksRequest, _ ...any) (*historyservice.RefreshWorkflowTasksResponse, error) {
|
|
s.Equal(namespaceID, req.NamespaceId)
|
|
s.NotZero(req.ArchetypeId) // WorkflowArchetypeID is computed dynamically
|
|
s.Equal(workflowID, req.Request.Execution.WorkflowId)
|
|
s.Equal(runID, req.Request.Execution.RunId)
|
|
return &historyservice.RefreshWorkflowTasksResponse{}, nil
|
|
})
|
|
|
|
err := a.processAdminTask(ctx, batchOperation, testTask, limiter)
|
|
s.NoError(err)
|
|
}
|
|
|
|
func (s *activitiesSuite) TestProcessAdminTask_RefreshWorkflowTasks_Error() {
|
|
ctx := context.Background()
|
|
mockHistoryClient := historyservicemock.NewMockHistoryServiceClient(s.controller)
|
|
|
|
a := &activities{
|
|
activityDeps: activityDeps{
|
|
HistoryClient: mockHistoryClient,
|
|
},
|
|
}
|
|
|
|
batchOperation := &batchspb.BatchOperationInput{
|
|
NamespaceId: "test-namespace-id",
|
|
AdminRequest: &adminservice.StartAdminBatchOperationRequest{
|
|
Namespace: "test-namespace",
|
|
Identity: "test-identity",
|
|
Operation: &adminservice.StartAdminBatchOperationRequest_RefreshTasksOperation{
|
|
RefreshTasksOperation: &adminservice.BatchOperationRefreshTasks{},
|
|
},
|
|
},
|
|
}
|
|
|
|
testTask := task{
|
|
executionInfo: &workflowpb.WorkflowExecutionInfo{
|
|
Execution: &commonpb.WorkflowExecution{
|
|
WorkflowId: "test-workflow-id",
|
|
RunId: "test-run-id",
|
|
},
|
|
},
|
|
}
|
|
|
|
limiter := rate.NewLimiter(rate.Limit(100), 1)
|
|
|
|
expectedErr := errors.New("refresh failed")
|
|
// Use gomock.Any() for context since it's modified with CallerTypePreemptable header
|
|
mockHistoryClient.EXPECT().RefreshWorkflowTasks(gomock.Any(), gomock.Any()).Return(nil, expectedErr)
|
|
|
|
err := a.processAdminTask(ctx, batchOperation, testTask, limiter)
|
|
s.Require().Error(err)
|
|
s.Equal(expectedErr, err)
|
|
}
|
|
|
|
func (s *activitiesSuite) TestIsNonRetryableError() {
|
|
tests := []struct {
|
|
name string
|
|
err error
|
|
batchType enumspb.BatchOperationType
|
|
want bool
|
|
}{
|
|
{
|
|
name: "nil error returns false",
|
|
err: nil,
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UPDATE_EXECUTION_OPTIONS,
|
|
want: false,
|
|
},
|
|
{
|
|
name: "pinned version error for UPDATE_EXECUTION_OPTIONS returns true",
|
|
err: errors.New("Pinned version 'deployment-foo:build-123' is not present in task queue 'my-queue' of type 'Workflow'"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UPDATE_EXECUTION_OPTIONS,
|
|
want: true,
|
|
},
|
|
{
|
|
name: "pinned version error with different format for UPDATE_EXECUTION_OPTIONS returns true",
|
|
err: errors.New("Pinned version 'prod:v2.0.1' is not present in task queue 'activity-queue' of type 'Activity'"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UPDATE_EXECUTION_OPTIONS,
|
|
want: true,
|
|
},
|
|
{
|
|
name: "error containing substring for UPDATE_EXECUTION_OPTIONS returns true",
|
|
err: fmt.Errorf("Some prefix: %s suffix", "is not present in task queue"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UPDATE_EXECUTION_OPTIONS,
|
|
want: true,
|
|
},
|
|
{
|
|
name: "unrelated error for UPDATE_EXECUTION_OPTIONS returns false",
|
|
err: errors.New("some other error that doesn't match"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_UPDATE_EXECUTION_OPTIONS,
|
|
want: false,
|
|
},
|
|
{
|
|
name: "pinned version error for different operation type returns false",
|
|
err: errors.New("Pinned version 'deployment-foo:build-123' is not present in task queue 'my-queue' of type 'Workflow'"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_TERMINATE,
|
|
want: false,
|
|
},
|
|
{
|
|
name: "pinned version error for SIGNAL operation returns false",
|
|
err: errors.New("Pinned version 'deployment-foo:build-123' is not present in task queue 'my-queue' of type 'Workflow'"),
|
|
batchType: enumspb.BATCH_OPERATION_TYPE_SIGNAL,
|
|
want: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
s.Run(tt.name, func() {
|
|
got := isNonRetryableError(tt.err, tt.batchType)
|
|
s.Equal(tt.want, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestStartTaskProcessor_SignalUsesWorkerNamespace verifies that startTaskProcessor uses
|
|
// the worker's authoritative namespace (passed as the namespace argument) for operations,
|
|
// not the user-controlled namespace from batchOperation.Request.Namespace.
|
|
// This guards against a regression introduced in PR #8144 where batchParams.Request.Namespace
|
|
// (user-controlled) was used instead of a.namespace.String() (server-trusted).
|
|
func (s *activitiesSuite) TestStartTaskProcessor_SignalUsesWorkerNamespace() {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
a := &activities{
|
|
activityDeps: activityDeps{
|
|
FrontendClient: s.mockFrontendClient,
|
|
Logger: log.NewTestLogger(),
|
|
MetricsHandler: metrics.NoopMetricsHandler,
|
|
},
|
|
}
|
|
|
|
workerNamespace := "trusted-namespace"
|
|
requestNamespace := "untrusted-namespace" // intentionally different
|
|
|
|
batchOperation := &batchspb.BatchOperationInput{
|
|
NamespaceId: "some-namespace-id",
|
|
Request: &workflowservice.StartBatchOperationRequest{
|
|
Namespace: requestNamespace,
|
|
Operation: &workflowservice.StartBatchOperationRequest_SignalOperation{
|
|
SignalOperation: &batchpb.BatchOperationSignal{
|
|
Signal: "test-signal",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
testPage := &page{
|
|
executionInfos: []*workflowpb.WorkflowExecutionInfo{
|
|
{
|
|
Execution: &commonpb.WorkflowExecution{
|
|
WorkflowId: "test-workflow-id",
|
|
RunId: "test-run-id",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
testTask := task{
|
|
executionInfo: testPage.executionInfos[0],
|
|
attempts: 1,
|
|
page: testPage,
|
|
}
|
|
|
|
taskCh := make(chan task, 1)
|
|
respCh := make(chan taskResponse, 1)
|
|
limiter := rate.NewLimiter(rate.Limit(100), 1)
|
|
|
|
// The signal must be executed with the worker's trusted namespace, not the user-supplied one.
|
|
s.mockFrontendClient.EXPECT().
|
|
SignalWorkflowExecution(gomock.Any(), gomock.Any()).
|
|
DoAndReturn(func(_ context.Context, req *workflowservice.SignalWorkflowExecutionRequest, _ ...any) (*workflowservice.SignalWorkflowExecutionResponse, error) {
|
|
s.Equal(workerNamespace, req.Namespace, "must use worker namespace, not request namespace")
|
|
return &workflowservice.SignalWorkflowExecutionResponse{}, nil
|
|
})
|
|
|
|
taskCh <- testTask
|
|
|
|
go a.startTaskProcessor(ctx, batchOperation, workerNamespace, taskCh, respCh, limiter, nil, s.mockFrontendClient, metrics.NoopMetricsHandler, log.NewTestLogger())
|
|
|
|
resp := <-respCh
|
|
s.NoError(resp.err)
|
|
}
|
|
|
|
func (s *activitiesSuite) TestProcessAdminTask_UnknownOperation() {
|
|
ctx := context.Background()
|
|
|
|
a := &activities{}
|
|
|
|
// AdminRequest with nil operation
|
|
batchOperation := &batchspb.BatchOperationInput{
|
|
NamespaceId: "test-namespace-id",
|
|
AdminRequest: &adminservice.StartAdminBatchOperationRequest{
|
|
Namespace: "test-namespace",
|
|
},
|
|
}
|
|
|
|
testTask := task{
|
|
executionInfo: &workflowpb.WorkflowExecutionInfo{
|
|
Execution: &commonpb.WorkflowExecution{
|
|
WorkflowId: "test-workflow-id",
|
|
RunId: "test-run-id",
|
|
},
|
|
},
|
|
}
|
|
|
|
limiter := rate.NewLimiter(rate.Limit(100), 1)
|
|
|
|
err := a.processAdminTask(ctx, batchOperation, testTask, limiter)
|
|
s.Require().Error(err)
|
|
s.Contains(err.Error(), "unknown admin batch type")
|
|
}
|