mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Alan WuandGitHub
281db19ee9
## What changed? Add a dedicated DeleteChasmExecution RPC to the history service for deleting CHASM executions by namespace, execution key, and archetype ID. Uses the CHASM engine's DeleteExecution path (terminate-if-running + async DeleteExecutionTask), replacing the ForceDeleteWorkflowExecution workaround in the delete namespace activity which bypassed the engine. Also adds NewComponentRefByArchetypeID to chasm/ref.go to construct a ComponentRef from a runtime archetype ID without a compile-time type parameter. ## Why? Remove dependency on force deletion API. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [X] added new functional test(s)
145 lines
6.2 KiB
Go
145 lines
6.2 KiB
Go
package deletenamespace
|
|
|
|
import (
|
|
"context"
|
|
|
|
sdkworker "go.temporal.io/sdk/worker"
|
|
"go.temporal.io/sdk/workflow"
|
|
"go.temporal.io/server/common/cluster"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/headers"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/common/persistence/visibility/manager"
|
|
"go.temporal.io/server/common/primitives"
|
|
"go.temporal.io/server/common/resource"
|
|
workercommon "go.temporal.io/server/service/worker/common"
|
|
"go.temporal.io/server/service/worker/deletenamespace/deleteexecutions"
|
|
"go.temporal.io/server/service/worker/deletenamespace/reclaimresources"
|
|
"go.uber.org/fx"
|
|
)
|
|
|
|
type (
|
|
// deleteNamespaceComponent represent background work needed for delete namespace.
|
|
deleteNamespaceComponent struct {
|
|
atWorkerCfg sdkworker.Options
|
|
visibilityManager manager.VisibilityManager
|
|
metadataManager persistence.MetadataManager
|
|
clusterMetadata cluster.Metadata
|
|
nexusEndpointManager persistence.NexusEndpointManager
|
|
historyClient resource.HistoryClient
|
|
metricsHandler metrics.Handler
|
|
logger log.Logger
|
|
|
|
protectedNamespaces dynamicconfig.TypedPropertyFn[[]string]
|
|
allowDeleteNamespaceIfNexusEndpointTarget dynamicconfig.BoolPropertyFn
|
|
nexusEndpointListDefaultPageSize dynamicconfig.IntPropertyFn
|
|
deleteActivityRPS dynamicconfig.TypedSubscribable[int]
|
|
useChasmDeleteExecution dynamicconfig.BoolPropertyFn
|
|
namespaceCacheRefreshInterval dynamicconfig.DurationPropertyFn
|
|
}
|
|
componentParams struct {
|
|
fx.In
|
|
DynamicCollection *dynamicconfig.Collection
|
|
VisibilityManager manager.VisibilityManager
|
|
MetadataManager persistence.MetadataManager
|
|
ClusterMetadata cluster.Metadata
|
|
NexusEndpointManager persistence.NexusEndpointManager
|
|
HistoryClient resource.HistoryClient
|
|
MetricsHandler metrics.Handler
|
|
Logger log.Logger
|
|
}
|
|
)
|
|
|
|
var Module = workercommon.AnnotateWorkerComponentProvider(newComponent)
|
|
|
|
func newComponent(
|
|
params componentParams,
|
|
) workercommon.WorkerComponent {
|
|
return &deleteNamespaceComponent{
|
|
atWorkerCfg: dynamicconfig.WorkerDeleteNamespaceActivityLimits.Get(params.DynamicCollection)(),
|
|
visibilityManager: params.VisibilityManager,
|
|
metadataManager: params.MetadataManager,
|
|
clusterMetadata: params.ClusterMetadata,
|
|
nexusEndpointManager: params.NexusEndpointManager,
|
|
historyClient: params.HistoryClient,
|
|
metricsHandler: params.MetricsHandler,
|
|
logger: params.Logger,
|
|
protectedNamespaces: dynamicconfig.ProtectedNamespaces.Get(params.DynamicCollection),
|
|
allowDeleteNamespaceIfNexusEndpointTarget: dynamicconfig.AllowDeleteNamespaceIfNexusEndpointTarget.Get(params.DynamicCollection),
|
|
nexusEndpointListDefaultPageSize: dynamicconfig.NexusEndpointListDefaultPageSize.Get(params.DynamicCollection),
|
|
deleteActivityRPS: dynamicconfig.DeleteNamespaceDeleteActivityRPS.Subscribe(params.DynamicCollection),
|
|
useChasmDeleteExecution: dynamicconfig.DeleteNamespaceUseChasmDeleteExecution.Get(params.DynamicCollection),
|
|
namespaceCacheRefreshInterval: dynamicconfig.NamespaceCacheRefreshInterval.Get(params.DynamicCollection),
|
|
}
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) RegisterWorkflow(registry sdkworker.Registry) {
|
|
registry.RegisterWorkflowWithOptions(DeleteNamespaceWorkflow, workflow.RegisterOptions{Name: WorkflowName})
|
|
registry.RegisterActivity(wc.deleteNamespaceLocalActivities())
|
|
|
|
registry.RegisterWorkflowWithOptions(reclaimresources.ReclaimResourcesWorkflow, workflow.RegisterOptions{Name: reclaimresources.WorkflowName})
|
|
registry.RegisterActivity(wc.reclaimResourcesLocalActivities())
|
|
|
|
registry.RegisterWorkflowWithOptions(deleteexecutions.DeleteExecutionsWorkflow, workflow.RegisterOptions{Name: deleteexecutions.WorkflowName})
|
|
registry.RegisterActivity(wc.deleteExecutionsLocalActivities())
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) DedicatedWorkflowWorkerOptions() *workercommon.DedicatedWorkerOptions {
|
|
// use default worker
|
|
return nil
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) RegisterActivities(registry sdkworker.Registry) {
|
|
registry.RegisterActivity(wc.reclaimResourcesActivities())
|
|
registry.RegisterActivity(wc.deleteExecutionsActivities())
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) DedicatedActivityWorkerOptions() *workercommon.DedicatedWorkerOptions {
|
|
return &workercommon.DedicatedWorkerOptions{
|
|
TaskQueue: primitives.DeleteNamespaceActivityTQ,
|
|
Options: sdkworker.Options{
|
|
BackgroundActivityContext: headers.SetCallerType(context.Background(), headers.CallerTypePreemptable),
|
|
MaxConcurrentActivityExecutionSize: wc.atWorkerCfg.MaxConcurrentActivityExecutionSize,
|
|
TaskQueueActivitiesPerSecond: wc.atWorkerCfg.TaskQueueActivitiesPerSecond,
|
|
WorkerActivitiesPerSecond: wc.atWorkerCfg.WorkerActivitiesPerSecond,
|
|
MaxConcurrentActivityTaskPollers: wc.atWorkerCfg.MaxConcurrentActivityTaskPollers,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) deleteNamespaceLocalActivities() *localActivities {
|
|
return newLocalActivities(
|
|
wc.metadataManager,
|
|
wc.clusterMetadata,
|
|
wc.nexusEndpointManager,
|
|
wc.logger,
|
|
wc.protectedNamespaces,
|
|
wc.allowDeleteNamespaceIfNexusEndpointTarget,
|
|
wc.nexusEndpointListDefaultPageSize)
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) reclaimResourcesActivities() *reclaimresources.Activities {
|
|
return reclaimresources.NewActivities(wc.visibilityManager, wc.logger)
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) reclaimResourcesLocalActivities() *reclaimresources.LocalActivities {
|
|
return reclaimresources.NewLocalActivities(wc.visibilityManager, wc.metadataManager, wc.namespaceCacheRefreshInterval, wc.logger)
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) deleteExecutionsActivities() *deleteexecutions.Activities {
|
|
return deleteexecutions.NewActivities(
|
|
wc.visibilityManager,
|
|
wc.historyClient,
|
|
wc.deleteActivityRPS,
|
|
wc.useChasmDeleteExecution,
|
|
wc.metricsHandler,
|
|
wc.logger,
|
|
)
|
|
}
|
|
|
|
func (wc *deleteNamespaceComponent) deleteExecutionsLocalActivities() *deleteexecutions.LocalActivities {
|
|
return deleteexecutions.NewLocalActivities(wc.visibilityManager, wc.metricsHandler, wc.logger)
|
|
}
|