mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
zeekay
5a601d081b
Full module path rebrand from Temporal to Hanzo Tasks: - go.mod module: github.com/hanzoai/tasks - All internal Go imports updated (1906 files) - cmd/server renamed to cmd/tasksd - Binary name: tasksd (was temporal-server) - Docker images: hanzoai/tasks (was temporalio/server) - README rewritten with Hanzo Tasks branding - LLM.md created with integration notes - Makefile, goreleaser, CI workflows updated - go.temporal.io/sdk and go.temporal.io/api imports preserved (separate repos) Fork of Temporal.io (MIT license).
277 lines
8.7 KiB
Go
277 lines
8.7 KiB
Go
package tqid
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
"github.com/hanzoai/tasks/common/primitives"
|
|
)
|
|
|
|
func TestNormalizeAndValidate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
taskQueue *taskqueuepb.TaskQueue
|
|
defaultVal string
|
|
maxIDLengthLimit int
|
|
expectedError string
|
|
expectedKind enumspb.TaskQueueKind
|
|
validAsPartition bool
|
|
}{
|
|
{
|
|
name: "Nil task queue",
|
|
taskQueue: nil,
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue is not set",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_UNSPECIFIED,
|
|
},
|
|
{
|
|
name: "Empty name, no default",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "missing task queue name",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Empty name, with default",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Valid name",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "valid-name"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Name exactly at max length",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: strings.Repeat("a", 100)},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Name one character over max length",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: strings.Repeat("a", 101)},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue length exceeds limit",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Reserved prefix",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: reservedTaskQueuePrefix + "name"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "task queue name cannot start with reserved prefix /_sys/",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
validAsPartition: true,
|
|
},
|
|
{
|
|
name: "Sticky queue with valid normal name",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "sticky", Kind: enumspb.TASK_QUEUE_KIND_STICKY, NormalName: "normal"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_STICKY,
|
|
},
|
|
{
|
|
name: "Non-sticky queue with normal name set",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "normal", Kind: enumspb.TASK_QUEUE_KIND_NORMAL, NormalName: "should-be-ignored"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Task queue with unspecified kind",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "unspecified", Kind: enumspb.TASK_QUEUE_KIND_UNSPECIFIED},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
originalTaskQueue := tt.taskQueue
|
|
var originalKind enumspb.TaskQueueKind
|
|
if tt.taskQueue != nil {
|
|
originalKind = tt.taskQueue.GetKind()
|
|
}
|
|
|
|
err := NormalizeAndValidate(tt.taskQueue, tt.defaultVal, tt.maxIDLengthLimit)
|
|
|
|
if tt.expectedError == "" {
|
|
assert.NoError(t, err)
|
|
} else {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.expectedError)
|
|
}
|
|
|
|
err = NormalizeAndValidatePartition(tt.taskQueue, tt.defaultVal, tt.maxIDLengthLimit)
|
|
|
|
if tt.expectedError == "" || tt.validAsPartition {
|
|
assert.NoError(t, err)
|
|
} else {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.expectedError)
|
|
}
|
|
|
|
if originalTaskQueue == nil {
|
|
assert.Nil(t, tt.taskQueue)
|
|
} else {
|
|
if originalKind == enumspb.TASK_QUEUE_KIND_UNSPECIFIED {
|
|
assert.Equal(t, tt.expectedKind, tt.taskQueue.GetKind(), "Kind should be set to NORMAL if it was UNSPECIFIED")
|
|
} else {
|
|
assert.Equal(t, originalKind, tt.taskQueue.GetKind(), "Kind should not change if it wasn't UNSPECIFIED")
|
|
}
|
|
}
|
|
|
|
if tt.taskQueue != nil && tt.taskQueue.GetName() == "" && tt.defaultVal != "" {
|
|
assert.Equal(t, tt.defaultVal, tt.taskQueue.GetName())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNormalizeAndValidateUserDefined(t *testing.T) {
|
|
const perNsTaskQueue = primitives.PerNSWorkerTaskQueue
|
|
|
|
tests := []struct {
|
|
name string
|
|
taskQueue *taskqueuepb.TaskQueue
|
|
parentTaskQueue *taskqueuepb.TaskQueue
|
|
defaultVal string
|
|
maxIDLengthLimit int
|
|
expectedError string
|
|
}{
|
|
{
|
|
name: "Nil task queue",
|
|
taskQueue: nil,
|
|
parentTaskQueue: nil,
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue is not set",
|
|
},
|
|
{
|
|
name: "Valid user-defined task queue without parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "user-tq"},
|
|
parentTaskQueue: nil,
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
},
|
|
{
|
|
name: "Valid user-defined task queue with parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "user-tq"},
|
|
parentTaskQueue: &taskqueuepb.TaskQueue{Name: "parent-tq"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
},
|
|
{
|
|
name: "Internal per-ns task queue without parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: perNsTaskQueue},
|
|
parentTaskQueue: nil,
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "cannot use internal per-namespace task queue",
|
|
},
|
|
{
|
|
name: "Internal per-ns task queue with non-internal parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: perNsTaskQueue},
|
|
parentTaskQueue: &taskqueuepb.TaskQueue{Name: "user-parent-tq"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "cannot use internal per-namespace task queue",
|
|
},
|
|
{
|
|
name: "Reserved /_sys/ prefix task queue with non-internal parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "/_sys/my-task-queue"},
|
|
parentTaskQueue: &taskqueuepb.TaskQueue{Name: "user-parent-tq"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "task queue name cannot start with reserved prefix /_sys/",
|
|
},
|
|
{
|
|
name: "Internal per-ns task queue with internal per-ns parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: perNsTaskQueue},
|
|
parentTaskQueue: &taskqueuepb.TaskQueue{Name: perNsTaskQueue},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
},
|
|
{
|
|
name: "Empty name with default, no parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
parentTaskQueue: nil,
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
},
|
|
{
|
|
name: "Empty name, no default, no parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
parentTaskQueue: nil,
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "missing task queue name",
|
|
},
|
|
{
|
|
name: "Name exceeds max length",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: strings.Repeat("a", 101)},
|
|
parentTaskQueue: nil,
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue length exceeds limit",
|
|
},
|
|
{
|
|
name: "User task queue with empty parent",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "user-tq"},
|
|
parentTaskQueue: &taskqueuepb.TaskQueue{},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
var parentName string
|
|
if tt.parentTaskQueue != nil {
|
|
parentName = tt.parentTaskQueue.GetName()
|
|
}
|
|
err := NormalizeAndValidateUserDefined(tt.taskQueue, tt.defaultVal, parentName, tt.maxIDLengthLimit)
|
|
|
|
if tt.expectedError == "" {
|
|
require.NoError(t, err)
|
|
if tt.taskQueue != nil {
|
|
require.NotEqual(t, enumspb.TASK_QUEUE_KIND_UNSPECIFIED, tt.taskQueue.GetKind(), "Kind should be normalized")
|
|
}
|
|
} else {
|
|
var invalidArgErr *serviceerror.InvalidArgument
|
|
require.ErrorAs(t, err, &invalidArgErr)
|
|
require.Contains(t, invalidArgErr.Error(), tt.expectedError)
|
|
}
|
|
|
|
if tt.taskQueue != nil && tt.taskQueue.GetName() == "" && tt.defaultVal != "" && tt.expectedError == "" {
|
|
require.Equal(t, tt.defaultVal, tt.taskQueue.GetName(), "Default name should be applied")
|
|
}
|
|
})
|
|
}
|
|
}
|