Files
tasks/common/persistence/sql/sqlplugin/interfaces.go
T
Tim Deeb-SwihartandGitHub ee2587a8a9 Ban the connect attr interpolateParams for MySQL 8 Vis dbs (#5441)
## What changed?
Attempting to configure a MySQL 8 Visibility database with
go-sql-driver/mysql's `interpolateParams` option will now fail.

## Why?

There are a number of reasons why this doesn't work right now so we're
going to prevent it from happening while we discuss how much we should
invest in fixing it. The current work to fix this is in
https://github.com/temporalio/temporal/pull/5428

## How did you test it?
Added a new test

## Potential risks
There should be none. Any user who has currently set up their database
this way will already have encountered exciting errors like `Cannot
create a JSON value from a string with CHARACTER SET 'binary'` and
`Unable to parse ExecutionStatus value from DB`.

## Is hotfix candidate?

That's up for discussion
2024-03-08 20:03:47 +00:00

160 lines
4.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package sqlplugin
import (
"context"
"database/sql"
"github.com/jmoiron/sqlx"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/resolver"
)
type (
DbKind int
)
const (
DbKindUnknown DbKind = iota
DbKindMain
DbKindVisibility
)
type VersionedBlob struct {
Version int64
Data []byte
DataEncoding string
}
type (
// Plugin defines the interface for any SQL database that needs to implement
Plugin interface {
CreateDB(dbKind DbKind, cfg *config.SQL, r resolver.ServiceResolver) (DB, error)
CreateAdminDB(dbKind DbKind, cfg *config.SQL, r resolver.ServiceResolver) (AdminDB, error)
}
// TableCRUD defines the API for interacting with the database tables
TableCRUD interface {
ClusterMetadata
Namespace
Visibility
QueueMessage
QueueMetadata
QueueV2Message
QueueV2Metadata
MatchingTask
MatchingTaskQueue
NexusIncomingServices
HistoryNode
HistoryTree
HistoryShard
HistoryExecution
HistoryExecutionBuffer
HistoryExecutionActivity
HistoryExecutionChildWorkflow
HistoryExecutionTimer
HistoryExecutionRequestCancel
HistoryExecutionSignal
HistoryExecutionSignalRequest
HistoryImmediateTask
HistoryScheduledTask
HistoryTransferTask
HistoryTimerTask
HistoryReplicationTask
HistoryReplicationDLQTask
HistoryVisibilityTask
}
// AdminCRUD defines admin operations for CLI and test suites
AdminCRUD interface {
CreateSchemaVersionTables() error
ReadSchemaVersion(database string) (string, error)
UpdateSchemaVersion(database string, newVersion string, minCompatibleVersion string) error
WriteSchemaUpdateLog(oldVersion string, newVersion string, manifestMD5 string, desc string) error
ListTables(database string) ([]string, error)
DropTable(table string) error
DropAllTables(database string) error
CreateDatabase(database string) error
DropDatabase(database string) error
Exec(stmt string, args ...interface{}) error
}
// Tx defines the API for a SQL transaction
Tx interface {
TableCRUD
Commit() error
Rollback() error
}
// DB defines the API for regular SQL operations of a Temporal server
DB interface {
TableCRUD
BeginTx(ctx context.Context) (Tx, error)
PluginName() string
DbName() string
IsDupEntryError(err error) bool
Close() error
}
// AdminDB defines the API for admin SQL operations for CLI and testing suites
AdminDB interface {
AdminCRUD
PluginName() string
ExpectedVersion() string
VerifyVersion() error
Close() error
}
// Conn defines the API for a single database connection
Conn interface {
Rebind(query string) string
ExecContext(ctx context.Context, query string, args ...interface{}) (sql.Result, error)
NamedExecContext(ctx context.Context, query string, arg interface{}) (sql.Result, error)
GetContext(ctx context.Context, dest interface{}, query string, args ...interface{}) error
SelectContext(ctx context.Context, dest interface{}, query string, args ...interface{}) error
PrepareNamedContext(ctx context.Context, query string) (*sqlx.NamedStmt, error)
}
)
func (k DbKind) String() string {
switch k {
case DbKindMain:
return "main"
case DbKindVisibility:
return "visibility"
default:
return "unknown"
}
}