Files
tasks/common/persistence/sql/sqlplugin/postgresql/admin.go
T
Tim Deeb-SwihartandGitHub be7b5514a5 Reconnect to SQL databases when connections fail (#5926)
## What changed?

Both our PostgreSQL and MySQL database backends will now automatically
reconnect to the database when certain errors occur: all errors chosen
have been experienced when testing this behavior through an AWS Aurora
RDS failover of either MySQL or PostgreSQL.

For both backends we will reconnect when we see:
- `ECONNRESET`
- `ECONNABORTED`
- `ECONNREFUSED`
- `io.EOF`
- `io.ErrUnexpectedEOF`
- `database/sql/driver.ErrBadConn`

for postgres we will also reconnect on the following SQLStates:
- `25006` read-only transaction
- `57P03` cannot connect now
- `0A000` feature not supported, but ONLY when the message is `cannot
set transaction read-write mode during recovery`

for mysql we will also reconnect when we see the following error codes:
- `1040` too many connections 
- `1792` read-only transaction (SQLstate `25006`)
- `1836` running in read-only mode

This logic is easily extensible should we discover more failure modes
over time

## Why?

We've had multiple community reports of Temporal problems during RDS
failover. One part of this is the fact that we wouldn't necessarily
reconnect; we were at the whims of our chosen SQL abstraction's
connection pooling logic.

## How did you test it?

I manually tested this functionality in the presence of repeated RDS
failovers: 

- [x] postgres12 plugin with pq driver
- [x] postgres12 plugin with pgx driver
- [x] mysql plugin

Automated testing will be added to our regular testing pipelines once
our infrastructure friends have added the support I need (it's in
progress)

## Potential risks

We're concerned there's a correctness issue in our PostgreSQL backend
that's related to our behavior during an RDS failover. If we merge this
before I figure out what's going on, we could hide the issue and make it
harder to reproduce.

## Documentation
N/A

## Is hotfix candidate?
Yes?
2024-05-17 16:59:15 -07:00

157 lines
5.5 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package postgresql
import (
"fmt"
"time"
)
const (
readSchemaVersionQuery = `SELECT curr_version from schema_version where version_partition=0 and db_name=$1`
writeSchemaVersionQuery = `INSERT into schema_version(version_partition, db_name, creation_time, curr_version, min_compatible_version) VALUES (0,$1,$2,$3,$4)
ON CONFLICT (version_partition, db_name) DO UPDATE
SET creation_time = excluded.creation_time,
curr_version = excluded.curr_version,
min_compatible_version = excluded.min_compatible_version;`
writeSchemaUpdateHistoryQuery = `INSERT into schema_update_history(version_partition, year, month, update_time, old_version, new_version, manifest_md5, description) VALUES(0,$1,$2,$3,$4,$5,$6,$7)`
createSchemaVersionTableQuery = `CREATE TABLE IF NOT EXISTS schema_version(` +
`version_partition INT not null, ` +
`db_name VARCHAR(255) not null, ` +
`creation_time TIMESTAMP, ` +
`curr_version VARCHAR(64), ` +
`min_compatible_version VARCHAR(64), ` +
`PRIMARY KEY (version_partition, db_name));`
createSchemaUpdateHistoryTableQuery = `CREATE TABLE IF NOT EXISTS schema_update_history(` +
`version_partition INT not null, ` +
`year int not null, ` +
`month int not null, ` +
`update_time TIMESTAMP not null, ` +
`description VARCHAR(255), ` +
`manifest_md5 VARCHAR(64), ` +
`new_version VARCHAR(64), ` +
`old_version VARCHAR(64), ` +
`PRIMARY KEY (version_partition, year, month, update_time));`
// NOTE we have to use %v because somehow postgresql doesn't work with ? here
// It's a small bug in sqlx library
// TODO https://github.com/uber/cadence/issues/2893
createDatabaseQuery = `CREATE DATABASE "%v"`
dropDatabaseQuery = "DROP DATABASE IF EXISTS %v"
listTablesQuery = "select table_name from information_schema.tables where table_schema='public'"
dropTableQuery = "DROP TABLE %v"
)
// Exec executes a sql statement
func (pdb *db) Exec(stmt string, args ...any) error {
db, err := pdb.handle.DB()
if err != nil {
return err
}
_, err = db.Exec(stmt, args...)
return pdb.handle.ConvertError(err)
}
// CreateSchemaVersionTables sets up the schema version tables
func (pdb *db) CreateSchemaVersionTables() error {
if err := pdb.Exec(createSchemaVersionTableQuery); err != nil {
return err
}
return pdb.Exec(createSchemaUpdateHistoryTableQuery)
}
// ReadSchemaVersion returns the current schema version for the keyspace
func (pdb *db) ReadSchemaVersion(database string) (string, error) {
var version string
db, err := pdb.handle.DB()
if err != nil {
return "", err
}
err = db.Get(&version, readSchemaVersionQuery, database)
return version, pdb.handle.ConvertError(err)
}
// UpdateSchemaVersion updates the schema version for the keyspace
func (pdb *db) UpdateSchemaVersion(database string, newVersion string, minCompatibleVersion string) error {
return pdb.Exec(writeSchemaVersionQuery, database, time.Now().UTC(), newVersion, minCompatibleVersion)
}
// WriteSchemaUpdateLog adds an entry to the schema update history table
func (pdb *db) WriteSchemaUpdateLog(oldVersion string, newVersion string, manifestMD5 string, desc string) error {
now := time.Now().UTC()
err := pdb.Exec(writeSchemaUpdateHistoryQuery, now.Year(), int(now.Month()), now, oldVersion, newVersion, manifestMD5, desc)
return pdb.handle.ConvertError(err)
}
// ListTables returns a list of tables in this database
func (pdb *db) ListTables(database string) ([]string, error) {
var tables []string
err := pdb.Select(&tables, listTablesQuery)
return tables, pdb.handle.ConvertError(err)
}
// DropTable drops a given table from the database
func (pdb *db) DropTable(name string) error {
return pdb.Exec(fmt.Sprintf(dropTableQuery, name))
}
// DropAllTables drops all tables from this database
func (pdb *db) DropAllTables(database string) error {
tables, err := pdb.ListTables(database)
if err != nil {
return err
}
for _, tab := range tables {
if err := pdb.DropTable(tab); err != nil {
return err
}
}
return nil
}
// CreateDatabase creates a database if it doesn't exist
func (pdb *db) CreateDatabase(name string) error {
if err := pdb.Exec(fmt.Sprintf(createDatabaseQuery, name)); err != nil {
if pdb.IsDupDatabaseError(err) {
return nil
}
return err
}
return nil
}
// DropDatabase drops a database
func (pdb *db) DropDatabase(name string) error {
return pdb.Exec(fmt.Sprintf(dropDatabaseQuery, name))
}