mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Both our PostgreSQL and MySQL database backends will now automatically reconnect to the database when certain errors occur: all errors chosen have been experienced when testing this behavior through an AWS Aurora RDS failover of either MySQL or PostgreSQL. For both backends we will reconnect when we see: - `ECONNRESET` - `ECONNABORTED` - `ECONNREFUSED` - `io.EOF` - `io.ErrUnexpectedEOF` - `database/sql/driver.ErrBadConn` for postgres we will also reconnect on the following SQLStates: - `25006` read-only transaction - `57P03` cannot connect now - `0A000` feature not supported, but ONLY when the message is `cannot set transaction read-write mode during recovery` for mysql we will also reconnect when we see the following error codes: - `1040` too many connections - `1792` read-only transaction (SQLstate `25006`) - `1836` running in read-only mode This logic is easily extensible should we discover more failure modes over time ## Why? We've had multiple community reports of Temporal problems during RDS failover. One part of this is the fact that we wouldn't necessarily reconnect; we were at the whims of our chosen SQL abstraction's connection pooling logic. ## How did you test it? I manually tested this functionality in the presence of repeated RDS failovers: - [x] postgres12 plugin with pq driver - [x] postgres12 plugin with pgx driver - [x] mysql plugin Automated testing will be added to our regular testing pipelines once our infrastructure friends have added the support I need (it's in progress) ## Potential risks We're concerned there's a correctness issue in our PostgreSQL backend that's related to our behavior during an RDS failover. If we merge this before I figure out what's going on, we could hide the issue and make it harder to reproduce. ## Documentation N/A ## Is hotfix candidate? Yes?
207 lines
5.5 KiB
Go
207 lines
5.5 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package sqlplugin
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"database/sql/driver"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"sync"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/jmoiron/sqlx"
|
|
uberatomic "go.uber.org/atomic"
|
|
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/common/metrics"
|
|
)
|
|
|
|
const (
|
|
// TODO: this should be dynamic config.
|
|
sessionRefreshMinInternal = 1 * time.Second
|
|
)
|
|
|
|
var (
|
|
DatabaseUnavailableError = serviceerror.NewUnavailable("no usable database connection found")
|
|
)
|
|
|
|
type DatabaseHandle struct {
|
|
running bool
|
|
db uberatomic.Pointer[sqlx.DB]
|
|
connect func() (*sqlx.DB, error)
|
|
needsRefresh func(error) bool
|
|
|
|
lastRefresh time.Time
|
|
metrics metrics.Handler
|
|
logger log.Logger
|
|
// Ensures only one refresh call happens at a time
|
|
sync.Mutex
|
|
}
|
|
|
|
// An invalid connection returns `DatabaseUnavailableError` for all operations
|
|
type invalidConn struct{}
|
|
|
|
func NewDatabaseHandle(
|
|
connect func() (*sqlx.DB, error),
|
|
needsRefresh func(error) bool,
|
|
logger log.Logger,
|
|
metricsHandler metrics.Handler,
|
|
) *DatabaseHandle {
|
|
handle := &DatabaseHandle{
|
|
running: true,
|
|
connect: connect,
|
|
needsRefresh: needsRefresh,
|
|
metrics: metricsHandler,
|
|
logger: logger,
|
|
}
|
|
handle.reconnect(true)
|
|
return handle
|
|
}
|
|
|
|
// Close and reopen the underlying database connection
|
|
func (h *DatabaseHandle) reconnect(force bool) *sqlx.DB {
|
|
h.Lock()
|
|
defer h.Unlock()
|
|
|
|
// Don't reconnect if we've been closed
|
|
if !h.running {
|
|
return nil
|
|
}
|
|
|
|
prevConn := h.db.Load()
|
|
if prevConn != nil {
|
|
if !force {
|
|
// Another goroutine already reconnected
|
|
return prevConn
|
|
}
|
|
|
|
h.db.Store(nil)
|
|
// Store `nil` to prevent other goroutines from slamming the now-unusable database with
|
|
// transactions we know will fail
|
|
go prevConn.Close()
|
|
}
|
|
|
|
metrics.PersistenceSessionRefreshAttempts.With(h.metrics).Record(1)
|
|
|
|
now := time.Now()
|
|
lastRefresh := h.lastRefresh
|
|
h.lastRefresh = now
|
|
if now.Sub(lastRefresh) < sessionRefreshMinInternal {
|
|
h.logger.Warn("sql handle: did not refresh database connection pool because the last refresh was too close",
|
|
tag.NewDurationTag("min_refresh_interval_seconds", sessionRefreshMinInternal))
|
|
handler := h.metrics.WithTags(metrics.FailureTag("throttle"))
|
|
metrics.PersistenceSessionRefreshFailures.With(handler).Record(1)
|
|
return nil
|
|
}
|
|
|
|
newConn, err := h.connect()
|
|
if err != nil {
|
|
h.logger.Error("sql handle: unable to refresh database connection pool", tag.Error(err))
|
|
handler := h.metrics.WithTags(metrics.FailureTag("error"))
|
|
metrics.PersistenceSessionRefreshFailures.With(handler).Record(1)
|
|
return nil
|
|
}
|
|
|
|
h.db.Store(newConn)
|
|
return newConn
|
|
}
|
|
|
|
func (h *DatabaseHandle) Close() {
|
|
h.Lock()
|
|
defer h.Unlock()
|
|
|
|
if h.running {
|
|
h.running = false
|
|
db := h.db.Swap(nil)
|
|
if db != nil {
|
|
db.Close()
|
|
}
|
|
}
|
|
}
|
|
|
|
func (h *DatabaseHandle) DB() (*sqlx.DB, error) {
|
|
if db := h.db.Load(); db != nil {
|
|
return db, nil
|
|
}
|
|
|
|
if db := h.reconnect(false); db != nil {
|
|
return db, nil
|
|
}
|
|
return nil, DatabaseUnavailableError
|
|
}
|
|
|
|
func (h *DatabaseHandle) Conn() Conn {
|
|
if db := h.db.Load(); db != nil {
|
|
return db
|
|
}
|
|
|
|
if db := h.reconnect(false); db != nil {
|
|
return db
|
|
}
|
|
return invalidConn{}
|
|
}
|
|
|
|
func (h *DatabaseHandle) ConvertError(err error) error {
|
|
if h.needsRefresh(err) ||
|
|
errors.Is(err, driver.ErrBadConn) ||
|
|
errors.Is(err, io.ErrUnexpectedEOF) ||
|
|
errors.Is(err, io.EOF) ||
|
|
errors.Is(err, syscall.ECONNRESET) ||
|
|
errors.Is(err, syscall.ECONNABORTED) ||
|
|
errors.Is(err, syscall.ECONNREFUSED) {
|
|
h.reconnect(true)
|
|
return serviceerror.NewUnavailable(fmt.Sprintf("database connection lost: %s", err.Error()))
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (invalidConn) Rebind(query string) string {
|
|
return query
|
|
}
|
|
|
|
func (invalidConn) ExecContext(ctx context.Context, query string, args ...interface{}) (sql.Result, error) {
|
|
return nil, DatabaseUnavailableError
|
|
}
|
|
|
|
func (invalidConn) NamedExecContext(ctx context.Context, query string, arg interface{}) (sql.Result, error) {
|
|
return nil, DatabaseUnavailableError
|
|
}
|
|
|
|
func (invalidConn) GetContext(ctx context.Context, dest interface{}, query string, args ...interface{}) error {
|
|
return DatabaseUnavailableError
|
|
}
|
|
|
|
func (invalidConn) SelectContext(ctx context.Context, dest interface{}, query string, args ...interface{}) error {
|
|
return DatabaseUnavailableError
|
|
}
|
|
|
|
func (invalidConn) PrepareNamedContext(ctx context.Context, query string) (*sqlx.NamedStmt, error) {
|
|
return nil, DatabaseUnavailableError
|
|
}
|