Files
tasks/common/persistence/sql/sqlplugin/postgresql/plugin.go
T
Nikolay TretyakandGitHub 87ea6512d4 pgx support (#4913)
<!-- Describe what has changed in this PR -->
**What changed?**
`Driver` interface (with two implementations) was added to the
postgresql persistence package in order to support other drivers than
`lib/pq`. Fixes https://github.com/temporalio/temporal/issues/1775

Essentially, this PR does
https://github.com/temporalio/temporal/pull/4914 in a
backward-compatible and extendable way

<!-- Tell your future self why have you made these changes -->
**Why?**
Since `lib/pq` does not support multi-node clusters


<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Existing tests


<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No, since you should explicitly change the driver in your config file.
However, `connectAttributes` depend on the driver (e.g.,
`binary_parameters` is supported only by `lib/pq` and is not a part of
postresql standard), so one should be careful changing drivers in
production.


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No
2023-10-09 17:38:51 -05:00

132 lines
3.8 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package postgresql
import (
"fmt"
"strings"
"github.com/jmoiron/sqlx"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/persistence/sql"
"go.temporal.io/server/common/persistence/sql/sqlplugin"
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql/driver"
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql/session"
"go.temporal.io/server/common/resolver"
)
const (
// PluginName is the name of the plugin
PluginName = "postgres"
PluginNamePGX = "postgres_pgx"
)
var (
defaultDatabaseNames = []string{
"postgres", // normal PostgreSQL default DB name
"defaultdb", // special behavior for Aiven: #1389
}
)
type plugin struct {
d driver.Driver
}
var _ sqlplugin.Plugin = (*plugin)(nil)
func init() {
sql.RegisterPlugin(PluginName, &plugin{&driver.PQDriver{}})
sql.RegisterPlugin(PluginNamePGX, &plugin{&driver.PGXDriver{}})
}
// CreateDB initialize the db object
func (d *plugin) CreateDB(
dbKind sqlplugin.DbKind,
cfg *config.SQL,
r resolver.ServiceResolver,
) (sqlplugin.DB, error) {
conn, err := d.createDBConnection(cfg, r)
if err != nil {
return nil, err
}
db := newDB(dbKind, cfg.DatabaseName, d.d, conn, nil)
return db, nil
}
// CreateAdminDB initialize the adminDB object
func (d *plugin) CreateAdminDB(
dbKind sqlplugin.DbKind,
cfg *config.SQL,
r resolver.ServiceResolver,
) (sqlplugin.AdminDB, error) {
conn, err := d.createDBConnection(cfg, r)
if err != nil {
return nil, err
}
db := newDB(dbKind, cfg.DatabaseName, d.d, conn, nil)
return db, nil
}
// CreateDBConnection creates a returns a reference to a logical connection to the
// underlying SQL database. The returned object is to tied to a single
// SQL database and the object can be used to perform CRUD operations on
// the tables in the database
func (d *plugin) createDBConnection(
cfg *config.SQL,
resolver resolver.ServiceResolver,
) (*sqlx.DB, error) {
if cfg.DatabaseName != "" {
postgresqlSession, err := session.NewSession(cfg, d.d, resolver)
if err != nil {
return nil, err
}
return postgresqlSession.DB, nil
}
// database name not provided
// try defaults
defer func() { cfg.DatabaseName = "" }()
var errors []error
for _, databaseName := range defaultDatabaseNames {
cfg.DatabaseName = databaseName
if postgresqlSession, err := session.NewSession(
cfg,
d.d,
resolver,
); err == nil {
return postgresqlSession.DB, nil
} else {
errors = append(errors, err)
}
}
return nil, serviceerror.NewUnavailable(
fmt.Sprintf("unable to connect to DB, tried default DB names: %v, errors: %v", strings.Join(defaultDatabaseNames, ","), errors),
)
}