mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Nikolay TretyakandGitHub
87ea6512d4
<!-- Describe what has changed in this PR --> **What changed?** `Driver` interface (with two implementations) was added to the postgresql persistence package in order to support other drivers than `lib/pq`. Fixes https://github.com/temporalio/temporal/issues/1775 Essentially, this PR does https://github.com/temporalio/temporal/pull/4914 in a backward-compatible and extendable way <!-- Tell your future self why have you made these changes --> **Why?** Since `lib/pq` does not support multi-node clusters <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Existing tests <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No, since you should explicitly change the driver in your config file. However, `connectAttributes` depend on the driver (e.g., `binary_parameters` is supported only by `lib/pq` and is not a part of postresql standard), so one should be careful changing drivers in production. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No
80 lines
2.5 KiB
Go
80 lines
2.5 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package postgresql
|
|
|
|
import (
|
|
"go.temporal.io/server/common/config"
|
|
"go.temporal.io/server/common/persistence/sql"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql/driver"
|
|
"go.temporal.io/server/common/resolver"
|
|
)
|
|
|
|
const (
|
|
// PluginName is the name of the plugin
|
|
PluginNameV12 = "postgres12"
|
|
PluginNameV12PGX = "postgres12_pgx"
|
|
)
|
|
|
|
type pluginV12 struct {
|
|
plugin
|
|
}
|
|
|
|
var _ sqlplugin.Plugin = (*pluginV12)(nil)
|
|
|
|
func init() {
|
|
sql.RegisterPlugin(PluginNameV12, &pluginV12{plugin{&driver.PQDriver{}}})
|
|
sql.RegisterPlugin(PluginNameV12PGX, &pluginV12{plugin{&driver.PGXDriver{}}})
|
|
|
|
}
|
|
|
|
// CreateDB initialize the db object
|
|
func (d *pluginV12) CreateDB(
|
|
dbKind sqlplugin.DbKind,
|
|
cfg *config.SQL,
|
|
r resolver.ServiceResolver,
|
|
) (sqlplugin.DB, error) {
|
|
conn, err := d.createDBConnection(cfg, r)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
db := newDBV12(dbKind, cfg.DatabaseName, d.d, conn, nil)
|
|
return db, nil
|
|
}
|
|
|
|
// CreateAdminDB initialize the adminDB object
|
|
func (d *pluginV12) CreateAdminDB(
|
|
dbKind sqlplugin.DbKind,
|
|
cfg *config.SQL,
|
|
r resolver.ServiceResolver,
|
|
) (sqlplugin.AdminDB, error) {
|
|
conn, err := d.createDBConnection(cfg, r)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
db := newDBV12(dbKind, cfg.DatabaseName, d.d, conn, nil)
|
|
return db, nil
|
|
}
|