mirror of
https://github.com/hanzoai/team.git
synced 2026-11-01 07:55:31 +00:00
zeekay
8feb24ea1f
The server module named github.com/hanzoai/team/server/v8 — a path that resolves to the retired workspace's repository, not this one — while server/public still published github.com/mattermost/mattermost/server/public. Both are github.com/hanzoteam/server/... now, which is where this code actually lives. That second half is what made the binary unbootable. Upstream's public path stayed claimed by upstream, mattermost-plugin-ai imported it, and the build linked public/model twice; public/plugin's gob.Register then ran twice under one name and panicked at init, before main. Reverting the rename traded the brand for a working binary. Rebranding the plugin alongside it needs no such trade: the agents fork is github.com/hanzoteam/agents/v2 against our public module, so no module named mattermost/mattermost is in the graph at all. Measured: `go list -deps ./cmd/mattermost` names exactly one public/model, and it is ours.
149 lines
6.2 KiB
Go
149 lines
6.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package scheduled_recap
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/hanzoteam/server/server/public/model"
|
|
"github.com/hanzoteam/server/server/public/shared/mlog"
|
|
"github.com/hanzoteam/server/server/public/shared/request"
|
|
"github.com/hanzoteam/server/server/v8/channels/store/storetest/mocks"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type mockScheduledRecapApp struct {
|
|
mock.Mock
|
|
}
|
|
|
|
func (m *mockScheduledRecapApp) CreateRecapFromSchedule(rctx request.CTX, scheduledRecap *model.ScheduledRecap) (*model.Recap, *model.AppError) {
|
|
args := m.Called(rctx, scheduledRecap)
|
|
if args.Get(0) == nil {
|
|
return nil, args.Get(1).(*model.AppError)
|
|
}
|
|
return args.Get(0).(*model.Recap), nil
|
|
}
|
|
|
|
func TestProcessScheduledRecapJobReturnsPersistenceErrors(t *testing.T) {
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
t.Run("mark executed failure", func(t *testing.T) {
|
|
scheduledRecap := testScheduledRecap(true)
|
|
job := &model.Job{Data: map[string]string{"scheduled_recap_id": scheduledRecap.Id}}
|
|
|
|
mockStore := &mocks.Store{}
|
|
mockScheduledStore := &mocks.ScheduledRecapStore{}
|
|
mockStore.On("ScheduledRecap").Return(mockScheduledStore)
|
|
mockScheduledStore.On("Get", scheduledRecap.Id).Return(scheduledRecap, nil)
|
|
mockScheduledStore.On("MarkExecuted", scheduledRecap.Id, mock.AnythingOfType("int64"), mock.AnythingOfType("int64")).Return(errors.New("mark failed"))
|
|
|
|
mockApp := &mockScheduledRecapApp{}
|
|
mockApp.On("CreateRecapFromSchedule", mock.Anything, scheduledRecap).Return(&model.Recap{Id: model.NewId()}, nil)
|
|
|
|
err := processScheduledRecapJob(logger, job, mockStore, mockApp)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "failed to mark scheduled recap as executed")
|
|
mockScheduledStore.AssertExpectations(t)
|
|
mockApp.AssertExpectations(t)
|
|
})
|
|
|
|
t.Run("non recurring disable failure", func(t *testing.T) {
|
|
scheduledRecap := testScheduledRecap(false)
|
|
job := &model.Job{Data: map[string]string{"scheduled_recap_id": scheduledRecap.Id}}
|
|
|
|
mockStore := &mocks.Store{}
|
|
mockScheduledStore := &mocks.ScheduledRecapStore{}
|
|
mockStore.On("ScheduledRecap").Return(mockScheduledStore)
|
|
mockScheduledStore.On("Get", scheduledRecap.Id).Return(scheduledRecap, nil)
|
|
mockScheduledStore.On("MarkExecuted", scheduledRecap.Id, mock.AnythingOfType("int64"), mock.AnythingOfType("int64")).Return(nil)
|
|
mockScheduledStore.On("SetEnabled", scheduledRecap.Id, false).Return(errors.New("disable failed"))
|
|
|
|
mockApp := &mockScheduledRecapApp{}
|
|
mockApp.On("CreateRecapFromSchedule", mock.Anything, scheduledRecap).Return(&model.Recap{Id: model.NewId()}, nil)
|
|
|
|
err := processScheduledRecapJob(logger, job, mockStore, mockApp)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "failed to disable non-recurring scheduled recap")
|
|
mockScheduledStore.AssertExpectations(t)
|
|
mockApp.AssertExpectations(t)
|
|
})
|
|
}
|
|
|
|
func TestProcessScheduledRecapJobDailyLimitSkip(t *testing.T) {
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
limitErr := model.NewAppError("CreateRecapFromSchedule", "app.recap.max_recaps_reached.app_error", nil, "", 429)
|
|
|
|
t.Run("recurring schedule advances but stays enabled", func(t *testing.T) {
|
|
scheduledRecap := testScheduledRecap(true)
|
|
job := &model.Job{Data: map[string]string{"scheduled_recap_id": scheduledRecap.Id}}
|
|
|
|
mockStore := &mocks.Store{}
|
|
mockScheduledStore := &mocks.ScheduledRecapStore{}
|
|
mockRecapStore := &mocks.RecapStore{}
|
|
mockStore.On("ScheduledRecap").Return(mockScheduledStore)
|
|
mockStore.On("Recap").Return(mockRecapStore)
|
|
mockScheduledStore.On("Get", scheduledRecap.Id).Return(scheduledRecap, nil)
|
|
mockScheduledStore.On("MarkExecuted", scheduledRecap.Id, mock.AnythingOfType("int64"), mock.AnythingOfType("int64")).Return(nil)
|
|
mockRecapStore.On("SaveRecap", mock.MatchedBy(func(r *model.Recap) bool {
|
|
return r.Status == model.RecapStatusSkipped && r.ScheduledRecapId == scheduledRecap.Id
|
|
})).Return(&model.Recap{}, nil)
|
|
|
|
mockApp := &mockScheduledRecapApp{}
|
|
mockApp.On("CreateRecapFromSchedule", mock.Anything, scheduledRecap).Return(nil, limitErr)
|
|
|
|
err := processScheduledRecapJob(logger, job, mockStore, mockApp)
|
|
require.NoError(t, err)
|
|
mockScheduledStore.AssertExpectations(t)
|
|
mockRecapStore.AssertExpectations(t)
|
|
mockApp.AssertExpectations(t)
|
|
// A recurring schedule must not be disabled on the skip path.
|
|
mockScheduledStore.AssertNotCalled(t, "SetEnabled", mock.Anything, mock.Anything)
|
|
})
|
|
|
|
t.Run("non recurring schedule is disabled on skip", func(t *testing.T) {
|
|
scheduledRecap := testScheduledRecap(false)
|
|
job := &model.Job{Data: map[string]string{"scheduled_recap_id": scheduledRecap.Id}}
|
|
|
|
mockStore := &mocks.Store{}
|
|
mockScheduledStore := &mocks.ScheduledRecapStore{}
|
|
mockRecapStore := &mocks.RecapStore{}
|
|
mockStore.On("ScheduledRecap").Return(mockScheduledStore)
|
|
mockStore.On("Recap").Return(mockRecapStore)
|
|
mockScheduledStore.On("Get", scheduledRecap.Id).Return(scheduledRecap, nil)
|
|
mockScheduledStore.On("MarkExecuted", scheduledRecap.Id, mock.AnythingOfType("int64"), mock.AnythingOfType("int64")).Return(nil)
|
|
mockScheduledStore.On("SetEnabled", scheduledRecap.Id, false).Return(nil)
|
|
mockRecapStore.On("SaveRecap", mock.MatchedBy(func(r *model.Recap) bool {
|
|
return r.Status == model.RecapStatusSkipped && r.ScheduledRecapId == scheduledRecap.Id
|
|
})).Return(&model.Recap{}, nil)
|
|
|
|
mockApp := &mockScheduledRecapApp{}
|
|
mockApp.On("CreateRecapFromSchedule", mock.Anything, scheduledRecap).Return(nil, limitErr)
|
|
|
|
err := processScheduledRecapJob(logger, job, mockStore, mockApp)
|
|
require.NoError(t, err)
|
|
mockScheduledStore.AssertExpectations(t)
|
|
mockRecapStore.AssertExpectations(t)
|
|
mockApp.AssertExpectations(t)
|
|
})
|
|
}
|
|
|
|
func testScheduledRecap(isRecurring bool) *model.ScheduledRecap {
|
|
return &model.ScheduledRecap{
|
|
Id: model.NewId(),
|
|
UserId: model.NewId(),
|
|
Title: "Scheduled Recap",
|
|
DaysOfWeek: model.EveryDay,
|
|
TimeOfDay: "09:00",
|
|
Timezone: "America/New_York",
|
|
TimePeriod: model.TimePeriodLast24h,
|
|
ChannelMode: model.ChannelModeSpecific,
|
|
ChannelIds: []string{model.NewId()},
|
|
AgentId: "test-agent",
|
|
IsRecurring: isRecurring,
|
|
Enabled: true,
|
|
}
|
|
}
|