mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Harrison HealeyandGitHub
daec1283e5
* Switch Cypress to use shared ESLint config * Run --fix in Cypress * Manually fix remaining lint issues in Cypress * Switch Playwright to use shared ESLint config * Run --fix in Playwright * Manually fix remaining lint issues in Playwright * Install and cache web app deps during Cypress CI builds This also caches the types and client package. That isn't needed currently since it uses prepackaged versions of those, but I imagine we might change that at some point. * Run e2e-tests-check when ESLint plugin is updated * Change E2E test GHA caching to cache all of web app node_modules * Fix mismatch between cache save and restore * Try bumping cache keys * Copy step to install dependencies to server.run_cypress.sh I don't know how this must've worked before, but if this fixes the issue, it seems like neither Cypress nor Playwright actually use the cached depenendencies. * Try disabling caching entirely for Cypress tests * Try bypassing makefile? * Try also manually building dependencies in run_specs.sh I don't know why this appears to duplicate run_cypress.sh and run_playwright.sh, both of which are called run_test.sh which might not be used any more as best I can tell. * Try installing the web app dependencies in yet another place * Disable the extra steps in server.prepare.sh specifically for Cypress * Revert changes to update cache key and disable web app depenedency cache on Cypress builds
139 lines
4.8 KiB
TypeScript
139 lines
4.8 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import type {Client4} from '@mattermost/client';
|
|
import type {ServerChannel} from '@mattermost/types/channels';
|
|
import type {FileUploadResponse} from '@mattermost/types/files';
|
|
import type {Team} from '@mattermost/types/teams';
|
|
import type {UserProfile} from '@mattermost/types/users';
|
|
|
|
import {expect, test, getFileFromAsset, getBlobFromAsset} from '@mattermost/playwright-lib';
|
|
|
|
import {FileUploadResponseSchema} from './schema';
|
|
|
|
let userClient: Client4;
|
|
let user: UserProfile;
|
|
let team: Team;
|
|
let townSquareChannel: ServerChannel;
|
|
|
|
const filename = 'mattermost-icon_128x128.png';
|
|
const file = getFileFromAsset(filename);
|
|
const blob = getBlobFromAsset(filename);
|
|
|
|
test.beforeEach(async ({pw}) => {
|
|
({userClient, user, team} = await pw.initSetup());
|
|
townSquareChannel = await userClient.getChannelByName(team.id, 'town-square');
|
|
});
|
|
|
|
test('should succeed with File', async ({pw}) => {
|
|
// # Prepare data with File
|
|
const clientId = pw.random.id();
|
|
const formData = new FormData();
|
|
formData.set('channel_id', townSquareChannel.id);
|
|
formData.set('client_ids', clientId);
|
|
formData.set('files', file, filename);
|
|
|
|
// # Do upload then validate the response
|
|
const data = await userClient.uploadFile(formData);
|
|
validateFileUploadResponse(data, clientId, user.id, townSquareChannel.id);
|
|
});
|
|
|
|
test('should succeed with Blob', async ({pw}) => {
|
|
// # Prepare data with Blob
|
|
const clientId = pw.random.id();
|
|
const formData = new FormData();
|
|
formData.set('channel_id', townSquareChannel.id);
|
|
formData.set('client_ids', clientId);
|
|
formData.set('files', blob, filename);
|
|
|
|
// # Do upload then validate the response
|
|
const data = await userClient.uploadFile(formData);
|
|
validateFileUploadResponse(data, clientId, user.id, townSquareChannel.id);
|
|
});
|
|
|
|
test('should succeed even with channel_id only', async () => {
|
|
// # Set without channel ID
|
|
const formData = new FormData();
|
|
formData.set('channel_id', townSquareChannel.id);
|
|
|
|
// # Do upload then validate the response
|
|
const data = await userClient.uploadFile(formData);
|
|
|
|
// * Validate that it doe snot throw an error
|
|
const validate = () => FileUploadResponseSchema.parse(data);
|
|
expect(validate).not.toThrow();
|
|
|
|
// * Validate that file_infos and client_ids are as expected
|
|
expect(data.client_ids).toMatchObject([]);
|
|
expect(data.file_infos.length).toBe(0);
|
|
});
|
|
|
|
test('should fail on invalid channel ID', async ({pw}) => {
|
|
const clientId = pw.random.id();
|
|
|
|
// # Set with invalid channel ID
|
|
let formData = new FormData();
|
|
formData.set('channel_id', 'invalid.channel.id');
|
|
formData.set('client_ids', clientId);
|
|
formData.set('files', file, filename);
|
|
|
|
await expect(userClient.uploadFile(formData)).rejects.toThrowError(
|
|
'Invalid or missing channel_id parameter in request URL.',
|
|
);
|
|
|
|
// # Set without channel ID
|
|
formData = new FormData();
|
|
formData.set('client_ids', clientId);
|
|
formData.set('files', file, filename);
|
|
|
|
await expect(userClient.uploadFile(formData)).rejects.toThrowError(
|
|
'Invalid or missing channel_id in request body.',
|
|
);
|
|
});
|
|
|
|
test('should fail on missing files', async ({pw}) => {
|
|
const clientId = pw.random.id();
|
|
|
|
// # Set with invalid channel ID
|
|
const formData = new FormData();
|
|
formData.set('channel_id', townSquareChannel.id);
|
|
formData.set('client_ids', clientId);
|
|
|
|
await expect(userClient.uploadFile(formData)).rejects.toThrowError(
|
|
'Unable to upload file(s). Have 1 client_ids for 0 files.',
|
|
);
|
|
});
|
|
|
|
test('should fail on incorrect order setting up FormData', async ({pw}) => {
|
|
const clientId = pw.random.id();
|
|
|
|
// # Set with files before client_ids
|
|
const formData = new FormData();
|
|
formData.set('channel_id', townSquareChannel.id);
|
|
formData.set('files', file, filename);
|
|
formData.set('client_ids', clientId);
|
|
|
|
await expect(userClient.uploadFile(formData)).rejects.toThrowError(
|
|
'Invalid or missing client_ids in request body.',
|
|
);
|
|
});
|
|
|
|
function validateFileUploadResponse(data: FileUploadResponse, clientId: string, userId: string, channelId: string) {
|
|
// * Validate the schema
|
|
const validate = () => FileUploadResponseSchema.parse(data);
|
|
expect(validate).not.toThrow();
|
|
|
|
// * Validate that file_infos and client_ids are as expected
|
|
expect(data.client_ids).toMatchObject([clientId]);
|
|
expect(data.file_infos.length).toBe(1);
|
|
|
|
// * Validate important contents of file_infos
|
|
const fileInfo = data.file_infos[0];
|
|
expect(fileInfo.user_id).toBe(userId);
|
|
expect(fileInfo.channel_id).toBe(channelId);
|
|
expect(fileInfo.delete_at).toBe(0);
|
|
expect(fileInfo.extension).toBe('png');
|
|
expect(fileInfo.mime_type).toBe('image/png');
|
|
expect(fileInfo.archived).toBe(false);
|
|
}
|