mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
zeekay
8feb24ea1f
The server module named github.com/hanzoai/team/server/v8 — a path that resolves to the retired workspace's repository, not this one — while server/public still published github.com/mattermost/mattermost/server/public. Both are github.com/hanzoteam/server/... now, which is where this code actually lives. That second half is what made the binary unbootable. Upstream's public path stayed claimed by upstream, mattermost-plugin-ai imported it, and the build linked public/model twice; public/plugin's gob.Register then ran twice under one name and panicked at init, before main. Reverting the rename traded the brand for a working binary. Rebranding the plugin alongside it needs no such trade: the agents fork is github.com/hanzoteam/agents/v2 against our public module, so no module named mattermost/mattermost is in the graph at all. Measured: `go list -deps ./cmd/mattermost` names exactly one public/model, and it is ours.
421 lines
15 KiB
Go
421 lines
15 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/hanzoteam/server/server/public/model"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestUpdateScheduledPost(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
th := SetupConfig(t, func(cfg *model.Config) {
|
|
cfg.FeatureFlags.RecurringScheduledPosts = true
|
|
}).InitBasic(t)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicenseSKU(model.LicenseShortSkuProfessional))
|
|
|
|
t.Run("should not allow updating a scheduled post not belonging to the user", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "this is a scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
}
|
|
createdScheduledPost, _, err := th.Client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
|
|
originalMessage := createdScheduledPost.Message
|
|
originalScheduledAt := createdScheduledPost.ScheduledAt
|
|
|
|
createdScheduledPost.ScheduledAt = model.GetMillis() + 9999999
|
|
createdScheduledPost.Message = "Updated Message!!!"
|
|
|
|
// Switch to BasicUser2
|
|
th.LoginBasic2(t)
|
|
|
|
_, resp, err := th.Client.UpdateScheduledPost(context.Background(), createdScheduledPost)
|
|
require.Error(t, err)
|
|
CheckForbiddenStatus(t, resp)
|
|
|
|
// Switch back to original user and verify the post wasn't modified
|
|
th.LoginBasic(t)
|
|
|
|
fetchedPost, err := th.App.Srv().Store().ScheduledPost().Get(createdScheduledPost.Id)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, fetchedPost)
|
|
require.Equal(t, originalMessage, fetchedPost.Message)
|
|
require.Equal(t, originalScheduledAt, fetchedPost.ScheduledAt)
|
|
})
|
|
|
|
t.Run("should clear error state when rescheduling an existing scheduled post", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "weekly recurring scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: model.ScheduledPostRepeatTypeWeekly,
|
|
RepeatTimezone: "UTC",
|
|
}
|
|
createdScheduledPost, _, err := th.Client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
|
|
createdScheduledPost.ErrorCode = model.ScheduledPostErrorUnableToSend
|
|
createdScheduledPost.ProcessedAt = model.GetMillis()
|
|
require.NoError(t, th.App.Srv().Store().ScheduledPost().UpdatedScheduledPost(createdScheduledPost))
|
|
|
|
createdScheduledPost.ScheduledAt = model.GetMillis() + 300000
|
|
createdScheduledPost.RepeatTimezone = "America/New_York"
|
|
|
|
updatedScheduledPost, _, err := th.Client.UpdateScheduledPost(context.Background(), createdScheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updatedScheduledPost)
|
|
require.Empty(t, updatedScheduledPost.ErrorCode)
|
|
require.Zero(t, updatedScheduledPost.ProcessedAt)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, updatedScheduledPost.RepeatType)
|
|
require.Equal(t, "America/New_York", updatedScheduledPost.RepeatTimezone)
|
|
|
|
fetchedPost, err := th.App.Srv().Store().ScheduledPost().Get(createdScheduledPost.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, fetchedPost.RepeatType)
|
|
require.Equal(t, "America/New_York", fetchedPost.RepeatTimezone)
|
|
})
|
|
|
|
t.Run("should preserve recurrence when the update omits the repeat fields", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "weekly recurring scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: model.ScheduledPostRepeatTypeWeekly,
|
|
RepeatTimezone: "America/New_York",
|
|
}
|
|
createdScheduledPost, _, err := th.Client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
|
|
// Clients that predate recurring scheduled posts leave the repeat fields out of their
|
|
// update payloads. Marshalling a model.ScheduledPost always emits them, so the payload
|
|
// has to be built by hand to reproduce what those clients send.
|
|
payload := fmt.Sprintf(
|
|
`{"id":"%s","create_at":%d,"user_id":"%s","channel_id":"%s","message":"rescheduled by an old client","scheduled_at":%d}`,
|
|
createdScheduledPost.Id,
|
|
createdScheduledPost.CreateAt,
|
|
th.BasicUser.Id,
|
|
th.BasicChannel.Id,
|
|
model.GetMillis()+300000,
|
|
)
|
|
|
|
httpResp, err := th.Client.DoAPIPut(context.Background(), "/posts/schedule/"+createdScheduledPost.Id, payload)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, httpResp.StatusCode)
|
|
|
|
var updatedScheduledPost model.ScheduledPost
|
|
require.NoError(t, json.NewDecoder(httpResp.Body).Decode(&updatedScheduledPost))
|
|
require.NoError(t, httpResp.Body.Close())
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, updatedScheduledPost.RepeatType)
|
|
require.Equal(t, "America/New_York", updatedScheduledPost.RepeatTimezone)
|
|
|
|
fetchedPost, err := th.App.Srv().Store().ScheduledPost().Get(createdScheduledPost.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "rescheduled by an old client", fetchedPost.Message)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, fetchedPost.RepeatType)
|
|
require.Equal(t, "America/New_York", fetchedPost.RepeatTimezone)
|
|
})
|
|
|
|
t.Run("should stop recurrence when the update sends empty repeat fields", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "weekly recurring scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: model.ScheduledPostRepeatTypeWeekly,
|
|
RepeatTimezone: "America/New_York",
|
|
}
|
|
createdScheduledPost, _, err := th.Client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
|
|
createdScheduledPost.RepeatType = model.ScheduledPostRepeatTypeNone
|
|
createdScheduledPost.RepeatTimezone = ""
|
|
|
|
updatedScheduledPost, _, err := th.Client.UpdateScheduledPost(context.Background(), createdScheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updatedScheduledPost)
|
|
require.Empty(t, updatedScheduledPost.RepeatType)
|
|
require.Empty(t, updatedScheduledPost.RepeatTimezone)
|
|
|
|
fetchedPost, err := th.App.Srv().Store().ScheduledPost().Get(createdScheduledPost.Id)
|
|
require.NoError(t, err)
|
|
require.Empty(t, fetchedPost.RepeatType)
|
|
require.Empty(t, fetchedPost.RepeatTimezone)
|
|
})
|
|
}
|
|
|
|
func TestDeleteScheduledPost(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicenseSKU(model.LicenseShortSkuProfessional))
|
|
|
|
t.Run("should not allow deleting a scheduled post not belonging to the user", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "this is a scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
}
|
|
createdScheduledPost, _, err := th.Client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
|
|
// Switch to BasicUser2
|
|
th.LoginBasic2(t)
|
|
|
|
_, resp, err := th.Client.DeleteScheduledPost(context.Background(), createdScheduledPost.Id)
|
|
require.Error(t, err)
|
|
CheckForbiddenStatus(t, resp)
|
|
|
|
// Switch back to original user and verify the post wasn't deleted
|
|
th.LoginBasic(t)
|
|
|
|
fetchedPost, err := th.App.Srv().Store().ScheduledPost().Get(createdScheduledPost.Id)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, fetchedPost)
|
|
require.Equal(t, createdScheduledPost.Id, fetchedPost.Id)
|
|
require.Equal(t, createdScheduledPost.Message, fetchedPost.Message)
|
|
})
|
|
}
|
|
|
|
func TestCreateScheduledPost(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
th := SetupConfig(t, func(cfg *model.Config) {
|
|
cfg.FeatureFlags.RecurringScheduledPosts = true
|
|
}).InitBasic(t)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicenseSKU(model.LicenseShortSkuProfessional))
|
|
|
|
client := th.Client
|
|
|
|
t.Run("base case", func(t *testing.T) {
|
|
userId := model.NewId()
|
|
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: userId,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "this is a scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000, // 100 seconds in the future
|
|
}
|
|
createdScheduledPost, _, err := client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, createdScheduledPost)
|
|
})
|
|
|
|
t.Run("should not allow created scheduled post in read-only channel", func(t *testing.T) {
|
|
channel := th.CreatePublicChannel(t)
|
|
th.AddUserToChannel(t, th.BasicUser, channel)
|
|
|
|
channelModerationPatches := []*model.ChannelModerationPatch{
|
|
{
|
|
Name: new(model.PermissionCreatePost.Id),
|
|
Roles: &model.ChannelModeratedRolesPatch{
|
|
Guests: new(true),
|
|
Members: new(false),
|
|
},
|
|
},
|
|
}
|
|
|
|
err := th.App.SetPhase2PermissionsMigrationStatus(true)
|
|
require.NoError(t, err)
|
|
|
|
_, appErr := th.App.PatchChannelModerationsForChannel(th.Context, channel, channelModerationPatches)
|
|
require.Nil(t, appErr)
|
|
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "this is a scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000, // 100 seconds in the future
|
|
}
|
|
createdScheduledPost, _, httpErr := client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.Error(t, httpErr)
|
|
require.Contains(t, httpErr.Error(), "You do not have the appropriate permissions.")
|
|
require.Nil(t, createdScheduledPost)
|
|
})
|
|
|
|
t.Run("weekly recurring persists repeat fields", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "weekly message",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: model.ScheduledPostRepeatTypeWeekly,
|
|
RepeatTimezone: "America/New_York",
|
|
}
|
|
created, _, err := client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, created)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, created.RepeatType)
|
|
require.Equal(t, "America/New_York", created.RepeatTimezone)
|
|
})
|
|
|
|
t.Run("weekly recurring rejects file attachments", func(t *testing.T) {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "weekly message with a file",
|
|
FileIds: model.StringArray{model.NewId()},
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: model.ScheduledPostRepeatTypeWeekly,
|
|
RepeatTimezone: "America/New_York",
|
|
}
|
|
created, resp, err := client.CreateScheduledPost(context.Background(), scheduledPost)
|
|
require.Error(t, err)
|
|
CheckBadRequestStatus(t, resp)
|
|
require.Nil(t, created)
|
|
})
|
|
}
|
|
|
|
func TestScheduledPostRecurringFeatureFlag(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
// SetupConfig also makes feature flags writable, so the subtests below can toggle the flag.
|
|
th := SetupConfig(t, func(cfg *model.Config) {
|
|
cfg.FeatureFlags.RecurringScheduledPosts = false
|
|
}).InitBasic(t)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicenseSKU(model.LicenseShortSkuProfessional))
|
|
|
|
setFlag := func(t *testing.T, enabled bool) {
|
|
t.Helper()
|
|
th.App.UpdateConfig(func(cfg *model.Config) {
|
|
cfg.FeatureFlags.RecurringScheduledPosts = enabled
|
|
})
|
|
}
|
|
|
|
newScheduledPost := func(repeatType string) *model.ScheduledPost {
|
|
scheduledPost := &model.ScheduledPost{
|
|
Draft: model.Draft{
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "recurring feature flag scheduled post",
|
|
},
|
|
ScheduledAt: model.GetMillis() + 100000,
|
|
RepeatType: repeatType,
|
|
}
|
|
if repeatType == model.ScheduledPostRepeatTypeWeekly {
|
|
scheduledPost.RepeatTimezone = "UTC"
|
|
}
|
|
return scheduledPost
|
|
}
|
|
|
|
t.Run("creating a recurring scheduled post is rejected when the flag is off", func(t *testing.T) {
|
|
setFlag(t, false)
|
|
|
|
created, resp, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeWeekly))
|
|
require.Error(t, err)
|
|
CheckBadRequestStatus(t, resp)
|
|
CheckErrorID(t, err, "app.scheduled_post.recurring_disabled.app_error")
|
|
require.Nil(t, created)
|
|
})
|
|
|
|
t.Run("creating a one-shot scheduled post is still allowed when the flag is off", func(t *testing.T) {
|
|
setFlag(t, false)
|
|
|
|
created, _, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeNone))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, created)
|
|
})
|
|
|
|
t.Run("creating a recurring scheduled post succeeds when the flag is on", func(t *testing.T) {
|
|
setFlag(t, true)
|
|
|
|
created, _, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeWeekly))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, created)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, created.RepeatType)
|
|
})
|
|
|
|
t.Run("converting a recurring scheduled post to one-shot is allowed when the flag is off", func(t *testing.T) {
|
|
setFlag(t, true)
|
|
created, _, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeWeekly))
|
|
require.NoError(t, err)
|
|
|
|
setFlag(t, false)
|
|
created.RepeatType = model.ScheduledPostRepeatTypeNone
|
|
created.RepeatTimezone = ""
|
|
|
|
updated, _, err := th.Client.UpdateScheduledPost(context.Background(), created)
|
|
require.NoError(t, err)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeNone, updated.RepeatType)
|
|
})
|
|
|
|
t.Run("editing an existing recurring scheduled post keeps repeating when the flag is off", func(t *testing.T) {
|
|
setFlag(t, true)
|
|
created, _, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeWeekly))
|
|
require.NoError(t, err)
|
|
|
|
setFlag(t, false)
|
|
created.Message = "updated message for an existing weekly series"
|
|
|
|
updated, _, err := th.Client.UpdateScheduledPost(context.Background(), created)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "updated message for an existing weekly series", updated.Message)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeWeekly, updated.RepeatType)
|
|
})
|
|
|
|
t.Run("converting a one-shot scheduled post to recurring is rejected when the flag is off", func(t *testing.T) {
|
|
setFlag(t, false)
|
|
created, _, err := th.Client.CreateScheduledPost(context.Background(), newScheduledPost(model.ScheduledPostRepeatTypeNone))
|
|
require.NoError(t, err)
|
|
|
|
created.RepeatType = model.ScheduledPostRepeatTypeWeekly
|
|
created.RepeatTimezone = "UTC"
|
|
|
|
_, resp, err := th.Client.UpdateScheduledPost(context.Background(), created)
|
|
require.Error(t, err)
|
|
CheckBadRequestStatus(t, resp)
|
|
CheckErrorID(t, err, "app.scheduled_post.recurring_disabled.app_error")
|
|
|
|
fetched, storeErr := th.App.Srv().Store().ScheduledPost().Get(created.Id)
|
|
require.NoError(t, storeErr)
|
|
require.Equal(t, model.ScheduledPostRepeatTypeNone, fetched.RepeatType)
|
|
})
|
|
}
|