mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Jesse HallamandGitHub
edf2075381
* MM-68149: upgrade to Go 1.26.2 Update go directive in go.mod and .go-version. * MM-68149: replace pointer helpers with Go 1.26 new() Go 1.26 extends the built-in new() to accept an initial value expression, making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x) redundant. Replace every call site with new(x) and remove the now-unused helper functions and their //go:fix inline directives. * MM-68149: apply go fix for reflect API and format-string changes - reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26) - reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields() and the equivalent for Methods() and interface types - Fix format-string concatenation and variadic-arg mismatches flagged by go vet * MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder Go 1.26 ships a new image/jpeg encoder that produces slightly different output. Regenerate all JPEG fixture files and switch the comparison helpers from byte-equality to pixel-level comparison with a small per-channel tolerance, so minor encoder drift across patch versions is handled automatically. Add -update-fixtures flag to make it easy to regenerate fixtures after future major Go upgrades. Document the update procedure in tests/README.md. * MM-68149: CI check that go fix ./... produces no changes * Fix real bugs flagged by CodeRabbit review - group.go: set newGroup.MemberCount not group.MemberCount (member count was populated on the wrong variable and lost before publish/return) - file_test.go: guard compareImage(GetFilePreview) on the preview slice length, not the thumbnail slice length (copy-paste error) - config_test.go: remove duplicate MinimumLength assignment * fixup! Fix real bugs flagged by CodeRabbit review
73 lines
1.6 KiB
Go
73 lines
1.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestDownloadFromURL(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
th := Setup(t)
|
|
|
|
app := th.App
|
|
app.Config().PluginSettings.AllowInsecureDownloadURL = new(true)
|
|
|
|
// To keep track of how many times an endpoint is retried. This needs to be reset
|
|
// for each test run.
|
|
retries := 0
|
|
|
|
mux := http.NewServeMux()
|
|
mux.HandleFunc("/succeeds-after-retry", func(w http.ResponseWriter, r *http.Request) {
|
|
if retries < 2 {
|
|
http.Error(w, "Request Timed out", http.StatusGatewayTimeout)
|
|
retries++
|
|
return
|
|
}
|
|
|
|
_, _ = w.Write([]byte("Your request is successful."))
|
|
})
|
|
|
|
mux.HandleFunc("/fails-forever", func(w http.ResponseWriter, r *http.Request) {
|
|
http.Error(w, "This would fail forever", http.StatusInternalServerError)
|
|
})
|
|
|
|
testServer := httptest.NewServer(mux)
|
|
|
|
tests := []struct {
|
|
name string
|
|
downloadURL string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "Should succeed after two retries",
|
|
downloadURL: fmt.Sprintf("%s/succeeds-after-retry", testServer.URL),
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "Should not retry forever",
|
|
downloadURL: fmt.Sprintf("%s/fails-forever", testServer.URL),
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
retries = 0 // reset the retires
|
|
_, err := th.App.DownloadFromURL(tt.downloadURL)
|
|
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|