mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
zeekay
8feb24ea1f
The server module named github.com/hanzoai/team/server/v8 — a path that resolves to the retired workspace's repository, not this one — while server/public still published github.com/mattermost/mattermost/server/public. Both are github.com/hanzoteam/server/... now, which is where this code actually lives. That second half is what made the binary unbootable. Upstream's public path stayed claimed by upstream, mattermost-plugin-ai imported it, and the build linked public/model twice; public/plugin's gob.Register then ran twice under one name and panicked at init, before main. Reverting the rename traded the brand for a working binary. Rebranding the plugin alongside it needs no such trade: the agents fork is github.com/hanzoteam/agents/v2 against our public module, so no module named mattermost/mattermost is in the graph at all. Measured: `go list -deps ./cmd/mattermost` names exactly one public/model, and it is ours.
172 lines
5.2 KiB
Go
172 lines
5.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/hanzoteam/server/server/public/shared/mlog"
|
|
"github.com/hanzoteam/server/server/v8/channels/utils/fileutils"
|
|
)
|
|
|
|
func TestBuildPrepackagedPlugin(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
testsPath, found := fileutils.FindDir("tests")
|
|
require.True(t, found, "tests directory not found")
|
|
|
|
// Read public key file once for all subtests
|
|
publicKeyData, err := os.ReadFile(filepath.Join(testsPath, "development-public-key.asc"))
|
|
require.NoError(t, err)
|
|
|
|
t.Run("valid plugin with signature and icon data", func(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
// Import development public key for signature verification
|
|
appErr := th.App.AddPublicKey("development-public-key.asc", bytes.NewBuffer(publicKeyData))
|
|
require.Nil(t, appErr)
|
|
|
|
// Create test plugin path
|
|
pluginPath := &pluginSignaturePath{
|
|
pluginID: "testplugin",
|
|
bundlePath: filepath.Join(testsPath, "testplugin.tar.gz"),
|
|
signaturePath: filepath.Join(testsPath, "testplugin.tar.gz.sig"),
|
|
}
|
|
|
|
// Open plugin file
|
|
pluginFile, err := os.Open(pluginPath.bundlePath)
|
|
require.NoError(t, err)
|
|
defer pluginFile.Close()
|
|
|
|
// Create logger
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
// Test buildPrepackagedPlugin
|
|
plugin, pluginDir, err := th.App.ch.buildPrepackagedPlugin(logger, pluginPath, pluginFile, t.TempDir())
|
|
require.NoError(t, err)
|
|
require.NotNil(t, plugin)
|
|
require.NotEmpty(t, pluginDir)
|
|
|
|
// Verify plugin fields
|
|
assert.NotNil(t, plugin.Manifest)
|
|
assert.Equal(t, pluginPath.bundlePath, plugin.Path)
|
|
assert.Equal(t, pluginPath.signaturePath, plugin.SignaturePath)
|
|
assert.Equal(t, "testplugin", plugin.Manifest.Id)
|
|
|
|
// Verify plugin has icon data loaded
|
|
assert.Equal(t, "assets/icon.svg", plugin.Manifest.IconPath)
|
|
assert.NotEmpty(t, plugin.IconData, "Plugin should have icon data loaded")
|
|
})
|
|
|
|
t.Run("missing signature file", func(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
// Create plugin path with empty signature path
|
|
pluginPath := &pluginSignaturePath{
|
|
pluginID: "testplugin",
|
|
bundlePath: filepath.Join(testsPath, "testplugin.tar.gz"),
|
|
signaturePath: "", // Empty signature path
|
|
}
|
|
|
|
pluginFile, err := os.Open(pluginPath.bundlePath)
|
|
require.NoError(t, err)
|
|
defer pluginFile.Close()
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
plugin, pluginDir, err := th.App.ch.buildPrepackagedPlugin(logger, pluginPath, pluginFile, t.TempDir())
|
|
require.Error(t, err)
|
|
require.Nil(t, plugin)
|
|
require.Empty(t, pluginDir)
|
|
|
|
assert.Contains(t, err.Error(), "Prepackaged plugin missing required signature file")
|
|
})
|
|
|
|
t.Run("nonexistent signature file", func(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
pluginPath := &pluginSignaturePath{
|
|
pluginID: "testplugin",
|
|
bundlePath: filepath.Join(testsPath, "testplugin.tar.gz"),
|
|
signaturePath: "/nonexistent/signature.sig",
|
|
}
|
|
|
|
pluginFile, err := os.Open(pluginPath.bundlePath)
|
|
require.NoError(t, err)
|
|
defer pluginFile.Close()
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
plugin, pluginDir, err := th.App.ch.buildPrepackagedPlugin(logger, pluginPath, pluginFile, t.TempDir())
|
|
require.Error(t, err)
|
|
require.Nil(t, plugin)
|
|
require.Empty(t, pluginDir)
|
|
|
|
assert.Contains(t, err.Error(), "Failed to open prepackaged plugin signature")
|
|
})
|
|
|
|
t.Run("empty signature file", func(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
// Import development public key
|
|
appErr := th.App.AddPublicKey("development-public-key.asc", bytes.NewBuffer(publicKeyData))
|
|
require.Nil(t, appErr)
|
|
|
|
// Create empty signature file
|
|
tmpSig, err := os.CreateTemp("", "*.sig")
|
|
require.NoError(t, err)
|
|
tmpSig.Close()
|
|
defer os.Remove(tmpSig.Name())
|
|
|
|
pluginPath := &pluginSignaturePath{
|
|
pluginID: "testplugin",
|
|
bundlePath: filepath.Join(testsPath, "testplugin.tar.gz"),
|
|
signaturePath: tmpSig.Name(),
|
|
}
|
|
|
|
pluginFile, err := os.Open(pluginPath.bundlePath)
|
|
require.NoError(t, err)
|
|
defer pluginFile.Close()
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
plugin, pluginDir, err := th.App.ch.buildPrepackagedPlugin(logger, pluginPath, pluginFile, t.TempDir())
|
|
require.Error(t, err)
|
|
require.Nil(t, plugin)
|
|
require.Empty(t, pluginDir)
|
|
|
|
assert.Contains(t, err.Error(), "Prepackaged plugin signature verification failed")
|
|
})
|
|
|
|
t.Run("signature verification failure", func(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
// Use mismatched plugin and signature (testplugin.tar.gz with testplugin2.tar.gz.sig)
|
|
pluginPath := &pluginSignaturePath{
|
|
pluginID: "testplugin",
|
|
bundlePath: filepath.Join(testsPath, "testplugin.tar.gz"),
|
|
signaturePath: filepath.Join(testsPath, "testplugin2.tar.gz.sig"),
|
|
}
|
|
|
|
pluginFile, err := os.Open(pluginPath.bundlePath)
|
|
require.NoError(t, err)
|
|
defer pluginFile.Close()
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
plugin, pluginDir, err := th.App.ch.buildPrepackagedPlugin(logger, pluginPath, pluginFile, t.TempDir())
|
|
require.Error(t, err)
|
|
require.Nil(t, plugin)
|
|
require.Empty(t, pluginDir)
|
|
|
|
assert.Contains(t, err.Error(), "Prepackaged plugin signature verification failed")
|
|
})
|
|
}
|