mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
zeekay
8feb24ea1f
The server module named github.com/hanzoai/team/server/v8 — a path that resolves to the retired workspace's repository, not this one — while server/public still published github.com/mattermost/mattermost/server/public. Both are github.com/hanzoteam/server/... now, which is where this code actually lives. That second half is what made the binary unbootable. Upstream's public path stayed claimed by upstream, mattermost-plugin-ai imported it, and the build linked public/model twice; public/plugin's gob.Register then ran twice under one name and panicked at init, before main. Reverting the rename traded the brand for a working binary. Rebranding the plugin alongside it needs no such trade: the agents fork is github.com/hanzoteam/agents/v2 against our public module, so no module named mattermost/mattermost is in the graph at all. Measured: `go list -deps ./cmd/mattermost` names exactly one public/model, and it is ours.
731 lines
26 KiB
Go
731 lines
26 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package commands
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
"github.com/hanzoteam/server/server/public/model"
|
|
"github.com/hanzoteam/server/server/v8/channels/api4"
|
|
"github.com/hanzoteam/server/server/v8/channels/app"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/hanzoteam/server/server/v8/cmd/mmctl/client"
|
|
"github.com/hanzoteam/server/server/v8/cmd/mmctl/printer"
|
|
)
|
|
|
|
func (s *MmctlE2ETestSuite) TestListChannelsCmdF() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
var assertChannelNames = func(want []string, lines []any) {
|
|
var got []string
|
|
for i := range lines {
|
|
got = append(got, lines[i].(*model.Channel).Name)
|
|
}
|
|
|
|
s.ElementsMatch(want, got)
|
|
}
|
|
|
|
s.Run("List channels/Client", func() {
|
|
printer.Clean()
|
|
wantNames := append(
|
|
s.th.App.DefaultChannelNames(s.th.Context),
|
|
[]string{
|
|
s.th.BasicChannel.Name,
|
|
s.th.BasicChannel2.Name,
|
|
s.th.BasicDeletedChannel.Name,
|
|
s.th.BasicPrivateChannel.Name,
|
|
}...,
|
|
)
|
|
|
|
err := listChannelsCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name})
|
|
s.Require().Nil(err)
|
|
s.Equal(6, len(printer.GetLines()))
|
|
assertChannelNames(wantNames, printer.GetLines())
|
|
s.Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("List channels", func(c client.Client) {
|
|
printer.Clean()
|
|
wantNames := append(
|
|
s.th.App.DefaultChannelNames(s.th.Context),
|
|
[]string{
|
|
s.th.BasicChannel.Name,
|
|
s.th.BasicChannel2.Name,
|
|
s.th.BasicDeletedChannel.Name,
|
|
s.th.BasicPrivateChannel.Name,
|
|
s.th.BasicPrivateChannel2.Name,
|
|
}...,
|
|
)
|
|
|
|
err := listChannelsCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name})
|
|
s.Require().Nil(err)
|
|
s.Equal(7, len(printer.GetLines()))
|
|
assertChannelNames(wantNames, printer.GetLines())
|
|
s.Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForAllClients("List channels for non existent team", func(c client.Client) {
|
|
printer.Clean()
|
|
team := "non-existent-team"
|
|
|
|
err := listChannelsCmdF(c, &cobra.Command{}, []string{team})
|
|
s.Require().ErrorContains(err, "unable to find team \""+team+"\"")
|
|
s.Len(printer.GetErrorLines(), 1)
|
|
s.Equal("unable to find team \""+team+"\"", printer.GetErrorLines()[0])
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestSearchChannelCmd() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
s.RunForAllClients("Search nonexistent channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := searchChannelCmdF(c, &cobra.Command{}, []string{"test"})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal(`channel "test" was not found in any team`, err.Error())
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Search existing channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := searchChannelCmdF(c, &cobra.Command{}, []string{s.th.BasicChannel.Name})
|
|
s.Require().Nil(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
actualChannel, ok := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().True(ok)
|
|
s.Require().Equal(s.th.BasicChannel.Name, actualChannel.Name)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Search existing channel of a team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("team", s.th.BasicChannel.TeamId, "")
|
|
|
|
err := searchChannelCmdF(c, cmd, []string{s.th.BasicChannel.Name})
|
|
s.Require().Nil(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
actualChannel, ok := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().True(ok)
|
|
s.Require().Equal(s.th.BasicChannel.Name, actualChannel.Name)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Search existing channel that does not belong to a team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
testTeamName := api4.GenerateTestTeamName()
|
|
|
|
team, appErr := s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: testTeamName,
|
|
DisplayName: "dn_" + testTeamName,
|
|
Type: model.TeamOpen,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("team", team.Id, "")
|
|
|
|
err := searchChannelCmdF(c, cmd, []string{s.th.BasicChannel.Name})
|
|
s.Require().NotNil(err)
|
|
s.Require().ErrorContains(err, `Channel does not exist.`)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.Run("Search existing channel should fail for Client", func() {
|
|
printer.Clean()
|
|
|
|
err := searchChannelCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicChannel.Name})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal(fmt.Sprintf("channel \"%s\" was not found in any team", s.th.BasicChannel.Name), err.Error())
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestCreateChannelCmd() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
s.RunForAllClients("create channel successfully", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
cmd := &cobra.Command{}
|
|
channelName := model.NewRandomString(10)
|
|
teamName := s.th.BasicTeam.Name
|
|
channelDisplayName := "channelDisplayName"
|
|
cmd.Flags().String("name", channelName, "channel name")
|
|
cmd.Flags().String("team", teamName, "team name")
|
|
cmd.Flags().String("display-name", channelDisplayName, "display name")
|
|
|
|
err := createChannelCmdF(c, cmd, []string{})
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
|
|
printerChannel := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().Equal(channelName, printerChannel.Name)
|
|
s.Require().Equal(s.th.BasicTeam.Id, printerChannel.TeamId)
|
|
|
|
newChannel, err := s.th.App.GetChannelByName(s.th.Context, channelName, s.th.BasicTeam.Id, false)
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(channelName, newChannel.Name)
|
|
s.Require().Equal(channelDisplayName, newChannel.DisplayName)
|
|
s.Require().Equal(s.th.BasicTeam.Id, newChannel.TeamId)
|
|
})
|
|
|
|
s.RunForAllClients("create channel with nonexistent team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
cmd := &cobra.Command{}
|
|
channelName := model.NewRandomString(10)
|
|
teamName := "nonexistent team"
|
|
channelDisplayName := "channelDisplayName"
|
|
cmd.Flags().String("name", channelName, "channel name")
|
|
cmd.Flags().String("team", teamName, "team name")
|
|
cmd.Flags().String("display-name", channelDisplayName, "display name")
|
|
|
|
err := createChannelCmdF(c, cmd, []string{})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("unable to find team: "+teamName, err.Error())
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
|
|
_, err = s.th.App.GetChannelByName(s.th.Context, channelName, s.th.BasicTeam.Id, false)
|
|
s.Require().NotNil(err)
|
|
})
|
|
|
|
s.RunForAllClients("create channel with invalid name", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
cmd := &cobra.Command{}
|
|
channelName := "invalid name"
|
|
teamName := s.th.BasicTeam.Name
|
|
channelDisplayName := "channelDisplayName"
|
|
cmd.Flags().String("name", channelName, "channel name")
|
|
cmd.Flags().String("team", teamName, "team name")
|
|
cmd.Flags().String("display-name", channelDisplayName, "display name")
|
|
|
|
err := createChannelCmdF(c, cmd, []string{})
|
|
s.Require().NotNil(err)
|
|
s.Require().Contains(err.Error(), "Name must be 1 or more lowercase alphanumeric character")
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
|
|
_, err = s.th.App.GetChannelByName(s.th.Context, channelName, s.th.BasicTeam.Id, false)
|
|
s.Require().NotNil(err)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestArchiveChannelsCmdF() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
s.Run("Archive channel", func() {
|
|
printer.Clean()
|
|
|
|
err := archiveChannelsCmdF(s.th.SystemAdminClient, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicChannel.Name)})
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.Run("Archive channel without permissions", func() {
|
|
printer.Clean()
|
|
|
|
err := archiveChannelsCmdF(s.th.LocalClient, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicChannel.Name)})
|
|
s.Require().Error(err)
|
|
s.Require().Contains(printer.GetErrorLines()[0], fmt.Sprintf("Unable to archive channel '%s'", s.th.BasicChannel.Name))
|
|
})
|
|
|
|
s.RunForAllClients("Archive nonexistent channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := archiveChannelsCmdF(c, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, "nonexistent-channel")})
|
|
s.Require().Error(err)
|
|
s.Require().Contains(printer.GetErrorLines()[0], fmt.Sprintf("Unable to find channel '%s:%s'", s.th.BasicTeam.Id, "nonexistent-channel"))
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Archive deleted channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := archiveChannelsCmdF(c, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicDeletedChannel.Name)})
|
|
s.Require().Error(err)
|
|
s.Require().Contains(printer.GetErrorLines()[0], fmt.Sprintf("Unable to archive channel '%s'", s.th.BasicDeletedChannel.Name))
|
|
s.Require().Contains(printer.GetErrorLines()[0], "The channel has been archived or deleted.")
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestUnarchiveChannelsCmdF() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
s.Run("Unarchive channel", func() {
|
|
printer.Clean()
|
|
|
|
err := unarchiveChannelsCmdF(s.th.SystemAdminClient, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicDeletedChannel.Name)})
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
channel, appErr := s.th.App.GetChannel(s.th.Context, s.th.BasicDeletedChannel.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().True(channel.IsOpen())
|
|
})
|
|
|
|
s.Run("Unarchive channel without permissions", func() {
|
|
printer.Clean()
|
|
|
|
err := unarchiveChannelsCmdF(s.th.Client, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicDeletedChannel.Name)})
|
|
expectedError := fmt.Sprintf("Unable to unarchive channel '%s:%s'", s.th.BasicTeam.Id, s.th.BasicDeletedChannel.Name)
|
|
s.Require().ErrorContains(err, expectedError)
|
|
s.Require().Contains(printer.GetErrorLines()[0], expectedError)
|
|
s.Require().Contains(printer.GetErrorLines()[0], "You do not have the appropriate permissions.")
|
|
})
|
|
|
|
s.RunForAllClients("Unarchive nonexistent channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := unarchiveChannelsCmdF(c, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, "nonexistent-channel")})
|
|
expectedError := fmt.Sprintf("Unable to find channel '%s:%s'", s.th.BasicTeam.Id, "nonexistent-channel")
|
|
s.Require().ErrorContains(err, expectedError)
|
|
s.Require().Contains(printer.GetErrorLines()[0], expectedError)
|
|
})
|
|
|
|
s.Run("Unarchive open channel", func() {
|
|
printer.Clean()
|
|
|
|
err := unarchiveChannelsCmdF(s.th.SystemAdminClient, &cobra.Command{}, []string{fmt.Sprintf("%s:%s", s.th.BasicTeam.Id, s.th.BasicChannel.Name)})
|
|
expectedError := fmt.Sprintf("Unable to unarchive channel '%s:%s'", s.th.BasicTeam.Id, s.th.BasicChannel.Name)
|
|
s.Require().ErrorContains(err, expectedError)
|
|
s.Require().Contains(printer.GetErrorLines()[0], expectedError)
|
|
s.Require().Contains(printer.GetErrorLines()[0], "Unable to unarchive channel. The channel is not archived.")
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestDeleteChannelsCmd() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
previousConfig := s.th.App.Config().ServiceSettings.EnableAPIChannelDeletion
|
|
s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = true })
|
|
defer s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = *previousConfig })
|
|
|
|
user, appErr := s.th.App.CreateUser(s.th.Context, &model.User{Email: s.th.GenerateTestEmail(), Username: model.NewUsername(), Password: model.NewId()})
|
|
s.Require().Nil(appErr)
|
|
|
|
team, appErr := s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
DisplayName: "Best Team",
|
|
Name: "best-team",
|
|
Type: model.TeamOpen,
|
|
Email: s.th.GenerateTestEmail(),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
otherChannel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{Type: model.ChannelTypeOpen, Name: "channel_you_are_not_authorized_to", CreatorId: user.Id}, true)
|
|
s.Require().Nil(appErr)
|
|
|
|
s.RunForSystemAdminAndLocal("Delete channel", func(c client.Client) {
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{Type: model.ChannelTypeOpen, Name: "channel_name", CreatorId: user.Id}, true)
|
|
s.Require().Nil(appErr)
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("confirm", true, "")
|
|
args := []string{team.Id + ":" + channel.Id}
|
|
|
|
printer.Clean()
|
|
err := deleteChannelsCmdF(c, cmd, args)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(channel, printer.GetLines()[0])
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
_, err = s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
|
|
s.Require().NotNil(err)
|
|
s.CheckErrorID(err, "app.channel.get.existing.app_error")
|
|
})
|
|
|
|
s.Run("Delete channel with disabled config as system admin", func() {
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{Type: model.ChannelTypeOpen, Name: "channel_name_you_cannot_delete", CreatorId: user.Id}, true)
|
|
s.Require().Nil(appErr)
|
|
|
|
previousVal := s.th.App.Config().ServiceSettings.EnableAPIChannelDeletion
|
|
s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = false })
|
|
defer func() {
|
|
s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = *previousVal })
|
|
}()
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("confirm", true, "")
|
|
args := []string{team.Id + ":" + channel.Id}
|
|
|
|
printer.Clean()
|
|
err := deleteChannelsCmdF(s.th.SystemAdminClient, cmd, args)
|
|
|
|
var expected error
|
|
expected = multierror.Append(expected, errors.New("unable to delete channel '\""+channel.Name+"\"' error: Permanent channel deletion feature is not enabled. ServiceSettings.EnableAPIChannelDeletion must be set to true to use this command. See https://mattermost.com/pl/environment-configuration-settings for more information"))
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().EqualError(err, expected.Error())
|
|
|
|
channel, err = s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().NotNil(channel)
|
|
})
|
|
|
|
s.Run("Delete channel with disabled config as local client", func() {
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{Type: model.ChannelTypeOpen, Name: "channel_name", CreatorId: user.Id}, true)
|
|
s.Require().Nil(appErr)
|
|
|
|
previousVal := s.th.App.Config().ServiceSettings.EnableAPIChannelDeletion
|
|
s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = false })
|
|
defer func() {
|
|
s.th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPIChannelDeletion = *previousVal })
|
|
}()
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("confirm", true, "")
|
|
args := []string{team.Id + ":" + channel.Id}
|
|
|
|
printer.Clean()
|
|
err := deleteChannelsCmdF(s.th.LocalClient, cmd, args)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(channel, printer.GetLines()[0])
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
// expect the channel deleted
|
|
_, err = s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().NotNil(err)
|
|
s.CheckErrorID(err, "app.channel.get.existing.app_error")
|
|
})
|
|
|
|
s.Run("Delete channel without permissions", func() {
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("confirm", true, "")
|
|
args := []string{team.Id + ":" + otherChannel.Id}
|
|
|
|
printer.Clean()
|
|
err := deleteChannelsCmdF(s.th.Client, cmd, args)
|
|
|
|
arg := team.Id + ":" + otherChannel.Id
|
|
var expected error
|
|
expected = multierror.Append(expected, errors.New("unable to find channel '"+arg+"'"))
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().EqualError(err, expected.Error())
|
|
|
|
channel, err := s.th.App.GetChannel(s.th.Context, otherChannel.Id)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().NotNil(channel)
|
|
})
|
|
|
|
s.RunForAllClients("Delete not existing channel", func(c client.Client) {
|
|
notExistingChannelID := "not-existing-channel-ID"
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("confirm", true, "")
|
|
args := []string{team.Id + ":" + notExistingChannelID}
|
|
|
|
printer.Clean()
|
|
err := deleteChannelsCmdF(c, cmd, args)
|
|
|
|
arg := team.Id + ":" + notExistingChannelID
|
|
var expected error
|
|
expected = multierror.Append(expected, errors.New("unable to find channel '"+arg+"'"))
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().EqualError(err, expected.Error())
|
|
|
|
channel, err := s.th.App.GetChannel(s.th.Context, notExistingChannelID)
|
|
|
|
s.Require().Nil(channel)
|
|
s.Require().NotNil(err)
|
|
s.CheckErrorID(err, "app.channel.get.existing.app_error")
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestChannelRenameCmd() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
|
|
initChannelName := api4.GenerateTestChannelName()
|
|
initChannelDisplayName := "dn_" + initChannelName
|
|
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: initChannelName,
|
|
DisplayName: initChannelDisplayName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
|
|
s.RunForAllClients("Rename nonexistent channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
nonexistentChannelName := api4.GenerateTestChannelName()
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("name", "name", "")
|
|
cmd.Flags().String("display-name", "name", "")
|
|
|
|
err := renameChannelCmdF(c, cmd, []string{s.th.BasicTeam.Id + ":" + nonexistentChannelName})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal(fmt.Sprintf("unable to find channel from \"%s:%s\"", s.th.BasicTeam.Id, nonexistentChannelName), err.Error())
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Rename channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
newChannelName := api4.GenerateTestChannelName()
|
|
newChannelDisplayName := "dn_" + newChannelName
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("name", newChannelName, "")
|
|
cmd.Flags().String("display-name", newChannelDisplayName, "")
|
|
|
|
err := renameChannelCmdF(c, cmd, []string{s.th.BasicTeam.Id + ":" + channel.Id})
|
|
s.Require().Nil(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
printedChannel, ok := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().True(ok, "unexpected printer output type")
|
|
|
|
s.Require().Equal(newChannelName, printedChannel.Name)
|
|
s.Require().Equal(newChannelDisplayName, printedChannel.DisplayName)
|
|
|
|
rchannel, err := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(newChannelName, rchannel.Name)
|
|
s.Require().Equal(newChannelDisplayName, rchannel.DisplayName)
|
|
})
|
|
|
|
s.Run("Rename channel without permission", func() {
|
|
printer.Clean()
|
|
|
|
channelInit, appErr := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(appErr)
|
|
|
|
newChannelName := api4.GenerateTestChannelName()
|
|
newChannelDisplayName := "dn_" + newChannelName
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("name", newChannelName, "")
|
|
cmd.Flags().String("display-name", newChannelDisplayName, "")
|
|
|
|
err := renameChannelCmdF(s.th.Client, cmd, []string{s.th.BasicTeam.Id + ":" + channel.Id})
|
|
s.Require().NotNil(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
s.Require().Equal(fmt.Sprintf("cannot rename channel \"%s\", error: You do not have the appropriate permissions.", channelInit.Name), err.Error())
|
|
|
|
rchannel, err := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(channelInit.Name, rchannel.Name)
|
|
s.Require().Equal(channelInit.DisplayName, rchannel.DisplayName)
|
|
})
|
|
|
|
s.Run("Rename channel with permission", func() {
|
|
printer.Clean()
|
|
|
|
_, appErr := s.th.App.AddChannelMember(s.th.Context, s.th.BasicUser.Id, channel, app.ChannelMemberOpts{})
|
|
s.Require().Nil(appErr)
|
|
|
|
newChannelName := api4.GenerateTestChannelName()
|
|
newChannelDisplayName := "dn_" + newChannelName
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().String("name", newChannelName, "")
|
|
cmd.Flags().String("display-name", newChannelDisplayName, "")
|
|
|
|
err := renameChannelCmdF(s.th.Client, cmd, []string{s.th.BasicTeam.Id + ":" + channel.Id})
|
|
s.Require().Nil(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
printedChannel, ok := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().True(ok, "unexpected printer output type")
|
|
|
|
s.Require().Equal(newChannelName, printedChannel.Name)
|
|
s.Require().Equal(newChannelDisplayName, printedChannel.DisplayName)
|
|
|
|
rchannel, err := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(newChannelName, rchannel.Name)
|
|
s.Require().Equal(newChannelDisplayName, rchannel.DisplayName)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestMoveChannelCmd() {
|
|
s.SetupTestHelper().InitBasic(s.T())
|
|
initChannelName := api4.GenerateTestChannelName()
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: initChannelName,
|
|
DisplayName: "dName_" + initChannelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
|
|
s.RunForAllClients("Move nonexistent team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := moveChannelCmdF(c, &cobra.Command{}, []string{"test"})
|
|
s.Require().Error(err)
|
|
s.Require().Equal(`unable to find destination team "test"`, err.Error())
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Move existing channel to specified team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
testTeamName := api4.GenerateTestTeamName()
|
|
var team *model.Team
|
|
team, appErr = s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: testTeamName,
|
|
DisplayName: "dName_" + testTeamName,
|
|
Type: model.TeamOpen,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
args := []string{team.Id, channel.Id}
|
|
cmd := &cobra.Command{}
|
|
|
|
err := moveChannelCmdF(c, cmd, args)
|
|
|
|
s.Require().NoError(err)
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
actualChannel, ok := printer.GetLines()[0].(*model.Channel)
|
|
s.Require().True(ok)
|
|
s.Require().Equal(channel.Name, actualChannel.Name)
|
|
s.Require().Equal(team.Id, actualChannel.TeamId)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Moving team to non existing channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
args := []string{s.th.BasicTeam.Id, "no-channel"}
|
|
cmd := &cobra.Command{}
|
|
|
|
var expected error
|
|
expected = multierror.Append(expected, fmt.Errorf("unable to find channel %q", "no-channel"))
|
|
|
|
err := moveChannelCmdF(c, cmd, args)
|
|
|
|
s.Require().EqualError(err, expected.Error())
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Moving channel which is already moved to particular team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
initChannelName := api4.GenerateTestChannelName()
|
|
channel, appErr = s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: initChannelName,
|
|
DisplayName: "dName_" + initChannelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
|
|
args := []string{channel.TeamId, channel.Id}
|
|
|
|
cmd := &cobra.Command{}
|
|
|
|
err := moveChannelCmdF(c, cmd, args)
|
|
s.Require().NoError(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.Run("Move existing channel to specified team should fail for client", func() {
|
|
printer.Clean()
|
|
|
|
testTeamName := api4.GenerateTestTeamName()
|
|
var team *model.Team
|
|
team, appErr = s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: testTeamName,
|
|
DisplayName: "dName_" + testTeamName,
|
|
Type: model.TeamOpen,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
args := []string{team.Id, channel.Id}
|
|
cmd := &cobra.Command{}
|
|
|
|
err := moveChannelCmdF(s.th.Client, cmd, args)
|
|
s.Require().Error(err)
|
|
s.Require().Equal(fmt.Sprintf("unable to find destination team %q", team.Id), err.Error())
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Move channel auto-adding users missing from the destination team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
testTeamName := api4.GenerateTestTeamName()
|
|
team, appErr := s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: testTeamName,
|
|
DisplayName: "dName_" + testTeamName,
|
|
Type: model.TeamOpen,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
srcChannelName := api4.GenerateTestChannelName()
|
|
srcChannel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: srcChannelName,
|
|
DisplayName: "dName_" + srcChannelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
|
|
// A channel member that belongs to the source team but not the destination team.
|
|
user, appErr := s.th.App.CreateUser(s.th.Context, &model.User{Email: s.th.GenerateTestEmail(), Username: model.NewUsername(), Password: model.NewId()})
|
|
s.Require().Nil(appErr)
|
|
_, _, appErr = s.th.App.AddUserToTeam(s.th.Context, s.th.BasicTeam.Id, user.Id, "")
|
|
s.Require().Nil(appErr)
|
|
_, appErr = s.th.App.AddUserToChannel(s.th.Context, user, srcChannel, false)
|
|
s.Require().Nil(appErr)
|
|
|
|
// Without the flag the move is rejected and the missing user is reported.
|
|
err := moveChannelCmdF(c, &cobra.Command{}, []string{team.Id, srcChannel.Id})
|
|
s.Require().Error(err)
|
|
s.Require().Contains(err.Error(), user.Username)
|
|
s.Require().Contains(err.Error(), "--auto-add-users")
|
|
|
|
_, appErr = s.th.App.GetTeamMember(s.th.Context, team.Id, user.Id)
|
|
s.Require().NotNil(appErr)
|
|
|
|
// With the flag the user is added to the destination team and the move succeeds.
|
|
printer.Clean()
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().Bool("auto-add-users", true, "")
|
|
err = moveChannelCmdF(c, cmd, []string{team.Id, srcChannel.Id})
|
|
s.Require().NoError(err)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
movedChannel, appErr := s.th.App.GetChannel(s.th.Context, srcChannel.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().Equal(team.Id, movedChannel.TeamId)
|
|
|
|
teamMember, appErr := s.th.App.GetTeamMember(s.th.Context, team.Id, user.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().Equal(user.Id, teamMember.UserId)
|
|
})
|
|
}
|