mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* Add TeamSettings.LockProfileFieldsForEmailUsers with server-side enforcement Co-authored-by: Nick Misasi <[email protected]> * Add API tests for LockProfileFieldsForEmailUsers enforcement Co-authored-by: Nick Misasi <[email protected]> * Hide admin-locked profile fields in user settings and add System Console dropdown Co-authored-by: Nick Misasi <[email protected]> * Support pre-set username and name on team email invites Co-authored-by: Nick Misasi <[email protected]> * Add tests for invite profiles; fix resend worker channel-list parsing Co-authored-by: Nick Misasi <[email protected]> * Add pre-set profile inputs to member invite modal Co-authored-by: Nick Misasi <[email protected]> * Prefill and lock pre-set username on signup page Co-authored-by: Nick Misasi <[email protected]> * Add first/last name editing to System Console user detail and document new setting Co-authored-by: Nick Misasi <[email protected]> * Fix lint issues in invite modal profile inputs Co-authored-by: Nick Misasi <[email protected]> * Fix double outline on invite modal profile inputs inside GenericModal Co-authored-by: Nick Misasi <[email protected]> * Refactor invite emails to InviteEmailData struct and harden invite profile validation Co-authored-by: nick.misasi <[email protected]> * Centralize profile-lock permission exemption in app layer and add config coverage Co-authored-by: nick.misasi <[email protected]> * Per-field name locking in profile settings, typed lock setting, and shared invite profile helpers Co-authored-by: nick.misasi <[email protected]> * Add Playwright E2E coverage for locked profile fields and pre-set invite profiles Co-authored-by: nick.misasi <[email protected]> * Sync playwright package-lock with merged workspace versions Co-authored-by: nick.misasi <[email protected]> * Restore upstream playwright package-lock (fix npm ci drift) Co-authored-by: nick.misasi <[email protected]> * Assert invite input cleared instead of chip text after adding email Co-authored-by: nick.misasi <[email protected]> * Fix invite modal scroll, username error layout, and clipped autocomplete Keep the footer pinned while tall profile rows scroll, show username validation full-width after blur, and portal select menus so they are not clipped by the scroll container. * fixes for autocomplete items not aligning properly * Make invite autocomplete menu portal opt-in and fix modal chrome Confine document.body menu portaling to the invite modal via a menuPortal prop, and restore click-away, slide-in animation, and header alignment for the scrolling invite modal layout. * Fix eslint lines-around-comment on menuPortal props * Fix stylelint property order in invitation modal SCSS. * Fix stylelint property order in invitation_modal.scss Co-authored-by: nick.misasi <[email protected]> * Adapt invite modal E2E to portaled autocomplete menus Co-authored-by: nick.misasi <[email protected]> * Simplify locked profile invite implementation Co-authored-by: nick.misasi <[email protected]> * Fix invite modal review and E2E feedback Co-authored-by: nick.misasi <[email protected]> * Retry flaky enterprise CI Co-authored-by: nick.misasi <[email protected]> * Retry Docker image export CI Co-authored-by: nick.misasi <[email protected]> * Minimize locked profile fields diff Co-authored-by: nick.misasi <[email protected]> * Fix locked profile E2E documentation Co-authored-by: nick.misasi <[email protected]> * Address minimized test review feedback Co-authored-by: nick.misasi <[email protected]> * Fix email test whitespace Co-authored-by: nick.misasi <[email protected]> * Retry OpenSearch download CI Co-authored-by: nick.misasi <[email protected]> * Retry flaky Cypress thread navigation Co-authored-by: nick.misasi <[email protected]> * Preserve legacy invite behavior without profiles Co-authored-by: nick.misasi <[email protected]> * Clarify invite profile validation Co-authored-by: nick.misasi <[email protected]> * Retry flaky enterprise E2E Co-authored-by: nick.misasi <[email protected]> --------- Co-authored-by: Matthew Birtch <[email protected]> Co-authored-by: Hanzo Dev <[email protected]>
160 lines
5.3 KiB
Go
160 lines
5.3 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package model
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMemberInviteUnmarshalJSON(t *testing.T) {
|
|
t.Run("raw email array", func(t *testing.T) {
|
|
var invite MemberInvite
|
|
err := json.Unmarshal([]byte(`["[email protected]","[email protected]"]`), &invite)
|
|
require.NoError(t, err)
|
|
require.Equal(t, []string{"[email protected]", "[email protected]"}, invite.Emails)
|
|
require.Empty(t, invite.ChannelIds)
|
|
require.Empty(t, invite.Profiles)
|
|
})
|
|
|
|
t.Run("object with emails and channels", func(t *testing.T) {
|
|
var invite MemberInvite
|
|
err := json.Unmarshal([]byte(`{"emails":["[email protected]"],"channelIds":["junk"],"message":"hi"}`), &invite)
|
|
require.NoError(t, err)
|
|
require.Equal(t, []string{"[email protected]"}, invite.Emails)
|
|
require.Equal(t, []string{"junk"}, invite.ChannelIds)
|
|
require.Equal(t, "hi", invite.Message)
|
|
require.Empty(t, invite.Profiles)
|
|
})
|
|
|
|
t.Run("object with profiles", func(t *testing.T) {
|
|
var invite MemberInvite
|
|
err := json.Unmarshal([]byte(`{"emails":["[email protected]"],"profiles":[{"email":"[email protected]","username":"user.one","first_name":"User","last_name":"One"}]}`), &invite)
|
|
require.NoError(t, err)
|
|
require.Equal(t, []string{"[email protected]"}, invite.Emails)
|
|
require.Len(t, invite.Profiles, 1)
|
|
require.Equal(t, "[email protected]", invite.Profiles[0].Email)
|
|
require.Equal(t, "user.one", invite.Profiles[0].Username)
|
|
require.Equal(t, "User", invite.Profiles[0].FirstName)
|
|
require.Equal(t, "One", invite.Profiles[0].LastName)
|
|
})
|
|
}
|
|
|
|
func TestMemberInviteIsValid(t *testing.T) {
|
|
validInvite := func() *MemberInvite {
|
|
return &MemberInvite{
|
|
Emails: []string{"[email protected]"},
|
|
Profiles: []*MemberInviteProfile{{
|
|
Email: "[email protected]",
|
|
Username: "user.one",
|
|
FirstName: "User",
|
|
LastName: "One",
|
|
}},
|
|
}
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
mutate func(*MemberInvite)
|
|
expectedErr string
|
|
}{
|
|
{
|
|
name: "valid without profiles",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles = nil },
|
|
},
|
|
{name: "valid with profiles"},
|
|
{
|
|
name: "no emails",
|
|
mutate: func(invite *MemberInvite) { invite.Emails = nil },
|
|
expectedErr: "model.member.is_valid.emails.app_error",
|
|
},
|
|
{
|
|
name: "invalid channel",
|
|
mutate: func(invite *MemberInvite) { invite.ChannelIds = []string{"junk"} },
|
|
expectedErr: "model.member.is_valid.channel.app_error",
|
|
},
|
|
{
|
|
name: "case-insensitive profile email",
|
|
mutate: func(invite *MemberInvite) { invite.Emails[0] = "[email protected]" },
|
|
},
|
|
{
|
|
name: "profile email not invited",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles[0].Email = "[email protected]" },
|
|
expectedErr: "model.member.is_valid.profile_email.app_error",
|
|
},
|
|
{
|
|
name: "duplicate profile email",
|
|
mutate: func(invite *MemberInvite) {
|
|
invite.Profiles = append(invite.Profiles, &MemberInviteProfile{Email: "[email protected]", Username: "user.two"})
|
|
},
|
|
expectedErr: "model.member.is_valid.profile_email_duplicate.app_error",
|
|
},
|
|
{
|
|
name: "nil profile",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles = []*MemberInviteProfile{nil} },
|
|
expectedErr: "model.member.is_valid.profile_nil.app_error",
|
|
},
|
|
{
|
|
name: "duplicate usernames",
|
|
mutate: func(invite *MemberInvite) {
|
|
invite.Emails = append(invite.Emails, "[email protected]")
|
|
invite.Profiles = append(invite.Profiles, &MemberInviteProfile{Email: "[email protected]", Username: "USER.ONE"})
|
|
},
|
|
expectedErr: "model.member.is_valid.profile_username_duplicate.app_error",
|
|
},
|
|
{
|
|
name: "invalid username",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles[0].Username = "inv@lid" },
|
|
expectedErr: "model.member.is_valid.profile_username.app_error",
|
|
},
|
|
{
|
|
name: "uppercase username",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles[0].Username = "User.One" },
|
|
},
|
|
{
|
|
name: "first name too long",
|
|
mutate: func(invite *MemberInvite) {
|
|
invite.Profiles[0].FirstName = strings.Repeat("a", UserFirstNameMaxRunes+1)
|
|
},
|
|
expectedErr: "model.member.is_valid.profile_first_name.app_error",
|
|
},
|
|
{
|
|
name: "last name too long",
|
|
mutate: func(invite *MemberInvite) { invite.Profiles[0].LastName = strings.Repeat("a", UserLastNameMaxRunes+1) },
|
|
expectedErr: "model.member.is_valid.profile_last_name.app_error",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
invite := validInvite()
|
|
if test.mutate != nil {
|
|
test.mutate(invite)
|
|
}
|
|
appErr := invite.IsValid()
|
|
if test.expectedErr == "" {
|
|
require.Nil(t, appErr)
|
|
} else {
|
|
require.NotNil(t, appErr)
|
|
require.Equal(t, test.expectedErr, appErr.Id)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestMemberInviteAuditable(t *testing.T) {
|
|
invite := &MemberInvite{
|
|
Emails: []string{"[email protected]"},
|
|
ChannelIds: []string{"channel1"},
|
|
Profiles: []*MemberInviteProfile{{Email: "[email protected]", Username: "user.one"}},
|
|
}
|
|
auditable := invite.Auditable()
|
|
require.Equal(t, []string{"[email protected]"}, auditable["emails"])
|
|
require.Equal(t, []string{"channel1"}, auditable["channel_ids"])
|
|
require.Equal(t, 1, auditable["profile_count"])
|
|
}
|