mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
2bb8d01100
* Mattermost Blocks * Rethink some block props and styles * Remove obsolete comment * Style fixes and add examples * Add mention, search, and image metadata support * Several UI improvements * Validate blocks by translating them * Add initial e2e tests * Fix lint * Fix tests and lint * Fix lint * Improve e2e and simplify doPostAction * server side cleanup * Fix typo * Fix style * Fix some tests * Fix more tests * Fix cypress tests * Fix playwhright tests * Fix flaky system console test * Frontend cleanup * Add blocks editor * Fix CI * Limit all blocks width * Fix test * Enable webhook service on playwhright CI * fix flaky test * Fix style * Cleanups * Address coderabbit comments * Address coderabbit comments * Address CI errors * Fix tests * Address changes in valid actions * UX fixes * Fix test * Fix danger buttons and add allow emojis in buttons * style tweaks use semantic color tokens for buttons and accents, update max-heights for scollables, adjustments to containers, removed btn-sm (using default button size for mm blocks with height and padding adjustments for use within blocks. removed hover selector from utils to prevent hover state issue with primary button, refined semantic-color-warning. * Address feedback * Add interactive content to post previews * Add collapse transitions * Address autocomplete position * Handle columns within column sets * Fix css lint * Fix tests * Use feature flag * Address feedback * Fix lint and add missing tests * Fix e2e tests * Fix e2e test * Allow interactive posts without a message * Fix lint * Address feedback * Fix ci * Fix lint * Add limits to block translations * Fix lint * Address feedback * Address feedback * Update snapshot * Fix collapsible not defaulting to the right value * Add total text limit * Sync translations with mobile * Fix snapshot --------- Co-authored-by: Matthew Birtch <[email protected]> Co-authored-by: Mattermost Build <[email protected]>
352 lines
10 KiB
Go
352 lines
10 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package model
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCollectMmBlockActionIDs(t *testing.T) {
|
|
t.Run("nested container blocks", func(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{"type": "text", "text": "hi"},
|
|
map[string]any{
|
|
"type": "container",
|
|
"content": []any{
|
|
map[string]any{"type": "button", "text": "A", "action_id": "a1"},
|
|
map[string]any{"type": "static_select", "action_id": "s1", "placeholder": "pick"},
|
|
},
|
|
},
|
|
}
|
|
ids := CollectMmBlockActionIDs(blocks)
|
|
assert.Equal(t, map[string]struct{}{"a1": {}, "s1": {}}, ids)
|
|
})
|
|
|
|
t.Run("columnSet", func(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{
|
|
"type": "column_set",
|
|
"columns": []any{
|
|
map[string]any{
|
|
"type": "column",
|
|
"items": []any{
|
|
map[string]any{"type": "button", "text": "A", "action_id": "inset"},
|
|
},
|
|
},
|
|
map[string]any{
|
|
"type": "text",
|
|
"text": "not a column",
|
|
},
|
|
},
|
|
},
|
|
map[string]any{
|
|
"type": "column",
|
|
"items": []any{
|
|
map[string]any{"type": "button", "text": "B", "action_id": "orphan"},
|
|
},
|
|
},
|
|
}
|
|
ids := CollectMmBlockActionIDs(blocks)
|
|
assert.Equal(t, map[string]struct{}{"inset": {}}, ids)
|
|
})
|
|
}
|
|
|
|
func TestSubsetMmBlocksActions(t *testing.T) {
|
|
all := map[string]any{
|
|
"a1": map[string]any{"type": "external", "url": "http://example.com/a"},
|
|
"b2": map[string]any{"type": "external", "url": "http://example.com/b"},
|
|
}
|
|
subset := SubsetMmBlocksActions(all, map[string]struct{}{"a1": {}})
|
|
require.Len(t, subset, 1)
|
|
assert.Contains(t, subset, "a1")
|
|
}
|
|
|
|
func TestValidateMmBlocksActionsForWebhook(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{"type": "button", "text": "Go", "action_id": "act"},
|
|
}
|
|
require.Error(t, ValidateMmBlocksActionsForWebhook(blocks, nil))
|
|
require.Error(t, ValidateMmBlocksActionsForWebhook(nil, map[string]any{"act": map[string]any{}}))
|
|
require.NoError(t, ValidateMmBlocksActionsForWebhook(blocks, map[string]any{
|
|
"act": map[string]any{"type": "external", "url": "http://example.com"},
|
|
}))
|
|
}
|
|
|
|
func TestCollectMmactionIDsFromMmBlockText(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{
|
|
"type": "text",
|
|
"text": "Choose [one](mmaction://pick1) or [two](mmaction://pick2)",
|
|
},
|
|
}
|
|
ids := CollectMmBlockActionIDs(blocks)
|
|
assert.Equal(t, map[string]struct{}{"pick1": {}, "pick2": {}}, ids)
|
|
}
|
|
|
|
func TestCollectMmactionIDsFromText(t *testing.T) {
|
|
t.Run("skipsCode", func(t *testing.T) {
|
|
ids := CollectMmactionIDsFromText("Use [real](mmaction://real1) not `mmaction://inline`")
|
|
assert.Equal(t, map[string]struct{}{"real1": {}}, ids)
|
|
|
|
ids = CollectMmactionIDsFromText("```\n[mmaction://fence](mmaction://fence)\n```\n[ok](mmaction://ok1)")
|
|
assert.Equal(t, map[string]struct{}{"ok1": {}}, ids)
|
|
})
|
|
}
|
|
|
|
func TestCollectBlockKitActionIDs(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{
|
|
"type": "section",
|
|
"text": map[string]any{"type": "mrkdwn", "text": "[Go](mmaction://md1)"},
|
|
"accessory": map[string]any{
|
|
"type": "button", "text": map[string]any{"type": "plain_text", "text": "Btn"},
|
|
"action_id": "acc1",
|
|
},
|
|
},
|
|
map[string]any{
|
|
"type": "actions",
|
|
"elements": []any{
|
|
map[string]any{
|
|
"type": "button",
|
|
"text": map[string]any{"type": "plain_text", "text": "OK"},
|
|
"action_id": "row1",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
ids := CollectBlockKitActionIDs(blocks)
|
|
assert.Equal(t, map[string]struct{}{"md1": {}, "acc1": {}, "row1": {}}, ids)
|
|
}
|
|
|
|
func TestCollectAdaptiveCardActionIDs(t *testing.T) {
|
|
cards := []any{
|
|
map[string]any{
|
|
"type": "AdaptiveCard",
|
|
"body": []any{
|
|
map[string]any{"type": "TextBlock", "text": "See [here](mmaction://cardmd)"},
|
|
map[string]any{
|
|
"type": "ActionSet",
|
|
"actions": []any{
|
|
map[string]any{"type": "Action.Submit", "title": "OK", "id": "submit1"},
|
|
},
|
|
},
|
|
},
|
|
"actions": []any{
|
|
map[string]any{"type": "Action.Submit", "title": "Footer", "id": "footer1"},
|
|
},
|
|
},
|
|
}
|
|
ids := CollectAdaptiveCardActionIDs(cards)
|
|
assert.Equal(t, map[string]struct{}{"cardmd": {}, "submit1": {}, "footer1": {}}, ids)
|
|
}
|
|
|
|
func TestValidateMmBlocksActionsOnPost(t *testing.T) {
|
|
t.Run("pairing", func(t *testing.T) {
|
|
post := &Post{
|
|
Props: map[string]any{
|
|
PostPropsMmBlocks: []any{
|
|
map[string]any{"type": "button", "text": "Go", "action_id": "act"},
|
|
},
|
|
PostPropsMmBlocksActions: map[string]any{
|
|
"act": map[string]any{"type": "external", "url": "http://example.com"},
|
|
},
|
|
},
|
|
}
|
|
require.NoError(t, ValidateMmBlocksActions(post))
|
|
|
|
extra := post.Clone()
|
|
extraProps := extra.GetProps()
|
|
extraProps[PostPropsMmBlocksActions] = map[string]any{
|
|
"act": map[string]any{"type": "external", "url": "http://example.com"},
|
|
"extra": map[string]any{"type": "external", "url": "http://example.com/2"},
|
|
}
|
|
extra.SetProps(extraProps)
|
|
require.Error(t, ValidateMmBlocksActions(extra))
|
|
})
|
|
|
|
t.Run("disabledControlSkipsActionRegistry", func(t *testing.T) {
|
|
post := &Post{
|
|
Props: map[string]any{
|
|
PostPropsMmBlocks: []any{
|
|
map[string]any{
|
|
"type": "button",
|
|
"text": "Disabled",
|
|
"action_id": "disabled_only",
|
|
"disabled": true,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
require.NoError(t, ValidateMmBlocksActions(post))
|
|
})
|
|
}
|
|
|
|
func TestValidateInteractiveActionsForWebhook(t *testing.T) {
|
|
t.Run("messageMmaction", func(t *testing.T) {
|
|
post := &Post{
|
|
Message: "Click [go](mmaction://go1)",
|
|
Props: map[string]any{
|
|
PostPropsMmBlocksActions: map[string]any{
|
|
"go1": map[string]any{"type": "external", "url": "http://example.com"},
|
|
},
|
|
},
|
|
}
|
|
require.NoError(t, ValidateInteractiveActionsForWebhook(post))
|
|
|
|
postMissing := &Post{Message: "Click [go](mmaction://go1)"}
|
|
require.Error(t, ValidateInteractiveActionsForWebhook(postMissing))
|
|
})
|
|
}
|
|
|
|
func TestApplyMmBlocksWithActionsToProps(t *testing.T) {
|
|
t.Run("nilProps", func(t *testing.T) {
|
|
blocks := []any{
|
|
map[string]any{"type": "button", "text": "Go", "action_id": "act1"},
|
|
}
|
|
actions := map[string]any{
|
|
"act1": map[string]any{"type": "external", "url": "http://example.com"},
|
|
}
|
|
|
|
props := ApplyMmBlocksWithActionsToProps(nil, blocks, actions)
|
|
require.NotNil(t, props)
|
|
require.Equal(t, blocks, props[PostPropsMmBlocks])
|
|
require.Equal(t, actions, props[PostPropsMmBlocksActions])
|
|
})
|
|
}
|
|
|
|
func TestPost_InteractiveBlocksImageURLs(t *testing.T) {
|
|
t.Run("empty post", func(t *testing.T) {
|
|
assert.Nil(t, (&Post{}).InteractiveBlocksImageURLs(true))
|
|
})
|
|
|
|
t.Run("collects URLs from all interactive sources when enabled", func(t *testing.T) {
|
|
post := &Post{
|
|
Props: StringInterface{
|
|
PostPropsMmBlocks: []any{
|
|
map[string]any{
|
|
"type": "text",
|
|
"text": "x ",
|
|
},
|
|
map[string]any{
|
|
"type": "image",
|
|
"url": "https://example.com/mm_direct1.png",
|
|
},
|
|
map[string]any{
|
|
"type": "image",
|
|
"url": "https://example.com/mm_direct2.png",
|
|
},
|
|
map[string]any{
|
|
"type": "container",
|
|
"content": []any{
|
|
map[string]any{
|
|
"type": "image",
|
|
"url": "https://example.com/mm_nested.png",
|
|
},
|
|
map[string]any{
|
|
"type": "image",
|
|
"url": "https://example.com/mm_nested2.png",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
PostPropsBlockKitBlocks: []any{
|
|
map[string]any{
|
|
"type": "image",
|
|
"image_url": "https://example.com/bk_top1.png",
|
|
},
|
|
map[string]any{
|
|
"type": "image",
|
|
"image_url": "https://example.com/bk_top2.png",
|
|
},
|
|
map[string]any{
|
|
"type": "section",
|
|
"text": map[string]any{
|
|
"type": "plain_text",
|
|
"text": "caption",
|
|
},
|
|
"accessory": map[string]any{
|
|
"type": "image",
|
|
"image_url": "https://example.com/bk_accessory.png",
|
|
},
|
|
},
|
|
},
|
|
PostPropsAdaptiveCards: []any{
|
|
map[string]any{
|
|
"type": "AdaptiveCard",
|
|
"body": []any{
|
|
map[string]any{
|
|
"type": "Image",
|
|
"url": "https://example.com/ac_card1_a.png",
|
|
},
|
|
map[string]any{
|
|
"type": "Image",
|
|
"url": "https://example.com/ac_card1_b.png",
|
|
},
|
|
},
|
|
},
|
|
map[string]any{
|
|
"type": "AdaptiveCard",
|
|
"body": []any{
|
|
map[string]any{
|
|
"type": "Image",
|
|
"url": "https://example.com/ac_card2.png",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
PostPropsAttachments: []*MessageAttachment{
|
|
{
|
|
ImageURL: "https://example.com/attach_main.png",
|
|
ThumbURL: "https://example.com/attach_thumb.png",
|
|
AuthorIcon: "https://example.com/attach_author.png",
|
|
FooterIcon: "https://example.com/attach_footer.png",
|
|
},
|
|
{ImageURL: "https://example.com/attach_second.png"},
|
|
nil,
|
|
{Text: "no images"},
|
|
},
|
|
},
|
|
}
|
|
|
|
urls := post.InteractiveBlocksImageURLs(true)
|
|
|
|
// Markdown images inside text blocks are not returned here; they are gathered with Post.AllStrings in getEmbedsAndImages.
|
|
assert.ElementsMatch(t, []string{
|
|
"https://example.com/mm_direct1.png",
|
|
"https://example.com/mm_direct2.png",
|
|
"https://example.com/mm_nested.png",
|
|
"https://example.com/mm_nested2.png",
|
|
"https://example.com/bk_top1.png",
|
|
"https://example.com/bk_top2.png",
|
|
"https://example.com/bk_accessory.png",
|
|
"https://example.com/ac_card1_a.png",
|
|
"https://example.com/ac_card1_b.png",
|
|
"https://example.com/ac_card2.png",
|
|
"https://example.com/attach_main.png",
|
|
"https://example.com/attach_thumb.png",
|
|
"https://example.com/attach_author.png",
|
|
"https://example.com/attach_footer.png",
|
|
"https://example.com/attach_second.png",
|
|
}, urls)
|
|
})
|
|
|
|
t.Run("attachment URLs only when mmBlocksEnabled is false", func(t *testing.T) {
|
|
post := &Post{
|
|
Props: StringInterface{
|
|
PostPropsMmBlocks: []any{
|
|
map[string]any{"type": "image", "url": "https://example.com/mm.png"},
|
|
},
|
|
PostPropsAttachments: []*MessageAttachment{
|
|
{ImageURL: "https://example.com/attach_main.png"},
|
|
},
|
|
},
|
|
}
|
|
urls := post.InteractiveBlocksImageURLs(false)
|
|
assert.ElementsMatch(t, []string{"https://example.com/attach_main.png"}, urls)
|
|
})
|
|
}
|