mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* [MM-59089] Add a compliance export constant (#27919) * add a useful constant * i18n * another constant * another i18n * [MM-60422] Add GetChannelsWithActivityDuring (#28301) * modify GetUsersInChannelDuring to accept a slice of channelIds * add GetChannelsWithActivityDuring * add compliance export progress message; remove unused custom status * linting * tests running too fast * add batch size config settings * add store tests * linting * empty commit * i18n changes * fix i18n ordering * MM-60570 - Server-side changes consolidating the export CLI with server/ent code (#28640) * add an i18n field; add the CLI's export directory * int64 -> int * Add UntilUpdateAt for MessageExport and AnalyticsPostCount to merge * remove now-unused i18n strings * add TranslationsPreInitFromBuffer to allow CLI to use i18n * use GetBuilder to simplify; rename TranslationsPreInitFromFileBytes * [MM-59089] Improve compliance export timings (#1733 - Enterprise repo) * MM-60422 - Performance and logic fixes for Compliance Exports (#1757 - Enterprise repo) * MM-60570 - Enterprise-side changes consolidating the export CLI with server/ent code (#1769 - Enterprise repo) * merge conflicts; missed file from ent branch * MM-61038 - Add an option to sqlstore.New (#28702) remove useless comment add test add an option to sqlstore.New * MM-60976: Remove RunExport command from Mattermost binary (#28805) * remove RunExport command from mattermost binary * remove the code it was calling * fix i18n * remove test (was only testing license, not functionality) * empty commit * fix flaky GetChannelsWithActivityDuring test * MM-60063: Dedicated Export Filestore fix, redo of #1772 (enterprise) (#28803) * redo filestore fix #1772 (enterprise repo) on top of MM-59966 feature * add new e2e tests for export filestore * golint * ok, note to self: shadowing bad, actually (when there's a defer) * empty commit * MM-61137 - Message export: Support 7.8.11 era dbs (#28824) * support 7.8.11 era dbs by wrapping the store using only what we need * fix flaky GetChannelsWithActivityDuring test * add a comment * only need to define the MEFileInfoStore (the one that'll be overridden) * blank commit * MM-60974 - Message Export: Add performance metrics (#28836) * support 7.8.11 era dbs by wrapping the store using only what we need * fix flaky GetChannelsWithActivityDuring test * add a comment * only need to define the MEFileInfoStore (the one that'll be overridden) * performance metrics * cleanup unneeded named returns * blank commit * MM-60975 - Message export: Add startTime and endTime to export folder name (#28840) * support 7.8.11 era dbs by wrapping the store using only what we need * fix flaky GetChannelsWithActivityDuring test * add a comment * only need to define the MEFileInfoStore (the one that'll be overridden) * performance metrics * output startTime and endTime in export folder * empty commit * merge conflict * MM-60978 - Message export: Improve xml fields; fix delete semantics (#28873) * support 7.8.11 era dbs by wrapping the store using only what we need * fix flaky GetChannelsWithActivityDuring test * add a comment * only need to define the MEFileInfoStore (the one that'll be overridden) * performance metrics * output startTime and endTime in export folder * empty commit * add xml fields, omit when empty, tests * fix delete semantics; test (and test for update semantics) * clarify comments * simplify edited post detection, now there's no edge case. * add some spacing to help fast running tests * merge conflicts/updates needed for new deleted post semantics * linting; fixing tests from upstream merge * use SafeDereference * linting * stronger typing; better wrapped errors; better formatting * blank commit * goimports formatting * fix merge mistake * minor fixes due to changes in master * MM-61755 - Simplifying and Support reporting to the db from the CLI (#29281) * finally clean up JobData struct and stringMap; prep for CLI using db * and now simplify using StringMapToJobDataWithZeroValues * remove unused fn * create JobDataExported; clean up errors * MM-60176 - Message Export: Global relay cleanup (#29168) * move global relay logic into global_relay_export * blank commit * blank commit * improve errors * MM-60693 - Refactor CSV to use same codepath as Actiance (#29191) * move global relay logic into global_relay_export * blank commit * refactor (and simplify) ExportParams into shared * blank commit * remove unused fn * csv now uses pre-calculated joins/leaves like actiance * improve errors * remove nil post check; remove ignoredPosts metric * remove unneeded copy * MM-61696 - Refactor GlobalRelay to use same codepath as Actiance (#29225) * move global relay logic into global_relay_export * blank commit * refactor (and simplify) ExportParams into shared * blank commit * remove unused fn * csv now uses pre-calculated joins/leaves like actiance * remove newly unneeded function and its test. goodbye. * refactor GetPostAttachments for csv + global relay to share * refactor global_relay_export and fix tests (no changes to output) * improve errors * remove nil post check; remove ignoredPosts metric * remove unneeded copy * remove unneeded nil check * PR comments * MM-61715 - Generalize e2e to all export types 🤖 (#29369) * move global relay logic into global_relay_export * blank commit * refactor (and simplify) ExportParams into shared * blank commit * remove unused fn * csv now uses pre-calculated joins/leaves like actiance * remove newly unneeded function and its test. goodbye. * refactor GetPostAttachments for csv + global relay to share * refactor global_relay_export and fix tests (no changes to output) * improve errors * remove nil post check; remove ignoredPosts metric * remove unneeded copy * remove unneeded nil check * PR comments * refactor isDeletedMsg for all export types * fix start and endtime, nasty csv createAt bug; bring closer to Actiance * align unit tests with new logic (e.g. starttime / endtime) * refactor a TimestampConvert fn for code + tests * bug: pass templates to global relay (hurray for e2e tests, otherwise...) * add global relay zip to allowed list (only for tests) * test helpers * new templates for e2e tests * e2e tests... phew. * linting * merge conflicts * unexport PostToRow; add test helper marker * cleanup, shortening, thanks to PR comments * MM-61972 - Generalize export data path - Actiance (#29399) * extract and generalize the export data generation functions * finish moving test (bc of previous extraction) * lift a function from common -> shared (to break an import cycle) * actiance now takes general export data, processes it into actiance data * bring tests in line with correct sorting rules (upadateAt, messageId) * fixups, PR comments * turn strings.Repeat into a more descriptive const amended: one letter fix; bad rebase * MM-62009 - e2e clock heisenbug (#29434) * consolidate assertions; output debuggable diffs (keeping for future) * refactor test output generator to generators file * waitUntilZeroPosts + pass through until to job = fix all clock issues * simplify messages to model.NewId(); remove unneeded waitUntilZeroPosts * model.NewId() -> storetest.NewTestID() * MM-61980 - Generalize export data path - CSV (#29482) * simple refactoring * increase sleep times for (very) rare test failures * add extra information to the generic export for CSV * adj Actiance to handle new generic export (no difference in its output) * no longer need mergePosts (yay), move getJoinLeavePosts for everyone * adjust tests for new csv semantics (detailed in summary) * and need to add the new exported data to the export_data_tests * rearrange csv writing to happen after data export (more logical) * linting * remove debug statements * figured out what was wrong with global relay e2e test 3; solid now * PR comments * MM-61718 - Generalize export data path - Global Relay (#29508) * move global relay over to using the generalized export data * performance pass -- not much can be done * Update server/enterprise/message_export/global_relay_export/global_relay_export.go Co-authored-by: Claudio Costa <[email protected]> --------- Co-authored-by: Claudio Costa <[email protected]> * MM-62058 - Align CSV with Actiance (#29551) * refactoring actiance files and var names for clarity * bug found in exported attachments (we used to miss some start/ends) * changes needed for actiance due to new generic exports * bringing CSV up to actiance standards * fixing global relay b/c of new semantics (adding a note on an edge case) * aligning e2e tests, adding comments to clarify what is expected/tested * necessary changes; 1 more test for added functionality (ignoreDeleted) * comment style * MM-62059 - Align Global Relay with Actiance/CSV; many fixes (#29665) * core logic changes to general export_data and the specific export paths * unit tests and e2e tests, covering all new edge cases and all logic * linting * better var naming, const value, and cleaning up functions calls * MM-62436 - Temporarily skip cypress tests that require download link (#29772) --------- Co-authored-by: Claudio Costa <[email protected]>
1018 lines
24 KiB
Go
1018 lines
24 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"database/sql"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-sql-driver/mysql"
|
|
"github.com/lib/pq"
|
|
"github.com/pkg/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"golang.org/x/sync/errgroup"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin/plugintest/mock"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/db"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/searchtest"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest"
|
|
"github.com/mattermost/mattermost/server/v8/einterfaces/mocks"
|
|
)
|
|
|
|
type storeType struct {
|
|
Name string
|
|
SqlSettings *model.SqlSettings
|
|
SqlStore *SqlStore
|
|
Store store.Store
|
|
}
|
|
|
|
var storeTypes []*storeType
|
|
|
|
func newStoreType(name, driver string) *storeType {
|
|
return &storeType{
|
|
Name: name,
|
|
SqlSettings: storetest.MakeSqlSettings(driver, false),
|
|
}
|
|
}
|
|
|
|
func StoreTest(t *testing.T, f func(*testing.T, request.CTX, store.Store)) {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
tearDownStores()
|
|
panic(err)
|
|
}
|
|
}()
|
|
for _, st := range storeTypes {
|
|
st := st
|
|
rctx := request.TestContext(t)
|
|
|
|
t.Run(st.Name, func(t *testing.T) {
|
|
if testing.Short() {
|
|
t.SkipNow()
|
|
}
|
|
f(t, rctx, st.Store)
|
|
})
|
|
}
|
|
}
|
|
|
|
func StoreTestWithSearchTestEngine(t *testing.T, f func(*testing.T, store.Store, *searchtest.SearchTestEngine)) {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
tearDownStores()
|
|
panic(err)
|
|
}
|
|
}()
|
|
|
|
for _, st := range storeTypes {
|
|
st := st
|
|
searchTestEngine := &searchtest.SearchTestEngine{
|
|
Driver: *st.SqlSettings.DriverName,
|
|
}
|
|
|
|
t.Run(st.Name, func(t *testing.T) { f(t, st.Store, searchTestEngine) })
|
|
}
|
|
}
|
|
|
|
func StoreTestWithSqlStore(t *testing.T, f func(*testing.T, request.CTX, store.Store, storetest.SqlStore)) {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
tearDownStores()
|
|
panic(err)
|
|
}
|
|
}()
|
|
for _, st := range storeTypes {
|
|
st := st
|
|
rctx := request.TestContext(t)
|
|
|
|
t.Run(st.Name, func(t *testing.T) {
|
|
if testing.Short() {
|
|
t.SkipNow()
|
|
}
|
|
f(t, rctx, st.Store, &StoreTestWrapper{st.SqlStore})
|
|
})
|
|
}
|
|
}
|
|
|
|
func initStores(logger mlog.LoggerIFace) {
|
|
if testing.Short() {
|
|
return
|
|
}
|
|
// In CI, we already run the entire test suite for both mysql and postgres in parallel.
|
|
// So we just run the tests for the current database set.
|
|
if os.Getenv("IS_CI") == "true" {
|
|
switch os.Getenv("MM_SQLSETTINGS_DRIVERNAME") {
|
|
case "mysql":
|
|
storeTypes = append(storeTypes, newStoreType("MySQL", model.DatabaseDriverMysql))
|
|
case "postgres":
|
|
storeTypes = append(storeTypes, newStoreType("PostgreSQL", model.DatabaseDriverPostgres))
|
|
}
|
|
} else {
|
|
storeTypes = append(storeTypes,
|
|
newStoreType("MySQL", model.DatabaseDriverMysql),
|
|
newStoreType("PostgreSQL", model.DatabaseDriverPostgres),
|
|
)
|
|
}
|
|
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
tearDownStores()
|
|
panic(err)
|
|
}
|
|
}()
|
|
|
|
var eg errgroup.Group
|
|
for _, st := range storeTypes {
|
|
st := st
|
|
eg.Go(func() error {
|
|
var err error
|
|
st.SqlStore, err = New(*st.SqlSettings, logger, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
st.Store = st.SqlStore
|
|
st.Store.DropAllTables()
|
|
st.Store.MarkSystemRanUnitTests()
|
|
|
|
return nil
|
|
})
|
|
}
|
|
if err := eg.Wait(); err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
var tearDownStoresOnce sync.Once
|
|
|
|
func tearDownStores() {
|
|
if testing.Short() {
|
|
return
|
|
}
|
|
tearDownStoresOnce.Do(func() {
|
|
var wg sync.WaitGroup
|
|
wg.Add(len(storeTypes))
|
|
for _, st := range storeTypes {
|
|
st := st
|
|
go func() {
|
|
if st.Store != nil {
|
|
st.Store.Close()
|
|
}
|
|
if st.SqlSettings != nil {
|
|
storetest.CleanupSqlSettings(st.SqlSettings)
|
|
}
|
|
wg.Done()
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
})
|
|
}
|
|
|
|
// This test was used to consistently reproduce the race
|
|
// before the fix in MM-28397.
|
|
// Keeping it here to help avoiding future regressions.
|
|
func TestStoreLicenseRace(t *testing.T) {
|
|
logger := mlog.CreateTestLogger(t)
|
|
|
|
settings, err := makeSqlSettings(model.DatabaseDriverPostgres)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
store.Close()
|
|
storetest.CleanupSqlSettings(settings)
|
|
}()
|
|
|
|
wg := sync.WaitGroup{}
|
|
wg.Add(3)
|
|
|
|
go func() {
|
|
store.UpdateLicense(&model.License{})
|
|
wg.Done()
|
|
}()
|
|
|
|
go func() {
|
|
store.GetReplica()
|
|
wg.Done()
|
|
}()
|
|
|
|
go func() {
|
|
store.GetSearchReplicaX()
|
|
wg.Done()
|
|
}()
|
|
|
|
wg.Wait()
|
|
}
|
|
|
|
func TestGetReplica(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := mlog.CreateTestLogger(t)
|
|
|
|
testCases := []struct {
|
|
Description string
|
|
DataSourceReplicaNum int
|
|
DataSourceSearchReplicaNum int
|
|
}{
|
|
{
|
|
"no replicas",
|
|
0,
|
|
0,
|
|
},
|
|
{
|
|
"one source replica",
|
|
1,
|
|
0,
|
|
},
|
|
{
|
|
"multiple source replicas",
|
|
3,
|
|
0,
|
|
},
|
|
{
|
|
"one source search replica",
|
|
0,
|
|
1,
|
|
},
|
|
{
|
|
"multiple source search replicas",
|
|
0,
|
|
3,
|
|
},
|
|
{
|
|
"one source replica, one source search replica",
|
|
1,
|
|
1,
|
|
},
|
|
{
|
|
"one source replica, multiple source search replicas",
|
|
1,
|
|
3,
|
|
},
|
|
{
|
|
"multiple source replica, one source search replica",
|
|
3,
|
|
1,
|
|
},
|
|
{
|
|
"multiple source replica, multiple source search replicas",
|
|
3,
|
|
3,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.Description+" with license", func(t *testing.T) {
|
|
settings, err := makeSqlSettings(model.DatabaseDriverPostgres)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
|
|
dataSourceReplicas := []string{}
|
|
dataSourceSearchReplicas := []string{}
|
|
for i := 0; i < testCase.DataSourceReplicaNum; i++ {
|
|
dataSourceReplicas = append(dataSourceReplicas, *settings.DataSource)
|
|
}
|
|
for i := 0; i < testCase.DataSourceSearchReplicaNum; i++ {
|
|
dataSourceSearchReplicas = append(dataSourceSearchReplicas, *settings.DataSource)
|
|
}
|
|
|
|
settings.DataSourceReplicas = dataSourceReplicas
|
|
settings.DataSourceSearchReplicas = dataSourceSearchReplicas
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
store.Close()
|
|
storetest.CleanupSqlSettings(settings)
|
|
}()
|
|
|
|
store.UpdateLicense(&model.License{})
|
|
|
|
replicas := make(map[*sqlxDBWrapper]bool)
|
|
for i := 0; i < 5; i++ {
|
|
replicas[store.GetReplica()] = true
|
|
}
|
|
|
|
searchReplicas := make(map[*sqlxDBWrapper]bool)
|
|
for i := 0; i < 5; i++ {
|
|
searchReplicas[store.GetSearchReplicaX()] = true
|
|
}
|
|
|
|
if testCase.DataSourceReplicaNum > 0 {
|
|
// If replicas were defined, ensure none are the master.
|
|
assert.Len(t, replicas, testCase.DataSourceReplicaNum)
|
|
|
|
for replica := range replicas {
|
|
assert.NotSame(t, store.GetMaster(), replica)
|
|
}
|
|
} else if assert.Len(t, replicas, 1) {
|
|
// Otherwise ensure the replicas contains only the master.
|
|
for replica := range replicas {
|
|
assert.Same(t, store.GetMaster(), replica)
|
|
}
|
|
}
|
|
|
|
if testCase.DataSourceSearchReplicaNum > 0 {
|
|
// If search replicas were defined, ensure none are the master nor the replicas.
|
|
assert.Len(t, searchReplicas, testCase.DataSourceSearchReplicaNum)
|
|
|
|
for searchReplica := range searchReplicas {
|
|
assert.NotSame(t, store.GetMaster(), searchReplica)
|
|
for replica := range replicas {
|
|
assert.NotSame(t, searchReplica, replica)
|
|
}
|
|
}
|
|
} else if testCase.DataSourceReplicaNum > 0 {
|
|
assert.Equal(t, len(replicas), len(searchReplicas))
|
|
for k := range replicas {
|
|
assert.True(t, searchReplicas[k])
|
|
}
|
|
} else if testCase.DataSourceReplicaNum == 0 && assert.Len(t, searchReplicas, 1) {
|
|
// Otherwise ensure the search replicas contains the master.
|
|
for searchReplica := range searchReplicas {
|
|
assert.Same(t, store.GetMaster(), searchReplica)
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run(testCase.Description+" without license", func(t *testing.T) {
|
|
settings, err := makeSqlSettings(model.DatabaseDriverPostgres)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
|
|
dataSourceReplicas := []string{}
|
|
dataSourceSearchReplicas := []string{}
|
|
for i := 0; i < testCase.DataSourceReplicaNum; i++ {
|
|
dataSourceReplicas = append(dataSourceReplicas, *settings.DataSource)
|
|
}
|
|
for i := 0; i < testCase.DataSourceSearchReplicaNum; i++ {
|
|
dataSourceSearchReplicas = append(dataSourceSearchReplicas, *settings.DataSource)
|
|
}
|
|
|
|
settings.DataSourceReplicas = dataSourceReplicas
|
|
settings.DataSourceSearchReplicas = dataSourceSearchReplicas
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
store.Close()
|
|
storetest.CleanupSqlSettings(settings)
|
|
}()
|
|
|
|
replicas := make(map[*sqlxDBWrapper]bool)
|
|
for i := 0; i < 5; i++ {
|
|
replicas[store.GetReplica()] = true
|
|
}
|
|
|
|
searchReplicas := make(map[*sqlxDBWrapper]bool)
|
|
for i := 0; i < 5; i++ {
|
|
searchReplicas[store.GetSearchReplicaX()] = true
|
|
}
|
|
|
|
if testCase.DataSourceReplicaNum > 0 {
|
|
// If replicas were defined, ensure none are the master.
|
|
assert.Len(t, replicas, 1)
|
|
|
|
for replica := range replicas {
|
|
assert.Same(t, store.GetMaster(), replica)
|
|
}
|
|
} else if assert.Len(t, replicas, 1) {
|
|
// Otherwise ensure the replicas contains only the master.
|
|
for replica := range replicas {
|
|
assert.Same(t, store.GetMaster(), replica)
|
|
}
|
|
}
|
|
|
|
if testCase.DataSourceSearchReplicaNum > 0 {
|
|
// If search replicas were defined, ensure none are the master nor the replicas.
|
|
assert.Len(t, searchReplicas, 1)
|
|
|
|
for searchReplica := range searchReplicas {
|
|
assert.Same(t, store.GetMaster(), searchReplica)
|
|
}
|
|
} else if testCase.DataSourceReplicaNum > 0 {
|
|
assert.Equal(t, len(replicas), len(searchReplicas))
|
|
for k := range replicas {
|
|
assert.True(t, searchReplicas[k])
|
|
}
|
|
} else if assert.Len(t, searchReplicas, 1) {
|
|
// Otherwise ensure the search replicas contains the master.
|
|
for searchReplica := range searchReplicas {
|
|
assert.Same(t, store.GetMaster(), searchReplica)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetDbVersion(t *testing.T) {
|
|
logger := mlog.CreateTestLogger(t)
|
|
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
for _, d := range testDrivers {
|
|
driver := d
|
|
t.Run("Should return db version for "+driver, func(t *testing.T) {
|
|
t.Parallel()
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
|
|
version, err := store.GetDbVersion(false)
|
|
require.NoError(t, err)
|
|
require.Regexp(t, regexp.MustCompile(`\d+\.\d+(\.\d+)?`), version)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestEnsureMinimumDBVersion(t *testing.T) {
|
|
tests := []struct {
|
|
driver string
|
|
ver string
|
|
ok bool
|
|
err string
|
|
}{
|
|
{
|
|
driver: model.DatabaseDriverPostgres,
|
|
ver: "100001",
|
|
ok: false,
|
|
err: "",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverPostgres,
|
|
ver: "110001",
|
|
ok: true,
|
|
err: "",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverPostgres,
|
|
ver: "90603",
|
|
ok: false,
|
|
err: "minimum Postgres version requirements not met",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverPostgres,
|
|
ver: "12.34.1",
|
|
ok: false,
|
|
err: "cannot parse DB version",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverMysql,
|
|
ver: "10.4.5-MariaDB",
|
|
ok: true,
|
|
err: "",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverMysql,
|
|
ver: "5.6.99-test",
|
|
ok: false,
|
|
err: "Minimum MySQL version requirements not met",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverMysql,
|
|
ver: "34-55.12",
|
|
ok: false,
|
|
err: "cannot parse MySQL DB version",
|
|
},
|
|
{
|
|
driver: model.DatabaseDriverMysql,
|
|
ver: "8.0.0-log",
|
|
ok: true,
|
|
err: "",
|
|
},
|
|
}
|
|
|
|
pg := model.DatabaseDriverPostgres
|
|
pgSettings := &model.SqlSettings{
|
|
DriverName: &pg,
|
|
}
|
|
my := model.DatabaseDriverMysql
|
|
mySettings := &model.SqlSettings{
|
|
DriverName: &my,
|
|
}
|
|
for _, tc := range tests {
|
|
store := &SqlStore{}
|
|
switch tc.driver {
|
|
case pg:
|
|
store.settings = pgSettings
|
|
case my:
|
|
store.settings = mySettings
|
|
}
|
|
ok, err := store.ensureMinimumDBVersion(tc.ver)
|
|
assert.Equal(t, tc.ok, ok)
|
|
if tc.err != "" {
|
|
assert.Contains(t, err.Error(), tc.err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIsBinaryParamEnabled(t *testing.T) {
|
|
tests := []struct {
|
|
store SqlStore
|
|
expected bool
|
|
}{
|
|
{
|
|
store: SqlStore{
|
|
settings: &model.SqlSettings{
|
|
DriverName: model.NewPointer(model.DatabaseDriverPostgres),
|
|
DataSource: model.NewPointer("postgres://mmuser:mostest@localhost/loadtest?sslmode=disable\u0026binary_parameters=yes"),
|
|
},
|
|
},
|
|
expected: true,
|
|
},
|
|
{
|
|
store: SqlStore{
|
|
settings: &model.SqlSettings{
|
|
DriverName: model.NewPointer(model.DatabaseDriverMysql),
|
|
DataSource: model.NewPointer("postgres://mmuser:mostest@localhost/loadtest?sslmode=disable\u0026binary_parameters=yes"),
|
|
},
|
|
},
|
|
expected: false,
|
|
},
|
|
{
|
|
store: SqlStore{
|
|
settings: &model.SqlSettings{
|
|
DriverName: model.NewPointer(model.DatabaseDriverPostgres),
|
|
DataSource: model.NewPointer("postgres://mmuser:mostest@localhost/loadtest?sslmode=disable&binary_parameters=yes"),
|
|
},
|
|
},
|
|
expected: true,
|
|
},
|
|
{
|
|
store: SqlStore{
|
|
settings: &model.SqlSettings{
|
|
DriverName: model.NewPointer(model.DatabaseDriverPostgres),
|
|
DataSource: model.NewPointer("postgres://mmuser:mostest@localhost/loadtest?sslmode=disable"),
|
|
},
|
|
},
|
|
expected: false,
|
|
},
|
|
}
|
|
|
|
for i := range tests {
|
|
ok, err := tests[i].store.computeBinaryParam()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tests[i].expected, ok)
|
|
}
|
|
}
|
|
|
|
func TestGetAllConns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
testCases := []struct {
|
|
Description string
|
|
DataSourceReplicaNum int
|
|
DataSourceSearchReplicaNum int
|
|
ExpectedNumConnections int
|
|
}{
|
|
{
|
|
"no replicas",
|
|
0,
|
|
0,
|
|
1,
|
|
},
|
|
{
|
|
"one source replica",
|
|
1,
|
|
0,
|
|
2,
|
|
},
|
|
{
|
|
"multiple source replicas",
|
|
3,
|
|
0,
|
|
4,
|
|
},
|
|
{
|
|
"one source search replica",
|
|
0,
|
|
1,
|
|
1,
|
|
},
|
|
{
|
|
"multiple source search replicas",
|
|
0,
|
|
3,
|
|
1,
|
|
},
|
|
{
|
|
"one source replica, one source search replica",
|
|
1,
|
|
1,
|
|
2,
|
|
},
|
|
{
|
|
"one source replica, multiple source search replicas",
|
|
1,
|
|
3,
|
|
2,
|
|
},
|
|
{
|
|
"multiple source replica, one source search replica",
|
|
3,
|
|
1,
|
|
4,
|
|
},
|
|
{
|
|
"multiple source replica, multiple source search replicas",
|
|
3,
|
|
3,
|
|
4,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.Description, func(t *testing.T) {
|
|
t.Parallel()
|
|
settings, err := makeSqlSettings(model.DatabaseDriverPostgres)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
dataSourceReplicas := []string{}
|
|
dataSourceSearchReplicas := []string{}
|
|
for i := 0; i < testCase.DataSourceReplicaNum; i++ {
|
|
dataSourceReplicas = append(dataSourceReplicas, *settings.DataSource)
|
|
}
|
|
for i := 0; i < testCase.DataSourceSearchReplicaNum; i++ {
|
|
dataSourceSearchReplicas = append(dataSourceSearchReplicas, *settings.DataSource)
|
|
}
|
|
|
|
settings.DataSourceReplicas = dataSourceReplicas
|
|
settings.DataSourceSearchReplicas = dataSourceSearchReplicas
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
store.Close()
|
|
storetest.CleanupSqlSettings(settings)
|
|
}()
|
|
|
|
assert.Len(t, store.GetAllConns(), testCase.ExpectedNumConnections)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIsDuplicate(t *testing.T) {
|
|
testErrors := map[error]bool{
|
|
&pq.Error{Code: "42P06"}: false,
|
|
&pq.Error{Code: PGDupTableErrorCode}: true,
|
|
&mysql.MySQLError{Number: uint16(1000)}: false,
|
|
&mysql.MySQLError{Number: MySQLDupTableErrorCode}: true,
|
|
errors.New("Random error"): false,
|
|
}
|
|
|
|
for e, b := range testErrors {
|
|
err := e
|
|
expected := b
|
|
t.Run(fmt.Sprintf("Should return %t for %s", expected, err.Error()), func(t *testing.T) {
|
|
t.Parallel()
|
|
assert.Equal(t, expected, IsDuplicate(err))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestVersionString(t *testing.T) {
|
|
versions := []struct {
|
|
input int
|
|
driver string
|
|
output string
|
|
}{
|
|
{
|
|
input: 100000,
|
|
driver: model.DatabaseDriverPostgres,
|
|
output: "10.0",
|
|
},
|
|
{
|
|
input: 90603,
|
|
driver: model.DatabaseDriverPostgres,
|
|
output: "9.603",
|
|
},
|
|
{
|
|
input: 120005,
|
|
driver: model.DatabaseDriverPostgres,
|
|
output: "12.5",
|
|
},
|
|
{
|
|
input: 5708,
|
|
driver: model.DatabaseDriverMysql,
|
|
output: "5.7.8",
|
|
},
|
|
{
|
|
input: 8000,
|
|
driver: model.DatabaseDriverMysql,
|
|
output: "8.0.0",
|
|
},
|
|
}
|
|
|
|
for _, v := range versions {
|
|
out := versionString(v.input, v.driver)
|
|
assert.Equal(t, v.output, out)
|
|
}
|
|
}
|
|
|
|
func TestReplicaLagQuery(t *testing.T) {
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
for _, driver := range testDrivers {
|
|
t.Run(driver, func(t *testing.T) {
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
var query string
|
|
var tableName string
|
|
// Just any random query which returns a row in (string, int) format.
|
|
switch driver {
|
|
case model.DatabaseDriverPostgres:
|
|
query = `SELECT relname, count(relname) FROM pg_class WHERE relname='posts' GROUP BY relname`
|
|
tableName = "posts"
|
|
case model.DatabaseDriverMysql:
|
|
query = `SELECT table_name, count(table_name) FROM information_schema.tables WHERE table_name='Posts' and table_schema=Database() GROUP BY table_name`
|
|
tableName = "Posts"
|
|
}
|
|
|
|
settings.ReplicaLagSettings = []*model.ReplicaLagSettings{{
|
|
DataSource: model.NewPointer(*settings.DataSource),
|
|
QueryAbsoluteLag: model.NewPointer(query),
|
|
QueryTimeLag: model.NewPointer(query),
|
|
}}
|
|
|
|
mockMetrics := &mocks.MetricsInterface{}
|
|
mockMetrics.On("SetReplicaLagAbsolute", tableName, float64(1))
|
|
mockMetrics.On("SetReplicaLagTime", tableName, float64(1))
|
|
mockMetrics.On("RegisterDBCollector", mock.AnythingOfType("*sql.DB"), "master")
|
|
|
|
store := &SqlStore{
|
|
rrCounter: 0,
|
|
srCounter: 0,
|
|
settings: settings,
|
|
metrics: mockMetrics,
|
|
logger: mlog.CreateConsoleTestLogger(t),
|
|
quitMonitor: make(chan struct{}),
|
|
wgMonitor: &sync.WaitGroup{},
|
|
}
|
|
|
|
require.NoError(t, store.initConnection())
|
|
store.stores.post = newSqlPostStore(store, mockMetrics)
|
|
err = store.migrate(migrationsDirectionUp, false)
|
|
require.NoError(t, err)
|
|
|
|
defer store.Close()
|
|
|
|
err = store.ReplicaLagAbs()
|
|
require.NoError(t, err)
|
|
err = store.ReplicaLagTime()
|
|
require.NoError(t, err)
|
|
mockMetrics.AssertExpectations(t)
|
|
})
|
|
}
|
|
}
|
|
|
|
var errDriverMismatch = errors.New("database drivers mismatch")
|
|
var errDriverUnsupported = errors.New("database driver not supported")
|
|
|
|
func makeSqlSettings(driver string) (*model.SqlSettings, error) {
|
|
// When running under CI, only one database engine container is launched
|
|
// so here we must error out if the requested driver doesn't match.
|
|
if os.Getenv("IS_CI") == "true" {
|
|
envDriver := os.Getenv("MM_SQLSETTINGS_DRIVERNAME")
|
|
if envDriver != "" && envDriver != driver {
|
|
return nil, errDriverMismatch
|
|
}
|
|
}
|
|
|
|
switch driver {
|
|
case model.DatabaseDriverPostgres:
|
|
return storetest.MakeSqlSettings(driver, false), nil
|
|
case model.DatabaseDriverMysql:
|
|
return storetest.MakeSqlSettings(driver, false), nil
|
|
}
|
|
|
|
return nil, errDriverUnsupported
|
|
}
|
|
|
|
func TestExecNoTimeout(t *testing.T) {
|
|
StoreTest(t, func(t *testing.T, rctx request.CTX, ss store.Store) {
|
|
sqlStore := ss.(*SqlStore)
|
|
var query string
|
|
timeout := sqlStore.masterX.queryTimeout
|
|
sqlStore.masterX.queryTimeout = 1
|
|
defer func() {
|
|
sqlStore.masterX.queryTimeout = timeout
|
|
}()
|
|
if sqlStore.DriverName() == model.DatabaseDriverMysql {
|
|
query = `SELECT SLEEP(2);`
|
|
} else if sqlStore.DriverName() == model.DatabaseDriverPostgres {
|
|
query = `SELECT pg_sleep(2);`
|
|
}
|
|
_, err := sqlStore.GetMaster().ExecNoTimeout(query)
|
|
require.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestMySQLReadTimeout(t *testing.T) {
|
|
settings, err := makeSqlSettings(model.DatabaseDriverMysql)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
dataSource := *settings.DataSource
|
|
config, err := mysql.ParseDSN(dataSource)
|
|
require.NoError(t, err)
|
|
|
|
config.ReadTimeout = 1 * time.Second
|
|
dataSource = config.FormatDSN()
|
|
settings.DataSource = &dataSource
|
|
|
|
store := &SqlStore{
|
|
settings: settings,
|
|
logger: mlog.CreateConsoleTestLogger(t),
|
|
quitMonitor: make(chan struct{}),
|
|
wgMonitor: &sync.WaitGroup{},
|
|
}
|
|
require.NoError(t, store.initConnection())
|
|
defer store.Close()
|
|
|
|
_, err = store.GetMaster().ExecNoTimeout(`SELECT SLEEP(3)`)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestGetDBSchemaVersion(t *testing.T) {
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
assets := db.Assets()
|
|
|
|
for _, d := range testDrivers {
|
|
driver := d
|
|
t.Run("Should return latest version number of applied migrations for "+driver, func(t *testing.T) {
|
|
t.Parallel()
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
|
|
assetsList, err := assets.ReadDir(filepath.Join("migrations", driver))
|
|
require.NoError(t, err)
|
|
|
|
var assetNamesForDriver []string
|
|
for _, entry := range assetsList {
|
|
assetNamesForDriver = append(assetNamesForDriver, entry.Name())
|
|
}
|
|
sort.Strings(assetNamesForDriver)
|
|
|
|
require.NotEmpty(t, assetNamesForDriver)
|
|
lastMigration := assetNamesForDriver[len(assetNamesForDriver)-1]
|
|
expectedVersion := strings.Split(lastMigration, "_")[0]
|
|
|
|
version, err := store.GetDBSchemaVersion()
|
|
require.NoError(t, err)
|
|
require.Equal(t, expectedVersion, fmt.Sprintf("%06d", version))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetLocalSchemaVersion(t *testing.T) {
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
for _, d := range testDrivers {
|
|
driver := d
|
|
t.Run(driver, func(t *testing.T) {
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
|
|
ver, err := store.GetLocalSchemaVersion()
|
|
require.NoError(t, err)
|
|
|
|
dbVer, err := store.GetDBSchemaVersion()
|
|
require.NoError(t, err)
|
|
require.Equal(t, ver, dbVer)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetAppliedMigrations(t *testing.T) {
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
assets := db.Assets()
|
|
|
|
for _, d := range testDrivers {
|
|
driver := d
|
|
t.Run("Should return db applied migrations for "+driver, func(t *testing.T) {
|
|
t.Parallel()
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
store, err := New(*settings, logger, nil)
|
|
require.NoError(t, err)
|
|
|
|
assetsList, err := assets.ReadDir(filepath.Join("migrations", driver))
|
|
require.NoError(t, err)
|
|
|
|
var migrationsFromFiles []model.AppliedMigration
|
|
for _, entry := range assetsList {
|
|
if strings.HasSuffix(entry.Name(), ".up.sql") {
|
|
versionString := strings.Split(entry.Name(), "_")[0]
|
|
version, vErr := strconv.Atoi(versionString)
|
|
require.NoError(t, vErr)
|
|
|
|
name := strings.TrimSuffix(strings.TrimLeft(entry.Name(), versionString+"_"), ".up.sql")
|
|
|
|
migrationsFromFiles = append(migrationsFromFiles, model.AppliedMigration{
|
|
Version: version,
|
|
Name: name,
|
|
})
|
|
}
|
|
}
|
|
|
|
require.NotEmpty(t, migrationsFromFiles)
|
|
|
|
migrations, err := store.GetAppliedMigrations()
|
|
require.NoError(t, err)
|
|
require.ElementsMatch(t, migrationsFromFiles, migrations)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSkipMigrationsOption(t *testing.T) {
|
|
testDrivers := []string{
|
|
model.DatabaseDriverPostgres,
|
|
model.DatabaseDriverMysql,
|
|
}
|
|
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
for _, d := range testDrivers {
|
|
driver := d
|
|
t.Run("Should not apply migrations when skipMigrations=true for "+driver, func(t *testing.T) {
|
|
t.Parallel()
|
|
settings, err := makeSqlSettings(driver)
|
|
if err != nil {
|
|
t.Skip(err)
|
|
}
|
|
|
|
store, err := New(*settings, logger, nil, SkipMigrations())
|
|
require.NoError(t, err)
|
|
|
|
_, err = store.GetDBSchemaVersion()
|
|
assert.Error(t, err)
|
|
|
|
// Unfortunately there's no error for table doesn't exist, but we know it won't be ErrNoRows:
|
|
assert.True(t, !errors.Is(err, sql.ErrNoRows))
|
|
|
|
// And we know what each db will return:
|
|
if driver == model.DatabaseDriverPostgres {
|
|
assert.Contains(t, err.Error(), "pq: relation \"db_migrations\" does not exist")
|
|
} else {
|
|
// Mysql includes the random db name, so test the end:
|
|
assert.Contains(t, err.Error(), ".db_migrations' doesn't exist")
|
|
}
|
|
})
|
|
}
|
|
}
|