mirror of
https://github.com/hanzoai/team.git
synced 2026-10-30 14:49:35 +00:00
ce5644223a
* allow workflow_dispatch trigger for Server CI (for plugins CI) * [MM-68402] MBE Phase 2: declare four generic plugin hooks (#36291) * new hooks-only phase 2 * remove ChannelWillBeMoved * remove RecapWillBeProcessed and MessageWillBeRewrittenByAI Drop the AI/recap hooks from the new-hook surface; AI-LLM paths remain uncovered in tech preview and are documented as residuals. * [MM-68403] MBE Phase 3: ChannelGuards primitive (storage + cache + plugin API) (#36365) * phase 3 * phase 3: register ChannelGuard mock in test setup helper NewChannels' startup-time call to reloadGuardCache invokes s.ChannelGuard().GetAll(); without an expectation on the mock store, every test that sets up the server with GetMockStoreForSetupFunctions panics during init. * phase 3: register ChannelGuard mock in retrylayer test retrylayer.New walks every store getter to wrap it; without the mock expectation on ChannelGuard, TestRetry panics during layer construction. * use rctx properly in the store methods * phase 3: match rctx arg in testlib ChannelGuard mock GetAll now takes request.CTX, so the testify expectation must include mock.Anything; otherwise the call panics under the mocked store. * phase 3: set api.ctx in TestChannelGuardLowercaseNormalization The test constructs PluginAPI directly without a ctx, which used to work when App.RegisterChannelGuard built its own EmptyContext. Now that the App methods take rctx from the caller, the nil ctx panics inside RequestContextWithMaster. * [MM-68404] MBE Phase 4: App-layer plugin hook wiring (#36407) * phase 4 * Fix nil rctx in TestChannelGuardLowercaseNormalization The PluginAPI struct literal was missing ctx: rctx after a refactor moved the rctx declaration below the struct construction, leaving api.ctx as nil. This caused a nil pointer dereference in reloadGuardCache when RegisterChannelGuard called store.RequestContextWithMaster(nil). * Remove ChannelWillBeMoved hook call from MoveChannel (phase 4) The hook and its ID were removed from mbe-phase-2 but the call site in MoveChannel and its i18n string were not cleaned up during the rebase. * remove channel will be moved test * Remove RecapWillBeProcessed and MessageWillBeRewrittenByAI hook calls (phase 4) The hooks and their IDs were removed from mbe-phase-2 but the call sites in ProcessRecapChannel and RewriteMessage, their i18n strings, and their tests were not cleaned up during the rebase. * Revert channel_id plumbing on rewrite endpoint (phase 4) The channel_id field on RewriteRequest was added in phase 4 to feed the synthetic post passed to MessageWillBeRewrittenByAI. With that hook removed from mbe-phase-2, channel_id has no consumer; revert the field, the api4 validation, the app.RewriteMessage parameter, and the corresponding webapp client + hook plumbing. * [MM-68555] MBE Phase 5: Channel-guard enforcement + two-phase dispatch (#36473) * phase 5 * Bake plugin counter-file paths into source instead of env vars t.Setenv panics when an ancestor test calls t.Parallel, so the two channel-guard tests broke under ENABLE_FULLY_PARALLEL_TESTS in CI. Build each plugin source per-subtest with its temp file path embedded as a Go literal — same pattern as TestPluginUploadsAPI. * Remove guarded helpers and tests for dropped hooks (phase 5) The runGuardedRecapWillBeProcessed and runGuardedMessageWillBeRewrittenByAI helpers were never wired (their app-layer call sites were already removed in the phase-4 cleanup), and the corresponding sub-tests across panic / allow / reject / partial plugins reference hooks that no longer exist. * [MM-68405] MBE Phase 6: fire MessagesWillBeConsumed on the edit path (#36475) --------- --------- --------- --------- * rebase onto master --------- Co-authored-by: Hanzo Dev <[email protected]>
69 lines
2.4 KiB
Go
69 lines
2.4 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"encoding/json"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
)
|
|
|
|
func (s *Server) clusterInstallPluginHandler(msg *model.ClusterMessage) {
|
|
var data model.PluginEventData
|
|
if jsonErr := json.Unmarshal(msg.Data, &data); jsonErr != nil {
|
|
s.Log().Warn("Failed to decode from JSON", mlog.Err(jsonErr))
|
|
}
|
|
s.Channels().installPluginFromClusterMessage(data.Id)
|
|
}
|
|
|
|
func (s *Server) clusterRemovePluginHandler(msg *model.ClusterMessage) {
|
|
var data model.PluginEventData
|
|
if jsonErr := json.Unmarshal(msg.Data, &data); jsonErr != nil {
|
|
s.Log().Warn("Failed to decode from JSON", mlog.Err(jsonErr))
|
|
}
|
|
s.Channels().removePluginFromClusterMessage(data.Id)
|
|
}
|
|
|
|
func (s *Server) clusterPluginEventHandler(msg *model.ClusterMessage) {
|
|
if msg.Props == nil {
|
|
s.Log().Warn("ClusterMessage.Props for plugin event should not be nil")
|
|
return
|
|
}
|
|
pluginID := msg.Props["PluginID"]
|
|
eventID := msg.Props["EventID"]
|
|
if pluginID == "" || eventID == "" {
|
|
s.Log().Warn("Invalid ClusterMessage.Props values for plugin event",
|
|
mlog.String("plugin_id", pluginID),
|
|
mlog.String("event_id", eventID),
|
|
)
|
|
return
|
|
}
|
|
|
|
hooks, err := s.Channels().HooksForPlugin(pluginID)
|
|
if err != nil {
|
|
s.Log().Warn("Getting hooks for plugin failed", mlog.String("plugin_id", pluginID), mlog.Err(err))
|
|
return
|
|
}
|
|
|
|
hooks.OnPluginClusterEvent(&plugin.Context{}, model.PluginClusterEvent{
|
|
Id: eventID,
|
|
Data: msg.Data,
|
|
})
|
|
}
|
|
|
|
// registerClusterHandlers registers the cluster message handlers that are handled by the server.
|
|
//
|
|
// The cluster event handlers are spread across this function and NewLocalCacheLayer.
|
|
// Be careful to not have duplicated handlers here and there.
|
|
func (s *Server) registerClusterHandlers() {
|
|
s.platform.RegisterClusterMessageHandler(model.ClusterEventInstallPlugin, s.clusterInstallPluginHandler)
|
|
s.platform.RegisterClusterMessageHandler(model.ClusterEventRemovePlugin, s.clusterRemovePluginHandler)
|
|
s.platform.RegisterClusterMessageHandler(model.ClusterEventPluginEvent, s.clusterPluginEventHandler)
|
|
s.platform.RegisterClusterMessageHandler(clusterEventInvalidateChannelGuardCache, s.Channels().clusterInvalidateGuardCacheHandler)
|
|
|
|
s.platform.RegisterClusterHandlers()
|
|
}
|