mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Jesse HallamandGitHub
edf2075381
* MM-68149: upgrade to Go 1.26.2 Update go directive in go.mod and .go-version. * MM-68149: replace pointer helpers with Go 1.26 new() Go 1.26 extends the built-in new() to accept an initial value expression, making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x) redundant. Replace every call site with new(x) and remove the now-unused helper functions and their //go:fix inline directives. * MM-68149: apply go fix for reflect API and format-string changes - reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26) - reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields() and the equivalent for Methods() and interface types - Fix format-string concatenation and variadic-arg mismatches flagged by go vet * MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder Go 1.26 ships a new image/jpeg encoder that produces slightly different output. Regenerate all JPEG fixture files and switch the comparison helpers from byte-equality to pixel-level comparison with a small per-channel tolerance, so minor encoder drift across patch versions is handled automatically. Add -update-fixtures flag to make it easy to regenerate fixtures after future major Go upgrades. Document the update procedure in tests/README.md. * MM-68149: CI check that go fix ./... produces no changes * Fix real bugs flagged by CodeRabbit review - group.go: set newGroup.MemberCount not group.MemberCount (member count was populated on the wrong variable and lost before publish/return) - file_test.go: guard compareImage(GetFilePreview) on the preview slice length, not the thumbnail slice length (copy-paste error) - config_test.go: remove duplicate MinimumLength assignment * fixup! Fix real bugs flagged by CodeRabbit review
111 lines
3.2 KiB
Go
111 lines
3.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package featureflag
|
|
|
|
import (
|
|
"math"
|
|
"reflect"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/splitio/go-client/v6/splitio/client"
|
|
"github.com/splitio/go-client/v6/splitio/conf"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
)
|
|
|
|
type SyncParams struct {
|
|
ServerID string
|
|
SplitKey string
|
|
SyncIntervalSeconds int
|
|
Log *mlog.Logger
|
|
Attributes map[string]any
|
|
}
|
|
|
|
type Synchronizer struct {
|
|
SyncParams
|
|
|
|
client *client.SplitClient
|
|
stop chan struct{}
|
|
stopped chan struct{}
|
|
}
|
|
|
|
var featureNames = getStructFields(model.FeatureFlags{})
|
|
|
|
func NewSynchronizer(params SyncParams) (*Synchronizer, error) {
|
|
cfg := conf.Default()
|
|
if params.Log != nil {
|
|
cfg.Logger = &splitLogger{wrappedLog: params.Log.With(mlog.String("service", "split"))}
|
|
} else {
|
|
cfg.LoggerConfig.LogLevel = math.MinInt32
|
|
}
|
|
factory, err := client.NewSplitFactory(params.SplitKey, cfg)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "unable to create split factory")
|
|
}
|
|
|
|
return &Synchronizer{
|
|
SyncParams: params,
|
|
client: factory.Client(),
|
|
stop: make(chan struct{}),
|
|
stopped: make(chan struct{}),
|
|
}, nil
|
|
}
|
|
|
|
// EnsureReady blocks until the synchronizer is ready to update feature flag values
|
|
func (f *Synchronizer) EnsureReady() error {
|
|
if err := f.client.BlockUntilReady(10); err != nil {
|
|
return errors.Wrap(err, "split.io client could not initialize")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (f *Synchronizer) UpdateFeatureFlagValues(base model.FeatureFlags) model.FeatureFlags {
|
|
featuresMap := f.client.Treatments(f.ServerID, featureNames, f.Attributes)
|
|
ffm := featureFlagsFromMap(featuresMap, base)
|
|
return ffm
|
|
}
|
|
|
|
func (f *Synchronizer) Close() {
|
|
f.client.Destroy()
|
|
}
|
|
|
|
// featureFlagsFromMap sets the feature flags from a map[string]string.
|
|
// It starts with baseFeatureFlags and only sets values that are
|
|
// given by the upstream management system.
|
|
// Makes the assumption that all feature flags are strings or booleans.
|
|
// Strings are converted to booleans by considering case insensitive "on" or any value considered by strconv.ParseBool as true and any other value as false.
|
|
func featureFlagsFromMap(featuresMap map[string]string, baseFeatureFlags model.FeatureFlags) model.FeatureFlags {
|
|
refStruct := reflect.ValueOf(&baseFeatureFlags).Elem()
|
|
for fieldName, fieldValue := range featuresMap {
|
|
refField := refStruct.FieldByName(fieldName)
|
|
// "control" is returned by split.io if the treatment is not found, in this case we should use the default value.
|
|
if !refField.IsValid() || !refField.CanSet() || fieldValue == "control" {
|
|
continue
|
|
}
|
|
|
|
switch refField.Type().Kind() {
|
|
case reflect.Bool:
|
|
parsedBoolValue, _ := strconv.ParseBool(fieldValue)
|
|
refField.Set(reflect.ValueOf(strings.ToLower(fieldValue) == "on" || parsedBoolValue))
|
|
default:
|
|
refField.Set(reflect.ValueOf(fieldValue))
|
|
}
|
|
}
|
|
return baseFeatureFlags
|
|
}
|
|
|
|
func getStructFields(s any) []string {
|
|
structType := reflect.TypeOf(s)
|
|
fieldNames := make([]string, 0, structType.NumField())
|
|
for field := range structType.Fields() {
|
|
fieldNames = append(fieldNames, field.Name)
|
|
}
|
|
|
|
return fieldNames
|
|
}
|