mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Felipe MartinandGitHub
31447b14b1
On a fresh install, the first user created in the system is granted the system_admin role based solely on the user store being empty. Bot users created by plugins on a fresh database could therefore be promoted to the first system admin. Skip the first-user system_admin promotion for bot users so that only the first non-bot user is granted the role.
123 lines
3.2 KiB
Go
123 lines
3.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package users
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestIsUsernameTaken(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
user := th.BasicUser
|
|
taken := th.service.IsUsernameTaken(user.Username)
|
|
|
|
if !taken {
|
|
t.Logf("the username '%v' should be taken", user.Username)
|
|
t.FailNow()
|
|
}
|
|
|
|
newUsername := "randomUsername"
|
|
taken = th.service.IsUsernameTaken(newUsername)
|
|
|
|
if taken {
|
|
t.Logf("the username '%v' should not be taken", newUsername)
|
|
t.FailNow()
|
|
}
|
|
}
|
|
|
|
func TestFirstUserPromoted(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
user, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, user)
|
|
|
|
require.Equal(t, model.SystemAdminRoleId+" "+model.SystemUserRoleId, user.Roles)
|
|
|
|
user2, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, user2)
|
|
|
|
require.Equal(t, model.SystemUserRoleId, user2.Roles)
|
|
|
|
err = th.dbStore.User().PermanentDelete(th.Context, user.Id)
|
|
require.NoError(t, err)
|
|
|
|
b := &model.Bot{
|
|
UserId: user2.Id,
|
|
OwnerId: model.NewId(),
|
|
Username: model.NewUsername(),
|
|
}
|
|
|
|
_, err = th.dbStore.Bot().Save(b)
|
|
require.NoError(t, err)
|
|
|
|
user3, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, user3)
|
|
|
|
require.Equal(t, model.SystemAdminRoleId+" "+model.SystemUserRoleId, user3.Roles)
|
|
|
|
user4, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, user4)
|
|
|
|
require.Equal(t, model.SystemUserRoleId, user4.Roles)
|
|
}
|
|
|
|
func TestFirstUserNotPromotedIfBot(t *testing.T) {
|
|
th := Setup(t)
|
|
|
|
// On a completely fresh install the store is empty, but a bot user
|
|
// (one created by a plugin) must never become the first system admin.
|
|
botUser, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
IsBot: true,
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, botUser)
|
|
require.Equal(t, model.SystemUserRoleId, botUser.Roles)
|
|
|
|
// Record the corresponding bot so the store correctly excludes it.
|
|
_, err = th.dbStore.Bot().Save(&model.Bot{
|
|
UserId: botUser.Id,
|
|
OwnerId: model.NewId(),
|
|
Username: botUser.Username,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// The first non-bot user is still promoted to system admin.
|
|
user, err := th.service.CreateUser(th.Context, &model.User{
|
|
Username: model.NewUsername(),
|
|
Password: model.NewId(),
|
|
Email: "[email protected]",
|
|
}, UserCreateOptions{})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, user)
|
|
require.Equal(t, model.SystemAdminRoleId+" "+model.SystemUserRoleId, user.Roles)
|
|
}
|