mirror of
https://github.com/hanzoai/team.git
synced 2026-11-01 07:55:31 +00:00
Jesse HallamandGitHub
edf2075381
* MM-68149: upgrade to Go 1.26.2 Update go directive in go.mod and .go-version. * MM-68149: replace pointer helpers with Go 1.26 new() Go 1.26 extends the built-in new() to accept an initial value expression, making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x) redundant. Replace every call site with new(x) and remove the now-unused helper functions and their //go:fix inline directives. * MM-68149: apply go fix for reflect API and format-string changes - reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26) - reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields() and the equivalent for Methods() and interface types - Fix format-string concatenation and variadic-arg mismatches flagged by go vet * MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder Go 1.26 ships a new image/jpeg encoder that produces slightly different output. Regenerate all JPEG fixture files and switch the comparison helpers from byte-equality to pixel-level comparison with a small per-channel tolerance, so minor encoder drift across patch versions is handled automatically. Add -update-fixtures flag to make it easy to regenerate fixtures after future major Go upgrades. Document the update procedure in tests/README.md. * MM-68149: CI check that go fix ./... produces no changes * Fix real bugs flagged by CodeRabbit review - group.go: set newGroup.MemberCount not group.MemberCount (member count was populated on the wrong variable and lost before publish/return) - file_test.go: guard compareImage(GetFilePreview) on the preview slice length, not the thumbnail slice length (copy-paste error) - config_test.go: remove duplicate MinimumLength assignment * fixup! Fix real bugs flagged by CodeRabbit review
189 lines
4.9 KiB
Go
189 lines
4.9 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
package jobs
|
|
|
|
import (
|
|
"os"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin/plugintest/mock"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest"
|
|
"github.com/mattermost/mattermost/server/v8/channels/utils/testutils"
|
|
)
|
|
|
|
type MockScheduler struct {
|
|
mock.Mock
|
|
}
|
|
|
|
func (scheduler *MockScheduler) Enabled(cfg *model.Config) bool {
|
|
return true
|
|
}
|
|
|
|
func (scheduler *MockScheduler) NextScheduleTime(cfg *model.Config, now time.Time, pendingJobs bool, lastSuccessfulJob *model.Job) *time.Time {
|
|
nextTime := time.Now().Add(60 * time.Second)
|
|
return &nextTime
|
|
}
|
|
|
|
func (scheduler *MockScheduler) ScheduleJob(rctx request.CTX, cfg *model.Config, pendingJobs bool, lastSuccessfulJob *model.Job) (*model.Job, *model.AppError) {
|
|
return nil, nil
|
|
}
|
|
|
|
func TestScheduler(t *testing.T) {
|
|
if os.Getenv("ENABLE_FULLY_PARALLEL_TESTS") == "true" {
|
|
t.Parallel()
|
|
}
|
|
|
|
mockStore := &storetest.Store{}
|
|
defer mockStore.AssertExpectations(t)
|
|
|
|
job := &model.Job{
|
|
Id: model.NewId(),
|
|
CreateAt: model.GetMillis(),
|
|
Status: model.JobStatusPending,
|
|
Type: model.JobTypeMessageExport,
|
|
}
|
|
// mock job store doesn't return a previously successful job, forcing fallback to config
|
|
mockStore.JobStore.On("GetNewestJobByStatusesAndType", mock.AnythingOfType("[]string"), mock.AnythingOfType("string")).Return(job, nil)
|
|
mockStore.JobStore.On("GetCountByStatusAndType", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(int64(1), nil)
|
|
|
|
jobServer := &JobServer{
|
|
Store: mockStore,
|
|
ConfigService: &testutils.StaticConfigService{
|
|
Cfg: &model.Config{
|
|
// mock config
|
|
DataRetentionSettings: model.DataRetentionSettings{
|
|
EnableMessageDeletion: new(true),
|
|
},
|
|
MessageExportSettings: model.MessageExportSettings{
|
|
EnableExport: new(true),
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
jobServer.initSchedulers()
|
|
jobServer.RegisterJobType(model.JobTypeDataRetention, nil, new(MockScheduler))
|
|
jobServer.RegisterJobType(model.JobTypeMessageExport, nil, new(MockScheduler))
|
|
|
|
t.Run("Base", func(t *testing.T) {
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
|
|
err = jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
// They should be all on here
|
|
for _, element := range jobServer.schedulers.nextRunTimes {
|
|
assert.NotNil(t, element)
|
|
}
|
|
})
|
|
|
|
t.Run("ClusterLeaderChanged", func(t *testing.T) {
|
|
jobServer.initSchedulers()
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
jobServer.HandleClusterLeaderChange(false)
|
|
|
|
err = jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
// They should be turned off
|
|
for _, element := range jobServer.schedulers.nextRunTimes {
|
|
assert.Nil(t, element)
|
|
}
|
|
})
|
|
|
|
t.Run("ClusterLeaderChangedBeforeStart", func(t *testing.T) {
|
|
jobServer.initSchedulers()
|
|
jobServer.HandleClusterLeaderChange(false)
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
err = jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
for _, element := range jobServer.schedulers.nextRunTimes {
|
|
assert.Nil(t, element)
|
|
}
|
|
})
|
|
|
|
t.Run("DoubleClusterLeaderChangedBeforeStart", func(t *testing.T) {
|
|
jobServer.initSchedulers()
|
|
jobServer.HandleClusterLeaderChange(false)
|
|
jobServer.HandleClusterLeaderChange(true)
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
err = jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
for _, element := range jobServer.schedulers.nextRunTimes {
|
|
assert.NotNil(t, element)
|
|
}
|
|
})
|
|
|
|
t.Run("ConfigChanged", func(t *testing.T) {
|
|
jobServer.initSchedulers()
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
jobServer.HandleClusterLeaderChange(false)
|
|
// After running a config change, they should stay off
|
|
jobServer.schedulers.handleConfigChange(nil, nil)
|
|
err = jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
for _, element := range jobServer.schedulers.nextRunTimes {
|
|
assert.Nil(t, element)
|
|
}
|
|
})
|
|
|
|
t.Run("ConfigChangedDeadlock", func(t *testing.T) {
|
|
jobServer.initSchedulers()
|
|
err := jobServer.StartSchedulers()
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
|
|
var wg sync.WaitGroup
|
|
wg.Add(2)
|
|
go func() {
|
|
defer wg.Done()
|
|
err := jobServer.StopSchedulers()
|
|
require.NoError(t, err)
|
|
}()
|
|
go func() {
|
|
defer wg.Done()
|
|
jobServer.schedulers.handleConfigChange(nil, nil)
|
|
}()
|
|
|
|
wg.Wait()
|
|
})
|
|
}
|
|
|
|
func TestRandomDelay(t *testing.T) {
|
|
if os.Getenv("ENABLE_FULLY_PARALLEL_TESTS") == "true" {
|
|
t.Parallel()
|
|
}
|
|
|
|
cases := []int64{5, 10, 100}
|
|
for _, c := range cases {
|
|
out := getRandomDelay(c)
|
|
require.Less(t, out.Milliseconds(), c)
|
|
}
|
|
}
|