mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* ci: shard server Postgres tests into 4 parallel runners (#35739) Cherry-pick of00296f9b49from master. * updated go to version 1.25.8 (#35817) Cherry-pick of32a10bac62from master. * Move password hashers from server/v8 to server/public (#35805) Cherry-pick ofcca3f08574from master. * Generate instead of hard-coding test passwords, enforce new minimum for FIPS, shard CI, fix FIPS builds (#35905) Cherry-pick of1bdd985b41from master. * upgrade golangci-lint (#35845) Cherry-pick of157e0400b2from master. On release-11.4 (unlike 11.5), UpdatePostsChannelTypeByChannelId and BackfillPostsChannelType exist in the elasticsearch/opensearch files, so the imports they require (fmt, updatebyquery, scriptlanguage) must be added — they were not in the cherry-pick diff since they already existed on master. Also updates html2text/tablewriter/olekukonko deps to fix a workspace conflict where enterprise's Go 1.25.8 bump pulled in a newer html2text that requires tablewriter ≥ 1.1 (was pinned to 0.0.5 via a replace directive). Matches the subset of866f759e4b(Mm 66662 bump deps) relevant to this incompatibility. * Fix FIPS-incompatible passwords and config in e2e test suites (#36001) Cherry-pick ofb51b4a8937from master. release-11.4 differences vs release-11.5: - demo_plugin_installation.spec.ts also deleted (modify/delete conflict, git rm) - authentication_2_spec.ts conflict: HEAD missing check() call; took incoming (check + FIPS-length passwords) - member_invitation_ui_spec.ts: HEAD has 'Create Account' (capital A) matching release-11.4 button text; kept HEAD's button text with incoming's newTestPassword() * fix(cypress): demo plugin (#36056) Cherry-pick of39f1979aa5from master. demo_plugin_installation.spec.ts was deleted in step 10 (modify/delete); re-created here with both the FIPS-password change and the URL fix. * test: clean up channel store data after TestChannelStore (#36066) TestChannelStore sub-tests create channels, members, and team members using fake TeamIds and UserIds (model.NewId() for non-existent rows). These records are left in the database and cause integrity tests (TestCheck*) running in the same binary to fail their full-table scans. Register a t.Cleanup on TestChannelStore that purges the affected tables entirely. A blanket purge is safe: the schema enforces no FK constraints, and every test suite creates its own data independently. * Fix command injection in server-test-template workflow (#36080) Cherry-pick of9223935f16from master. * fix(ci): restore testname format in sharded gotestsum runs (#36078) run-shard-tests.sh called gotestsum directly without --format, so it fell back to gotestsum's default (pkgname) instead of the testname format set by the Makefile. Pass --format "${GOTESTSUM_FORMAT:-testname}" to match the Makefile default. Co-authored-by: Mattermost Build <[email protected]> * fixup: drop demo_plugin playwright specs — master-only APIs demo_plugin/helpers.ts and demo_plugin_installation.spec.ts use installAndEnablePlugin and isPluginActive which don't exist on release-11.4's PlaywrightExtended type. These files were re-created by the step-11 cherry-pick of39f1979aa5, but they don't compile on this branch (same class of problem as actions.spec.ts in step 10). * fixup: add missing await in PluginLinkTooltip test The test added in39f1979aa5is missing an await on renderWithContext, causing the pointer-events assertion to race. Fix from 0c7d3f27c6 (on a feature branch, not yet on master). * fixup: drop pointer-events test incompatible with jsdom@20 The 'should not block interaction with elements outside the tooltip' test checks getComputedStyle for pointer-events: none, which is set only in SCSS. release-11.4 uses jest-environment-jsdom@29 (jsdom@20), which does not apply stylesheets, so getComputedStyle always returns "". The test passes on release-11.5+ only because they use jest-environment-jsdom@30 (jsdom@25+). Drop the test rather than backport the jsdom upgrade. * fixup: add missing i18n keys for elasticsearch/opensearch functions BackfillPostsChannelType and UpdatePostsChannelTypeByChannelId exist on release-11.4 (unlike release-11.5+). The golangci-lint cherry-pick added new error strings to those functions referencing i18n keys that weren't in en.json. * fixup: run make i18n-extract to reorder keys correctly * fixup: drop terms-and-privacy checkbox from MM-T1774 on release-11.4 The #signup-body-card-form-check-terms-and-privacy element did not exist on release-11.4's signup page. It was added to master after this branch was cut, so the check() call from the incoming cherry-pick causes the test to fail with "element never found". * fixup: remove UpdatePostsChannelTypeByChannelId/BackfillPostsChannelType These functions were introduced by MM-67540 (allow searching public channel messages without channel membership), which never landed on release-11.4. The golangci-lint cherry-pick only modernizes existing code; the rerere resolution incorrectly added the full function bodies from master. Remove both functions and their now-unused imports (fmt, updatebyquery, scriptlanguage) from elasticsearch.go and opensearch.go. Also remove the two i18n keys added to support them. Same treatment as release-11.5, where these functions were also absent. --------- Co-authored-by: Mattermost Build <[email protected]>
301 lines
8.5 KiB
Go
301 lines
8.5 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package platform
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest/mocks"
|
|
"github.com/mattermost/mattermost/server/v8/channels/testlib"
|
|
"github.com/mattermost/mattermost/server/v8/config"
|
|
"github.com/mattermost/mattermost/server/v8/einterfaces"
|
|
)
|
|
|
|
type TestHelper struct {
|
|
Context request.CTX
|
|
Service *PlatformService
|
|
Suite SuiteIFace
|
|
Store store.Store
|
|
|
|
BasicTeam *model.Team
|
|
BasicUser *model.User
|
|
BasicUser2 *model.User
|
|
BasicChannel *model.Channel
|
|
// BasicPost *model.Post
|
|
|
|
SystemAdminUser *model.User
|
|
|
|
runShutdown sync.Once
|
|
|
|
tempWorkspace string
|
|
}
|
|
|
|
type mockSuite struct{}
|
|
|
|
func (ms *mockSuite) SetStatusLastActivityAt(userID string, activityAt int64) {}
|
|
func (ms *mockSuite) SetStatusOffline(userID string, manual bool, force bool) {}
|
|
func (ms *mockSuite) IsUserAway(lastActivityAt int64) bool { return false }
|
|
func (ms *mockSuite) SetStatusOnline(userID string, manual bool) {}
|
|
func (ms *mockSuite) UpdateLastActivityAtIfNeeded(session model.Session) {}
|
|
func (ms *mockSuite) SetStatusAwayIfNeeded(userID string, manual bool) {}
|
|
func (ms *mockSuite) GetSession(token string) (*model.Session, *model.AppError) {
|
|
return &model.Session{}, nil
|
|
}
|
|
func (ms *mockSuite) RolesGrantPermission(roleNames []string, permissionId string) bool { return true }
|
|
func (ms *mockSuite) UserCanSeeOtherUser(rctx request.CTX, userID string, otherUserId string) (bool, *model.AppError) {
|
|
return true, nil
|
|
}
|
|
|
|
func (ms *mockSuite) HasPermissionToReadChannel(rctx request.CTX, userID string, channel *model.Channel) bool {
|
|
return true
|
|
}
|
|
|
|
func (ms *mockSuite) MFARequired(rctx request.CTX) *model.AppError {
|
|
return nil
|
|
}
|
|
|
|
func setupDBStore(tb testing.TB) (store.Store, *model.SqlSettings) {
|
|
var dbStore store.Store
|
|
var dbSettings *model.SqlSettings
|
|
if mainHelper.Options.RunParallel {
|
|
dbStore, _, dbSettings, _ = mainHelper.GetNewStores(tb)
|
|
tb.Cleanup(func() {
|
|
dbStore.Close()
|
|
})
|
|
} else {
|
|
dbStore = mainHelper.GetStore()
|
|
dbStore.DropAllTables()
|
|
dbStore.MarkSystemRanUnitTests()
|
|
dbSettings = mainHelper.Settings
|
|
mainHelper.PreloadMigrations()
|
|
}
|
|
|
|
return dbStore, dbSettings
|
|
}
|
|
|
|
func Setup(tb testing.TB, options ...Option) *TestHelper {
|
|
if testing.Short() {
|
|
tb.SkipNow()
|
|
}
|
|
|
|
dbStore, dbSettings := setupDBStore(tb)
|
|
|
|
return setupTestHelper(dbStore, dbSettings, false, true, tb, options...)
|
|
}
|
|
|
|
func (th *TestHelper) InitBasic(tb testing.TB) *TestHelper {
|
|
th.SystemAdminUser = th.CreateAdmin(tb)
|
|
|
|
th.BasicUser = th.CreateUserOrGuest(tb, false)
|
|
|
|
th.BasicUser2 = th.CreateUserOrGuest(tb, false)
|
|
|
|
th.BasicTeam = th.CreateTeam(tb)
|
|
|
|
// th.LinkUserToTeam(t, th.BasicUser, th.BasicTeam)
|
|
// th.LinkUserToTeam(t, th.BasicUser2, th.BasicTeam)
|
|
th.BasicChannel = th.CreateChannel(tb, th.BasicTeam)
|
|
// th.BasicPost = th.CreatePost(t, th.BasicChannel)
|
|
return th
|
|
}
|
|
|
|
func SetupWithStoreMock(tb testing.TB, options ...Option) *TestHelper {
|
|
mockStore := testlib.GetMockStoreForSetupFunctions()
|
|
options = append(options, StoreOverride(mockStore))
|
|
th := setupTestHelper(mockStore, &model.SqlSettings{}, false, false, tb, options...)
|
|
return th
|
|
}
|
|
|
|
func SetupWithCluster(tb testing.TB, cluster einterfaces.ClusterInterface) *TestHelper {
|
|
if testing.Short() {
|
|
tb.SkipNow()
|
|
}
|
|
|
|
dbStore, dbSettings := setupDBStore(tb)
|
|
|
|
th := setupTestHelper(dbStore, dbSettings, true, true, tb)
|
|
th.Service.clusterIFace = cluster
|
|
|
|
return th
|
|
}
|
|
|
|
func setupTestHelper(dbStore store.Store, dbSettings *model.SqlSettings, enterprise bool, includeCacheLayer bool, tb testing.TB, options ...Option) *TestHelper {
|
|
tempWorkspace, err := os.MkdirTemp("", "apptest")
|
|
require.NoError(tb, err)
|
|
|
|
configStore := config.NewTestMemoryStore()
|
|
|
|
memoryConfig := configStore.Get()
|
|
memoryConfig.SqlSettings = *dbSettings
|
|
*memoryConfig.PluginSettings.Directory = filepath.Join(tempWorkspace, "plugins")
|
|
*memoryConfig.PluginSettings.ClientDirectory = filepath.Join(tempWorkspace, "webapp")
|
|
*memoryConfig.PluginSettings.AutomaticPrepackagedPlugins = false
|
|
*memoryConfig.LogSettings.EnableSentry = false // disable error reporting during tests
|
|
*memoryConfig.AnnouncementSettings.AdminNoticesEnabled = false
|
|
*memoryConfig.AnnouncementSettings.UserNoticesEnabled = false
|
|
*memoryConfig.MetricsSettings.Enable = true
|
|
*memoryConfig.ServiceSettings.ListenAddress = "localhost:0"
|
|
*memoryConfig.MetricsSettings.ListenAddress = "localhost:0"
|
|
_, _, err = configStore.Set(memoryConfig)
|
|
require.NoError(tb, err)
|
|
|
|
options = append(options, ConfigStore(configStore))
|
|
|
|
ps, err := New(
|
|
ServiceConfig{
|
|
Store: dbStore,
|
|
}, options...)
|
|
if err != nil {
|
|
require.NoError(tb, err)
|
|
}
|
|
|
|
th := &TestHelper{
|
|
Context: request.TestContext(tb),
|
|
Service: ps,
|
|
Suite: &mockSuite{},
|
|
Store: dbStore,
|
|
tempWorkspace: tempWorkspace,
|
|
}
|
|
|
|
if _, ok := dbStore.(*mocks.Store); ok {
|
|
statusMock := mocks.StatusStore{}
|
|
statusMock.On("UpdateExpiredDNDStatuses").Return([]*model.Status{}, nil)
|
|
statusMock.On("Get", "user1").Return(&model.Status{UserId: "user1", Status: model.StatusOnline}, nil)
|
|
statusMock.On("UpdateLastActivityAt", "user1", mock.Anything).Return(nil)
|
|
statusMock.On("SaveOrUpdate", mock.AnythingOfType("*model.Status")).Return(nil)
|
|
emptyMockStore := mocks.Store{}
|
|
emptyMockStore.On("Close").Return(nil)
|
|
emptyMockStore.On("Status").Return(&statusMock)
|
|
th.Service.Store = &emptyMockStore
|
|
}
|
|
|
|
// Share same configuration with app.TestHelper
|
|
th.Service.UpdateConfig(func(cfg *model.Config) {
|
|
*cfg.TeamSettings.MaxUsersPerTeam = 50
|
|
*cfg.RateLimitSettings.Enable = false
|
|
*cfg.TeamSettings.EnableOpenServer = true
|
|
})
|
|
|
|
if enterprise {
|
|
th.Service.SetLicense(model.NewTestLicense())
|
|
} else {
|
|
th.Service.SetLicense(nil)
|
|
}
|
|
|
|
err = th.Service.Start(nil)
|
|
require.NoError(tb, err)
|
|
|
|
tb.Cleanup(func() {
|
|
th.Shutdown(tb)
|
|
})
|
|
|
|
return th
|
|
}
|
|
|
|
// Shutdown may be called by tests to manually shut down the [TestHelper].
|
|
// If it's not called manually, it will get called automatically via [testing.TB.Cleanup].
|
|
func (th *TestHelper) Shutdown(tb testing.TB) {
|
|
th.runShutdown.Do(func() {
|
|
err := th.Service.ShutdownMetrics()
|
|
require.NoError(tb, err)
|
|
err = th.Service.Shutdown()
|
|
require.NoError(tb, err)
|
|
err = th.Service.ShutdownConfig()
|
|
require.NoError(tb, err)
|
|
if th.tempWorkspace != "" {
|
|
err := os.RemoveAll(th.tempWorkspace)
|
|
require.NoError(tb, err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func (th *TestHelper) CreateTeam(tb testing.TB) *model.Team {
|
|
id := model.NewId()
|
|
|
|
team := &model.Team{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Email: "success+" + id + "@simulator.amazonses.com",
|
|
Type: model.TeamOpen,
|
|
}
|
|
|
|
team, err := th.Service.Store.Team().Save(team)
|
|
require.NoError(tb, err)
|
|
|
|
return team
|
|
}
|
|
|
|
func (th *TestHelper) CreateUserOrGuest(tb testing.TB, guest bool) *model.User {
|
|
id := model.NewId()
|
|
|
|
user := &model.User{
|
|
Email: "success+" + id + "@simulator.amazonses.com",
|
|
Username: "un_" + id,
|
|
Nickname: "nn_" + id,
|
|
Password: model.NewTestPassword(),
|
|
EmailVerified: true,
|
|
Roles: model.SystemUserRoleId,
|
|
}
|
|
|
|
user, err := th.Service.Store.User().Save(th.Context, user)
|
|
require.NoError(tb, err)
|
|
|
|
return user
|
|
}
|
|
|
|
func (th *TestHelper) CreateAdmin(tb testing.TB) *model.User {
|
|
id := model.NewId()
|
|
|
|
user := &model.User{
|
|
Email: "success+" + id + "@simulator.amazonses.com",
|
|
Username: "un_" + id,
|
|
Nickname: "nn_" + id,
|
|
Password: model.NewTestPassword(),
|
|
EmailVerified: true,
|
|
Roles: model.SystemAdminRoleId + " " + model.SystemUserRoleId,
|
|
}
|
|
|
|
user, err := th.Service.Store.User().Save(th.Context, user)
|
|
require.NoError(tb, err)
|
|
|
|
return user
|
|
}
|
|
|
|
type ChannelOption func(*model.Channel)
|
|
|
|
func WithShared(v bool) ChannelOption {
|
|
return func(channel *model.Channel) {
|
|
channel.Shared = model.NewPointer(v)
|
|
}
|
|
}
|
|
|
|
func (th *TestHelper) CreateChannel(tb testing.TB, team *model.Team, options ...ChannelOption) *model.Channel {
|
|
id := model.NewId()
|
|
|
|
channel := &model.Channel{
|
|
TeamId: team.Id,
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Type: model.ChannelTypeOpen,
|
|
}
|
|
|
|
for _, option := range options {
|
|
option(channel)
|
|
}
|
|
|
|
channel, err := th.Service.Store.Channel().Save(th.Context, channel, 999)
|
|
require.NoError(tb, err)
|
|
|
|
return channel
|
|
}
|