mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <[email protected]>
163 lines
4.2 KiB
Go
163 lines
4.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package config
|
|
|
|
import (
|
|
"os"
|
|
"path"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
)
|
|
|
|
type cleanUpFn func(store *Store)
|
|
|
|
func TestMigrate(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping migration test in short mode")
|
|
}
|
|
files := []string{
|
|
"IdpCertificateFile",
|
|
"PublicCertificateFile",
|
|
"PrivateKeyFile",
|
|
"internal.crt",
|
|
"internal2.crt",
|
|
}
|
|
filesData := make([]string, len(files))
|
|
for i := range files {
|
|
// Generate random data for each file, ensuring that stale data from a past test
|
|
// won't generate a false positive.
|
|
filesData[i] = model.NewId()
|
|
}
|
|
|
|
setup := func(t *testing.T) {
|
|
os.Clearenv()
|
|
t.Helper()
|
|
|
|
tempDir, err := os.MkdirTemp("", "TestMigrate")
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() {
|
|
os.RemoveAll(tempDir)
|
|
})
|
|
|
|
err = os.Chdir(tempDir)
|
|
require.NoError(t, err)
|
|
|
|
truncateTables(t)
|
|
}
|
|
|
|
setupSource := func(t *testing.T, source *Store) cleanUpFn {
|
|
t.Helper()
|
|
|
|
cfg := source.Get()
|
|
originalCfg := cfg.Clone()
|
|
cfg.ServiceSettings.SiteURL = model.NewPointer("http://example.com")
|
|
cfg.SamlSettings.IdpCertificateFile = &files[0]
|
|
cfg.SamlSettings.PublicCertificateFile = &files[1]
|
|
cfg.SamlSettings.PrivateKeyFile = &files[2]
|
|
cfg.PluginSettings.SignaturePublicKeyFiles = []string{
|
|
files[3],
|
|
files[4],
|
|
}
|
|
cfg.SqlSettings.DataSourceReplicas = []string{
|
|
"postgres://mmuser:password@replicahost:5432/mattermost",
|
|
}
|
|
cfg.SqlSettings.DataSourceSearchReplicas = []string{
|
|
"postgres://mmuser:password@searchreplicahost:5432/mattermost",
|
|
}
|
|
|
|
_, _, err := source.Set(cfg)
|
|
require.NoError(t, err)
|
|
|
|
for i, file := range files {
|
|
err = source.SetFile(file, []byte(filesData[i]))
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
return func(store *Store) {
|
|
_, _, err := store.Set(originalCfg)
|
|
require.NoError(t, err)
|
|
}
|
|
}
|
|
|
|
assertDestination := func(t *testing.T, destination *Store, source *Store) {
|
|
t.Helper()
|
|
|
|
for i, file := range files {
|
|
hasFile, err := destination.HasFile(file)
|
|
require.NoError(t, err)
|
|
require.Truef(t, hasFile, "destination missing file %s", file)
|
|
|
|
actualData, err := destination.GetFile(file)
|
|
require.NoError(t, err)
|
|
assert.Equalf(t, []byte(filesData[i]), actualData, "destination has wrong contents for file %s", file)
|
|
}
|
|
|
|
assert.Equal(t, source.Get(), destination.Get())
|
|
}
|
|
|
|
t.Run("database to file", func(t *testing.T) {
|
|
setup(t)
|
|
|
|
pwd, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
|
|
sqlSettings := mainHelper.GetSQLSettings()
|
|
destinationDSN := path.Join(pwd, "config-custom.json")
|
|
sourceDSN := getDsn(*sqlSettings.DriverName, *sqlSettings.DataSource)
|
|
|
|
sourcedb, err := NewDatabaseStore(sourceDSN)
|
|
require.NoError(t, err)
|
|
source, err := NewStoreFromBacking(sourcedb, nil, false)
|
|
require.NoError(t, err)
|
|
defer source.Close()
|
|
|
|
cleanUp := setupSource(t, source)
|
|
err = Migrate(sourceDSN, destinationDSN)
|
|
require.NoError(t, err)
|
|
|
|
destinationfile, err := NewFileStore(destinationDSN, false)
|
|
require.NoError(t, err)
|
|
destination, err := NewStoreFromBacking(destinationfile, nil, false)
|
|
require.NoError(t, err)
|
|
defer destination.Close()
|
|
defer cleanUp(destination)
|
|
|
|
assertDestination(t, destination, source)
|
|
})
|
|
|
|
t.Run("file to database", func(t *testing.T) {
|
|
setup(t)
|
|
|
|
pwd, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
|
|
sqlSettings := mainHelper.GetSQLSettings()
|
|
sourceDSN := path.Join(pwd, "config-custom.json")
|
|
destinationDSN := getDsn(*sqlSettings.DriverName, *sqlSettings.DataSource)
|
|
|
|
sourcefile, err := NewFileStore(sourceDSN, true)
|
|
require.NoError(t, err)
|
|
source, err := NewStoreFromBacking(sourcefile, nil, false)
|
|
require.NoError(t, err)
|
|
defer source.Close()
|
|
|
|
cleanUp := setupSource(t, source)
|
|
err = Migrate(sourceDSN, destinationDSN)
|
|
require.NoError(t, err)
|
|
|
|
destinationdb, err := NewDatabaseStore(destinationDSN)
|
|
require.NoError(t, err)
|
|
destination, err := NewStoreFromBacking(destinationdb, nil, false)
|
|
require.NoError(t, err)
|
|
defer destination.Close()
|
|
defer cleanUp(destination)
|
|
|
|
assertDestination(t, destination, source)
|
|
})
|
|
}
|