mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Updates all Custom Profile Attribute endpoints and app layer methods to pass caller user IDs through to the PropertyAccessService. This connects the access control service introduced in #34812 to the REST API, Plugin API, and internal app operations. Also updates the OpenAPI spec to document the new field attributes (protected, source_plugin_id, access_mode) and adds notes about protected field restrictions.
335 lines
13 KiB
Go
335 lines
13 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"database/sql"
|
|
"encoding/json"
|
|
"net/http"
|
|
"sort"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
const (
|
|
CustomProfileAttributesFieldLimit = 20
|
|
)
|
|
|
|
var cpaGroupID string
|
|
|
|
func (a *App) CpaGroupID() (string, error) {
|
|
return getCpaGroupID(a.Srv().propertyAccessService)
|
|
}
|
|
|
|
// ToDo: we should explore moving this to the database cache layer
|
|
// instead of maintaining the ID cached at the application level
|
|
func getCpaGroupID(service *PropertyAccessService) (string, error) {
|
|
if cpaGroupID != "" {
|
|
return cpaGroupID, nil
|
|
}
|
|
|
|
cpaGroup, err := service.RegisterPropertyGroup(model.CustomProfileAttributesPropertyGroupName)
|
|
if err != nil {
|
|
return "", errors.Wrap(err, "cannot register Custom Profile Attributes property group")
|
|
}
|
|
cpaGroupID = cpaGroup.ID
|
|
|
|
return cpaGroupID, nil
|
|
}
|
|
|
|
func (a *App) GetCPAField(callerId, fieldID string) (*model.CPAField, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetCPAField", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
field, err := a.Srv().propertyAccessService.GetPropertyField(callerId, groupID, fieldID)
|
|
if err != nil {
|
|
switch {
|
|
case errors.Is(err, sql.ErrNoRows):
|
|
return nil, model.NewAppError("GetCPAField", "app.custom_profile_attributes.property_field_not_found.app_error", nil, "", http.StatusNotFound).Wrap(err)
|
|
default:
|
|
return nil, model.NewAppError("GetCPAField", "app.custom_profile_attributes.get_property_field.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
}
|
|
|
|
cpaField, err := model.NewCPAFieldFromPropertyField(field)
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetCPAField", "app.custom_profile_attributes.property_field_conversion.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
return cpaField, nil
|
|
}
|
|
|
|
func (a *App) ListCPAFields(callerID string) ([]*model.CPAField, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("ListCPAFields", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
opts := model.PropertyFieldSearchOpts{
|
|
GroupID: groupID,
|
|
PerPage: CustomProfileAttributesFieldLimit,
|
|
}
|
|
|
|
fields, err := a.Srv().propertyAccessService.SearchPropertyFields(callerID, groupID, opts)
|
|
if err != nil {
|
|
return nil, model.NewAppError("ListCPAFields", "app.custom_profile_attributes.search_property_fields.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
// Convert PropertyFields to CPAFields
|
|
cpaFields := make([]*model.CPAField, 0, len(fields))
|
|
for _, field := range fields {
|
|
cpaField, convErr := model.NewCPAFieldFromPropertyField(field)
|
|
if convErr != nil {
|
|
return nil, model.NewAppError("ListCPAFields", "app.custom_profile_attributes.property_field_conversion.app_error", nil, "", http.StatusInternalServerError).Wrap(convErr)
|
|
}
|
|
cpaFields = append(cpaFields, cpaField)
|
|
}
|
|
|
|
sort.Slice(cpaFields, func(i, j int) bool {
|
|
return cpaFields[i].Attrs.SortOrder < cpaFields[j].Attrs.SortOrder
|
|
})
|
|
|
|
return cpaFields, nil
|
|
}
|
|
|
|
func (a *App) CreateCPAField(callerId string, field *model.CPAField) (*model.CPAField, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("CreateCPAField", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
fieldCount, err := a.Srv().propertyAccessService.CountActivePropertyFieldsForGroup(groupID)
|
|
if err != nil {
|
|
return nil, model.NewAppError("CreateCPAField", "app.custom_profile_attributes.count_property_fields.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
if fieldCount >= CustomProfileAttributesFieldLimit {
|
|
return nil, model.NewAppError("CreateCPAField", "app.custom_profile_attributes.limit_reached.app_error", nil, "", http.StatusUnprocessableEntity).Wrap(err)
|
|
}
|
|
|
|
field.GroupID = groupID
|
|
|
|
if appErr := field.SanitizeAndValidate(); appErr != nil {
|
|
return nil, appErr
|
|
}
|
|
|
|
newField, err := a.Srv().propertyAccessService.CreatePropertyField(callerId, field.ToPropertyField())
|
|
if err != nil {
|
|
var appErr *model.AppError
|
|
switch {
|
|
case errors.As(err, &appErr):
|
|
return nil, appErr
|
|
default:
|
|
return nil, model.NewAppError("CreateCPAField", "app.custom_profile_attributes.create_property_field.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
}
|
|
|
|
cpaField, err := model.NewCPAFieldFromPropertyField(newField)
|
|
if err != nil {
|
|
return nil, model.NewAppError("CreateCPAField", "app.custom_profile_attributes.property_field_conversion.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
message := model.NewWebSocketEvent(model.WebsocketEventCPAFieldCreated, "", "", "", nil, "")
|
|
message.Add("field", cpaField)
|
|
a.Publish(message)
|
|
|
|
return cpaField, nil
|
|
}
|
|
|
|
func (a *App) PatchCPAField(callerID string, fieldID string, patch *model.PropertyFieldPatch) (*model.CPAField, *model.AppError) {
|
|
existingField, appErr := a.GetCPAField(callerID, fieldID)
|
|
if appErr != nil {
|
|
return nil, appErr
|
|
}
|
|
|
|
shouldDeleteValues := false
|
|
if patch.Type != nil && *patch.Type != existingField.Type {
|
|
shouldDeleteValues = true
|
|
}
|
|
|
|
if err := existingField.Patch(patch); err != nil {
|
|
return nil, model.NewAppError("PatchCPAField", "app.custom_profile_attributes.patch_field.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
if appErr := existingField.SanitizeAndValidate(); appErr != nil {
|
|
return nil, appErr
|
|
}
|
|
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("PatchCPAField", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
patchedField, err := a.Srv().propertyAccessService.UpdatePropertyField(callerID, groupID, existingField.ToPropertyField())
|
|
if err != nil {
|
|
var nfErr *store.ErrNotFound
|
|
switch {
|
|
case errors.As(err, &nfErr):
|
|
return nil, model.NewAppError("PatchCPAField", "app.custom_profile_attributes.property_field_not_found.app_error", nil, "", http.StatusNotFound).Wrap(err)
|
|
default:
|
|
return nil, model.NewAppError("PatchCPAField", "app.custom_profile_attributes.property_field_update.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
}
|
|
|
|
cpaField, err := model.NewCPAFieldFromPropertyField(patchedField)
|
|
if err != nil {
|
|
return nil, model.NewAppError("PatchCPAField", "app.custom_profile_attributes.property_field_conversion.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
if shouldDeleteValues {
|
|
if dErr := a.Srv().propertyAccessService.DeletePropertyValuesForField(callerID, groupID, cpaField.ID); dErr != nil {
|
|
a.Log().Error("Error deleting property values when updating field",
|
|
mlog.String("fieldID", cpaField.ID),
|
|
mlog.Err(dErr),
|
|
)
|
|
}
|
|
}
|
|
|
|
message := model.NewWebSocketEvent(model.WebsocketEventCPAFieldUpdated, "", "", "", nil, "")
|
|
message.Add("field", cpaField)
|
|
message.Add("delete_values", shouldDeleteValues)
|
|
a.Publish(message)
|
|
|
|
return cpaField, nil
|
|
}
|
|
|
|
func (a *App) DeleteCPAField(callerID string, id string) *model.AppError {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return model.NewAppError("DeleteCPAField", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
if err := a.Srv().propertyAccessService.DeletePropertyField(callerID, groupID, id); err != nil {
|
|
var nfErr *store.ErrNotFound
|
|
switch {
|
|
case errors.As(err, &nfErr):
|
|
return model.NewAppError("DeleteCPAField", "app.custom_profile_attributes.property_field_not_found.app_error", nil, "", http.StatusNotFound).Wrap(err)
|
|
default:
|
|
return model.NewAppError("DeleteCPAField", "app.custom_profile_attributes.property_field_delete.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
}
|
|
|
|
message := model.NewWebSocketEvent(model.WebsocketEventCPAFieldDeleted, "", "", "", nil, "")
|
|
message.Add("field_id", id)
|
|
a.Publish(message)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (a *App) ListCPAValues(callerID, targetUserID string) ([]*model.PropertyValue, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("ListCPAValues", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
values, err := a.Srv().propertyAccessService.SearchPropertyValues(callerID, groupID, model.PropertyValueSearchOpts{
|
|
TargetIDs: []string{targetUserID},
|
|
PerPage: CustomProfileAttributesFieldLimit,
|
|
})
|
|
if err != nil {
|
|
return nil, model.NewAppError("ListCPAValues", "app.custom_profile_attributes.list_property_values.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
return values, nil
|
|
}
|
|
|
|
func (a *App) GetCPAValue(callerId, valueID string) (*model.PropertyValue, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetCPAValue", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
value, err := a.Srv().propertyAccessService.GetPropertyValue(callerId, groupID, valueID)
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetCPAValue", "app.custom_profile_attributes.get_property_field.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
return value, nil
|
|
}
|
|
|
|
func (a *App) PatchCPAValue(callerID string, userID string, fieldID string, value json.RawMessage, allowSynced bool) (*model.PropertyValue, *model.AppError) {
|
|
values, appErr := a.PatchCPAValues(callerID, userID, map[string]json.RawMessage{fieldID: value}, allowSynced)
|
|
if appErr != nil {
|
|
return nil, appErr
|
|
}
|
|
|
|
return values[0], nil
|
|
}
|
|
|
|
func (a *App) PatchCPAValues(callerID string, userID string, fieldValueMap map[string]json.RawMessage, allowSynced bool) ([]*model.PropertyValue, *model.AppError) {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
valuesToUpdate := []*model.PropertyValue{}
|
|
for fieldID, rawValue := range fieldValueMap {
|
|
// make sure field exists in this group
|
|
cpaField, appErr := a.GetCPAField(callerID, fieldID)
|
|
if appErr != nil {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.property_field_not_found.app_error", nil, "", http.StatusNotFound).Wrap(appErr)
|
|
} else if cpaField.DeleteAt > 0 {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.property_field_not_found.app_error", nil, "", http.StatusNotFound)
|
|
}
|
|
|
|
if !allowSynced && cpaField.IsSynced() {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.property_field_is_synced.app_error", nil, "", http.StatusBadRequest)
|
|
}
|
|
|
|
sanitizedValue, sErr := model.SanitizeAndValidatePropertyValue(cpaField, rawValue)
|
|
if sErr != nil {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.validate_value.app_error", nil, "", http.StatusBadRequest).Wrap(sErr)
|
|
}
|
|
|
|
value := &model.PropertyValue{
|
|
GroupID: groupID,
|
|
TargetType: model.PropertyValueTargetTypeUser,
|
|
TargetID: userID,
|
|
FieldID: fieldID,
|
|
Value: sanitizedValue,
|
|
}
|
|
valuesToUpdate = append(valuesToUpdate, value)
|
|
}
|
|
|
|
updatedValues, err := a.Srv().propertyAccessService.UpsertPropertyValues(callerID, valuesToUpdate)
|
|
if err != nil {
|
|
return nil, model.NewAppError("PatchCPAValues", "app.custom_profile_attributes.property_value_upsert.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
updatedFieldValueMap := map[string]json.RawMessage{}
|
|
for _, value := range updatedValues {
|
|
updatedFieldValueMap[value.FieldID] = value.Value
|
|
}
|
|
|
|
message := model.NewWebSocketEvent(model.WebsocketEventCPAValuesUpdated, "", "", "", nil, "")
|
|
message.Add("user_id", userID)
|
|
message.Add("values", updatedFieldValueMap)
|
|
a.Publish(message)
|
|
|
|
return updatedValues, nil
|
|
}
|
|
|
|
func (a *App) DeleteCPAValues(callerId, userID string) *model.AppError {
|
|
groupID, err := a.CpaGroupID()
|
|
if err != nil {
|
|
return model.NewAppError("DeleteCPAValues", "app.custom_profile_attributes.cpa_group_id.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
if err := a.Srv().propertyAccessService.DeletePropertyValuesForTarget(callerId, groupID, "user", userID); err != nil {
|
|
return model.NewAppError("DeleteCPAValues", "app.custom_profile_attributes.delete_property_values_for_user.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
message := model.NewWebSocketEvent(model.WebsocketEventCPAValuesUpdated, "", "", "", nil, "")
|
|
message.Add("user_id", userID)
|
|
message.Add("values", map[string]json.RawMessage{})
|
|
a.Publish(message)
|
|
|
|
return nil
|
|
}
|