mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
5a4c2a3afa
* initial commit for POC of Plugin Bridge * Updates * POC for plugin bridge * Updates from collaboration * Fixes * Refactor Plugin Bridge to use HTTP/REST instead of RPC - Remove ExecuteBridgeCall hook and Context.SourcePluginId - Implement HTTP-based bridge using existing PluginHTTP infrastructure - Add CallPlugin API method with endpoint parameter instead of method name - Update CallPluginBridge to construct HTTP POST requests - Add proper headers: Mattermost-User-Id, Mattermost-Plugin-ID - Use 'com.mattermost.server' as plugin ID for core server calls - Update ai.go to use REST endpoint /inter-plugin/v1/completion - Add comprehensive spec documentation in server/spec.md - Add MIGRATION_GUIDE.md for plugin developers - Fix 401/404 issues by setting correct headers and URL paths * Improve Plugin Bridge security and architecture - Create ServeInternalPluginRequest for internal plugin calls (core + plugin-to-plugin) - Move header-setting logic from CallPluginBridge to ServeInternalPluginRequest - Improve separation of concerns: business logic vs HTTP transport - Add security documentation explaining header protection Security Improvements: - ServeInternalPluginRequest is NOT exposed as HTTP route (internal only) - Headers (Mattermost-User-Id, Mattermost-Plugin-ID) are set by trusted server code - External requests cannot spoof these headers (stripped by servePluginRequest) - Core calls use 'com.mattermost.server' as plugin ID for authorization - Plugin-to-plugin calls use real plugin ID (enforced by server) Backward Compatibility: - Keep ServeInterPluginRequest for existing API.PluginHTTP callers (deprecated) - All tests pass Docs: - Update spec.md with security model explanation - Update MIGRATION_GUIDE.md with correct header usage examples * Space * cursor please stop creating markdown files * Fix style * Fix i18n, linter * REMOVE MARKDOWN * Remove CallPlugin method from plugin API interface Per review feedback, this method is no longer needed. Co-authored-by: Nick Misasi <[email protected]> * Remove CallPlugin method implementation from PluginAPI Co-authored-by: Nick Misasi <[email protected]> * fixes * Add AI OpenAPI spec * fix openapi spec * Use agents client (#34225) * Use agents client * Remove default agent * Fixes * fix: modify system prompts to ensure JSON is being returned * Base implementation for recaps working * small fixes * Adjustments * remove webapp changes * Add feature flags for rewrites and ai bridge, clean up * Remove comments that aren't helpful * Fix i18n * Remove rewrites * Fix tests * Fix i18n * adjust i18n again * Add back translations * Remove leftover mock code * remove model file * Changes from PR review * Make the real substitutions * Include a basic invokation of the client with noop to ensure build works * more fix * Remove unneeded change * Updates from review * Fixes * Remove some logic from rewrites to clean up branch * Use v1.5.0 of agents plugin * A bunch more additions for general UX flow * Add missing files * Add mocks * Fixes for vet-api, i18n, build, types, etc * One more linter fix * Fix i18n and some tests * Refactors and cleanup in backend code * remove rogue markdown file * fixes after refactors from backend * Add back renamed files, and add tests * More self code review * More fixes * More refactors * Fix call stack exceeded bug * Include read messages if there are no unreads * Fix test failure: use correct error message key for recap permission denied The getRecapAndCheckOwnership function was using strings.ToLower(callerName) to generate error keys, which caused 'GetRecap' to become 'getrecap' instead of the expected 'get'. Changed to use the correct static key that matches the en.json localization file. Fixes TestGetRecap/get_recap_by_non-owner test failure. Co-authored-by: Nick Misasi <[email protected]> * Consolidate permission errors down to a single string * Fixes for i18n, worktrees making this difficult * Fix i18n * Fix i18n once and for all (for real) (final) * Fix duplicate getAgents method in client4.ts * Remove duplicate ai state from initial_state.ts * Fix types * Fix tests * Fix return type of GetAgents and GetServices * Add tests for recaps components * Fix types * Update i18n * Fixes * Fixes * More cleanup * Revert random file * Use undefined * fix linter * Address feedback * Missed a git add * Fixes * Fix i18n * Remove fallback * Fixes for PR --------- Co-authored-by: Nick Misasi <[email protected]> Co-authored-by: Christopher Speller <[email protected]> Co-authored-by: Felipe Martin <[email protected]> Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Hanzo Dev <[email protected]>
308 lines
9.7 KiB
Go
308 lines
9.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCreateRecap(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_ENABLEAIRECAPS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_ENABLEAIRECAPS")
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("create recap with valid channels", func(t *testing.T) {
|
|
channel2 := th.CreateChannel(t, th.BasicTeam)
|
|
channelIds := []string{th.BasicChannel.Id, channel2.Id}
|
|
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
recap, err := th.App.CreateRecap(ctx, "My Test Recap", channelIds, "test-agent-id")
|
|
require.Nil(t, err)
|
|
require.NotNil(t, recap)
|
|
assert.Equal(t, th.BasicUser.Id, recap.UserId)
|
|
assert.Equal(t, model.RecapStatusPending, recap.Status)
|
|
assert.Equal(t, "My Test Recap", recap.Title)
|
|
})
|
|
|
|
t.Run("create recap with channel user is not member of", func(t *testing.T) {
|
|
// Create a private channel and add only BasicUser2
|
|
privateChannel := th.CreatePrivateChannel(t, th.BasicTeam)
|
|
// Remove BasicUser if they were added automatically
|
|
_ = th.App.RemoveUserFromChannel(th.Context, th.BasicUser.Id, "", privateChannel)
|
|
// Ensure BasicUser2 is a member instead
|
|
th.AddUserToChannel(t, th.BasicUser2, privateChannel)
|
|
|
|
// Try to create recap as BasicUser who is not a member
|
|
channelIds := []string{privateChannel.Id}
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
recap, err := th.App.CreateRecap(ctx, "Test Recap", channelIds, "test-agent-id")
|
|
require.NotNil(t, err)
|
|
assert.Nil(t, recap)
|
|
assert.Equal(t, "app.recap.permission_denied", err.Id)
|
|
})
|
|
}
|
|
|
|
func TestGetRecap(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_ENABLEAIRECAPS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_ENABLEAIRECAPS")
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("get recap by owner", func(t *testing.T) {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: th.BasicUser.Id,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
_, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
|
|
// Create recap channel
|
|
recapChannel := &model.RecapChannel{
|
|
Id: model.NewId(),
|
|
RecapId: recap.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
ChannelName: th.BasicChannel.DisplayName,
|
|
Highlights: []string{"Test highlight"},
|
|
ActionItems: []string{"Test action"},
|
|
SourcePostIds: []string{model.NewId()},
|
|
CreateAt: model.GetMillis(),
|
|
}
|
|
|
|
err = th.App.Srv().Store().Recap().SaveRecapChannel(recapChannel)
|
|
require.NoError(t, err)
|
|
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
retrievedRecap, appErr := th.App.GetRecap(ctx, recap.Id)
|
|
require.Nil(t, appErr)
|
|
require.NotNil(t, retrievedRecap)
|
|
assert.Equal(t, recap.Id, retrievedRecap.Id)
|
|
assert.Len(t, retrievedRecap.Channels, 1)
|
|
assert.Equal(t, recapChannel.ChannelName, retrievedRecap.Channels[0].ChannelName)
|
|
})
|
|
|
|
t.Run("get recap by non-owner", func(t *testing.T) {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: th.BasicUser.Id,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
_, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
|
|
// Try to get as a different user - create context with BasicUser2's session
|
|
ctx := request.TestContext(t).WithSession(&model.Session{UserId: th.BasicUser2.Id})
|
|
retrievedRecap, appErr := th.App.GetRecap(ctx, recap.Id)
|
|
// Permissions are now checked in API layer, so App layer should return the recap
|
|
require.Nil(t, appErr)
|
|
require.NotNil(t, retrievedRecap)
|
|
assert.Equal(t, recap.Id, retrievedRecap.Id)
|
|
})
|
|
}
|
|
|
|
func TestGetRecapsForUser(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_ENABLEAIRECAPS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_ENABLEAIRECAPS")
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("get recaps for user", func(t *testing.T) {
|
|
// Create multiple recaps for the user
|
|
for range 5 {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: th.BasicUser.Id,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
_, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
recaps, err := th.App.GetRecapsForUser(ctx, 0, 10)
|
|
require.Nil(t, err)
|
|
assert.Len(t, recaps, 5)
|
|
})
|
|
|
|
t.Run("pagination works correctly", func(t *testing.T) {
|
|
userId := model.NewId()
|
|
|
|
// Create context with the test user's session
|
|
ctx := request.TestContext(t).WithSession(&model.Session{UserId: userId})
|
|
|
|
// Create 15 recaps
|
|
for range 15 {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: userId,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
_, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
// Get first page
|
|
recapsPage1, err := th.App.GetRecapsForUser(ctx, 0, 10)
|
|
require.Nil(t, err)
|
|
assert.Len(t, recapsPage1, 10)
|
|
|
|
// Get second page
|
|
recapsPage2, err := th.App.GetRecapsForUser(ctx, 1, 10)
|
|
require.Nil(t, err)
|
|
assert.Len(t, recapsPage2, 5)
|
|
})
|
|
}
|
|
|
|
func TestMarkRecapAsRead(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_ENABLEAIRECAPS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_ENABLEAIRECAPS")
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("mark recap as read by owner", func(t *testing.T) {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: th.BasicUser.Id,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
savedRecap, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
|
|
// Mark as read
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
updatedRecap, appErr := th.App.MarkRecapAsRead(ctx, savedRecap)
|
|
require.Nil(t, appErr)
|
|
require.NotNil(t, updatedRecap)
|
|
assert.Greater(t, updatedRecap.ReadAt, int64(0))
|
|
})
|
|
|
|
t.Run("mark recap as read by non-owner", func(t *testing.T) {
|
|
recap := &model.Recap{
|
|
Id: model.NewId(),
|
|
UserId: th.BasicUser.Id,
|
|
Title: "Test Recap",
|
|
CreateAt: model.GetMillis(),
|
|
UpdateAt: model.GetMillis(),
|
|
DeleteAt: 0,
|
|
ReadAt: 0,
|
|
TotalMessageCount: 10,
|
|
Status: model.RecapStatusCompleted,
|
|
}
|
|
|
|
savedRecap, err := th.App.Srv().Store().Recap().SaveRecap(recap)
|
|
require.NoError(t, err)
|
|
|
|
// Try to mark as read as a different user - create context with BasicUser2's session
|
|
ctx := request.TestContext(t).WithSession(&model.Session{UserId: th.BasicUser2.Id})
|
|
updatedRecap, appErr := th.App.MarkRecapAsRead(ctx, savedRecap)
|
|
// Permissions are now checked in API layer, so App layer should allow it
|
|
require.Nil(t, appErr)
|
|
require.NotNil(t, updatedRecap)
|
|
assert.Greater(t, updatedRecap.ReadAt, int64(0))
|
|
})
|
|
}
|
|
|
|
func TestProcessRecapChannel(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_ENABLEAIRECAPS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_ENABLEAIRECAPS")
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("process empty channel", func(t *testing.T) {
|
|
// Ensure channel has no posts (it shouldn't in init)
|
|
channel := th.CreateChannel(t, th.BasicTeam)
|
|
// No posts added
|
|
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
recapID := model.NewId()
|
|
agentID := "test-agent"
|
|
|
|
result, err := th.App.ProcessRecapChannel(ctx, recapID, channel.Id, th.BasicUser.Id, agentID)
|
|
require.Nil(t, err)
|
|
require.NotNil(t, result)
|
|
assert.True(t, result.Success)
|
|
assert.Equal(t, 0, result.MessageCount)
|
|
})
|
|
|
|
t.Run("process channel with posts", func(t *testing.T) {
|
|
// This test expects failure at SummarizePosts because we can't mock AI easily in integration test
|
|
channel := th.CreateChannel(t, th.BasicTeam)
|
|
th.CreatePost(t, channel)
|
|
|
|
ctx := th.Context.WithSession(&model.Session{UserId: th.BasicUser.Id})
|
|
recapID := model.NewId()
|
|
agentID := "test-agent"
|
|
|
|
result, err := th.App.ProcessRecapChannel(ctx, recapID, channel.Id, th.BasicUser.Id, agentID)
|
|
// It will fail at SummarizePosts agent call
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "app.ai.summarize.agent_call_failed", err.Id)
|
|
assert.False(t, result.Success)
|
|
})
|
|
}
|
|
|
|
func TestExtractPostIDs(t *testing.T) {
|
|
t.Run("extract post IDs from posts", func(t *testing.T) {
|
|
posts := []*model.Post{
|
|
{Id: "post1", Message: "test1"},
|
|
{Id: "post2", Message: "test2"},
|
|
{Id: "post3", Message: "test3"},
|
|
}
|
|
|
|
ids := extractPostIDs(posts)
|
|
assert.Len(t, ids, 3)
|
|
assert.Equal(t, "post1", ids[0])
|
|
assert.Equal(t, "post2", ids[1])
|
|
assert.Equal(t, "post3", ids[2])
|
|
})
|
|
|
|
t.Run("extract from empty posts", func(t *testing.T) {
|
|
posts := []*model.Post{}
|
|
ids := extractPostIDs(posts)
|
|
assert.Len(t, ids, 0)
|
|
})
|
|
}
|