mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <[email protected]>
472 lines
13 KiB
Go
472 lines
13 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"database/sql"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/lib/pq"
|
|
sq "github.com/mattermost/squirrel"
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
)
|
|
|
|
const (
|
|
jobsCleanupDelay = 100 * time.Millisecond
|
|
)
|
|
|
|
type SqlJobStore struct {
|
|
*SqlStore
|
|
|
|
jobColumns []string
|
|
jobQuery sq.SelectBuilder
|
|
}
|
|
|
|
func newSqlJobStore(sqlStore *SqlStore) store.JobStore {
|
|
s := &SqlJobStore{
|
|
SqlStore: sqlStore,
|
|
jobColumns: []string{
|
|
"Id",
|
|
"Type",
|
|
"Priority",
|
|
"CreateAt",
|
|
"StartAt",
|
|
"LastActivityAt",
|
|
"Status",
|
|
"Progress",
|
|
"Data",
|
|
},
|
|
}
|
|
|
|
s.jobQuery = s.getQueryBuilder().
|
|
Select(s.jobColumns...).
|
|
From("Jobs")
|
|
|
|
return s
|
|
}
|
|
|
|
func (jss SqlJobStore) Save(job *model.Job) (*model.Job, error) {
|
|
jsonData, err := json.Marshal(job.Data)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed marshalling job data")
|
|
}
|
|
if jss.IsBinaryParamEnabled() {
|
|
jsonData = AppendBinaryFlag(jsonData)
|
|
}
|
|
query := jss.getQueryBuilder().
|
|
Insert("Jobs").
|
|
Columns("Id", "Type", "Priority", "CreateAt", "StartAt", "LastActivityAt", "Status", "Progress", "Data").
|
|
Values(job.Id, job.Type, job.Priority, job.CreateAt, job.StartAt, job.LastActivityAt, job.Status, job.Progress, jsonData)
|
|
|
|
queryString, args, err := query.ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
if _, err = jss.GetMaster().Exec(queryString, args...); err != nil {
|
|
return nil, errors.Wrap(err, "failed to save Job")
|
|
}
|
|
|
|
return job, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) SaveOnce(job *model.Job) (*model.Job, error) {
|
|
jsonData, err := json.Marshal(job.Data)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed marshalling job data")
|
|
}
|
|
if jss.IsBinaryParamEnabled() {
|
|
jsonData = AppendBinaryFlag(jsonData)
|
|
}
|
|
|
|
tx, err := jss.GetMaster().BeginXWithIsolation(&sql.TxOptions{
|
|
Isolation: sql.LevelSerializable,
|
|
})
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "begin_transaction")
|
|
}
|
|
defer finalizeTransactionX(tx, &err)
|
|
|
|
query, args, err := jss.getQueryBuilder().
|
|
Select("COUNT(*)").
|
|
From("Jobs").
|
|
Where(sq.Eq{
|
|
"Status": []string{model.JobStatusPending, model.JobStatusInProgress},
|
|
"Type": job.Type,
|
|
}).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
var count int64
|
|
err = tx.Get(&count, query, args...)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to count pending and in-progress jobs with type=%s", job.Type)
|
|
}
|
|
|
|
if count > 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
query, args, err = jss.getQueryBuilder().
|
|
Insert("Jobs").
|
|
Columns("Id", "Type", "Priority", "CreateAt", "StartAt", "LastActivityAt", "Status", "Progress", "Data").
|
|
Values(job.Id, job.Type, job.Priority, job.CreateAt, job.StartAt, job.LastActivityAt, job.Status, job.Progress, jsonData).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
if _, err = tx.Exec(query, args...); err != nil {
|
|
if isRepeatableError(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, errors.Wrap(err, "failed to save Job")
|
|
}
|
|
|
|
if err = tx.Commit(); err != nil {
|
|
if isRepeatableError(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, errors.Wrap(err, "commit_transaction")
|
|
}
|
|
|
|
return job, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) UpdateOptimistically(job *model.Job, currentStatus string) (bool, error) {
|
|
dataJSON, jsonErr := json.Marshal(job.Data)
|
|
if jsonErr != nil {
|
|
return false, errors.Wrap(jsonErr, "failed to encode job's data to JSON")
|
|
}
|
|
if jss.IsBinaryParamEnabled() {
|
|
dataJSON = AppendBinaryFlag(dataJSON)
|
|
}
|
|
query, args, err := jss.getQueryBuilder().
|
|
Update("Jobs").
|
|
Set("LastActivityAt", model.GetMillis()).
|
|
Set("Status", job.Status).
|
|
Set("Data", dataJSON).
|
|
Set("Progress", job.Progress).
|
|
Where(sq.Eq{"Id": job.Id, "Status": currentStatus}).ToSql()
|
|
if err != nil {
|
|
return false, errors.Wrap(err, "job_tosql")
|
|
}
|
|
sqlResult, err := jss.GetMaster().Exec(query, args...)
|
|
if err != nil {
|
|
return false, errors.Wrap(err, "failed to update Job")
|
|
}
|
|
|
|
rows, err := sqlResult.RowsAffected()
|
|
|
|
if err != nil {
|
|
return false, errors.Wrap(err, "unable to get rows affected")
|
|
}
|
|
|
|
if rows != 1 {
|
|
return false, nil
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) UpdateStatus(id string, status string) (*model.Job, error) {
|
|
job := &model.Job{
|
|
Id: id,
|
|
Status: status,
|
|
LastActivityAt: model.GetMillis(),
|
|
}
|
|
|
|
if _, err := jss.GetMaster().NamedExec(`UPDATE Jobs
|
|
SET Status=:Status, LastActivityAt=:LastActivityAt
|
|
WHERE Id=:Id`, job); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to update Job with id=%s", id)
|
|
}
|
|
|
|
return job, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) UpdateStatusOptimistically(id string, currentStatus string, newStatus string) (*model.Job, error) {
|
|
lastActivityAndStartTime := model.GetMillis()
|
|
|
|
// Use RETURNING to get the updated job in a single query
|
|
builder := jss.getQueryBuilder().
|
|
Update("Jobs").
|
|
Set("LastActivityAt", lastActivityAndStartTime).
|
|
Set("Status", newStatus).
|
|
Where(sq.Eq{"Id": id, "Status": currentStatus}).
|
|
Suffix("RETURNING " + strings.Join(jss.jobColumns, ", "))
|
|
|
|
if newStatus == model.JobStatusInProgress {
|
|
builder = builder.Set("StartAt", lastActivityAndStartTime)
|
|
}
|
|
|
|
var job []*model.Job
|
|
if err := jss.GetMaster().SelectBuilder(&job, builder); err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, store.NewErrNotFound("Job", id)
|
|
}
|
|
return nil, errors.Wrapf(err, "failed to update Job with id=%s", id)
|
|
}
|
|
|
|
// we are updating by id, so we should only ever update 1 job
|
|
if len(job) != 1 {
|
|
// no row was updated, but no error above, so to remain consistent we return nil, nil
|
|
return nil, nil
|
|
}
|
|
|
|
return job[0], nil
|
|
}
|
|
|
|
func (jss SqlJobStore) Get(rctx request.CTX, id string) (*model.Job, error) {
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Id": id}).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
var status model.Job
|
|
if err = jss.GetReplica().Get(&status, query, args...); err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, store.NewErrNotFound("Job", id)
|
|
}
|
|
return nil, errors.Wrapf(err, "failed to get Job with id=%s", id)
|
|
}
|
|
|
|
return &status, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByTypesPage(rctx request.CTX, jobTypes []string, page int, perPage int) ([]*model.Job, error) {
|
|
offset := page * perPage
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Type": jobTypes}).
|
|
OrderBy("CreateAt DESC").
|
|
Limit(uint64(perPage)).
|
|
Offset(uint64(offset)).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
var jobs []*model.Job
|
|
if err = jss.GetReplica().Select(&jobs, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with types")
|
|
}
|
|
|
|
return jobs, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByType(rctx request.CTX, jobType string) ([]*model.Job, error) {
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Type": jobType}).
|
|
OrderBy("CreateAt DESC").ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
statuses := []*model.Job{}
|
|
if err = jss.GetReplica().Select(&statuses, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with type=%s", jobType)
|
|
}
|
|
|
|
return statuses, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByTypeAndStatus(rctx request.CTX, jobType string, status string) ([]*model.Job, error) {
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Type": jobType, "Status": status}).
|
|
OrderBy("CreateAt DESC").ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
jobs := []*model.Job{}
|
|
if err = jss.GetReplica().Select(&jobs, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with type=%s", jobType)
|
|
}
|
|
|
|
return jobs, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByTypePage(rctx request.CTX, jobType string, page int, perPage int) ([]*model.Job, error) {
|
|
offset := page * perPage
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Type": jobType}).
|
|
OrderBy("CreateAt DESC").
|
|
Limit(uint64(perPage)).
|
|
Offset(uint64(offset)).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
statuses := []*model.Job{}
|
|
if err = jss.GetReplica().Select(&statuses, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with type=%s", jobType)
|
|
}
|
|
|
|
return statuses, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByStatus(rctx request.CTX, status string) ([]*model.Job, error) {
|
|
statuses := []*model.Job{}
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Status": status}).
|
|
OrderBy("CreateAt ASC").ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
if err = jss.GetReplica().Select(&statuses, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with status=%s", status)
|
|
}
|
|
|
|
return statuses, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetAllByTypesAndStatusesPage(rctx request.CTX, jobType []string, status []string, offset int, limit int) ([]*model.Job, error) {
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Type": jobType, "Status": status}).
|
|
OrderBy("CreateAt DESC").
|
|
Limit(uint64(limit)).
|
|
Offset(uint64(offset)).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
jobs := []*model.Job{}
|
|
if err = jss.GetReplica().Select(&jobs, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Jobs with types=%s and statuses=%s", strings.Join(jobType, ","), strings.Join(status, ","))
|
|
}
|
|
|
|
return jobs, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetNewestJobByStatusAndType(status string, jobType string) (*model.Job, error) {
|
|
return jss.GetNewestJobByStatusesAndType([]string{status}, jobType)
|
|
}
|
|
|
|
func (jss SqlJobStore) GetNewestJobByStatusesAndType(status []string, jobType string) (*model.Job, error) {
|
|
query, args, err := jss.jobQuery.
|
|
Where(sq.Eq{"Status": status, "Type": jobType}).
|
|
OrderBy("CreateAt DESC").
|
|
Limit(1).ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
var job model.Job
|
|
if err = jss.GetReplica().Get(&job, query, args...); err != nil {
|
|
if err == sql.ErrNoRows {
|
|
return nil, store.NewErrNotFound("Job", fmt.Sprintf("<status, type>=<%s, %s>", strings.Join(status, ","), jobType))
|
|
}
|
|
return nil, errors.Wrapf(err, "failed to find Job with statuses=%s and type=%s", strings.Join(status, ","), jobType)
|
|
}
|
|
return &job, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetCountByStatusAndType(status string, jobType string) (int64, error) {
|
|
query, args, err := jss.getQueryBuilder().
|
|
Select("COUNT(*)").
|
|
From("Jobs").
|
|
Where(sq.Eq{"Status": status, "Type": jobType}).ToSql()
|
|
if err != nil {
|
|
return 0, errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
var count int64
|
|
err = jss.GetReplica().Get(&count, query, args...)
|
|
if err != nil {
|
|
return int64(0), errors.Wrapf(err, "failed to count Jobs with status=%s and type=%s", status, jobType)
|
|
}
|
|
return count, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) GetByTypeAndData(rctx request.CTX, jobType string, data map[string]string, useMaster bool, statuses ...string) ([]*model.Job, error) {
|
|
query := jss.jobQuery.Where(sq.Eq{"Type": jobType})
|
|
|
|
// Add status filtering if provided - enables full usage of idx_jobs_status_type index
|
|
if len(statuses) > 0 {
|
|
query = query.Where(sq.Eq{"Status": statuses})
|
|
}
|
|
|
|
// Add JSON data filtering for each key-value pair
|
|
for key, value := range data {
|
|
query = query.Where(sq.Expr("Data->? = ?", key, fmt.Sprintf(`"%s"`, value)))
|
|
}
|
|
|
|
queryString, args, err := query.ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "get_by_type_and_data_tosql")
|
|
}
|
|
|
|
var jobs []*model.Job
|
|
// For consistency-critical operations (like job deduplication), use master
|
|
db := jss.GetReplica()
|
|
if useMaster {
|
|
db = jss.GetMaster()
|
|
}
|
|
|
|
if err := db.Select(&jobs, queryString, args...); err != nil {
|
|
return nil, errors.Wrap(err, "failed to get Jobs by type and data")
|
|
}
|
|
|
|
return jobs, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) Delete(id string) (string, error) {
|
|
query, args, err := jss.getQueryBuilder().
|
|
Delete("Jobs").
|
|
Where(sq.Eq{"Id": id}).ToSql()
|
|
if err != nil {
|
|
return "", errors.Wrap(err, "job_tosql")
|
|
}
|
|
|
|
if _, err = jss.GetMaster().Exec(query, args...); err != nil {
|
|
return "", errors.Wrapf(err, "failed to delete Job with id=%s", id)
|
|
}
|
|
return id, nil
|
|
}
|
|
|
|
func (jss SqlJobStore) Cleanup(expiryTime int64, batchSize int) error {
|
|
query := "DELETE FROM Jobs WHERE Id IN (SELECT Id FROM Jobs WHERE CreateAt < ? AND (Status != ? AND Status != ?) ORDER BY CreateAt ASC LIMIT ?)"
|
|
|
|
var rowsAffected int64 = 1
|
|
|
|
for rowsAffected > 0 {
|
|
sqlResult, err := jss.GetMaster().Exec(query,
|
|
expiryTime, model.JobStatusInProgress, model.JobStatusPending, batchSize)
|
|
if err != nil {
|
|
return errors.Wrap(err, "unable to delete jobs")
|
|
}
|
|
var rowErr error
|
|
rowsAffected, rowErr = sqlResult.RowsAffected()
|
|
if rowErr != nil {
|
|
return errors.Wrap(err, "unable to delete jobs")
|
|
}
|
|
|
|
time.Sleep(jobsCleanupDelay)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// isRepeatableError is a bit of copied code from retrylayer.go.
|
|
// A little copying is fine because we don't want to import another package
|
|
// in the store layer
|
|
func isRepeatableError(err error) bool {
|
|
var pqErr *pq.Error
|
|
switch {
|
|
case errors.As(err, &pqErr):
|
|
if pqErr.Code == "40001" || pqErr.Code == "40P01" {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|