mirror of
https://github.com/hanzoai/team.git
synced 2026-10-30 14:49:35 +00:00
0c29335238
* Improves the Property System Architecture groups The group creation for builtin property groups is moved from behaving like a singleton in the app layer (first call creates the group) to register groups and making sure they're present at server startup time. At the same time, it adds a groups cache as a sync map in the property service, to avoid having individual caches per feature as package variables, making the group caching part of the system. * Fix i18n * Fix test and calls after updating the branch * Avoid panics by controlling the errors * Adjust translations after merge --------- Co-authored-by: Miguel de la Cruz <[email protected]> Co-authored-by: Mattermost Build <[email protected]>
54 lines
1.5 KiB
Go
54 lines
1.5 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package properties
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
)
|
|
|
|
// RegisterBuiltinGroups registers a set of property groups at startup
|
|
// and populates the cache so that subsequent Group calls are free of
|
|
// database round-trips.
|
|
func (ps *PropertyService) RegisterBuiltinGroups(groups []*model.PropertyGroup) error {
|
|
for _, group := range groups {
|
|
if _, err := ps.RegisterPropertyGroup(group.Name); err != nil {
|
|
return fmt.Errorf("failed to register builtin property group %q: %w", group.Name, err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Group returns the cached PropertyGroup for a given name. If the
|
|
// group is not in the cache (e.g. a plugin-registered group), it
|
|
// falls back to a database lookup and caches the result.
|
|
func (ps *PropertyService) Group(name string) (*model.PropertyGroup, error) {
|
|
if cached, ok := ps.groupCache.Load(name); ok {
|
|
return cached.(*model.PropertyGroup), nil
|
|
}
|
|
|
|
group, err := ps.groupStore.Get(name)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("property group %q not found: %w", name, err)
|
|
}
|
|
|
|
ps.groupCache.Store(name, group)
|
|
return group, nil
|
|
}
|
|
|
|
func (ps *PropertyService) RegisterPropertyGroup(name string) (*model.PropertyGroup, error) {
|
|
group, err := ps.groupStore.Register(name)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
ps.groupCache.Store(name, group)
|
|
return group, nil
|
|
}
|
|
|
|
func (ps *PropertyService) GetPropertyGroup(name string) (*model.PropertyGroup, error) {
|
|
return ps.groupStore.Get(name)
|
|
}
|