mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <[email protected]>
317 lines
10 KiB
Go
317 lines
10 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
sq "github.com/mattermost/squirrel"
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
)
|
|
|
|
type SqlPreferenceStore struct {
|
|
*SqlStore
|
|
preferenceSelectQuery sq.SelectBuilder
|
|
}
|
|
|
|
func newSqlPreferenceStore(sqlStore *SqlStore) store.PreferenceStore {
|
|
s := &SqlPreferenceStore{SqlStore: sqlStore}
|
|
|
|
s.preferenceSelectQuery = s.getQueryBuilder().
|
|
Select("UserId", "Category", "Name", "Value").
|
|
From("Preferences")
|
|
|
|
return s
|
|
}
|
|
|
|
func (s SqlPreferenceStore) deleteUnusedFeatures() {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"Category": model.PreferenceCategoryAdvancedSettings}).
|
|
Where(sq.Eq{"Value": "false"}).
|
|
Where(sq.Like{"Name": store.FeatureTogglePrefix + "%"}).ToSql()
|
|
if err != nil {
|
|
mlog.Warn("Could not build sql query to delete unused features", mlog.Err(err))
|
|
}
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
mlog.Warn("Failed to delete unused features", mlog.Err(err))
|
|
}
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Save(preferences model.Preferences) (err error) {
|
|
// wrap in a transaction so that if one fails, everything fails
|
|
transaction, err := s.GetMaster().Beginx()
|
|
if err != nil {
|
|
return errors.Wrap(err, "begin_transaction")
|
|
}
|
|
|
|
defer finalizeTransactionX(transaction, &err)
|
|
for _, preference := range preferences {
|
|
if upsertErr := s.saveTx(transaction, &preference); upsertErr != nil {
|
|
return upsertErr
|
|
}
|
|
}
|
|
|
|
if err := transaction.Commit(); err != nil {
|
|
// don't need to rollback here since the transaction is already closed
|
|
return errors.Wrap(err, "commit_transaction")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) save(transaction *sqlxTxWrapper, preference *model.Preference) error {
|
|
preference.PreUpdate()
|
|
|
|
if err := preference.IsValid(); err != nil {
|
|
return err
|
|
}
|
|
|
|
query := s.getQueryBuilder().
|
|
Insert("Preferences").
|
|
Columns("UserId", "Category", "Name", "Value").
|
|
Values(preference.UserId, preference.Category, preference.Name, preference.Value).
|
|
SuffixExpr(sq.Expr("ON CONFLICT (userid, category, name) DO UPDATE SET Value = ?", preference.Value))
|
|
|
|
queryString, args, err := query.ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
if _, err = transaction.Exec(queryString, args...); err != nil {
|
|
return errors.Wrap(err, "failed to save Preference")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) saveTx(transaction *sqlxTxWrapper, preference *model.Preference) error {
|
|
preference.PreUpdate()
|
|
|
|
if err := preference.IsValid(); err != nil {
|
|
return err
|
|
}
|
|
|
|
query := s.getQueryBuilder().
|
|
Insert("Preferences").
|
|
Columns("UserId", "Category", "Name", "Value").
|
|
Values(preference.UserId, preference.Category, preference.Name, preference.Value).
|
|
SuffixExpr(sq.Expr("ON CONFLICT (userid, category, name) DO UPDATE SET Value = ?", preference.Value))
|
|
|
|
queryString, args, err := query.ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
if _, err = transaction.Exec(queryString, args...); err != nil {
|
|
return errors.Wrap(err, "failed to save Preference")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Get(userId string, category string, name string) (*model.Preference, error) {
|
|
var preference model.Preference
|
|
query := s.preferenceSelectQuery.
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).
|
|
Where(sq.Eq{"Name": name})
|
|
|
|
if err := s.GetReplica().GetBuilder(&preference, query); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preference with userId=%s, category=%s, name=%s", userId, category, name)
|
|
}
|
|
|
|
return &preference, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) GetCategoryAndName(category string, name string) (model.Preferences, error) {
|
|
var preferences model.Preferences
|
|
query := s.preferenceSelectQuery.
|
|
Where(sq.Eq{"Category": category}).
|
|
Where(sq.Eq{"Name": name})
|
|
|
|
if err := s.GetReplica().SelectBuilder(&preferences, query); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preferences with category=%s, name=%s", category, name)
|
|
}
|
|
return preferences, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) GetCategory(userId string, category string) (model.Preferences, error) {
|
|
var preferences model.Preferences
|
|
query := s.preferenceSelectQuery.
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category})
|
|
|
|
if err := s.GetReplica().SelectBuilder(&preferences, query); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preferences with userId=%s, category=%s", userId, category)
|
|
}
|
|
return preferences, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) GetAll(userId string) (model.Preferences, error) {
|
|
var preferences model.Preferences
|
|
query := s.preferenceSelectQuery.
|
|
Where(sq.Eq{"UserId": userId})
|
|
|
|
if err := s.GetReplica().SelectBuilder(&preferences, query); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preferences with userId=%s", userId)
|
|
}
|
|
return preferences, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) PermanentDeleteByUser(userId string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by user")
|
|
}
|
|
if _, err := s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s", userId)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Delete(userId, category, name string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).
|
|
Where(sq.Eq{"Name": name}).ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s, category=%s and name=%s", userId, category, name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) DeleteCategory(userId string, category string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by category")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s and category=%s", userId, category)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) DeleteCategoryAndName(category string, name string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"Name": name}).
|
|
Where(sq.Eq{"Category": category}).ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by category and name")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with category=%s and name=%s", category, name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// DeleteOrphanedRows removes entries from Preferences (flagged post) when a
|
|
// corresponding post no longer exists.
|
|
func (s *SqlPreferenceStore) DeleteOrphanedRows(limit int) (deleted int64, err error) {
|
|
const query = `
|
|
DELETE FROM Preferences WHERE ctid IN (
|
|
SELECT Preferences.ctid FROM Preferences
|
|
LEFT JOIN Posts ON Preferences.Name = Posts.Id
|
|
WHERE Posts.Id IS NULL AND Category = $1
|
|
LIMIT $2
|
|
)`
|
|
|
|
result, err := s.GetMaster().Exec(query, model.PreferenceCategoryFlaggedPost, limit)
|
|
if err != nil {
|
|
return
|
|
}
|
|
deleted, err = result.RowsAffected()
|
|
return
|
|
}
|
|
|
|
func (s SqlPreferenceStore) CleanupFlagsBatch(limit int64) (int64, error) {
|
|
if limit < 0 {
|
|
// uint64 does not throw an error, it overflows if it is negative.
|
|
// it is better to manually check here, or change the function type to uint64
|
|
return int64(0), errors.Errorf("Received a negative limit")
|
|
}
|
|
nameInQ, nameInArgs, err := sq.Select("Name").
|
|
FromSelect(
|
|
sq.Select("Preferences.Name").
|
|
From("Preferences").
|
|
LeftJoin("Posts ON Preferences.Name = Posts.Id").
|
|
Where(sq.Eq{"Preferences.Category": model.PreferenceCategoryFlaggedPost}).
|
|
Where(sq.Eq{"Posts.Id": nil}).
|
|
Limit(uint64(limit)),
|
|
"t").
|
|
ToSql()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "could not build nested sql query to delete preference")
|
|
}
|
|
query, args, err := s.getQueryBuilder().Delete("Preferences").
|
|
Where(sq.Eq{"Category": model.PreferenceCategoryFlaggedPost}).
|
|
Where(sq.Expr("name IN ("+nameInQ+")", nameInArgs...)).
|
|
ToSql()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "could not build sql query to delete preference")
|
|
}
|
|
|
|
sqlResult, err := s.GetMaster().Exec(query, args...)
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "failed to delete Preference")
|
|
}
|
|
rowsAffected, err := sqlResult.RowsAffected()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "unable to get rows affected")
|
|
}
|
|
|
|
return rowsAffected, nil
|
|
}
|
|
|
|
// Delete preference for limit_visible_dms_gms where their value is greater than "40" or less than "1"
|
|
func (s SqlPreferenceStore) DeleteInvalidVisibleDmsGms() (int64, error) {
|
|
// We need to pad the value field with zeros when doing comparison's because the value is stored as a string.
|
|
// Having them the same length allows Postgres to compare them correctly.
|
|
whereClause := sq.And{
|
|
sq.Eq{"Category": model.PreferenceCategorySidebarSettings},
|
|
sq.Eq{"Name": model.PreferenceLimitVisibleDmsGms},
|
|
sq.Or{
|
|
sq.Gt{"SUBSTRING(CONCAT('000000000000000', Value), LENGTH(Value) + 1, 15)": "000000000000040"},
|
|
sq.Lt{"SUBSTRING(CONCAT('000000000000000', Value), LENGTH(Value) + 1, 15)": "000000000000001"},
|
|
},
|
|
}
|
|
subQuery := s.getQueryBuilder().
|
|
Select("UserId, Category, Name").
|
|
From("Preferences").
|
|
Where(whereClause).
|
|
Limit(100)
|
|
queryString, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Expr("(userid, category, name) IN (?)", subQuery)).
|
|
ToSql()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "could not build sql query to delete preference")
|
|
}
|
|
|
|
result, err := s.GetMaster().Exec(queryString, args...)
|
|
if err != nil {
|
|
return 0, errors.Wrap(err, "failed to delete Preference")
|
|
}
|
|
rowsAffected, err := result.RowsAffected()
|
|
if err != nil {
|
|
return 0, errors.Wrap(err, "unable to get rows affected")
|
|
}
|
|
return rowsAffected, nil
|
|
}
|