mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
Harrison HealeyandGitHub
ded2db3e36
* Add initial version of Button * Use Button in ConfirmModal * Use Button in easy places that use className='btn btn-primary' This is everywhere that I could just replace `<button className='btn btn-primary'>` with `<Button emphasis='primary'>` (and some other emphasis versions) without any additional changes. There's still more places where this could be used which require more in-depth changes that will be in a following commit. * Use Button in place of divs with className='btn btn-primary' This is a minor functional change because these elements are now accessible. * Use Button in SpinnerButton This is removing some usage of a save-button CSS class that doesn't seem to affect these components. * Replace RB Button with our Button There's a small functional change here because the copy button in the header of the FullLogEventModal is now styled when it wasn't before. * Use Button in many places which used btn-secondary, btn-tertiary, and btn-danger This removes some CSS classes from some different elements, but as elsewhere, those CSS classes don't actually do anything. I think some might have had a purpose once, but there seems to be quite a few that were copied around during previous, possibly AI-assisted refactors. * Use Button in many places in System Console Notably, this includes: 1. Cleaning up some complicated logic in PurchaseLink/RenewalLink for determining their styling. 2. Making some minor functional changes in ChannelProfile/TeamProfile because they didn't use standard CSS classes previously. The styles mostly match a secondary button, but they had slightly different padding and colours previously. 3. I also removed a workaround for an old issue with OverlayTrigger and disabled buttons in favour of just using the disabled attribute. For more information on the previous code, see https://github.com/mattermost/mattermost-webapp/pull/10387. Based on some brief testing, that's no longer needed. * Use Button in MultiSelect and remove unneeded backButtonClass prop Everything that used that prop either passed the tertiary class that was the default or passed a class that didn't exist. * Use Button in more places that used btn-primary/secondary/tertiary/quaternary * Use Button in more places that used btn-danger * Use Button for all buttons with a className starting with 'btn btn-...' * Migrate anchors that really should've been buttons to Buttons All of these are anchors with click handlers and the btn class, so they'd appear as buttons anyway. * Migrate SettingItemMax and SettingPicture to Button * Use Button in BrowseChannels * Use Button in TourTip * Migrate GenericModal to Button There's a minor UX change due to the old `delete` class having a slightly different colour from `btn-danger`, but I think that was from an older version of the default themes. Ideally, we'd remove the `GenericModal__button`, `confirm`, and `delete` classes from the buttons on that modal, but doing that would require changes to a large number of E2E tests that I'd rather not do now. * Change order of building packages in postinstall * Fix move_thread E2E tests * Coderabbit feedback * Address feedback * Add JSDoc comments and remove width prop I don't think we need this since this should be set by a parent with `display: flex`, so I'm not going to add it to the Button. * Share Button with plugins