Files
team/server/channels/app/ai_bridge_test_helper.go
Jesse HallamandGitHub edf2075381 MM-68149: Upgrade to Go 1.26.2 (#36418)
* MM-68149: upgrade to Go 1.26.2

Update go directive in go.mod and .go-version.

* MM-68149: replace pointer helpers with Go 1.26 new()

Go 1.26 extends the built-in new() to accept an initial value expression,
making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x)
redundant. Replace every call site with new(x) and remove the now-unused
helper functions and their //go:fix inline directives.

* MM-68149: apply go fix for reflect API and format-string changes

- reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26)
- reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields()
  and the equivalent for Methods() and interface types
- Fix format-string concatenation and variadic-arg mismatches flagged by go vet

* MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder

Go 1.26 ships a new image/jpeg encoder that produces slightly different output.
Regenerate all JPEG fixture files and switch the comparison helpers from
byte-equality to pixel-level comparison with a small per-channel tolerance,
so minor encoder drift across patch versions is handled automatically.

Add -update-fixtures flag to make it easy to regenerate fixtures after future
major Go upgrades. Document the update procedure in tests/README.md.

* MM-68149: CI check that go fix ./... produces no changes

* Fix real bugs flagged by CodeRabbit review

- group.go: set newGroup.MemberCount not group.MemberCount (member count
  was populated on the wrong variable and lost before publish/return)
- file_test.go: guard compareImage(GetFilePreview) on the preview slice
  length, not the thumbnail slice length (copy-paste error)
- config_test.go: remove duplicate MinimumLength assignment

* fixup! Fix real bugs flagged by CodeRabbit review
2026-05-12 15:59:12 +00:00

68 lines
1.9 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package app
import (
"net/http"
"github.com/mattermost/mattermost/server/public/model"
)
func (a *App) SetAIBridgeTestHelperConfig(config *model.AIBridgeTestHelperConfig) *model.AppError {
bridge, err := newE2EAgentsBridge(config)
if err != nil {
return model.NewAppError("SetAIBridgeTestHelperConfig", "app.ai_bridge_test_helper.invalid_config", nil, err.Error(), http.StatusBadRequest)
}
a.ch.SetAgentsBridge(bridge)
if config.FeatureFlags != nil {
if appErr := a.setAIBridgeTestHelperFeatureFlags(config.FeatureFlags); appErr != nil {
return appErr
}
}
return nil
}
func (a *App) GetAIBridgeTestHelperState() *model.AIBridgeTestHelperState {
var state *model.AIBridgeTestHelperState
if e2e, ok := a.ch.agentsBridge.(*e2eAgentsBridge); ok {
state = e2e.GetState()
} else {
state = &model.AIBridgeTestHelperState{
RecordedRequests: []model.AIBridgeTestHelperRecordedRequest{},
}
}
state.FeatureFlags = &model.AIBridgeTestHelperFeatureFlags{
EnableAIPluginBridge: new(a.Config().FeatureFlags.EnableAIPluginBridge),
EnableAIRecaps: new(a.Config().FeatureFlags.EnableAIRecaps),
}
return state
}
func (a *App) ResetAIBridgeTestHelper() {
a.ch.SetAgentsBridge(newLiveAgentsBridge(a.ch))
}
func (a *App) setAIBridgeTestHelperFeatureFlags(featureFlags *model.AIBridgeTestHelperFeatureFlags) *model.AppError {
configStore := a.Srv().Platform().GetConfigStore()
configStore.SetReadOnlyFF(false)
defer configStore.SetReadOnlyFF(true)
a.UpdateConfig(func(cfg *model.Config) {
if featureFlags.EnableAIPluginBridge != nil {
cfg.FeatureFlags.EnableAIPluginBridge = *featureFlags.EnableAIPluginBridge
}
if featureFlags.EnableAIRecaps != nil {
cfg.FeatureFlags.EnableAIRecaps = *featureFlags.EnableAIRecaps
}
})
return nil
}