mirror of
https://github.com/hanzoai/team.git
synced 2026-09-30 01:57:35 +00:00
* Simplify invite_people email parsing Replace backwards in-place mutation loop with a straightforward forward filter into a new slice. Extract into parseEmailList so the logic can be unit tested directly. * MM-68150: Upgrade golangci-lint to v2.12.2 Remove //go:fix inline from NewPointer, which is a generic function not yet supported by the inline analyzer, and fix 11 slicesbackward modernize issues flagged by the new version. * MM-68150: Enable all linters by default; disable those with >20 existing issues Switch from opt-in (default: none) to opt-out (default: all) so new linters added to golangci-lint are evaluated automatically. Explicitly disable every linter that has more than 20 pre-existing violations, deferring those for later cleanup. Also disable a handful of linters whose violations are intentional patterns in this codebase (nilerr, dogsled, sqlclosecheck, iotamixing, predeclared, containedctx, iface, gocheckcompilerdirectives, promlinter, goprintffuncname, gomoddirectives). * MM-68150: Fix mirror linter issues Replace Write([]byte(s)) with WriteString(s), and FindIndex([]byte(s)) with FindStringIndex(s), to avoid unnecessary allocations. * MM-68150: Fix nosprintfhostport linter issue Use net.JoinHostPort to construct host:port strings instead of fmt.Sprintf with a manually formatted pattern. * MM-68150: Fix rowserrcheck and sqlclosecheck linter issues Check rows.Err() after iteration loops in schema_dump.go. In the sqlx_wrapper test, defer rows.Close() rather than closing inline. * MM-68150: Fix nilnesserr linter issues — wrong variable in error handlers In 11 places, a stale variable (often the outer err from a prior assignment) was used instead of the freshly-checked error variable (appErr, rowErr, jsonErr, writeErr, esErr). Each produces a typed-nil wrapped in a non-nil interface, silently discarding the real error. * MM-68150: Add i18n string for app.compile_csv_chunks.write_error --------- Co-authored-by: Mattermost Build <[email protected]>
216 lines
7.6 KiB
Go
216 lines
7.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
)
|
|
|
|
func (a *App) SaveReactionForPost(rctx request.CTX, reaction *model.Reaction) (*model.Reaction, *model.AppError) {
|
|
post, err := a.GetSinglePost(rctx, reaction.PostId, false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if post.Type == model.PostTypeBurnOnRead && post.UserId != reaction.UserId {
|
|
receipt, err := a.Srv().Store().ReadReceipt().Get(rctx, post.Id, reaction.UserId)
|
|
if err != nil && !store.IsErrNotFound(err) {
|
|
return nil, model.NewAppError("SaveReactionForPost", "app.reaction.save.save.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
if receipt == nil || receipt.ExpireAt < model.GetMillis() {
|
|
return nil, model.NewAppError("SaveReactionForPost", "api.reaction.save.burn_on_read.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
}
|
|
|
|
// Check whether this is a valid emoji
|
|
if _, ok := model.GetSystemEmojiId(reaction.EmojiName); !ok {
|
|
if _, emojiErr := a.GetEmojiByName(rctx, reaction.EmojiName); emojiErr != nil {
|
|
return nil, emojiErr
|
|
}
|
|
}
|
|
|
|
existing, dErr := a.Srv().Store().Reaction().ExistsOnPost(reaction.PostId, reaction.EmojiName)
|
|
if dErr != nil {
|
|
return nil, model.NewAppError("SaveReactionForPost", "app.reaction.save.save.app_error", nil, "", http.StatusInternalServerError).Wrap(dErr)
|
|
}
|
|
|
|
// If it exists already, we don't need to check for the limit
|
|
if !existing {
|
|
count, dErr := a.Srv().Store().Reaction().GetUniqueCountForPost(reaction.PostId)
|
|
if dErr != nil {
|
|
return nil, model.NewAppError("SaveReactionForPost", "app.reaction.save.save.app_error", nil, "", http.StatusInternalServerError).Wrap(dErr)
|
|
}
|
|
|
|
if count >= *a.Config().ServiceSettings.UniqueEmojiReactionLimitPerPost {
|
|
return nil, model.NewAppError("SaveReactionForPost", "app.reaction.save.save.too_many_reactions", nil, "", http.StatusBadRequest)
|
|
}
|
|
}
|
|
|
|
channel, err := a.GetChannel(rctx, post.ChannelId)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
restrictDM, appErr := a.CheckIfChannelIsRestrictedDM(rctx, channel)
|
|
if appErr != nil {
|
|
return nil, appErr
|
|
}
|
|
|
|
if restrictDM {
|
|
err := model.NewAppError("SaveReactionForPost", "api.reaction.save.restricted_dm.error", nil, "", http.StatusBadRequest)
|
|
return nil, err
|
|
}
|
|
|
|
if channel.DeleteAt > 0 {
|
|
return nil, model.NewAppError("SaveReactionForPost", "api.reaction.save.archived_channel.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
// Pre-populating the channelID to save a DB call in store.
|
|
reaction.ChannelId = post.ChannelId
|
|
reaction, nErr := a.Srv().Store().Reaction().Save(reaction)
|
|
if nErr != nil {
|
|
var appErr *model.AppError
|
|
switch {
|
|
case errors.As(nErr, &appErr):
|
|
return nil, appErr
|
|
default:
|
|
return nil, model.NewAppError("SaveReactionForPost", "app.reaction.save.save.app_error", nil, "", http.StatusInternalServerError).Wrap(nErr)
|
|
}
|
|
}
|
|
|
|
if post.RootId == "" {
|
|
if appErr := a.ResolvePersistentNotification(rctx, post, reaction.UserId); appErr != nil {
|
|
a.CountNotificationReason(model.NotificationStatusError, model.NotificationTypeAll, model.NotificationReasonResolvePersistentNotificationError, model.NotificationNoPlatform)
|
|
a.Log().LogM(mlog.MlvlNotificationError, "Error resolving persistent notification",
|
|
mlog.String("sender_id", reaction.UserId),
|
|
mlog.String("post_id", post.RootId),
|
|
mlog.String("status", model.NotificationStatusError),
|
|
mlog.String("reason", model.NotificationReasonResolvePersistentNotificationError),
|
|
mlog.Err(appErr),
|
|
)
|
|
return nil, appErr
|
|
}
|
|
}
|
|
|
|
// The post is always modified since the UpdateAt always changes
|
|
a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
|
|
|
|
pluginContext := pluginContext(rctx)
|
|
a.Srv().Go(func() {
|
|
a.ch.RunMultiHook(func(hooks plugin.Hooks, _ *model.Manifest) bool {
|
|
hooks.ReactionHasBeenAdded(pluginContext, reaction)
|
|
return true
|
|
}, plugin.ReactionHasBeenAddedID)
|
|
})
|
|
|
|
a.sendReactionEvent(rctx, model.WebsocketEventReactionAdded, reaction, post)
|
|
|
|
return reaction, nil
|
|
}
|
|
|
|
func (a *App) GetReactionsForPost(postID string) ([]*model.Reaction, *model.AppError) {
|
|
reactions, err := a.Srv().Store().Reaction().GetForPost(postID, true)
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetReactionsForPost", "app.reaction.get_for_post.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
return reactions, nil
|
|
}
|
|
|
|
func (a *App) GetBulkReactionsForPosts(postIDs []string) (map[string][]*model.Reaction, *model.AppError) {
|
|
reactions := make(map[string][]*model.Reaction)
|
|
|
|
allReactions, err := a.Srv().Store().Reaction().BulkGetForPosts(postIDs)
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetBulkReactionsForPosts", "app.reaction.bulk_get_for_post_ids.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
for _, reaction := range allReactions {
|
|
reactionsForPost := reactions[reaction.PostId]
|
|
reactionsForPost = append(reactionsForPost, reaction)
|
|
|
|
reactions[reaction.PostId] = reactionsForPost
|
|
}
|
|
|
|
reactions = populateEmptyReactions(postIDs, reactions)
|
|
return reactions, nil
|
|
}
|
|
|
|
func populateEmptyReactions(postIDs []string, reactions map[string][]*model.Reaction) map[string][]*model.Reaction {
|
|
for _, postID := range postIDs {
|
|
if _, present := reactions[postID]; !present {
|
|
reactions[postID] = []*model.Reaction{}
|
|
}
|
|
}
|
|
return reactions
|
|
}
|
|
|
|
func (a *App) DeleteReactionForPost(rctx request.CTX, reaction *model.Reaction) *model.AppError {
|
|
post, err := a.GetSinglePost(rctx, reaction.PostId, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
channel, err := a.GetChannel(rctx, post.ChannelId)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
restrictDM, appErr := a.CheckIfChannelIsRestrictedDM(rctx, channel)
|
|
if appErr != nil {
|
|
return appErr
|
|
}
|
|
|
|
if restrictDM {
|
|
err := model.NewAppError("DeleteReactionForPost", "api.reaction.delete.restricted_dm.error", nil, "", http.StatusBadRequest)
|
|
return err
|
|
}
|
|
|
|
if channel.DeleteAt > 0 {
|
|
return model.NewAppError("DeleteReactionForPost", "api.reaction.delete.archived_channel.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
|
|
if _, err := a.Srv().Store().Reaction().Delete(reaction); err != nil {
|
|
return model.NewAppError("DeleteReactionForPost", "app.reaction.delete_all_with_emoji_name.get_reactions.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
// The post is always modified since the UpdateAt always changes
|
|
a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
|
|
|
|
pluginContext := pluginContext(rctx)
|
|
a.Srv().Go(func() {
|
|
a.ch.RunMultiHook(func(hooks plugin.Hooks, _ *model.Manifest) bool {
|
|
hooks.ReactionHasBeenRemoved(pluginContext, reaction)
|
|
return true
|
|
}, plugin.ReactionHasBeenRemovedID)
|
|
})
|
|
|
|
a.sendReactionEvent(rctx, model.WebsocketEventReactionRemoved, reaction, post)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (a *App) sendReactionEvent(rctx request.CTX, event model.WebsocketEventType, reaction *model.Reaction, post *model.Post) {
|
|
// send out that a reaction has been added/removed
|
|
message := model.NewWebSocketEvent(event, "", post.ChannelId, "", nil, "")
|
|
reactionJSON, err := json.Marshal(reaction)
|
|
if err != nil {
|
|
rctx.Logger().Warn("Failed to encode reaction to JSON", mlog.Err(err))
|
|
}
|
|
message.Add("reaction", string(reactionJSON))
|
|
|
|
// For burn-on-read posts, filter recipients based on read receipts
|
|
if post.Type == model.PostTypeBurnOnRead {
|
|
useBurnOnReadReactionHook(message, post.UserId, post.Id)
|
|
}
|
|
|
|
a.Publish(message)
|
|
}
|