Files
team/server/public/model/session_attributes_test.go
7670eac5d3 Seed display names for session attribute fields (#37033)
* Seed display names for session attribute fields

Co-authored-by: maria.nunez <[email protected]>

* Extract session attribute display names into named constants

Co-authored-by: maria.nunez <[email protected]>

---------

Co-authored-by: Hanzo Dev <[email protected]>
2026-06-12 11:45:21 -04:00

158 lines
5.7 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package model
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestSAFieldFromPropertyField(t *testing.T) {
field := &PropertyField{
Name: SessionAttributesPropertyFieldVPNActive,
Type: PropertyFieldTypeText,
ObjectType: PropertyFieldObjectTypeSession,
Attrs: StringInterface{
"enabled": true,
"platforms": []string{SessionAttributePlatformDesktop, SessionAttributePlatformMobile},
"ttl_seconds": 60,
"grace_period_seconds": 15,
"display_name": "VPN Active",
},
}
saField, err := SAFieldFromPropertyField(field)
require.NoError(t, err)
assert.True(t, saField.Attrs.Enabled)
assert.Equal(t, []string{SessionAttributePlatformDesktop, SessionAttributePlatformMobile}, saField.Attrs.Platforms)
assert.Equal(t, 60, saField.Attrs.TTLSeconds)
assert.Equal(t, 15, saField.Attrs.GracePeriodSeconds)
assert.Equal(t, "VPN Active", saField.Attrs.DisplayName)
}
func TestSessionAttributeSystemFieldsDisplayNames(t *testing.T) {
fields := SessionAttributeSystemFields("group-id")
require.NotEmpty(t, fields)
displayNamesByName := make(map[string]string, len(fields))
for _, field := range fields {
saField, err := SAFieldFromPropertyField(field)
require.NoError(t, err)
require.NotEmpty(t, saField.Attrs.DisplayName, "field %q must have a display name", field.Name)
displayNamesByName[field.Name] = saField.Attrs.DisplayName
}
expected := map[string]string{
SessionAttributesPropertyFieldClientIPAddress: SessionAttributesDisplayNameClientIPAddress,
SessionAttributesPropertyFieldNetworkInterfaceType: SessionAttributesDisplayNameNetworkInterfaceType,
SessionAttributesPropertyFieldVPNActive: SessionAttributesDisplayNameVPNActive,
SessionAttributesPropertyFieldSSID: SessionAttributesDisplayNameSSID,
SessionAttributesPropertyFieldClientDeviceID: SessionAttributesDisplayNameClientDeviceID,
SessionAttributesPropertyFieldHardwareID: SessionAttributesDisplayNameHardwareID,
SessionAttributesPropertyFieldMDMEnrolled: SessionAttributesDisplayNameMDMEnrolled,
SessionAttributesPropertyFieldClientVersion: SessionAttributesDisplayNameClientVersion,
SessionAttributesPropertyFieldOSPlatform: SessionAttributesDisplayNameOSPlatform,
SessionAttributesPropertyFieldOSVersion: SessionAttributesDisplayNameOSVersion,
SessionAttributesPropertyFieldJailbreakDetected: SessionAttributesDisplayNameJailbreakDetected,
}
for name, displayName := range expected {
assert.Equal(t, displayName, displayNamesByName[name], "display name for %q", name)
}
}
func TestSAFieldEnabledForPlatform(t *testing.T) {
field := &PropertyField{
Name: SessionAttributesPropertyFieldVPNActive,
Type: PropertyFieldTypeText,
Attrs: StringInterface{
"enabled": true,
"platforms": []string{SessionAttributePlatformDesktop, SessionAttributePlatformMobile},
},
}
saField, err := SAFieldFromPropertyField(field)
require.NoError(t, err)
assert.True(t, saField.EnabledForPlatform(SessionAttributePlatformDesktop))
assert.True(t, saField.EnabledForPlatform(SessionAttributePlatformMobile))
assert.False(t, saField.EnabledForPlatform(SessionAttributePlatformBrowser))
field.Attrs["enabled"] = false
disabled, err := SAFieldFromPropertyField(field)
require.NoError(t, err)
assert.False(t, disabled.EnabledForPlatform(SessionAttributePlatformDesktop))
}
func TestIsValidSessionAttributeValue(t *testing.T) {
textField := &PropertyField{
Name: SessionAttributesPropertyFieldOSPlatform,
Type: PropertyFieldTypeText,
}
selectField := &PropertyField{
Name: SessionAttributesPropertyFieldNetworkInterfaceType,
Type: PropertyFieldTypeSelect,
Attrs: StringInterface{
PropertyFieldAttributeOptions: []map[string]string{
{"name": "wifi"},
{"name": "ethernet"},
},
},
}
boolField := &PropertyField{
Name: SessionAttributesPropertyFieldVPNActive,
Type: PropertyFieldTypeSelect,
Attrs: StringInterface{
PropertyFieldAttributeOptions: []map[string]string{
{"name": "true"},
{"name": "false"},
},
},
}
t.Run("text accepts string", func(t *testing.T) {
assert.True(t, IsValidSessionAttributeValue(textField, "linux"))
})
t.Run("text rejects non-string", func(t *testing.T) {
assert.False(t, IsValidSessionAttributeValue(textField, 42))
})
t.Run("select accepts valid option", func(t *testing.T) {
assert.True(t, IsValidSessionAttributeValue(selectField, "wifi"))
})
t.Run("select accepts valid option from db-shaped attrs", func(t *testing.T) {
dbSelectField := &PropertyField{
Name: SessionAttributesPropertyFieldNetworkInterfaceType,
Type: PropertyFieldTypeSelect,
Attrs: StringInterface{
PropertyFieldAttributeOptions: []any{
map[string]any{"name": "wifi"},
map[string]any{"name": "ethernet"},
},
},
}
assert.True(t, IsValidSessionAttributeValue(dbSelectField, "wifi"))
})
t.Run("select rejects invalid option", func(t *testing.T) {
assert.False(t, IsValidSessionAttributeValue(selectField, "bluetooth"))
})
t.Run("select rejects empty string", func(t *testing.T) {
assert.False(t, IsValidSessionAttributeValue(selectField, ""))
})
t.Run("bool select accepts true and false", func(t *testing.T) {
assert.True(t, IsValidSessionAttributeValue(boolField, "true"))
assert.True(t, IsValidSessionAttributeValue(boolField, "false"))
})
t.Run("bool select rejects non-option values", func(t *testing.T) {
assert.False(t, IsValidSessionAttributeValue(boolField, true))
assert.False(t, IsValidSessionAttributeValue(boolField, "yes"))
})
}