Files
team/tools/mattermost-govet/openApiSync/openApiSync_test.go
T
zeekayandHanzo Dev 404de134f3 Point the API spec and its route checker at the new base
The OpenAPI document keys every operation by its full path, so the spec
described endpoints that no longer exist the moment the server moved.

The openApiSync analyzer cross-checks each registered subrouter against
that document and reconstructs the prefix from a literal of its own, so
spec and analyzer have to move together or every route reports as
missing. Its special case for the v5 root goes away with the root
itself.

The api/v4 directory keeps its name: it is where the spec sources live,
not a URL anyone requests.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-14 10:58:08 -07:00

149 lines
4.0 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package openApiSync
import (
"net/http"
"testing"
v3high "github.com/pb33f/libopenapi/datamodel/high/v3"
"golang.org/x/tools/go/analysis/analysistest"
)
func Test(t *testing.T) {
testdata := analysistest.TestData()
specFile = analysistest.TestData() + "/spec.yaml"
analysistest.Run(t, testdata, Analyzer, "api")
}
func TestCleanRegexp(t *testing.T) {
tests := []struct {
input string
want string
}{
{"/v1/team/users/{user_id:[0-9]+}", "/v1/team/users/{user_id}"},
{"/v1/team/users/{username:[A-Za-z0-9\\_\\-\\.]+}", "/v1/team/users/{username}"},
{"/v1/team/jobs/type/{job_type:[A-Za-z0-9_-]+}", "/v1/team/jobs/type/{job_type}"},
// Literal-value constraints (e.g., {websocket:websocket}) are stripped like any other.
{"/v1/team/{websocket:websocket}", "/v1/team/{websocket}"},
// Group-alternation patterns must be left intact for splitHandlerByGroup.
{"/v1/team/groups/{group_id}/{syncable_type:teams|channels}/{syncable_id}/link", "/v1/team/groups/{group_id}/{syncable_type:teams|channels}/{syncable_id}/link"},
// No constraint — unchanged.
{"/v1/team/users/{user_id}/posts", "/v1/team/users/{user_id}/posts"},
// Multiple constrained params in one path.
{"/v1/team/users/{user_id:[0-9]+}/posts/{post_id:[0-9]+}", "/v1/team/users/{user_id}/posts/{post_id}"},
}
for _, tc := range tests {
t.Run(tc.input, func(t *testing.T) {
if got := cleanRegexp(tc.input); got != tc.want {
t.Errorf("cleanRegexp(%q) = %q, want %q", tc.input, got, tc.want)
}
})
}
}
func TestMatchesTemplate(t *testing.T) {
tests := []struct {
specPath string
handlerPath string
want bool
}{
// Exact match.
{
"/v1/team/groups/{group_id}/teams/{syncable_id}/link",
"/v1/team/groups/{group_id}/teams/{syncable_id}/link",
true,
},
// Spec param matches handler literal segment.
{
"/v1/team/groups/{group_id}/{syncable_type}/{syncable_id}/link",
"/v1/team/groups/{group_id}/channels/{syncable_id}/link",
true,
},
// Spec literal does not match a different handler literal.
{
"/v1/team/groups/{group_id}/teams/{syncable_id}/link",
"/v1/team/groups/{group_id}/channels/{syncable_id}/link",
false,
},
// Spec param matches handler param name.
{
"/v1/team/users/{user_id}",
"/v1/team/users/{user_id}",
true,
},
// Spec param matches handler literal "me".
{
"/v1/team/users/{user_id}",
"/v1/team/users/me",
true,
},
// Different path lengths.
{
"/v1/team/users/{user_id}/posts",
"/v1/team/users/{user_id}",
false,
},
// Completely different paths.
{
"/v1/team/teams/{team_id}",
"/v1/team/users/{user_id}",
false,
},
}
for _, tc := range tests {
t.Run(tc.specPath+"~"+tc.handlerPath, func(t *testing.T) {
if got := matchesTemplate(tc.specPath, tc.handlerPath); got != tc.want {
t.Errorf("matchesTemplate(%q, %q) = %v, want %v", tc.specPath, tc.handlerPath, got, tc.want)
}
})
}
}
func TestGetOperation(t *testing.T) {
get := &v3high.Operation{}
post := &v3high.Operation{}
put := &v3high.Operation{}
patch := &v3high.Operation{}
del := &v3high.Operation{}
head := &v3high.Operation{}
opts := &v3high.Operation{}
trace := &v3high.Operation{}
pathItem := &v3high.PathItem{
Get: get,
Post: post,
Put: put,
Patch: patch,
Delete: del,
Head: head,
Options: opts,
Trace: trace,
}
tests := []struct {
method string
want *v3high.Operation
}{
{http.MethodGet, get},
{http.MethodPost, post},
{http.MethodPut, put},
{http.MethodPatch, patch},
{http.MethodDelete, del},
{http.MethodHead, head},
{http.MethodOptions, opts},
{http.MethodTrace, trace},
{"get", get}, // case-insensitive
{"post", post}, // case-insensitive
{"UNKNOWN", nil},
}
for _, tc := range tests {
t.Run(tc.method, func(t *testing.T) {
if got := getOperation(pathItem, tc.method); got != tc.want {
t.Errorf("getOperation(pathItem, %q) = %v, want %v", tc.method, got, tc.want)
}
})
}
}