Files
47ec7d41a4 bump minimum version of go to 1.25 (#14567)
Follows the normal procedure with the release of [go
1.26](https://go.dev/doc/devel/release#go1.26.0)

---------

Signed-off-by: alex boten <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
2026-02-11 22:37:45 +00:00

1188 lines
35 KiB
Go

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package queue
import (
"context"
"encoding/binary"
"errors"
"fmt"
"strconv"
"sync"
"sync/atomic"
"syscall"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/experr"
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/hosttest"
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/request"
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
"go.opentelemetry.io/collector/exporter/exportertest"
"go.opentelemetry.io/collector/extension/extensiontest"
"go.opentelemetry.io/collector/extension/xextension/storage"
"go.opentelemetry.io/collector/pipeline"
)
type intRequest int64
func (i intRequest) MergeSplit(context.Context, int, request.SizerType, request.Request) ([]request.Request, error) {
panic("implement me")
}
func (i intRequest) ItemsCount() int {
return int(i)
}
func (i intRequest) BytesSize() int {
return int(i) * 10
}
type int64Encoding struct {
rc ReferenceCounter[intRequest]
}
func (int64Encoding) Marshal(_ context.Context, val intRequest) ([]byte, error) {
str := strconv.FormatInt(int64(val), 10)
return []byte(str), nil
}
func (ie int64Encoding) Unmarshal(bytes []byte) (context.Context, intRequest, error) {
val, err := strconv.ParseInt(string(bytes), 10, 64)
if err != nil {
return context.Background(), 0, err
}
ie.rc.Ref(intRequest(val))
return context.Background(), intRequest(val), nil
}
func newFakeBoundedStorageClient(maxSizeInBytes int) *fakeBoundedStorageClient {
return &fakeBoundedStorageClient{
st: map[string][]byte{},
maxSizeInBytes: maxSizeInBytes,
}
}
// fakeBoundedStorageClient storage client mimics the behavior of actual storage engines with limited
// storage space available in general, real storage engines often have a per-write-transaction
// storage overhead, needing to keep both the old and the new value stored until the transaction
// is committed this is useful for testing the persistent queue behavior with a full disk.
type fakeBoundedStorageClient struct {
maxSizeInBytes int
st map[string][]byte
sizeInBytes int
mux sync.Mutex
}
func (m *fakeBoundedStorageClient) Get(ctx context.Context, key string) ([]byte, error) {
op := storage.GetOperation(key)
if err := m.Batch(ctx, op); err != nil {
return nil, err
}
return op.Value, nil
}
func (m *fakeBoundedStorageClient) Set(ctx context.Context, key string, value []byte) error {
return m.Batch(ctx, storage.SetOperation(key, value))
}
func (m *fakeBoundedStorageClient) Delete(ctx context.Context, key string) error {
return m.Batch(ctx, storage.DeleteOperation(key))
}
func (m *fakeBoundedStorageClient) Close(context.Context) error {
return nil
}
func (m *fakeBoundedStorageClient) Batch(_ context.Context, ops ...*storage.Operation) error {
m.mux.Lock()
defer m.mux.Unlock()
totalAdded, totalRemoved := m.getTotalSizeChange(ops)
// the assumption here is that the new data needs to coexist with the old data on disk
// for the transaction to succeed
// this seems to be true for the file storage extension at least
if m.sizeInBytes+totalAdded-totalRemoved > m.maxSizeInBytes {
return fmt.Errorf("insufficient space available: %w", syscall.ENOSPC)
}
for _, op := range ops {
switch op.Type {
case storage.Get:
op.Value = m.st[op.Key]
case storage.Set:
m.st[op.Key] = op.Value
case storage.Delete:
delete(m.st, op.Key)
default:
return errors.New("wrong operation type")
}
}
m.sizeInBytes += totalAdded - totalRemoved
return nil
}
func (m *fakeBoundedStorageClient) SetMaxSizeInBytes(newMaxSize int) {
m.mux.Lock()
defer m.mux.Unlock()
m.maxSizeInBytes = newMaxSize
}
func (m *fakeBoundedStorageClient) GetSizeInBytes() int {
m.mux.Lock()
defer m.mux.Unlock()
return m.sizeInBytes
}
func (m *fakeBoundedStorageClient) getTotalSizeChange(ops []*storage.Operation) (totalAdded, totalRemoved int) {
totalAdded, totalRemoved = 0, 0
for _, op := range ops {
switch op.Type {
case storage.Set:
if oldValue, ok := m.st[op.Key]; ok {
totalRemoved += len(oldValue)
} else {
totalAdded += len(op.Key)
}
totalAdded += len(op.Value)
case storage.Delete:
if value, ok := m.st[op.Key]; ok {
totalRemoved += len(op.Key)
totalRemoved += len(value)
}
default:
}
}
return totalAdded, totalRemoved
}
func newFakeStorageClientWithErrors(errors []error) *fakeStorageClientWithErrors {
return &fakeStorageClientWithErrors{
errors: errors,
}
}
// this storage client just returns errors from a list in order
// used for testing error handling
type fakeStorageClientWithErrors struct {
errors []error
nextErrorIndex int
mux sync.Mutex
}
func (m *fakeStorageClientWithErrors) Get(ctx context.Context, key string) ([]byte, error) {
op := storage.GetOperation(key)
err := m.Batch(ctx, op)
if err != nil {
return nil, err
}
return op.Value, nil
}
func (m *fakeStorageClientWithErrors) Set(ctx context.Context, key string, value []byte) error {
return m.Batch(ctx, storage.SetOperation(key, value))
}
func (m *fakeStorageClientWithErrors) Delete(ctx context.Context, key string) error {
return m.Batch(ctx, storage.DeleteOperation(key))
}
func (m *fakeStorageClientWithErrors) Close(context.Context) error {
return nil
}
func (m *fakeStorageClientWithErrors) Batch(context.Context, ...*storage.Operation) error {
m.mux.Lock()
defer m.mux.Unlock()
if m.nextErrorIndex >= len(m.errors) {
return nil
}
m.nextErrorIndex++
return m.errors[m.nextErrorIndex-1]
}
func (m *fakeStorageClientWithErrors) Reset() {
m.mux.Lock()
defer m.mux.Unlock()
m.nextErrorIndex = 0
}
type fakeReferenceCounter struct {
mu sync.Mutex
ref int64
}
func (f *fakeReferenceCounter) Ref(intRequest) {
f.mu.Lock()
defer f.mu.Unlock()
f.ref++
}
func (f *fakeReferenceCounter) Unref(intRequest) {
f.mu.Lock()
defer f.mu.Unlock()
f.ref--
if f.ref < 0 {
panic("this should never happen")
}
}
func newSettings(sizerType request.SizerType, capacity int64) Settings[intRequest] {
rc := &fakeReferenceCounter{}
return Settings[intRequest]{
ReferenceCounter: rc,
SizerType: sizerType,
Capacity: capacity,
Signal: pipeline.SignalTraces,
Encoding: int64Encoding{rc},
ID: component.NewID(exportertest.NopType),
Telemetry: componenttest.NewNopTelemetrySettings(),
}
}
func newSettingsWithStorage(sizerType request.SizerType, capacity int64) Settings[intRequest] {
set := newSettings(sizerType, capacity)
storageID := component.ID{}
set.StorageID = &storageID
return set
}
func createTestPersistentQueueWithClient(client storage.Client) *persistentQueue[intRequest] {
pq := newPersistentQueue[intRequest](newSettingsWithStorage(request.SizerTypeRequests, 1000)).(*persistentQueue[intRequest])
pq.initClient(context.Background(), client)
return pq
}
func createTestPersistentQueueWithRequestsSizer(tb testing.TB, ext storage.Extension, capacity int64) *persistentQueue[intRequest] {
return createTestPersistentQueue(tb, ext, request.SizerTypeRequests, capacity)
}
func createTestPersistentQueueWithItemsSizer(tb testing.TB, ext storage.Extension, capacity int64) *persistentQueue[intRequest] {
return createTestPersistentQueue(tb, ext, request.SizerTypeItems, capacity)
}
func createTestPersistentQueue(tb testing.TB, ext storage.Extension, sizerType request.SizerType, capacity int64) *persistentQueue[intRequest] {
pq := newPersistentQueue[intRequest](newSettingsWithStorage(sizerType, capacity))
require.NoError(tb, pq.Start(context.Background(), hosttest.NewHost(map[component.ID]component.Component{{}: ext})))
return pq.(*persistentQueue[intRequest])
}
func TestPersistentQueue_FullCapacity(t *testing.T) {
tests := []struct {
name string
sizerType request.SizerType
capacity int64
sizeMultiplier int64
}{
{
name: "requests_capacity",
sizerType: request.SizerTypeRequests,
capacity: 5,
sizeMultiplier: 1,
},
{
name: "items_capacity",
sizerType: request.SizerTypeItems,
capacity: 55,
sizeMultiplier: 10,
},
{
name: "bytes_capacity",
sizerType: request.SizerTypeBytes,
capacity: 550,
sizeMultiplier: 100,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueue(t, ext, tt.sizerType, tt.capacity)
assert.Equal(t, int64(0), pq.Size())
// The consumer picks first request. Wait until the consumer is blocked on done.
require.NoError(t, pq.Offer(context.Background(), intRequest(10)))
assert.Equal(t, 1*tt.sizeMultiplier, pq.Size())
_, _, done, ok := pq.Read(context.Background())
assert.True(t, ok)
done.OnDone(nil)
assert.Equal(t, int64(0), pq.Size())
for i := range 10 {
result := pq.Offer(context.Background(), intRequest(10))
if i < 5 {
require.NoError(t, result)
} else {
require.ErrorIs(t, result, ErrQueueIsFull)
}
}
assert.Equal(t, 5*tt.sizeMultiplier, pq.Size())
require.NoError(t, pq.Shutdown(context.Background()))
})
}
}
func TestPersistentQueue_Shutdown(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueue(t, ext, request.SizerTypeRequests, 1001)
req := intRequest(10)
for range 1000 {
require.NoError(t, pq.Offer(context.Background(), req))
}
require.NoError(t, pq.Shutdown(context.Background()))
}
func TestPersistentQueue_ConsumersProducers(t *testing.T) {
cases := []struct {
numMessagesProduced int
numConsumers int
}{
{
numMessagesProduced: 1,
numConsumers: 1,
},
{
numMessagesProduced: 100,
numConsumers: 1,
},
{
numMessagesProduced: 100,
numConsumers: 3,
},
{
numMessagesProduced: 1,
numConsumers: 100,
},
{
numMessagesProduced: 100,
numConsumers: 100,
},
}
for _, c := range cases {
t.Run(fmt.Sprintf("#messages: %d #consumers: %d", c.numMessagesProduced, c.numConsumers), func(t *testing.T) {
consumed := &atomic.Int64{}
pq := newPersistentQueue[intRequest](newSettingsWithStorage(request.SizerTypeRequests, 1000))
aq := newAsyncQueue[intRequest](pq, c.numConsumers, func(_ context.Context, _ intRequest, done Done) {
consumed.Add(int64(1))
done.OnDone(nil)
}, nil)
require.NoError(t, aq.Start(context.Background(), hosttest.NewHost(map[component.ID]component.Component{
{}: storagetest.NewMockStorageExtension(nil),
},
)))
for i := 0; i < c.numMessagesProduced; i++ {
require.NoError(t, aq.Offer(context.Background(), intRequest(10)))
}
// Because the persistent queue is not draining after Shutdown, need to wait here for the drain.
assert.Eventually(t, func() bool {
return c.numMessagesProduced == int(consumed.Load())
}, 5*time.Second, 10*time.Millisecond)
require.NoError(t, aq.Shutdown(context.Background()))
})
}
}
func TestPersistentBlockingQueue(t *testing.T) {
tests := []struct {
name string
sizerType request.SizerType
}{
{
name: "requests_based",
sizerType: request.SizerTypeRequests,
},
{
name: "items_based",
sizerType: request.SizerTypeItems,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
set := newSettingsWithStorage(tt.sizerType, 1000)
set.BlockOnOverflow = true
pq := newPersistentQueue[intRequest](set)
consumed := &atomic.Int64{}
ac := newAsyncQueue(pq, 10, func(_ context.Context, _ intRequest, done Done) {
consumed.Add(1)
done.OnDone(nil)
}, set.ReferenceCounter)
require.NoError(t, ac.Start(context.Background(), hosttest.NewHost(map[component.ID]component.Component{
{}: storagetest.NewMockStorageExtension(nil),
})))
td := intRequest(10)
wg := &sync.WaitGroup{}
for range 10 {
wg.Go(func() {
for range 100_000 {
assert.NoError(t, pq.Offer(context.Background(), td))
}
})
}
wg.Wait()
// Because the persistent queue is not draining after Shutdown, need to wait here for the drain.
assert.Eventually(t, func() bool {
return int(consumed.Load()) == 1_000_000
}, 5*time.Second, 10*time.Millisecond)
require.NoError(t, ac.Shutdown(context.Background()))
})
}
}
func TestToStorageClient(t *testing.T) {
getStorageClientError := errors.New("unable to create storage client")
testCases := []struct {
name string
storage storage.Extension
numStorages int
storageIndex int
expectedError error
getClientError error
}{
{
name: "obtain storage extension by name",
numStorages: 2,
storageIndex: 0,
expectedError: nil,
},
{
name: "fail on not existing storage extension",
numStorages: 2,
storageIndex: 100,
expectedError: errNoStorageClient,
},
{
name: "invalid extension type",
numStorages: 2,
storageIndex: 100,
expectedError: errNoStorageClient,
},
{
name: "fail on error getting storage client from extension",
numStorages: 1,
storageIndex: 0,
expectedError: getStorageClientError,
getClientError: getStorageClientError,
},
}
for _, tt := range testCases {
t.Run(tt.name, func(t *testing.T) {
storageID := component.MustNewIDWithName("file_storage", strconv.Itoa(tt.storageIndex))
extensions := map[component.ID]component.Component{}
for i := 0; i < tt.numStorages; i++ {
extensions[component.MustNewIDWithName("file_storage", strconv.Itoa(i))] = storagetest.NewMockStorageExtension(tt.getClientError)
}
host := hosttest.NewHost(extensions)
ownerID := component.MustNewID("foo_exporter")
// execute
client, err := toStorageClient(context.Background(), storageID, host, ownerID, pipeline.SignalTraces)
// verify
if tt.expectedError != nil {
require.ErrorIs(t, err, tt.expectedError)
assert.Nil(t, client)
} else {
require.NoError(t, err)
assert.NotNil(t, client)
}
})
}
}
func TestInvalidStorageExtensionType(t *testing.T) {
storageID := component.MustNewIDWithName("extension", "extension")
// make a test extension
factory := extensiontest.NewNopFactory()
extConfig := factory.CreateDefaultConfig()
settings := extensiontest.NewNopSettings(factory.Type())
extension, err := factory.Create(context.Background(), settings, extConfig)
require.NoError(t, err)
extensions := map[component.ID]component.Component{
storageID: extension,
}
host := hosttest.NewHost(extensions)
ownerID := component.MustNewID("foo_exporter")
// execute
client, err := toStorageClient(context.Background(), storageID, host, ownerID, pipeline.SignalTraces)
// we should get an error about the extension type
require.ErrorIs(t, err, errWrongExtensionType)
assert.Nil(t, client)
}
func TestPersistentQueue_StopAfterBadStart(t *testing.T) {
storageID := component.ID{}
pq := newPersistentQueue[intRequest](Settings[intRequest]{StorageID: &storageID})
// verify that stopping a un-start/started w/error queue does not panic
assert.NoError(t, pq.Shutdown(context.Background()))
}
func TestPersistentQueue_CorruptedData(t *testing.T) {
cases := []struct {
name string
corruptAllData bool
corruptSomeData bool
corruptMetadataKey bool
desiredQueueSize int64
}{
{
name: "corrupted no items",
desiredQueueSize: 3,
},
{
name: "corrupted all items",
corruptAllData: true,
desiredQueueSize: 2, // - the dispatched item which was corrupted.
},
{
name: "corrupted some items",
corruptSomeData: true,
desiredQueueSize: 2, // - the dispatched item which was corrupted.
},
{
name: "corrupted metadata",
corruptMetadataKey: true,
desiredQueueSize: 0,
},
{
name: "corrupted everything",
corruptAllData: true,
corruptMetadataKey: true,
desiredQueueSize: 0,
},
}
badBytes := []byte{0, 1, 2}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
ps := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
// Put some items, make sure they are loaded and shutdown the storage...
for range 3 {
require.NoError(t, ps.Offer(context.Background(), intRequest(50)))
}
assert.Equal(t, int64(3), ps.Size())
require.True(t, consume(ps, func(context.Context, intRequest) error {
return experr.NewShutdownErr(nil)
}))
assert.Equal(t, int64(3), ps.Size())
// We can corrupt data (in several ways) and not worry since we return ShutdownErr client will not be touched.
if c.corruptAllData || c.corruptSomeData {
require.NoError(t, ps.client.Set(context.Background(), "0", badBytes))
}
if c.corruptAllData {
require.NoError(t, ps.client.Set(context.Background(), "1", badBytes))
require.NoError(t, ps.client.Set(context.Background(), "2", badBytes))
}
if c.corruptMetadataKey {
require.NoError(t, ps.client.Set(context.Background(), metadataKey, badBytes))
}
// Cannot close until we corrupt the data because the
require.NoError(t, ps.Shutdown(context.Background()))
// Reload
newPs := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
assert.Equal(t, c.desiredQueueSize, newPs.Size())
require.NoError(t, newPs.Shutdown(context.Background()))
})
}
}
func TestPersistentQueue_CurrentlyProcessedItems(t *testing.T) {
req := intRequest(50)
ext := storagetest.NewMockStorageExtension(nil)
ps := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
for range 5 {
require.NoError(t, ps.Offer(context.Background(), req))
}
requireCurrentlyDispatchedItemsEqual(t, ps, []uint64{})
// Takes index 0 in process.
_, readReq, _, found := ps.Read(context.Background())
require.True(t, found)
assert.Equal(t, req, readReq)
requireCurrentlyDispatchedItemsEqual(t, ps, []uint64{0})
// This takes item 1 to process.
_, secondReadReq, secondDone, found := ps.Read(context.Background())
require.True(t, found)
assert.Equal(t, req, secondReadReq)
requireCurrentlyDispatchedItemsEqual(t, ps, []uint64{0, 1})
// Lets mark item 1 as finished, it will remove it from the currently dispatched items list.
secondDone.OnDone(nil)
requireCurrentlyDispatchedItemsEqual(t, ps, []uint64{0})
// Reload the storage. Since items 0 was not finished, this should be re-enqueued at the end.
// The queue should be essentially {3,4,0,2}.
newPs := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
assert.Equal(t, int64(4), newPs.Size())
requireCurrentlyDispatchedItemsEqual(t, newPs, []uint64{})
// We should be able to pull all remaining items now
for range 4 {
consume(newPs, func(_ context.Context, val intRequest) error {
assert.Equal(t, req, val)
return nil
})
}
// The queue should be now empty
requireCurrentlyDispatchedItemsEqual(t, newPs, []uint64{})
assert.Equal(t, int64(0), newPs.Size())
// The writeIndex should be now set accordingly
require.EqualValues(t, 6, newPs.metadata.WriteIndex)
// There should be no items left in the storage
for i := uint64(0); i < newPs.metadata.WriteIndex; i++ {
bb, err := newPs.client.Get(context.Background(), getItemKey(i))
require.NoError(t, err)
require.Nil(t, bb)
}
}
// this test attempts to check if all the invariants are kept if the queue is recreated while
// close to full and with some items dispatched
func TestPersistentQueueStartWithNonDispatched(t *testing.T) {
req := intRequest(50)
ext := storagetest.NewMockStorageExtension(nil)
ps := createTestPersistentQueueWithRequestsSizer(t, ext, 5)
// Put in items up to capacity
for range 5 {
require.NoError(t, ps.Offer(context.Background(), req))
}
require.Equal(t, int64(5), ps.Size())
require.True(t, consume(ps, func(context.Context, intRequest) error {
// Check that size is still full even when consuming the element.
require.Equal(t, int64(5), ps.Size())
return experr.NewShutdownErr(nil)
}))
require.NoError(t, ps.Shutdown(context.Background()))
// Reload with extra capacity to make sure we re-enqueue in-progress items.
newPs := createTestPersistentQueueWithRequestsSizer(t, ext, 5)
require.Equal(t, int64(5), newPs.Size())
}
func TestPersistentQueueStartWithNonDispatchedConcurrent(t *testing.T) {
req := intRequest(1)
ext := storagetest.NewMockStorageExtensionWithDelay(nil, 20*time.Nanosecond)
pq := createTestPersistentQueueWithItemsSizer(t, ext, 25)
proWg := sync.WaitGroup{}
// Sending small amount of data as windows test can't handle the test fast enough
for range 5 {
proWg.Go(func() {
// Put in items up to capacity
for range 10 {
for {
// retry infinitely so the exact amount of items are added to the queue eventually
if err := pq.Offer(context.Background(), req); err == nil {
break
}
time.Sleep(50 * time.Nanosecond)
}
}
})
}
conWg := sync.WaitGroup{}
for range 5 {
conWg.Go(func() {
for range 10 {
assert.True(t, consume(pq, func(context.Context, intRequest) error { return nil }))
}
})
}
conDone := make(chan struct{})
go func() {
defer close(conDone)
conWg.Wait()
}()
proDone := make(chan struct{})
go func() {
defer close(proDone)
proWg.Wait()
}()
doneCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
select {
case <-conDone:
case <-doneCtx.Done():
assert.Fail(t, "timed out waiting for consumers to complete")
}
select {
case <-proDone:
case <-doneCtx.Done():
assert.Fail(t, "timed out waiting for producers to complete")
}
assert.Zero(t, pq.Size())
}
func TestPersistentQueue_PutCloseReadClose(t *testing.T) {
req := intRequest(50)
ext := storagetest.NewMockStorageExtension(nil)
ps := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
assert.Equal(t, int64(0), ps.Size())
// Put two elements and close the extension
require.NoError(t, ps.Offer(context.Background(), req))
require.NoError(t, ps.Offer(context.Background(), req))
assert.Equal(t, int64(2), ps.Size())
// TODO: Remove this, after the initialization writes the readIndex.
_, _, _, _ = ps.Read(context.Background())
require.NoError(t, ps.Shutdown(context.Background()))
newPs := createTestPersistentQueueWithRequestsSizer(t, ext, 1000)
require.Equal(t, int64(2), newPs.Size())
// Let's read both of the elements we put
consume(newPs, func(_ context.Context, val intRequest) error {
require.Equal(t, req, val)
return nil
})
assert.Equal(t, int64(1), newPs.Size())
consume(newPs, func(_ context.Context, val intRequest) error {
require.Equal(t, req, val)
return nil
})
require.Equal(t, int64(0), newPs.Size())
require.NoError(t, newPs.Shutdown(context.Background()))
}
func BenchmarkPersistentQueue(b *testing.B) {
ext := storagetest.NewMockStorageExtension(nil)
ps := createTestPersistentQueueWithRequestsSizer(b, ext, 10000000)
req := intRequest(100)
b.ReportAllocs()
for b.Loop() {
for range 100 {
require.NoError(b, ps.Offer(context.Background(), req))
}
for range 100 {
require.True(b, consume(ps, func(context.Context, intRequest) error { return nil }))
}
}
require.NoError(b, ext.Shutdown(context.Background()))
}
func TestItemIndexMarshaling(t *testing.T) {
cases := []struct {
in uint64
out uint64
}{
{
in: 0,
out: 0,
},
{
in: 1,
out: 1,
},
{
in: 0xFFFFFFFFFFFFFFFF,
out: 0xFFFFFFFFFFFFFFFF,
},
}
for _, c := range cases {
t.Run(fmt.Sprintf("#elements:%v", c.in), func(*testing.T) {
buf := binary.LittleEndian.AppendUint64([]byte{}, c.in)
out, err := bytesToItemIndex(buf)
require.NoError(t, err)
require.Equal(t, c.out, out)
})
}
}
func TestItemIndexArrayMarshaling(t *testing.T) {
cases := []struct {
in []uint64
out []uint64
}{
{
in: []uint64{0, 1, 2},
out: []uint64{0, 1, 2},
},
{
in: []uint64{},
out: nil,
},
{
in: nil,
out: nil,
},
}
for _, c := range cases {
t.Run(fmt.Sprintf("#elements:%v", c.in), func(_ *testing.T) {
buf := itemIndexArrayToBytes(c.in)
out, err := bytesToItemIndexArray(buf)
require.NoError(t, err)
require.Equal(t, c.out, out)
})
}
}
func TestPersistentQueue_ShutdownWhileConsuming(t *testing.T) {
ps := createTestPersistentQueueWithRequestsSizer(t, storagetest.NewMockStorageExtension(nil), 1000)
assert.Equal(t, int64(0), ps.Size())
assert.False(t, ps.client.(*storagetest.MockStorageClient).IsClosed())
require.NoError(t, ps.Offer(context.Background(), intRequest(50)))
_, _, done, ok := ps.Read(context.Background())
require.True(t, ok)
assert.False(t, ps.client.(*storagetest.MockStorageClient).IsClosed())
require.NoError(t, ps.Shutdown(context.Background()))
assert.False(t, ps.client.(*storagetest.MockStorageClient).IsClosed())
done.OnDone(nil)
assert.True(t, ps.client.(*storagetest.MockStorageClient).IsClosed())
}
func TestPersistentQueue_StorageFull(t *testing.T) {
marshaled, err := int64Encoding{}.Marshal(context.Background(), intRequest(50))
require.NoError(t, err)
maxSizeInBytes := len(marshaled)*5 + 60 // arbitrary small number
client := newFakeBoundedStorageClient(maxSizeInBytes)
ps := createTestPersistentQueueWithClient(client)
// Put enough items in to fill the underlying storage
reqCount := 0
for {
reqCount++
err = ps.Offer(context.Background(), intRequest(50))
if errors.Is(err, syscall.ENOSPC) {
break
}
require.NoError(t, err)
}
// Check that the size is correct
require.EqualValues(t, reqCount, ps.Size(), "Size must be equal to the number of items inserted")
// Manually set the storage to support writing the dispatch value.
client.SetMaxSizeInBytes(client.GetSizeInBytes() + 19)
// Take out all the items except last. Last one is there only in metadata because the data write failed.
for i := 0; i < reqCount-1; i++ {
require.True(t, consume(ps, func(_ context.Context, val intRequest) error {
require.Equal(t, intRequest(50), val)
return nil
}))
}
require.Equal(t, int64(1), ps.Size())
// Add one more element, and then read (drain) so metadata will be fixed.
require.NoError(t, ps.Offer(context.Background(), intRequest(50)))
require.True(t, consume(ps, func(_ context.Context, val intRequest) error {
require.Equal(t, intRequest(50), val)
return nil
}))
require.Equal(t, int64(0), ps.Size())
}
func TestPersistentQueue_ItemDispatchingFinish_ErrorHandling(t *testing.T) {
errDeletingItem := errors.New("error deleting item")
errUpdatingDispatched := errors.New("error updating dispatched items")
testCases := []struct {
storageErrors []error
expectedError error
name string
}{
{
name: "no errors",
storageErrors: []error{},
expectedError: nil,
},
{
name: "error on first transaction, success afterwards",
storageErrors: []error{
errUpdatingDispatched,
},
expectedError: nil,
},
{
name: "error on first and second transaction",
storageErrors: []error{
errUpdatingDispatched,
errDeletingItem,
},
expectedError: errDeletingItem,
},
{
name: "error on first and third transaction",
storageErrors: []error{
errUpdatingDispatched,
nil,
errUpdatingDispatched,
},
expectedError: errUpdatingDispatched,
},
}
for _, tt := range testCases {
t.Run(tt.name, func(t *testing.T) {
client := newFakeStorageClientWithErrors(tt.storageErrors)
ps := createTestPersistentQueueWithClient(client)
client.Reset()
require.ErrorIs(t, ps.itemDispatchingFinish(context.Background(), 0), tt.expectedError)
})
}
}
func TestPersistentQueue_ItemsCapacityUsageRestoredOnShutdown(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueueWithItemsSizer(t, ext, 100)
assert.Equal(t, int64(0), pq.Size())
// Fill the queue up to the capacity.
require.NoError(t, pq.Offer(context.Background(), intRequest(40)))
require.NoError(t, pq.Offer(context.Background(), intRequest(40)))
require.NoError(t, pq.Offer(context.Background(), intRequest(20)))
assert.Equal(t, int64(100), pq.Size())
require.ErrorIs(t, pq.Offer(context.Background(), intRequest(25)), ErrQueueIsFull)
assert.Equal(t, int64(100), pq.Size())
assert.True(t, consume(pq, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(40), val)
return nil
}))
assert.Equal(t, int64(60), pq.Size())
require.NoError(t, pq.Shutdown(context.Background()))
newPQ := createTestPersistentQueueWithItemsSizer(t, ext, 100)
// The queue should be restored to the previous size.
assert.Equal(t, int64(60), newPQ.Size())
require.NoError(t, newPQ.Offer(context.Background(), intRequest(10)))
// Check the combined queue size.
assert.Equal(t, int64(70), newPQ.Size())
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(40), val)
return nil
}))
assert.Equal(t, int64(30), newPQ.Size())
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(20), val)
return nil
}))
assert.Equal(t, int64(10), newPQ.Size())
require.NoError(t, newPQ.Shutdown(context.Background()))
}
func TestPersistentQueue_ItemsCapacityIsAlwyasRecorder(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueueWithRequestsSizer(t, ext, 100)
assert.Equal(t, int64(0), pq.Size())
require.NoError(t, pq.Offer(context.Background(), intRequest(40)))
require.NoError(t, pq.Offer(context.Background(), intRequest(20)))
require.NoError(t, pq.Offer(context.Background(), intRequest(25)))
assert.Equal(t, int64(3), pq.Size())
assert.True(t, consume(pq, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(40), val)
return nil
}))
assert.Equal(t, int64(2), pq.Size())
require.NoError(t, pq.Shutdown(context.Background()))
newPQ := createTestPersistentQueueWithItemsSizer(t, ext, 100)
// The queue items size cannot be restored.
assert.Equal(t, int64(45), newPQ.Size())
require.NoError(t, newPQ.Offer(context.Background(), intRequest(10)))
// Only new items are correctly reflected
assert.Equal(t, int64(55), newPQ.Size())
// Consuming a restored request should reduce the restored size by 20 but it should not go to below zero
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(20), val)
return nil
}))
assert.Equal(t, int64(35), newPQ.Size())
// Consuming another restored request should not affect the restored size since it's already dropped to 0.
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(25), val)
return nil
}))
assert.Equal(t, int64(10), newPQ.Size())
// Adding another batch should update the size accordingly
require.NoError(t, newPQ.Offer(context.Background(), intRequest(25)))
assert.Equal(t, int64(35), newPQ.Size())
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(10), val)
return nil
}))
assert.Equal(t, int64(25), newPQ.Size())
require.NoError(t, newPQ.Shutdown(context.Background()))
}
// This test covers the case when the queue is restarted with the less capacity than needed to restore the queued items.
// In that case, the queue has to be restored anyway even if it exceeds the capacity limit.
func TestPersistentQueue_RequestCapacityLessAfterRestart(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueueWithRequestsSizer(t, ext, 100)
assert.Equal(t, int64(0), pq.Size())
require.NoError(t, pq.Offer(context.Background(), intRequest(40)))
require.NoError(t, pq.Offer(context.Background(), intRequest(20)))
require.NoError(t, pq.Offer(context.Background(), intRequest(25)))
require.NoError(t, pq.Offer(context.Background(), intRequest(5)))
// Read the first request just to populate the read index in the storage.
// Otherwise, the write index won't be restored either.
assert.True(t, consume(pq, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(40), val)
return nil
}))
assert.Equal(t, int64(3), pq.Size())
require.NoError(t, pq.Shutdown(context.Background()))
// The queue is restarted with the less capacity than needed to restore the queued items, but with the same
// underlying storage. No need to drop requests that are over capacity since they are already in the storage.
newPQ := createTestPersistentQueueWithRequestsSizer(t, ext, 2)
// The queue items size cannot be restored, fall back to request-based size
assert.Equal(t, int64(3), newPQ.Size())
// Queue is full
require.Error(t, newPQ.Offer(context.Background(), intRequest(10)))
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(20), val)
return nil
}))
assert.Equal(t, int64(2), newPQ.Size())
// Still full
require.Error(t, newPQ.Offer(context.Background(), intRequest(10)))
assert.True(t, consume(newPQ, func(_ context.Context, val intRequest) error {
assert.Equal(t, intRequest(25), val)
return nil
}))
assert.Equal(t, int64(1), newPQ.Size())
// Now it can accept new items
require.NoError(t, newPQ.Offer(context.Background(), intRequest(10)))
require.NoError(t, newPQ.Shutdown(context.Background()))
}
// This test covers the case when the persistent storage is recovered from a snapshot which has
// bigger value for the used size than the size of the actual items in the storage.
func TestPersistentQueue_RestoredUsedSizeIsCorrectedOnDrain(t *testing.T) {
ext := storagetest.NewMockStorageExtension(nil)
pq := createTestPersistentQueueWithItemsSizer(t, ext, 1000)
assert.Equal(t, int64(0), pq.Size())
for range 6 {
require.NoError(t, pq.Offer(context.Background(), intRequest(10)))
}
assert.Equal(t, int64(60), pq.Size())
// Consume 30 items
for range 3 {
assert.True(t, consume(pq, func(context.Context, intRequest) error { return nil }))
}
assert.Equal(t, int64(30), pq.Size())
// Corrupt the size, in reality the size is 30.
// Once the queue is drained, it will be updated to the correct size.
pq.metadata.ItemsSize = 50
assert.Equal(t, int64(50), pq.Size())
assert.True(t, consume(pq, func(context.Context, intRequest) error { return nil }))
assert.True(t, consume(pq, func(context.Context, intRequest) error { return nil }))
assert.Equal(t, int64(30), pq.Size())
// Now the size must be correctly reflected
assert.True(t, consume(pq, func(context.Context, intRequest) error { return nil }))
assert.Equal(t, int64(0), pq.Size())
require.NoError(t, pq.Shutdown(context.Background()))
}
func requireCurrentlyDispatchedItemsEqual(t *testing.T, pq *persistentQueue[intRequest], compare []uint64) {
pq.mu.Lock()
defer pq.mu.Unlock()
assert.ElementsMatch(t, compare, pq.metadata.CurrentlyDispatchedItems)
}
func itemIndexArrayToBytes(arr []uint64) []byte {
size := len(arr)
buf := make([]byte, 0, 4+size*8)
buf = binary.LittleEndian.AppendUint32(buf, uint32(size))
for _, item := range arr {
buf = binary.LittleEndian.AppendUint64(buf, item)
}
return buf
}