mirror of
https://github.com/hanzoai/telemetry.git
synced 2026-10-30 20:01:49 +00:00
Florian LehnerandGitHub
ce6db6d113
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fix the naming of a test function from TestMergeSplitManySmallLogs to TestMergeSplitManySmallProfiles - was likely a copy/paste issue. And make sure data from GenerateProfiles() is correct. <!-- Issue number if applicable --> #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <[email protected]>
380 lines
13 KiB
Go
380 lines
13 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package xexporterhelper
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"go.opentelemetry.io/collector/exporter/exporterhelper"
|
|
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
|
|
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/sizer"
|
|
"go.opentelemetry.io/collector/pdata/pprofile"
|
|
"go.opentelemetry.io/collector/pdata/testdata"
|
|
)
|
|
|
|
func TestMergeProfiles(t *testing.T) {
|
|
pr1 := newProfilesRequest(testdata.GenerateProfiles(2))
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(3))
|
|
res, err := pr1.MergeSplit(context.Background(), 0, exporterhelper.RequestSizerTypeItems, pr2)
|
|
require.NoError(t, err)
|
|
assert.Len(t, res, 1)
|
|
assert.Equal(t, 5, res[0].ItemsCount())
|
|
}
|
|
|
|
func TestMergeProfilesInvalidInput(t *testing.T) {
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(3))
|
|
_, err := pr2.MergeSplit(context.Background(), 0, exporterhelper.RequestSizerTypeItems, &requesttest.FakeRequest{Items: 1})
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestMergeSplitProfiles(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
szt exporterhelper.RequestSizerType
|
|
maxSize int
|
|
pr1 Request
|
|
pr2 Request
|
|
expected []Request
|
|
}{
|
|
{
|
|
name: "both_requests_empty",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: newProfilesRequest(pprofile.NewProfiles()),
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "first_request_empty",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(0)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(5)),
|
|
expected: []Request{newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(0)
|
|
_ = testdata.GenerateProfiles(5).MergeTo(profiles)
|
|
return profiles
|
|
}())},
|
|
},
|
|
{
|
|
name: "first_empty_second_nil",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: nil,
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "merge_only",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(6)),
|
|
expected: []Request{newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(4)
|
|
testdata.GenerateProfiles(6).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}())},
|
|
},
|
|
{
|
|
name: "split_only",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 4,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(10)),
|
|
pr2: nil,
|
|
expected: []Request{
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(testdata.GenerateProfiles(2)),
|
|
},
|
|
},
|
|
{
|
|
name: "merge_and_split",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(8)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(20)),
|
|
expected: []Request{
|
|
newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(8)
|
|
testdata.GenerateProfiles(2).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}()),
|
|
newProfilesRequest(testdata.GenerateProfiles(10)),
|
|
newProfilesRequest(testdata.GenerateProfiles(8)),
|
|
},
|
|
},
|
|
{
|
|
name: "scope_profiles_split",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 4,
|
|
pr1: newProfilesRequest(func() pprofile.Profiles {
|
|
return testdata.GenerateProfiles(6)
|
|
}()),
|
|
pr2: nil,
|
|
expected: []Request{
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(func() pprofile.Profiles {
|
|
return testdata.GenerateProfiles(2)
|
|
}()),
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
res, err := tt.pr1.MergeSplit(context.Background(), tt.maxSize, tt.szt, tt.pr2)
|
|
require.NoError(t, err)
|
|
require.Len(t, res, len(tt.expected))
|
|
for i, r := range res {
|
|
assert.Equal(t, tt.expected[i].(*profilesRequest).pd, r.(*profilesRequest).pd)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestMergeSplitProfilesBasedOnByteSize(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
szt exporterhelper.RequestSizerType
|
|
maxSize int
|
|
pr1 Request
|
|
pr2 Request
|
|
expected []Request
|
|
}{
|
|
{
|
|
name: "both_requests_empty",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: newProfilesRequest(pprofile.NewProfiles()),
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "first_request_empty",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(5)),
|
|
expected: []Request{newProfilesRequest(testdata.GenerateProfiles(5))},
|
|
},
|
|
{
|
|
name: "first_empty_second_nil",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: nil,
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "merge_only",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(6)),
|
|
expected: []Request{newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(4)
|
|
testdata.GenerateProfiles(6).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}())},
|
|
},
|
|
{
|
|
name: "split_only",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 4,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(10)),
|
|
pr2: nil,
|
|
expected: []Request{
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(testdata.GenerateProfiles(2)),
|
|
},
|
|
},
|
|
{
|
|
name: "merge_and_split",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 10,
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(8)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(20)),
|
|
expected: []Request{
|
|
newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(8)
|
|
testdata.GenerateProfiles(2).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}()),
|
|
newProfilesRequest(testdata.GenerateProfiles(10)),
|
|
newProfilesRequest(testdata.GenerateProfiles(8)),
|
|
},
|
|
},
|
|
{
|
|
name: "scope_profiles_split",
|
|
szt: exporterhelper.RequestSizerTypeItems,
|
|
maxSize: 4,
|
|
pr1: newProfilesRequest(func() pprofile.Profiles {
|
|
return testdata.GenerateProfiles(6)
|
|
}()),
|
|
pr2: nil,
|
|
expected: []Request{
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(func() pprofile.Profiles {
|
|
return testdata.GenerateProfiles(2)
|
|
}()),
|
|
},
|
|
},
|
|
{
|
|
name: "both_requests_empty",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10)),
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: newProfilesRequest(pprofile.NewProfiles()),
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "first_request_empty",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10)),
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(5)),
|
|
expected: []Request{newProfilesRequest(testdata.GenerateProfiles(5))},
|
|
},
|
|
{
|
|
name: "first_empty_second_nil",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10)),
|
|
pr1: newProfilesRequest(pprofile.NewProfiles()),
|
|
pr2: nil,
|
|
expected: []Request{newProfilesRequest(pprofile.NewProfiles())},
|
|
},
|
|
{
|
|
name: "merge_only",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(13)),
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(6)),
|
|
expected: []Request{newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(4)
|
|
testdata.GenerateProfiles(6).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}())},
|
|
},
|
|
{
|
|
name: "split_only",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(4)),
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(0)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(10)),
|
|
expected: []Request{
|
|
newProfilesRequest(testdata.GenerateProfiles(4)),
|
|
newProfilesRequest(testdata.GenerateProfiles(5)),
|
|
newProfilesRequest(testdata.GenerateProfiles(1)),
|
|
},
|
|
},
|
|
{
|
|
name: "merge_and_split",
|
|
szt: exporterhelper.RequestSizerTypeBytes,
|
|
maxSize: profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10)),
|
|
pr1: newProfilesRequest(testdata.GenerateProfiles(8)),
|
|
pr2: newProfilesRequest(testdata.GenerateProfiles(20)),
|
|
expected: []Request{
|
|
newProfilesRequest(func() pprofile.Profiles {
|
|
profiles := testdata.GenerateProfiles(7)
|
|
testdata.GenerateProfiles(3).ResourceProfiles().MoveAndAppendTo(profiles.ResourceProfiles())
|
|
return profiles
|
|
}()),
|
|
newProfilesRequest(testdata.GenerateProfiles(11)),
|
|
newProfilesRequest(testdata.GenerateProfiles(7)),
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
res, err := tt.pr1.MergeSplit(context.Background(), tt.maxSize, tt.szt, tt.pr2)
|
|
require.NoError(t, err)
|
|
require.Len(t, res, len(tt.expected))
|
|
for i, r := range res {
|
|
assert.Equal(t, tt.expected[i].(*profilesRequest).pd.SampleCount(), r.(*profilesRequest).pd.SampleCount(), i)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestExtractProfiles(t *testing.T) {
|
|
for i := range 10 {
|
|
ld := testdata.GenerateProfiles(10)
|
|
extractedProfiles, _ := extractProfiles(ld, i, &sizer.ProfilesCountSizer{})
|
|
assert.Equal(t, i, extractedProfiles.SampleCount())
|
|
assert.Equal(t, 10-i, ld.SampleCount())
|
|
}
|
|
}
|
|
|
|
func TestMergeSplitManySmallProfiles(t *testing.T) {
|
|
// All requests merge into a single batch.
|
|
merged := []Request{newProfilesRequest(testdata.GenerateProfiles(1))}
|
|
for range 1000 {
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(10))
|
|
res, _ := merged[len(merged)-1].MergeSplit(context.Background(), 10000, exporterhelper.RequestSizerTypeItems, pr2)
|
|
merged = append(merged[0:len(merged)-1], res...)
|
|
}
|
|
assert.Len(t, merged, 2)
|
|
}
|
|
|
|
func BenchmarkSplittingBasedOnByteSizeManySmallProfiles(b *testing.B) {
|
|
// All requests merge into a single batch.
|
|
b.ReportAllocs()
|
|
for b.Loop() {
|
|
merged := []Request{newProfilesRequest(testdata.GenerateProfiles(10))}
|
|
for range 1000 {
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(10))
|
|
res, _ := merged[len(merged)-1].MergeSplit(
|
|
context.Background(),
|
|
profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(11000)),
|
|
exporterhelper.RequestSizerTypeBytes,
|
|
pr2,
|
|
)
|
|
merged = append(merged[0:len(merged)-1], res...)
|
|
}
|
|
assert.Len(b, merged, 2)
|
|
}
|
|
}
|
|
|
|
func BenchmarkSplittingBasedOnByteSizeManyProfilesSlightlyAboveLimit(b *testing.B) {
|
|
// Every incoming request results in a split.
|
|
b.ReportAllocs()
|
|
for b.Loop() {
|
|
merged := []Request{newProfilesRequest(testdata.GenerateProfiles(0))}
|
|
for range 10 {
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(10001))
|
|
res, _ := merged[len(merged)-1].MergeSplit(
|
|
context.Background(),
|
|
profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10000)),
|
|
exporterhelper.RequestSizerTypeBytes,
|
|
pr2,
|
|
)
|
|
assert.Len(b, res, 2)
|
|
merged = append(merged[0:len(merged)-1], res...)
|
|
}
|
|
assert.Len(b, merged, 11)
|
|
}
|
|
}
|
|
|
|
func BenchmarkSplittingBasedOnByteSizeHugeProfiles(b *testing.B) {
|
|
// One request splits into many batches.
|
|
b.ReportAllocs()
|
|
for b.Loop() {
|
|
merged := []Request{newProfilesRequest(testdata.GenerateProfiles(0))}
|
|
pr2 := newProfilesRequest(testdata.GenerateProfiles(100000))
|
|
res, _ := merged[len(merged)-1].MergeSplit(
|
|
context.Background(),
|
|
profilesMarshaler.ProfilesSize(testdata.GenerateProfiles(10010)),
|
|
exporterhelper.RequestSizerTypeBytes,
|
|
pr2,
|
|
)
|
|
merged = append(merged[0:len(merged)-1], res...)
|
|
assert.Len(b, merged, 10)
|
|
}
|
|
}
|