Files
aac1a8f39c [confmap] Stabilize confmap validation facilities (#15142)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

The `xconfmap.Validator` interface has existed in some form for a very
long time now and is ready to be stabilized. Similarly, the
`xconfmap.Validate` method has existed in it's current state for over a
year and doesn't have any open issues I'm aware of. It should also be
ready for stabilization.

Many modules depend on `xconfmap` merely for the validation facilities
(as can be seen by the go.mod diffs), so this will allow them to depend
on only stable modules.

---------

Co-authored-by: Alex Boten <[email protected]>
2026-05-08 13:33:15 +00:00

190 lines
5.5 KiB
Go

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package otlpexporter
import (
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/config/configauth"
"go.opentelemetry.io/collector/config/configgrpc"
"go.opentelemetry.io/collector/config/configopaque"
"go.opentelemetry.io/collector/config/configoptional"
"go.opentelemetry.io/collector/config/configretry"
"go.opentelemetry.io/collector/config/configtls"
"go.opentelemetry.io/collector/confmap"
"go.opentelemetry.io/collector/confmap/confmaptest"
"go.opentelemetry.io/collector/exporter/exporterhelper"
)
func TestUnmarshalDefaultConfig(t *testing.T) {
factory := NewFactory()
cfg := factory.CreateDefaultConfig()
require.NoError(t, confmap.New().Unmarshal(&cfg))
assert.Equal(t, factory.CreateDefaultConfig(), cfg)
}
func TestUnmarshalConfig(t *testing.T) {
cm, err := confmaptest.LoadConf(filepath.Join("testdata", "config.yaml"))
require.NoError(t, err)
factory := NewFactory()
cfg := factory.CreateDefaultConfig()
require.NoError(t, cm.Unmarshal(&cfg))
require.NoError(t, confmap.Validate(&cfg))
assert.Equal(t,
&Config{
TimeoutConfig: exporterhelper.TimeoutConfig{
Timeout: 10 * time.Second,
},
RetryConfig: configretry.BackOffConfig{
Enabled: true,
InitialInterval: 10 * time.Second,
RandomizationFactor: 0.7,
Multiplier: 1.3,
MaxInterval: 1 * time.Minute,
MaxElapsedTime: 10 * time.Minute,
},
QueueConfig: configoptional.Some(exporterhelper.QueueBatchConfig{
Sizer: exporterhelper.RequestSizerTypeItems,
NumConsumers: 2,
QueueSize: 100000,
Batch: configoptional.Some(exporterhelper.BatchConfig{
FlushTimeout: 200 * time.Millisecond,
Sizer: exporterhelper.RequestSizerTypeItems,
MinSize: 1000,
MaxSize: 10000,
}),
}),
ClientConfig: configgrpc.ClientConfig{
Headers: configopaque.MapList{
{Name: "another", Value: "somevalue"},
{Name: "can you have a . here?", Value: "F0000000-0000-0000-0000-000000000000"},
{Name: "header1", Value: "234"},
},
Endpoint: "1.2.3.4:1234",
Compression: "gzip",
TLS: configtls.ClientConfig{
Config: configtls.Config{
CAFile: "/var/lib/mycert.pem",
},
Insecure: false,
},
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
Time: 20 * time.Second,
PermitWithoutStream: true,
Timeout: 30 * time.Second,
}),
WriteBufferSize: 512 * 1024,
BalancerName: "round_robin",
Auth: configoptional.Some(configauth.Config{AuthenticatorID: component.MustNewID("nop")}),
},
}, cfg)
}
func TestUnmarshalDefaultBatchConfig(t *testing.T) {
cm, err := confmaptest.LoadConf(filepath.Join("testdata", "default-batch.yaml"))
require.NoError(t, err)
factory := NewFactory()
cfg := factory.CreateDefaultConfig()
require.NoError(t, cm.Unmarshal(&cfg))
require.NoError(t, confmap.Validate(&cfg))
assert.Equal(t,
&Config{
TimeoutConfig: exporterhelper.TimeoutConfig{
Timeout: 10 * time.Second,
},
RetryConfig: configretry.NewDefaultBackOffConfig(),
QueueConfig: configoptional.Some(exporterhelper.QueueBatchConfig{
Sizer: exporterhelper.RequestSizerTypeRequests,
QueueSize: 1000,
NumConsumers: 10,
Batch: configoptional.Some(exporterhelper.BatchConfig{
FlushTimeout: 200 * time.Millisecond,
Sizer: exporterhelper.RequestSizerTypeItems,
MinSize: 8192,
}),
}),
ClientConfig: configgrpc.ClientConfig{
Endpoint: "1.2.3.4:1234",
BalancerName: "round_robin",
Compression: "gzip",
WriteBufferSize: 512 * 1024,
},
}, cfg)
}
func TestUnmarshalInvalidConfig(t *testing.T) {
cm, err := confmaptest.LoadConf(filepath.Join("testdata", "invalid_configs.yaml"))
require.NoError(t, err)
factory := NewFactory()
for _, tt := range []struct {
name string
errorMsg string
}{
{
name: "no_endpoint",
errorMsg: `requires a non-empty "endpoint"`,
},
{
name: "https_endpoint",
errorMsg: `requires a non-empty "endpoint"`,
},
{
name: "http_endpoint",
errorMsg: `requires a non-empty "endpoint"`,
},
{
name: "invalid_timeout",
errorMsg: `'timeout' must be non-negative`,
},
{
name: "invalid_retry",
errorMsg: `'randomization_factor' must be within [0, 1]`,
},
{
name: "invalid_tls",
errorMsg: `invalid TLS min_version: unsupported TLS version: "asd"`,
},
{
name: "missing_port",
errorMsg: `missing port in address`,
},
{
name: "invalid_port",
errorMsg: `invalid port "port"`,
},
{
name: "invalid_unix_socket",
errorMsg: "unix socket path cannot be empty",
},
} {
t.Run(tt.name, func(t *testing.T) {
cfg := factory.CreateDefaultConfig()
sub, err := cm.Sub(tt.name)
require.NoError(t, err)
assert.NoError(t, sub.Unmarshal(&cfg))
assert.ErrorContains(t, confmap.Validate(cfg), tt.errorMsg)
})
}
}
func TestValidDNSEndpoint(t *testing.T) {
factory := NewFactory()
cfg := factory.CreateDefaultConfig().(*Config)
cfg.ClientConfig.Endpoint = "dns://authority/backend.example.com:4317"
assert.NoError(t, confmap.Validate(cfg))
}
func TestValidUnixSocketEndpoint(t *testing.T) {
factory := NewFactory()
cfg := factory.CreateDefaultConfig().(*Config)
cfg.ClientConfig.Endpoint = "unix:///my/unix/socket.sock"
assert.NoError(t, confmap.Validate(cfg))
}